Github user soniclavier closed the pull request at:
https://github.com/apache/flink/pull/2736
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r87862442
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/TimestampedValue.java
---
@@ -18,28 +18,77 @@
packa
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r87798796
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/TimestampedValue.java
---
@@ -18,28 +18,77 @@
packa
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r87798657
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/TimestampedValue.java
---
@@ -18,28 +18,77 @@
packa
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86510390
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java
---
@@ -273,32 +284,93 @@ pu
Github user soniclavier commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86462637
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java
---
@@ -273,32 +284,93 @@
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86377130
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/evictors/TimeEvictor.java
---
@@ -65,11 +107,23 @@ public long getWind
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86376593
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/evictors/Evictor.java
---
@@ -18,15 +18,17 @@
package org.apache.
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86379042
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java
---
@@ -273,32 +284,93 @@ pu
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86379858
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java
---
@@ -273,32 +284,93 @@ pu
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86388455
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperatorTest.java
---
@@ -58,6 +61,458 @@
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86385660
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/evictors/TimeEvictor.java
---
@@ -35,23 +37,63 @@
private stat
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86379014
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java
---
@@ -235,10 +244,10 @@ pu
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86377225
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/evictors/TimeEvictor.java
---
@@ -65,11 +107,23 @@ public long getWind
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86377093
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/evictors/TimeEvictor.java
---
@@ -65,11 +107,23 @@ public long getWind
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86376746
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/evictors/Evictor.java
---
@@ -41,13 +43,46 @@
public interface Ev
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86377048
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/evictors/TimeEvictor.java
---
@@ -65,11 +107,23 @@ public long getWind
GitHub user soniclavier opened a pull request:
https://github.com/apache/flink/pull/2736
[FLINK-4174] Enhance evictor functionality
The PR implements
[FLINK-4174](https://issues.apache.org/jira/browse/FLINK-4174) Enhance window
evictor as proposed in
[FLIP-4](https://cwiki.apache.
18 matches
Mail list logo
