Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r87798657
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/TimestampedValue.java
---
@@ -18,28 +18,77 @@
package org.apache.flink.streaming.runtime.operators.windowing;
import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
/**
* Stores the value and the timestamp of the record.
+ *
* @param <T> The type encapsulated value
*/
@PublicEvolving
public class TimestampedValue<T> {
+ /** The actual value held by this record */
private T value;
+
+ /** The timestamp of the record */
private long timestamp;
+ /** Flag whether the timestamp is actually set */
+ private boolean hasTimestamp;
+
+ /**
+ * Creates a new TimestampedValue. The record does not have a timestamp.
+ */
+ public TimestampedValue(T value) {
--- End diff --
This constructor is never called because in `EvictingWindowOperator` you
always instantiate `TimestampedValue` with a value and a timestamp even though
the `StreamRecord` might not have a timestamp.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
