Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2736#discussion_r86376746
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/evictors/Evictor.java
---
@@ -41,13 +43,46 @@
public interface Evictor<T, W extends Window> extends Serializable {
/**
- * Computes how many elements should be removed from the pane. The
result specifies how
- * many elements should be removed from the beginning.
- *
+ * Optionally evicts elements. Called before windowing function.
+ * @param elements The elements currently in the pane.
--- End diff --
Could you please add a newline before this line. (Same goes for the other
Javadoc comments where a newline is missing.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
