Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/699#issuecomment-104699134
+1!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/699#issuecomment-104561157
Congratulations on your first contribution @nikste!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/699
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/699#issuecomment-104240529
Looks good now. Will merge this.
Thank you for the contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/699#issuecomment-103925741
I just noticed this test case:
`flink-tests/src/test/scala/org/apache/flink/api/scala/DeltaIterationSanityCheckTest.scala`
The programs in this test are n
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/699#discussion_r30712602
--- Diff:
flink-staging/flink-tez/src/test/java/org/apache/flink/tez/test/WordCountITCase.java
---
@@ -37,7 +37,7 @@ protected void preSubmit() throws Exc
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/699#discussion_r30712611
--- Diff:
flink-staging/flink-tachyon/src/test/java/org/apache/flink/tachyon/TachyonFileSystemWrapperTest.java
---
@@ -141,8 +141,8 @@ public void testTac
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/699#discussion_r30712622
--- Diff:
flink-staging/flink-tachyon/src/test/java/org/apache/flink/tachyon/HDFSTest.java
---
@@ -110,8 +110,8 @@ public void testHDFS() {
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/699#discussion_r30712581
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/exampleJavaPrograms/WordCountITCase.java
---
@@ -36,7 +36,7 @@ protected void preSubmit() throws
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/699#discussion_r30711657
--- Diff:
flink-examples/flink-java-examples/src/main/java/org/apache/flink/examples/java/wordcount/WordCount.java
---
@@ -73,13 +73,14 @@ public static v
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/699#discussion_r30710944
--- Diff:
flink-optimizer/src/test/java/org/apache/flink/optimizer/java/PartitionOperatorTest.java
---
@@ -49,8 +50,8 @@ public void testPartitionOperator
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/699#discussion_r30710903
--- Diff:
flink-optimizer/src/test/java/org/apache/flink/optimizer/custompartition/GroupingPojoTranslationTest.java
---
@@ -176,19 +177,19 @@ public void
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/699#discussion_r30710708
--- Diff:
flink-optimizer/src/test/java/org/apache/flink/optimizer/custompartition/CustomPartitioningGlobalOptimizationTest.java
---
@@ -57,8 +58,8 @@ pub
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/699#discussion_r30710754
--- Diff:
flink-optimizer/src/test/java/org/apache/flink/optimizer/custompartition/GroupingKeySelectorTranslationTest.java
---
@@ -84,8 +85,8 @@ public vo
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/699#discussion_r30710761
--- Diff:
flink-optimizer/src/test/java/org/apache/flink/optimizer/custompartition/GroupingKeySelectorTranslationTest.java
---
@@ -115,8 +116,8 @@ public
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/699#discussion_r30710598
--- Diff: flink-optimizer/pom.xml ---
@@ -58,6 +58,12 @@ under the License.
guava
${guava.version}
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/699#discussion_r30710432
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -1357,11 +1362,16 @@ public long count() throws Exception {
/**
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/699#discussion_r30710411
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -1336,11 +1335,17 @@ public long count() throws Exception {
/**
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/699#issuecomment-103882937
Okay, the issue with print in test cases seems to be fixed in the second
commit, that looks good.
---
If your project is set up for it, you can reply to this email a
GitHub user nikste opened a pull request:
https://github.com/apache/flink/pull/699
Eager print
Uses collect in print function now.
No need for calling execute() after print().
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ni
20 matches
Mail list logo
