Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/699#discussion_r30710903
  
    --- Diff: 
flink-optimizer/src/test/java/org/apache/flink/optimizer/custompartition/GroupingPojoTranslationTest.java
 ---
    @@ -176,19 +177,19 @@ public void testCustomPartitioningTupleInvalidType() {
                        fail(e.getMessage());
                }
        }
    -   
    +
        @Test
        public void testCustomPartitioningTupleInvalidTypeSorted() {
                try {
                        ExecutionEnvironment env = 
ExecutionEnvironment.getExecutionEnvironment();
    -                   
    +
                        DataSet<Pojo3> data = env.fromElements(new Pojo3())
                                        .rebalance().setParallelism(4);
    -                   
    --- End diff --
    
    Many whitespace reformattings here. If you use IntelliJ, please set it to 
not auto-trim whitespaces. It blows up the diffs and distracts from actual 
changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to