Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/699#discussion_r30710411
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java 
---
    @@ -1336,11 +1335,17 @@ public long count() throws Exception {
        /**
         * Writes a DataSet to the standard output stream (stdout).<br/>
         * For each element of the DataSet the result of {@link 
Object#toString()} is written.
    -    * 
    -    *  @return The DataSink that writes the DataSet.
    +    * This triggers execute() automatically.
         */
    -   public DataSink<T> print() {
    -           return output(new PrintingOutputFormat<T>(false));
    +   public void print() throws Exception{
    +           try {
    --- End diff --
    
    How about removing this try/catch block?
    
    We are getting a very deep nesting of exceptions already. Not sure this 
wrapping exception adds any information. Why not let the 
"ProgramInvokationFailed" exception from the execution propagate?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to