Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1848
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1848#issuecomment-212608472
Merging this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1848#issuecomment-212590297
Thanks @dawidwys, unrelated test failures are OK.
I'll run the tests again after I rebasing and merging the PR.
---
If your project is set up for it, you can reply
Github user dawidwys commented on the pull request:
https://github.com/apache/flink/pull/1848#issuecomment-212581664
I think I applied all changes.
Unfortunately the travis build fails but I don't know why. The test it
fails has nothing in common with my changes. It also pass
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1848#discussion_r60411268
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/PartitionITCase.java
---
@@ -546,43 +549,274 @@ public void testRangePartitionInIt
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1848#issuecomment-212434056
You can leave the commits as they are. I can merge them before the PR is
merged.
The comment about the confusing nesting was not meant as a change request.
It's fin
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/1848#discussion_r60410346
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/PartitionITCase.java
---
@@ -546,43 +549,274 @@ public void testRangePartitionInI
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1848#issuecomment-212430790
It's a bit confusing with all these nested tuples and comparators, but I
think I got it now. I left a comment on the comparator that I think should be
changed. Please ch
Github user dawidwys commented on the pull request:
https://github.com/apache/flink/pull/1848#issuecomment-212432502
Unfortunately I agree that it can be confusing but could not find an easier
way to properly test it.
I will fix the issue with the smaller equal -> smaller.
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/1848#discussion_r60409121
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/PartitionITCase.java
---
@@ -546,43 +549,274 @@ public void testRangePartitionInI
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/1848#discussion_r60409063
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/PartitionITCase.java
---
@@ -546,43 +549,264 @@ public void testRangePartitionInI
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1848#discussion_r60408415
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/PartitionITCase.java
---
@@ -546,43 +549,274 @@ public void testRangePartitionInIt
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1848#discussion_r60407974
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/PartitionITCase.java
---
@@ -546,43 +549,264 @@ public void testRangePartitionInIt
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1848#discussion_r60407528
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/PartitionITCase.java
---
@@ -546,43 +549,274 @@ public void testRangePartitionInIt
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1848#discussion_r60406798
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/PartitionITCase.java
---
@@ -546,43 +549,264 @@ public void testRangePartitionInIt
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/1848#discussion_r60392270
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/PartitionITCase.java
---
@@ -546,43 +549,264 @@ public void testRangePartitionInI
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/1848#discussion_r60391643
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/PartitionITCase.java
---
@@ -546,43 +549,264 @@ public void testRangePartitionInI
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1848#issuecomment-211422717
Hi @dawidwys, thanks for the update and the extensive tests you added!
I had a few minor comments and I am not sure about the tests that check the
correctness of the
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1848#discussion_r60075546
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/PartitionITCase.java
---
@@ -546,43 +549,264 @@ public void testRangePartitionInIt
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1848#discussion_r60075060
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/PartitionITCase.java
---
@@ -546,43 +549,264 @@ public void testRangePartitionInIt
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1848#discussion_r60074102
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/PartitionNode.java
---
@@ -90,13 +90,20 @@ public SemanticProperties getSemanticProper
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1848#discussion_r60073978
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/PartitionNode.java
---
@@ -90,13 +90,20 @@ public SemanticProperties getSemanticProper
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1848#discussion_r60071991
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/PartitionOperator.java
---
@@ -98,6 +102,23 @@ public PartitionOperator(DataSet input,
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1848#discussion_r60071774
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/Keys.java ---
@@ -183,9 +193,13 @@ public String toString() {
Github user dawidwys commented on the pull request:
https://github.com/apache/flink/pull/1848#issuecomment-210485959
Hi @fhueske, I hope I applied all your comments, so it would be nice if you
could have a look at it once again.
---
If your project is set up for it, you can reply to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1848#discussion_r59176476
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/PartitionOperator.java
---
@@ -98,6 +101,14 @@ public PartitionOperator(DataSet input,
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/1848#discussion_r59137767
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/PartitionOperator.java
---
@@ -98,6 +101,14 @@ public PartitionOperator(DataSet input
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1848#issuecomment-206969649
Hi @dawidwys, thanks for the PR. I had a few comments.
Please let me know if you have any questions regarding the nested and
flattened keys.
---
If your project i
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1848#discussion_r58897266
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/PartitionITCase.java
---
@@ -546,6 +549,60 @@ public void testRangePartitionInIter
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1848#discussion_r58897094
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/PartitionITCase.java
---
@@ -546,6 +549,60 @@ public void testRangePartitionInIter
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1848#discussion_r58895433
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/PartitionOperator.java
---
@@ -98,6 +101,14 @@ public PartitionOperator(DataSet input,
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1848#discussion_r58895362
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/PartitionOperator.java
---
@@ -98,6 +101,14 @@ public PartitionOperator(DataSet input,
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1848#discussion_r58894245
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/base/PartitionOperatorBase.java
---
@@ -51,12 +53,19 @@
private Partitioner
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1848#issuecomment-206876652
Thanks for working on this issue and opening a PR @dawidwys!
I'll have a look at it and give feedback soon.
---
If your project is set up for it, you can reply to th
GitHub user dawidwys opened a pull request:
https://github.com/apache/flink/pull/1848
[FLINK-3665] Implemented sort orders support in range partitioning
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dawidwys/flink withOrders
A
35 matches
Mail list logo
