Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1848#discussion_r59137767
  
    --- Diff: 
flink-java/src/main/java/org/apache/flink/api/java/operators/PartitionOperator.java
 ---
    @@ -98,6 +101,14 @@ public PartitionOperator(DataSet<T> input, Keys<T> 
pKeys, Partitioner<?> customP
                this.customPartitioner = customPartitioner;
                this.distribution = distribution;
        }
    +
    +   public PartitionOperator<T> withOrders(Order... orders) {
    --- End diff --
    
    Hi. I started working on this change, but I don't quite know how should I 
treat keyExpression (with wildcards especially). 
    
    Lets take some complex example:
    
    ```
    TypeInformation<Tuple3<Integer, Pojo1, PojoWithMultiplePojos>> ti =
                new TupleTypeInfo<>(
                        BasicTypeInfo.INT_TYPE_INFO,
                        TypeExtractor.getForClass(Pojo1.class),
                        TypeExtractor.getForClass(PojoWithMultiplePojos.class)
                );
    
    ek = new ExpressionKeys<>(new String[] {"f2.p1.*", "f0"}, ti);
    
    public static class Pojo1 {
        public String a;
        public String b;
    }
    public static class Pojo2 {
        public String a2;
        public String b2;
    }
    public static class PojoWithMultiplePojos {
        public Pojo1 p1;
        public Pojo2 p2;
        public Integer i0;
    }
    ```
    
    What should be the output of `ek.getOriginalKeyFieldTypes`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to