Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1338
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-165754941
Olrite. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-165752988
I'll merge this PR in the next days. If I find a minor issue on the way,
would fix it on the fly.
Thanks for the good work, @sachingoel0101
---
If your pr
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-165744791
@StephanEwen can you have a look at this again? Apologies for being hasty,
but I've already addressed all concerns; this should be mergeable now.
---
If your pro
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-164384200
@StephanEwen, @rmetzger. Ping.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-163188173
Hi @StephanEwen, I have modified the signature of the `handleRequest`
method to separate path and query parameters.
If there are any more concerns, let me know
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-162349944
@sachingoel0101 , This looks good, let's get it merged soon.
Some comments on your questions:
1) Concerning the config key: Good that way, thanks!
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-162340095
@rmetzger thanks. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-162334327
I've tested the change again on a cluster, works nicely!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-156512603
Oh yay. Cool! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-156510858
Good news. Test on cluster was successful.
I'll take another look at the code, but otherwise +1 from my side.
---
If your project is set up for it, you can reply to
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-156503204
Okay, I'll test it again.
This time, I'm building Flink with Scala 2.11.
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-156502649
Okay. So I didn't actually cut down on the stack trace. Just made sure that
if it's an `ProgramInvocationException` and has an underlying cause, the cause
is prin
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-156494598
Okay, let me know when you are ready for another test drive
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-156483602
Yes. Except for the trace leading up to the handler, I think rest should be
okay to show. In case the exception isn't`ProgramInvocationException` or
`CompilerExce
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-156479850
Maybe it makes sense to just show the entire exception to the user, instead
of trying to cut away parts of the stack trace?
---
If your project is set up for it, you c
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-156477959
Yes. I will write some better exception reporting. As for this particular
error, how can it be detected?
From what I observed, ideally, `Client#getOptimizedPl
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-156476686
the jar has been build with scala 2.11 yes, flink with scala 2.10.
But I still expect a good exception in the web frontend for this.
---
If your project is set up f
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-156475956
Hi @rmetzger , are you sure you built the source with scala 2.11? I was
getting the same error you showed here, but building with scala 2.11 fixes it.
---
If you
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-156450181
here is the jar file:
https://transfer.sh/KNAnm/flink0.10-scala2.11-1.0-snapshot.jar
it has been build from here:
https://github.com/rmetzger/scratch/tree/flin
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-156448110
Hi @rmetzger. Thanks for testing.
Error reporting could be improved. I'm working on more detailed stack
traces right now.
As for the failing program,
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-156433498
Even with all the fields filled, it was not starting:
http://i.imgur.com/5WXKw9N.png
the log file also contained no helpful information
---
If your project is
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-156432901
I think we need to improve a bit on the error messages.
This is what I got for submitting a job without arguments on the web
interface:
```
Error in inv
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-156429370
Testing it again on YARN
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-155740233
That's not a problem. You can test at your own convenience. There's no
hurry. :)
---
If your project is set up for it, you can reply to this email and have your
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-155738690
I know. The problem is that MS Azure cloud needs 30 minutes to deploy a
small hortonworks cluster. Google handles that in a few minutes.
But I can use another cluste
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-155738270
Sure. :)
It's probably best you didn't. There was still a minor thing to hash out.
:')
---
If your project is set up for it, you can reply to this email and
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-155732014
Thank you. Sadly, I've shut down the cluster a few minutes ago, because I
was finished with the release testing.
I'll try soon...
---
If your project is set up for
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-155726578
@rmetzger I have pushed a fix. Can you check this again? I apologize if
this takes one two more iterations to get right since I cannot check this
myself.
---
If
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-155713026
Thank you. I've tested it on a YARN cluster, but the URL it is showing is
not correct.
It seems to me that you are just using the current hostname + ip of the web
f
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-155518122
@rmetzger Good to test. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-155424425
Okay :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-155423576
Not yet. I'm still fine-tuning some things. Will ping you when it's ready.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-155421694
I assume the PR is ready for another round of reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-155102201
Good idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-155101392
Okay. Cool.
I think we can post a link to the direct URL in the error message box
instead, explaining why it is needed to go to the direct URL.
---
If
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-155097754
Since its probably an intentional limitation of the proxy, how about the
following approach:
If the web frontend is running on YARN, we show the direct URL (not usin
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-155084660
@rmetzger. Ah yes. Figured it out. You must be testing on the yarn rm proxy
page I assume. Apparently, `POST` requests are not allowed through the proxy to
AMs. I
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-155082996
@rmetzger I did test, but on a slightly revision than this one. I'll check
again.
I did not realize usually jar sizes will exceed 10 MB. I must've
undere
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-155074648
Mh, Fabian is right. In practice, jar files very often exceed 10 MB.
> Does the web monitor also use heap space out of Job Manager? ]
Yes, the web moni
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-155068902
10MB isn't a lot for a fat jar which is how we advise our users to package
their programs.
---
If your project is set up for it, you can reply to this email and have yo
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-155065545
Okay, I see. Lets not fix it as part of this pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-155064766
This can be fixed, but it requires breaking the existing Netty pipeline.
The `HttpObjectAggregator` requires a max content length, which I think cannot
be set to
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-155059566
Thanks a lot for working on this.
I've tried out your changes locally, and it was working as expected.
- Why is there a 10 MB limit on the upload? Usually people
GitHub user sachingoel0101 opened a pull request:
https://github.com/apache/flink/pull/1338
[FLINK-2978][web-dashboard][webclient] Integrate web client into Web
Frontend
This PR creates an interface on the dashboard to perform the tasks the
webclient is doing right now, including d
87 matches
Mail list logo
