Github user sachingoel0101 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1338#discussion_r45101828
  
    --- Diff: 
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/RuntimeMonitorHandler.java
 ---
    @@ -113,7 +117,17 @@ private void respondAsLeader(ChannelHandlerContext 
ctx, Routed routed, ActorGate
                DefaultFullHttpResponse response;
     
                try {
    -                   String result = 
handler.handleRequest(routed.pathParams(), jobManager);
    +                   Map<String, String> params = routed.pathParams();
    --- End diff --
    
    I was not aware of this particular aspect of REST. How should query params 
be represented? Since here, the resource is `/jars/:jarid`, and representing a 
plan or submit as `/jars/:jarid/:parallelism/:entry-class/...` doesn't seem 
okay.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to