Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/5619#discussion_r189159027
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/ExplodeFunctionUtil.scala
---
@@ -18,74 +18,244
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/5619#discussion_r189156884
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/ExplodeFunctionUtil.scala
---
@@ -18,74 +18,244
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/5619#discussion_r188990005
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/ExplodeFunctionUtil.scala
---
@@ -18,74 +18,129
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/5619#discussion_r188988362
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/logical/LogicalUnnestRule.scala
---
@@ -104,7 +109,7 @@ class
GitHub user lincoln-lil opened a pull request:
https://github.com/apache/flink/pull/5619
[FLINK-8838] [table] Add Support for UNNEST a MultiSet type field.
## What is the purpose of the change
*This PR add support for UNNEST a MultiSet type field according to SQL
standard
GitHub user lincoln-lil opened a pull request:
https://github.com/apache/flink/pull/5046
[FLINK-6101] [table] Support select GroupBy fields with arithmetic exâ¦
## What is the purpose of the change
Support select GroupBy fields with arithmetic expressions(include UDF
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/4858#discussion_r146504940
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -486,11 +486,6 @@ case class Join
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r139580604
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
---
@@ -130,6 +130,72 @@ abstract class
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r139582270
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -762,13 +763,10 @@ class Table(
* @tparam T
Github user lincoln-lil commented on the issue:
https://github.com/apache/flink/pull/3829
Hi @fhueske sorry for late updates, I've updated the PR according to your
comments.
---
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r136491885
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -502,26 +513,140 @@ abstract class
Github user lincoln-lil commented on the issue:
https://github.com/apache/flink/pull/3829
Thanks you for such a detailed review! @fhueske These comments help me a
lot!
I left some comment on the `queryConfig` and `registerTableSink` methods.
I'd created another jira
[
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r136325581
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/queryConfig.scala
---
@@ -19,9 +19,21 @@
package
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r136321128
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
---
@@ -106,6 +106,43 @@ abstract class
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r134248050
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/queryConfig.scala
---
@@ -19,9 +19,21 @@
package
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r134186403
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -502,26 +513,140 @@ abstract class
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r134185829
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -502,26 +513,140 @@ abstract class
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r134186937
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -502,26 +513,140 @@ abstract class
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r134184973
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
---
@@ -132,6 +132,44 @@ abstract class
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r134228841
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/CsvSQLTableSink.scala
---
@@ -0,0 +1,55 @@
+/*
+ * Licensed
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r134185390
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -502,26 +513,140 @@ abstract class
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r133920847
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/queryConfig.scala
---
@@ -19,9 +19,21 @@
package
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3829#discussion_r133921697
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -502,26 +513,140 @@ abstract class
Github user lincoln-lil commented on the issue:
https://github.com/apache/flink/pull/3829
@fhueske I will continue this PR according to the above conclusions.
Thanks, Lincoln
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user lincoln-lil commented on the issue:
https://github.com/apache/flink/pull/3829
Hi @fhueske, agree with you, this API change should be discussed on dev
mailing list.
Including:
add two new method to`table.scala`
- `def insertInto[T](tableSink: String): Unit
Github user lincoln-lil commented on the issue:
https://github.com/apache/flink/pull/3829
@fhueske Agree with you. I've done most of the work, but after I deprecated
`tableEnv.sql` method and modify all the relevant test cases,
I found a problem when validate input `sql S
Github user lincoln-lil commented on the issue:
https://github.com/apache/flink/pull/3829
@fhueske Agree with you, we should maintain the consistency of the API.
For TableSink, register its schema before using it sounds reasonable. My
concern is this is a breaking change of the
Github user lincoln-lil commented on the issue:
https://github.com/apache/flink/pull/3829
@fhueske, thanks for reviewing this. I read the design doc again, the
original idea to support this functionality was doing minimal changes in the
current state.
Yes, currently a
Github user lincoln-lil commented on the issue:
https://github.com/apache/flink/pull/3829
rebased on master branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user lincoln-lil opened a pull request:
https://github.com/apache/flink/pull/3829
[FLINK-6442] [table] Extend TableAPI Support Sink Table Registration â¦
Support Sink Table Registration and âinsert intoâ Clause in SQL:
1. support registering a sink table (like source
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r111957849
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowSerializer.java
---
@@ -198,6 +209,7 @@ public Row deserialize(Row
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r111957675
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowSerializer.java
---
@@ -40,6 +42,7 @@
private static final
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r111957812
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowSerializer.java
---
@@ -171,6 +181,7 @@ public Row deserialize
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r111959451
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunction.scala
---
@@ -68,12 +70,35
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r111959829
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/RetractionITCase.scala
---
@@ -0,0 +1,310
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r111958057
--- Diff: flink-core/src/main/java/org/apache/flink/types/Row.java ---
@@ -46,6 +46,9 @@
/** The array to store actual values. */
private
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r111958631
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonCorrelate.scala
---
@@ -182,9 +192,17 @@ trait
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r111958339
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonCalc.scala
---
@@ -52,10 +53,18 @@ trait CommonCalc
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r111958512
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonCorrelate.scala
---
@@ -135,11 +136,20 @@ trait
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r111958225
--- Diff: flink-core/src/main/java/org/apache/flink/types/Row.java ---
@@ -46,6 +46,9 @@
/** The array to store actual values. */
private
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r111957949
--- Diff: flink-core/src/main/java/org/apache/flink/types/Command.java ---
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r111959008
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamGroupWindowAggregate.scala
---
@@ -107,6
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r111959203
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -129,11 +131,17
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r111959594
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunction.scala
---
@@ -84,16 +109,38
Github user lincoln-lil commented on the issue:
https://github.com/apache/flink/pull/3392
@greghogan agree with you make this change in 1.3.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user lincoln-lil commented on the issue:
https://github.com/apache/flink/pull/3379
Hi fhueske, I'm OK with the schedule and thanks for following this pr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user lincoln-lil commented on the issue:
https://github.com/apache/flink/pull/3379
Part of integration tests will occasionally fail when submit this pr, and
I configured Travis CI for my repository then got a whole pass. see
https://travis-ci.org/lincoln-lil/flink/builds
Github user lincoln-lil commented on the issue:
https://github.com/apache/flink/pull/3392
Appreciated if someone can merge this pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user lincoln-lil opened a pull request:
https://github.com/apache/flink/pull/3392
[FLINK-5883] Re-adding the Exception-thrown code for ListKeyGroupedItâ¦
â¦erator when the iterator is requested the second time
Originally, ListKeyGroupedIterator ensured that a
GitHub user lincoln-lil opened a pull request:
https://github.com/apache/flink/pull/3379
[FLINK-5498] [table] Add support for left/right outer joins with non-â¦
â¦equality predicates (and 1+ equality predicates)
Support left/right outer joins with non-equi-join conditions
Github user lincoln-lil commented on the issue:
https://github.com/apache/flink/pull/3141
@fhueske when I add more test cases for "outer joins" with local
predicates, I found different limitations between tableAPI and SQL, e.g.,
"SELECT c, g FROM Table3 left outer j
Github user lincoln-lil commented on the issue:
https://github.com/apache/flink/pull/3141
@fhueske thanks for your review, I'll update this pr according to your
comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user lincoln-lil commented on the issue:
https://github.com/apache/flink/pull/3141
@fhueske FLINK-5547 make sense to me, I'll update this pr today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user lincoln-lil commented on the issue:
https://github.com/apache/flink/pull/3141
@fhueske agree with you that the check in validation phase of the Table API
is useful for failing fast( IMO, it seems no difference on user experience that
when an exception be thrown either in
Github user lincoln-lil commented on the issue:
https://github.com/apache/flink/pull/3141
Hi, wuchong, thanks for your review. I'll switch the pr based on 1.2.0.
I think it's not necessary doing validation repeatedly both in
DataSetJoinRule.java and operators.scala,
GitHub user lincoln-lil opened a pull request:
https://github.com/apache/flink/pull/3141
[FLINK-5520] [table] Disable outer joins with non-equality predicates
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
56 matches
Mail list logo
