Github user lincoln-lil commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3733#discussion_r111959203
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
 ---
    @@ -129,11 +131,17 @@ class DataStreamOverAggregate(
                 generator,
                 inputDS,
                 isRowTimeType = false,
    -            isRowsClause = overWindow.isRows)
    +            isRowsClause = overWindow.isRows,
    +            consumeRetraction)
             } else if (
               overWindow.lowerBound.isPreceding && 
!overWindow.lowerBound.isUnbounded &&
                 overWindow.upperBound.isCurrentRow) {
               // bounded OVER window
    +          if (consumeRetraction) {
    +            throw new TableException(
    +              "Retraction for bounded over window is not supported yet. 
Note: Currently, bounded " +
    --- End diff --
    
    1. Retraction for -> on
    2. groupby -> groupBy
    3. keep the term consistent either choosing 'OVER' or 'over' in the same 
context.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to