Github user lincoln-lil commented on the issue:

    https://github.com/apache/flink/pull/3141
  
    Hi, wuchong, thanks for your review. I'll switch the pr based on 1.2.0.
    I think it's not necessary doing validation repeatedly both in 
DataSetJoinRule.java and operators.scala, and there already being several 
validations in DataSetJoin.translateToPlan function, why don't we put the same 
validation together to reduce code?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to