Re: [PR] [FLINK-37420] fix AbstractAggregatingState add may return wrong result [flink]

2025-03-04 Thread via GitHub
Zakelly commented on PR #26246: URL: https://github.com/apache/flink/pull/26246#issuecomment-2700142576 Ah, the CI fails due to the `AbstractAggregatingStateTest.AggregatingStateExecutor.hashMap` is static, which is problematic. -- This is an automated message from the Apache Git Service

Re: [PR] [FLINK-37302][table] Support PTFs with time and timer services [flink]

2025-03-04 Thread via GitHub
snuyanzin commented on code in PR #26250: URL: https://github.com/apache/flink/pull/26250#discussion_r1980864849 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/TestStep.java: ## @@ -50,6 +50,7 @@ enum TestKind { SINK_WITHOUT_DATA,

Re: [PR] [FLINK-37302][table] Support PTFs with time and timer services [flink]

2025-03-04 Thread via GitHub
snuyanzin commented on code in PR #26250: URL: https://github.com/apache/flink/pull/26250#discussion_r1980862517 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/FailingSqlTestStep.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Soft

Re: [PR] [FLINK-37302][table] Support PTFs with time and timer services [flink]

2025-03-04 Thread via GitHub
flinkbot commented on PR #26250: URL: https://github.com/apache/flink/pull/26250#issuecomment-2700117306 ## CI report: * 6c348b520bf423faf396b024914295bf71ddd911 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-37302][table] Support PTFs with time and timer services [flink]

2025-03-04 Thread via GitHub
snuyanzin commented on code in PR #26250: URL: https://github.com/apache/flink/pull/26250#discussion_r1980859071 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/FailingSqlTestStep.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Soft

Re: [PR] [BP-2.0][FLINK-37379][state/forst] Double list LRU in ForSt state and cache reload [flink]

2025-03-04 Thread via GitHub
Zakelly commented on PR #26248: URL: https://github.com/apache/flink/pull/26248#issuecomment-2700099437 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-36611][pipeline-connector][kafka] Add schema info to output of Kafka sink [flink-cdc]

2025-03-04 Thread via GitHub
MOBIN-F commented on PR #3791: URL: https://github.com/apache/flink-cdc/pull/3791#issuecomment-2700090679 > Thanks @MOBIN-F for this update. Overall, This modification is good for me, left some comments about the code structure. > > Additionally, you can manually test the data types i

Re: [PR] [FLINK-36611][pipeline-connector][kafka] Add schema info to output of Kafka sink [flink-cdc]

2025-03-04 Thread via GitHub
MOBIN-F commented on code in PR #3791: URL: https://github.com/apache/flink-cdc/pull/3791#discussion_r1980840821 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-kafka/src/main/java/org/apache/flink/cdc/connectors/kafka/json/debezium/DebeziumJsonSerializat

[jira] [Updated] (FLINK-37302) Support timers in PTFs

2025-03-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37302: --- Labels: pull-request-available (was: ) > Support timers in PTFs > -- >

Re: [PR] [FLINK-36611][pipeline-connector][kafka] Add schema info to output of Kafka sink [flink-cdc]

2025-03-04 Thread via GitHub
MOBIN-F commented on code in PR #3791: URL: https://github.com/apache/flink-cdc/pull/3791#discussion_r1980832960 ## docs/content/docs/connectors/pipeline-connectors/kafka.md: ## @@ -202,79 +266,100 @@ An output example is: Data Type Mapping +[Literal type](

[jira] [Commented] (FLINK-37411) Introduce the rollback mechanism for Autoscaler

2025-03-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932527#comment-17932527 ] Gyula Fora commented on FLINK-37411: Or simply with the existing operator rollback m

[jira] [Updated] (FLINK-34547) [Umbrella] FLIP-408: Introduce DataStream API V2

2025-03-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-34547: --- Fix Version/s: 2.0.0 2.0-preview 1.20.0 > [Umbrella] FLIP-408:

[jira] [Closed] (FLINK-34899) Include all classes in flink-core-api that skip the japicmp check back

2025-03-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-34899. -- Resolution: Later > Include all classes in flink-core-api that skip the japicmp check back > -

[jira] [Closed] (FLINK-34900) Check compatibility for classes in flink-core-api that skip japicmp

2025-03-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-34900. -- Fix Version/s: 2.0.0 Resolution: Done > Check compatibility for classes in flink-core-api that

[jira] [Updated] (FLINK-37135) FLIP-500: Support Join Extension in DataStream V2 API

2025-03-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-37135: --- Parent: FLINK-34547 Issue Type: Sub-task (was: New Feature) > FLIP-500: Support Join Extens

[jira] [Resolved] (FLINK-34547) [Umbrella] FLIP-408: Introduce DataStream API V2

2025-03-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo resolved FLINK-34547. Resolution: Done > [Umbrella] FLIP-408: Introduce DataStream API V2 >

[jira] [Commented] (FLINK-37411) Introduce the rollback mechanism for Autoscaler

2025-03-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932528#comment-17932528 ] Gyula Fora commented on FLINK-37411: In any case this is a quite tricky design overa

[jira] [Updated] (FLINK-37136) FLIP-501: Support Window Extension in DataStream V2 API

2025-03-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-37136: --- Parent: FLINK-34547 Issue Type: Sub-task (was: New Feature) > FLIP-501: Support Window Exte

[jira] [Commented] (FLINK-37411) Introduce the rollback mechanism for Autoscaler

2025-03-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932525#comment-17932525 ] Gyula Fora commented on FLINK-37411: It could be:  1. Operator detects broken parall

[jira] [Commented] (FLINK-37411) Introduce the rollback mechanism for Autoscaler

2025-03-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932524#comment-17932524 ] Gyula Fora commented on FLINK-37411: I am still not convinced that this is the right

[jira] [Closed] (FLINK-37418) caugth array out of index exception while using RowData.getArray method

2025-03-04 Thread Spongebob (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Spongebob closed FLINK-37418. - Resolution: Not A Problem > caugth array out of index exception while using RowData.getArray method > --

Re: [PR] [FLINK-33045][format avro-confluent] disable auto-registering schema in registry [flink]

2025-03-04 Thread via GitHub
albert597 commented on PR #25410: URL: https://github.com/apache/flink/pull/25410#issuecomment-2699957640 Hey thanks for working on this - just checking in if we can merge this soon? This bug is causing very annoying bugs on our side and I think others are facing the same issue. -- This

Re: [PR] [FLINK-37422][docs] Fix typo in streaming analytics zh document [flink]

2025-03-04 Thread via GitHub
flinkbot commented on PR #26249: URL: https://github.com/apache/flink/pull/26249#issuecomment-2699787445 ## CI report: * b05c7a59c1754db8de1f116bcb5a525873db78b7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-37422) Typo in streaming analytics zh document

2025-03-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37422: --- Labels: pull-request-available (was: ) > Typo in streaming analytics zh document >

[jira] [Updated] (FLINK-37119) Bump the version of Paimon flink to 1.0.1

2025-03-04 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-37119: --- Summary: Bump the version of Paimon flink to 1.0.1 (was: Bump the version of Paimon flink to 1.0.0)

[PR] [FLINK-37422][docs]Fix typo in streaming analytics zh document [flink]

2025-03-04 Thread via GitHub
ranko-aha opened a new pull request, #26249: URL: https://github.com/apache/flink/pull/26249 ## What is the purpose of the change Fix a typo in streaming analytics zh document. Typo here https://nightlies.apache.org/flink/flink-docs-release-1.20/zh/docs/learn-flink/streaming_analytics/

[jira] [Updated] (FLINK-37119) Bump the version of Paimon flink to 1.0.0

2025-03-04 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-37119: --- Fix Version/s: cdc-3.4.0 > Bump the version of Paimon flink to 1.0.0 > -

[jira] [Assigned] (FLINK-37348) [pipeline-paimon]fix paimon ArrayIndexOutOfBoundsException when add column before first_column

2025-03-04 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-37348: -- Assignee: MOBIN > [pipeline-paimon]fix paimon ArrayIndexOutOfBoundsException when add column

[jira] [Created] (FLINK-37422) Typo in streaming analytics zh document

2025-03-04 Thread ronghangye (Jira)
ronghangye created FLINK-37422: -- Summary: Typo in streaming analytics zh document Key: FLINK-37422 URL: https://issues.apache.org/jira/browse/FLINK-37422 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-37119) Bump the version of Paimon flink to 1.0.1

2025-03-04 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932498#comment-17932498 ] Leonard Xu commented on FLINK-37119: Hey [~911432], you can find the version mapping

[jira] [Resolved] (FLINK-37119) Bump the version of Paimon flink to 1.0.1

2025-03-04 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-37119. Resolution: Fixed Implemented via master: ba282700cc4b481033df5af1591b6307cd9c41f7 > Bump the ver

[jira] [Assigned] (FLINK-37119) Bump the version of Paimon flink to 1.0.0

2025-03-04 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-37119: -- Assignee: Yanquan Lv > Bump the version of Paimon flink to 1.0.0 > --

Re: [PR] [FLINK-37119] Bump the version of Paimon flink to 1.0.1 [flink-cdc]

2025-03-04 Thread via GitHub
leonardBang merged PR #3857: URL: https://github.com/apache/flink-cdc/pull/3857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[jira] [Resolved] (FLINK-37348) [pipeline-paimon]fix paimon ArrayIndexOutOfBoundsException when add column before first_column

2025-03-04 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-37348. Resolution: Fixed Fixed via master: 8019fd3fc07f3b3d4288347302b65b32860410f5 > [pipeline-paimon]f

[jira] [Updated] (FLINK-37348) [pipeline-paimon]fix paimon ArrayIndexOutOfBoundsException when add column before first_column

2025-03-04 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-37348: --- Fix Version/s: cdc-3.4.0 > [pipeline-paimon]fix paimon ArrayIndexOutOfBoundsException when add colum

Re: [PR] [FLINK-37348][pipeline-paimon] fix paimon ArrayIndexOutOfBoundsException when add column first [flink-cdc]

2025-03-04 Thread via GitHub
leonardBang merged PR #3925: URL: https://github.com/apache/flink-cdc/pull/3925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[jira] [Commented] (FLINK-37411) Introduce the rollback mechanism for Autoscaler

2025-03-04 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932494#comment-17932494 ] Rui Fan commented on FLINK-37411: - Thanks [~gyfora] for the quick feedback! :) {quote}It

Re: [PR] [FLINK-37420] fix AbstractAggregatingState add may return wrong result [flink]

2025-03-04 Thread via GitHub
mayuehappy commented on PR #26246: URL: https://github.com/apache/flink/pull/26246#issuecomment-2699708741 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-37420] fix AbstractAggregatingState add may return wrong result [flink]

2025-03-04 Thread via GitHub
mayuehappy commented on PR #26246: URL: https://github.com/apache/flink/pull/26246#issuecomment-2699693803 > can this bug be reproduced and a test cabe added? @nilmadhab @Zakelly Thanks for the reivew. This can be reproduced and I've add related Unit Test (`testAggregatingStateAddWi

Re: [PR] [FLINK-37419] fix the problem that ForStMapState serializeValue may g… [flink]

2025-03-04 Thread via GitHub
Zakelly commented on code in PR #26245: URL: https://github.com/apache/flink/pull/26245#discussion_r1980602627 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStMapState.java: ## @@ -139,6 +140,7 @@ public byte[] serializeValue(UV v

[jira] [Assigned] (FLINK-37419) ForStMapState serializeValue may get wrong result

2025-03-04 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan reassigned FLINK-37419: --- Assignee: Yue Ma > ForStMapState serializeValue may get wrong result >

Re: [PR] [FLINK-37379][state/forst] Double list LRU in ForSt state and cache reload [flink]

2025-03-04 Thread via GitHub
flinkbot commented on PR #26248: URL: https://github.com/apache/flink/pull/26248#issuecomment-2699624712 ## CI report: * 4a52cdda3d959825dd714b8359035b36478d00ab UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-33555) LocalRecoveryITCase.testRecoverLocallyFromProcessCrashWithWorkingDirectory:

2025-03-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932491#comment-17932491 ] Weijie Guo commented on FLINK-33555: [~dmvk] Could you please take a look at this? T

[PR] [FLINK-37379][state/forst] Double list LRU in ForSt state and cache reload [flink]

2025-03-04 Thread via GitHub
Zakelly opened a new pull request, #26248: URL: https://github.com/apache/flink/pull/26248 ## What is the purpose of the change Currently, the file-based LRU cache lacks of loading files from the disaggregated DFS. Meaning that after the job recovery, there will be no cache available

Re: [PR] [BP-2.0][FLINK-37387][build] Enable license check for jdk17 and jdk21 [flink]

2025-03-04 Thread via GitHub
JunRuiLee merged PR #26244: URL: https://github.com/apache/flink/pull/26244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-35810] Fix AsyncWaitOperatorTest missing endInput bug [flink]

2025-03-04 Thread via GitHub
reswqa merged PR #26242: URL: https://github.com/apache/flink/pull/26242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Commented] (FLINK-37387) License check behaves differently for different jdk versions

2025-03-04 Thread Junrui Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932485#comment-17932485 ] Junrui Lee commented on FLINK-37387: release-2.0 315046b171b13b4e02c0ad1a4e4529305fd

[jira] [Resolved] (FLINK-35810) OOM in AsyncWaitOperatorTest.testProcessingTimeRepeatedCompleteUnorderedWithRetry

2025-03-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo resolved FLINK-35810. Fix Version/s: 2.1.0 Resolution: Fixed master(2.1) via 49466aa995861ab529f11936dcf2b5522573

Re: [PR] [FLINK-35810][BP-2.0] Fix AsyncWaitOperatorTest missing endInput bug [flink]

2025-03-04 Thread via GitHub
reswqa merged PR #26241: URL: https://github.com/apache/flink/pull/26241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Commented] (FLINK-37265) Document of python elasticsearch connector exeample has a little mistake

2025-03-04 Thread Hirson Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932480#comment-17932480 ] Hirson Zhang commented on FLINK-37265: -- Hello, [~reswqa], could you please help me

[jira] [Assigned] (FLINK-3154) Update Kryo version from 2.24.0 to latest Kryo LTS version

2025-03-04 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song reassigned FLINK-3154: --- Assignee: Kurt Ostfeld > Update Kryo version from 2.24.0 to latest Kryo LTS version > --

Re: [PR] [FLINK-37420] fix AbstractAggregatingState add may return wrong result [flink]

2025-03-04 Thread via GitHub
Zakelly commented on PR #26246: URL: https://github.com/apache/flink/pull/26246#issuecomment-2698399338 I know it's easy to add UT covering this alone, but it would be great if implementing a mocked `StateRequestHandler` and verifying those methods of 'abstract' classes via that. -- This

[jira] [Closed] (FLINK-37421) [flink-operator][FlinkDeployment] Doesn't provide a mechanism to label the deployment

2025-03-04 Thread Julian (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian closed FLINK-37421. -- Resolution: Works for Me > [flink-operator][FlinkDeployment] Doesn't provide a mechanism to label the > deplo

[jira] [Commented] (FLINK-37421) [flink-operator][FlinkDeployment] Doesn't provide a mechanism to label the deployment

2025-03-04 Thread Yaroslav Tkachenko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932440#comment-17932440 ] Yaroslav Tkachenko commented on FLINK-37421: [~jklaw90] you can add labels a

[jira] [Updated] (FLINK-37421) [flink-operator][FlinkDeployment] Doesn't provide a mechanism to label the deployment

2025-03-04 Thread Julian (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian updated FLINK-37421: --- Description: I don't see a way to add labels to the Deployment created by the FlinkDeployment. My organizat

[jira] [Updated] (FLINK-37421) [flink-operator][FlinkDeployment] Doesn't provide a mechanism to label the deployment

2025-03-04 Thread Julian (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian updated FLINK-37421: --- Description: I don't see a way to add labels to the Deployment created by the FlinkDeployment. My organizat

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-04 Thread via GitHub
ferenc-csaky commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1980080222 ## flink-connector-kudu/src/test/java/org/apache/flink/connector/kudu/source/KuduSourceITCase.java: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Sof

[jira] [Created] (FLINK-37421) [flink-operator][FlinkDeployment] Doesn't provide a mechanism to label the deployment

2025-03-04 Thread Julian (Jira)
Julian created FLINK-37421: -- Summary: [flink-operator][FlinkDeployment] Doesn't provide a mechanism to label the deployment Key: FLINK-37421 URL: https://issues.apache.org/jira/browse/FLINK-37421 Project: Fl

Re: [PR] [FLINK-36203][Connectors/DynamoDB] Added polling delay between getrecords calls [flink-connector-aws]

2025-03-04 Thread via GitHub
gguptp commented on code in PR #190: URL: https://github.com/apache/flink-connector-aws/pull/190#discussion_r1980022377 ## flink-connector-aws/flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/source/reader/PollingDynamoDbStreamsShardSplitReaderTest.java: #

Re: [PR] [FLINK-36203][Connectors/DynamoDB] Added polling delay between getrecords calls [flink-connector-aws]

2025-03-04 Thread via GitHub
gguptp commented on code in PR #190: URL: https://github.com/apache/flink-connector-aws/pull/190#discussion_r1980009840 ## flink-connector-aws/flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/source/reader/PollingDynamoDbStreamsShardSplitReaderTest.java: #

Re: [PR] [FLINK-36203][Connectors/DynamoDB] Added polling delay between getrecords calls [flink-connector-aws]

2025-03-04 Thread via GitHub
gguptp commented on PR #190: URL: https://github.com/apache/flink-connector-aws/pull/190#issuecomment-2698575556 > Added some questions. Thanks @gguptp Thanks @hlteoh37 . I have updated the PR with the requested changes -- This is an automated message from the Apache Git Service. T

Re: [PR] [FLINK-36203][Connectors/DynamoDB] Added polling delay between getrecords calls [flink-connector-aws]

2025-03-04 Thread via GitHub
gguptp commented on code in PR #190: URL: https://github.com/apache/flink-connector-aws/pull/190#discussion_r1980023788 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/config/DynamodbStreamsSourceConfigConstants.java: ##

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-04 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1979988711 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to

Re: [PR] [FLINK-30371] Fix the problem of JdbcOutputFormat database connection leak [flink-connector-jdbc]

2025-03-04 Thread via GitHub
KevDi commented on PR #75: URL: https://github.com/apache/flink-connector-jdbc/pull/75#issuecomment-2698552638 Ok but how should the connection leak beeing fixed then? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-04 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1979991125 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-04 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1979991560 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/utils/KuduSplitGenerator.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Ap

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-04 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1979989809 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to

[PR] [FLINK-37365][pyflink] Add API stability decorators for PyFlink APIs [flink]

2025-03-04 Thread via GitHub
autophagy opened a new pull request, #26247: URL: https://github.com/apache/flink/pull/26247 ## What is the purpose of the change Currently, the Java APIs use annotations like `@PublicEvolving` and `@Experimental` to clearly indicate the stability status of API components. This is su

[jira] [Assigned] (FLINK-37420) AbstractAggregatingState add may return wrong result

2025-03-04 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan reassigned FLINK-37420: --- Assignee: Yue Ma > AbstractAggregatingState add may return wrong result > -

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-04 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1979887307 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-04 Thread via GitHub
ferenc-csaky commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1979790813 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-04 Thread via GitHub
ferenc-csaky commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1979799806 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-35343) NullPointerException in SourceReaderBase

2025-03-04 Thread Nil Madhab (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932382#comment-17932382 ] Nil Madhab commented on FLINK-35343: There is an upgrade in doris, 24.0.1. Does the

Re: [PR] [FLINK-36630][Connectors/Kafka] Wrap consumer.position in retryOnWakeup [flink-connector-kafka]

2025-03-04 Thread via GitHub
fapaul commented on PR #133: URL: https://github.com/apache/flink-connector-kafka/pull/133#issuecomment-2698041282 > I never liked it much, But I was not able to deterministically make it throw within a thread. Any help is welcome. I agree with that the current code structure make

Re: [PR] [FLINK-36630][Connectors/Kafka] Wrap consumer.position in retryOnWakeup [flink-connector-kafka]

2025-03-04 Thread via GitHub
trompa commented on PR #133: URL: https://github.com/apache/flink-connector-kafka/pull/133#issuecomment-2698004133 TBH, I think the code is just about adding a missing wrapper on the position call to make it consistent with the rest of the usages on the file, but didnt liked to create a PR

[jira] [Commented] (FLINK-27641) Create view lost Time attribute in Hive Catalog

2025-03-04 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-27641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932349#comment-17932349 ] Grzegorz Kołakowski commented on FLINK-27641: - For missing *PROCTIME* attrib

[jira] [Comment Edited] (FLINK-35145) Add timeout for cluster termination

2025-03-04 Thread Nishita Pattanayak (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932348#comment-17932348 ] Nishita Pattanayak edited comment on FLINK-35145 at 3/4/25 3:18 PM: --

[jira] [Comment Edited] (FLINK-35145) Add timeout for cluster termination

2025-03-04 Thread Nishita Pattanayak (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932348#comment-17932348 ] Nishita Pattanayak edited comment on FLINK-35145 at 3/4/25 3:17 PM: --

[jira] [Commented] (FLINK-35145) Add timeout for cluster termination

2025-03-04 Thread Nishita Pattanayak (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932348#comment-17932348 ] Nishita Pattanayak commented on FLINK-35145: Is this being worked upon? I wo

Re: [PR] [FLINK-37420] fix AbstractAggregatingState add may return wrong result [flink]

2025-03-04 Thread via GitHub
nilmadhab commented on PR #26246: URL: https://github.com/apache/flink/pull/26246#issuecomment-2697956609 can this bug be reproduced and a test case be added? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [FLINK-36203][Connectors/DynamoDB] Added polling delay between getrecords calls [flink-connector-aws]

2025-03-04 Thread via GitHub
hlteoh37 commented on code in PR #190: URL: https://github.com/apache/flink-connector-aws/pull/190#discussion_r1979590842 ## flink-connector-aws/flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/source/reader/PollingDynamoDbStreamsShardSplitReaderTest.java: ###

Re: [PR] [FLINK-36203][Connectors/DynamoDB] Added polling delay between getrecords calls [flink-connector-aws]

2025-03-04 Thread via GitHub
gguptp commented on code in PR #190: URL: https://github.com/apache/flink-connector-aws/pull/190#discussion_r1979568486 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/config/DynamodbStreamsSourceConfigConstants.java: ##

Re: [PR] [FLINK-36203][Connectors/DynamoDB] Added polling delay between getrecords calls [flink-connector-aws]

2025-03-04 Thread via GitHub
gguptp commented on code in PR #190: URL: https://github.com/apache/flink-connector-aws/pull/190#discussion_r1979571088 ## flink-connector-aws/flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/source/reader/PollingDynamoDbStreamsShardSplitReaderTest.java: #

Re: [PR] [FLINK-36203][Connectors/DynamoDB] Added polling delay between getrecords calls [flink-connector-aws]

2025-03-04 Thread via GitHub
gguptp commented on code in PR #190: URL: https://github.com/apache/flink-connector-aws/pull/190#discussion_r1979569780 ## flink-connector-aws/flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/source/reader/PollingDynamoDbStreamsShardSplitReaderTest.java: #

Re: [PR] Draft PR for plugin based approach for evaluation hook for scaling metric evaluation [flink-kubernetes-operator]

2025-03-04 Thread via GitHub
pchoudhury22 commented on PR #952: URL: https://github.com/apache/flink-kubernetes-operator/pull/952#issuecomment-2697507125 There is another evaluated metric, EXPECTED_PROCESSING_RATE, which gets computed at JobVertexScaler.computeScaleTargetParallelism . Since we calculate this first a

Re: [PR] [FLINK-36203][Connectors/DynamoDB] Added polling delay between getrecords calls [flink-connector-aws]

2025-03-04 Thread via GitHub
gguptp commented on code in PR #190: URL: https://github.com/apache/flink-connector-aws/pull/190#discussion_r1979566056 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/reader/PollingDynamoDbStreamsShardSplitReader.java: #

Re: [PR] [FLINK-36203][Connectors/DynamoDB] Added polling delay between getrecords calls [flink-connector-aws]

2025-03-04 Thread via GitHub
gguptp commented on code in PR #190: URL: https://github.com/apache/flink-connector-aws/pull/190#discussion_r1979565026 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/reader/PollingDynamoDbStreamsShardSplitReader.java: #

Re: [PR] [FLINK-36203][Connectors/DynamoDB] Added polling delay between getrecords calls [flink-connector-aws]

2025-03-04 Thread via GitHub
hlteoh37 commented on code in PR #190: URL: https://github.com/apache/flink-connector-aws/pull/190#discussion_r1979552202 ## flink-connector-aws/flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/source/reader/PollingDynamoDbStreamsShardSplitReaderTest.java: ###

[jira] [Commented] (FLINK-8929) "UnknownTaskExecutorException: No TaskExecutor registered" when having tab open for taskmanager that does not exist (anymore)

2025-03-04 Thread Seung Eun Choi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932333#comment-17932333 ] Seung Eun Choi commented on FLINK-8929: --- In my case, it was OOM Killed in K8S. > "

Re: [PR] [FLINK-36172][metrics][rest] Optimize transient metric cleanup [flink]

2025-03-04 Thread via GitHub
fdc-ntflx commented on PR #26204: URL: https://github.com/apache/flink/pull/26204#issuecomment-2697766555 Thanks for the review, everyone! I got caught up with work and wasn't able to address the comments before the PR was merged. I agree that more unit tests could have been added, but I fe

Re: [PR] [FLINK-37420] fix AbstractAggregatingState add may return wrong result [flink]

2025-03-04 Thread via GitHub
flinkbot commented on PR #26246: URL: https://github.com/apache/flink/pull/26246#issuecomment-2697640544 ## CI report: * 9d20743a1e0f52e33b75eb0ffac46fdd0cd0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [backport][FLINK-3154][API] Upgrade from Kryo 2.x to Kryo 5.x. Removed twitter chill companion library which is abandoned. [flink]

2025-03-04 Thread via GitHub
gyfora merged PR #26243: URL: https://github.com/apache/flink/pull/26243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[PR] [FLINK-37420] fix AbstractAggregatingState add may return wrong result [flink]

2025-03-04 Thread via GitHub
mayuehappy opened a new pull request, #26246: URL: https://github.com/apache/flink/pull/26246 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[jira] [Updated] (FLINK-37420) AbstractAggregatingState add may return wrong result

2025-03-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37420: --- Labels: pull-request-available (was: ) > AbstractAggregatingState add may return wrong resu

[jira] [Created] (FLINK-37420) AbstractAggregatingState add may return wrong result

2025-03-04 Thread Yue Ma (Jira)
Yue Ma created FLINK-37420: -- Summary: AbstractAggregatingState add may return wrong result Key: FLINK-37420 URL: https://issues.apache.org/jira/browse/FLINK-37420 Project: Flink Issue Type: Bug

[jira] [Closed] (FLINK-3154) Update Kryo version from 2.24.0 to latest Kryo LTS version

2025-03-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-3154. - Fix Version/s: 2.1.0 Resolution: Fixed merged: master - ef09e1716924d1e6ed64bfc273859f2de979b027 r

Re: [PR] [FLINK-37419] fix the problem that ForStMapState serializeValue may g… [flink]

2025-03-04 Thread via GitHub
flinkbot commented on PR #26245: URL: https://github.com/apache/flink/pull/26245#issuecomment-2697544462 ## CI report: * cf25f30b4e18a217c953b1814d30399e1e2a9573 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-37418) caugth array out of index exception while using RowData.getArray method

2025-03-04 Thread Spongebob (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Spongebob updated FLINK-37418: -- Description: Test RowData's arity is 10. the 5th column is an array structure. then I called rowData.

[jira] [Updated] (FLINK-37419) ForStMapState serializeValue may get wrong result

2025-03-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37419: --- Labels: pull-request-available (was: ) > ForStMapState serializeValue may get wrong result

[PR] [FLINK-37419] fix the problem that ForStMapState serializeValue may g… [flink]

2025-03-04 Thread via GitHub
mayuehappy opened a new pull request, #26245: URL: https://github.com/apache/flink/pull/26245 …et wrong result ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we av

  1   2   >