Zakelly commented on code in PR #26245: URL: https://github.com/apache/flink/pull/26245#discussion_r1980602627
########## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStMapState.java: ########## @@ -139,6 +140,7 @@ public byte[] serializeValue(UV value) throws IOException { public UV deserializeValue(byte[] valueBytes) throws IOException { DataInputDeserializer inputView = valueDeserializerView.get(); inputView.setBuffer(valueBytes); + inputView.readBoolean(); Review Comment: We should respect this read value and return null if `true` (since it may come from the sync state). The invokers of this method should also deal with the returned null. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org