Re: [PR] [FLINK-3154][API] Upgrade from Kryo 2.x to Kryo 5.x. Removed twitter … [flink]

2025-01-03 Thread via GitHub
flinkbot commented on PR #25896: URL: https://github.com/apache/flink/pull/25896#issuecomment-2570421218 ## CI report: * 8e2738f3503d7be2e5078d0d7d42bdd9e6cd5b17 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-3154][API] Upgrade from Kryo 2.x to Kryo 5.x. Removed twitter … [flink]

2025-01-03 Thread via GitHub
kurtostfeld opened a new pull request, #25896: URL: https://github.com/apache/flink/pull/25896 …chill companion library which is abandoned. ## What is the purpose of the change Update the Kryo dependency. Remove the old Kryo dependency and the companion Chill dependency.

Re: [PR] [FLINK-36759][sql-gateway] Add REST API to deploy script in application mode [flink]

2025-01-03 Thread via GitHub
fsk119 commented on PR #25730: URL: https://github.com/apache/flink/pull/25730#issuecomment-2570100070 The failed test is because REST endpoint doesn't start in 30 seconds. In my private pipline, e2e test passes. https://dev.azure.com/1059623455/Flink/_build/results?buildId=652&view=

Re: [PR] [FLINK-36759][sql-gateway] Add REST API to deploy script in application mode [flink]

2025-01-03 Thread via GitHub
fsk119 commented on PR #25730: URL: https://github.com/apache/flink/pull/25730#issuecomment-2570077892 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FLINK-3154][runtime] Upgrade from Kryo v2 + Chill 0.7.6 to Kryo v5 w… [flink]

2025-01-03 Thread via GitHub
kurtostfeld closed pull request #22660: [FLINK-3154][runtime] Upgrade from Kryo v2 + Chill 0.7.6 to Kryo v5 w… URL: https://github.com/apache/flink/pull/22660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [hotfix][table-planner] Remove legacy table source in the plan when test AdaptiveJoinTest [flink]

2025-01-03 Thread via GitHub
xuyangzhong commented on PR #25891: URL: https://github.com/apache/flink/pull/25891#issuecomment-2570012643 @lsyldliu Could you help to take a look since these tests break the master... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-36007][table] Apply changes from FLINK-36277 to AdaptiveJoin [flink]

2025-01-03 Thread via GitHub
xuyangzhong commented on PR #25895: URL: https://github.com/apache/flink/pull/25895#issuecomment-2570010312 Hi, @snuyanzin there has been a quick hotfix https://github.com/apache/flink/pull/25891 waiting anybody helps review & merge for it after https://github.com/apache/flink/pull/25326 b

Re: [PR] [FLINK-36007][table] Apply changes from FLINK-36277 to AdaptiveJoin [flink]

2025-01-03 Thread via GitHub
snuyanzin commented on PR #25895: URL: https://github.com/apache/flink/pull/25895#issuecomment-2570003726 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-37006) Apply changes from FLINK-36277 to AdaptiveJoin

2025-01-03 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-37006: Priority: Blocker (was: Major) > Apply changes from FLINK-36277 to AdaptiveJoin > ---

[jira] [Updated] (FLINK-37006) Apply changes from FLINK-36277 to AdaptiveJoin

2025-01-03 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-37006: Description: Blocker since now every master build is failing like https://dev.azure.com/a

Re: [PR] [docs] Add 'scan.incremental.snapshot.backfill.skip' to docs. [flink-cdc]

2025-01-03 Thread via GitHub
github-actions[bot] commented on PR #3030: URL: https://github.com/apache/flink-cdc/pull/3030#issuecomment-2569949177 This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. --

Re: [PR] [FLINK-36007][table] Apply changes from FLINK-36277 to AdaptiveJoin [flink]

2025-01-03 Thread via GitHub
snuyanzin commented on PR #25895: URL: https://github.com/apache/flink/pull/25895#issuecomment-2569934571 also + @JunRuiLee , @zhuzhurk since you were participating in AdaptiveJoin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] [FLINK-36007][table] Apply changes from FLINK-36277 to AdaptiveJoin [flink]

2025-01-03 Thread via GitHub
flinkbot commented on PR #25895: URL: https://github.com/apache/flink/pull/25895#issuecomment-2569932201 ## CI report: * aeb5ec2cfc5fdc97d52a167add9e6bc870386979 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-36007][table] Apply changes from FLINK-36277 to AdaptiveJoin [flink]

2025-01-03 Thread via GitHub
snuyanzin commented on PR #25895: URL: https://github.com/apache/flink/pull/25895#issuecomment-2569929262 @lsyldliu @xuyangzhong this is a follow up for https://github.com/apache/flink/pull/25326 could you please have a look? -- This is an automated message from the Apache Git S

Re: [PR] [FLINK-36277][table] Remove all direct uses of `TableEnvironmentInternal#registerTableSourceInternal` in table module [flink]

2025-01-03 Thread via GitHub
snuyanzin commented on PR #25326: URL: https://github.com/apache/flink/pull/25326#issuecomment-2569928339 Hey @xuyangzhong , @lsyldliu It seems this is the reason of master failure https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=64822&view=logs&j=0c940707-2659-5648

[PR] [FLINK-36007][table] Apply changes from FLINK-36277 to AdaptiveJoin [flink]

2025-01-03 Thread via GitHub
snuyanzin opened a new pull request, #25895: URL: https://github.com/apache/flink/pull/25895 ## What is the purpose of the change This is a follow up for https://github.com/apache/flink/pull/25326 for `AdaptiveJoin` ## Brief change log plan changes ## Verifyin

[jira] [Created] (FLINK-37006) Apply changes from FLINK-36277 to AdaptiveJoin

2025-01-03 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-37006: --- Summary: Apply changes from FLINK-36277 to AdaptiveJoin Key: FLINK-37006 URL: https://issues.apache.org/jira/browse/FLINK-37006 Project: Flink Issue Ty

Re: [PR] [FLINK-36303] PostgreSQL timestamp precision 0 not supported [flink-connector-jdbc]

2025-01-03 Thread via GitHub
kgeis commented on PR #142: URL: https://github.com/apache/flink-connector-jdbc/pull/142#issuecomment-2569906036 Thanks, @eskabetxe. I had renamed the PR and didn't know how to clear that check, and I appreciate the pointer. I've never renamed a pushed commit before. Always learning!

Re: [PR] [FLINK-36997] Add Log4j JSONTemplateLayout to flink-dist [flink]

2025-01-03 Thread via GitHub
ryanvanhuuksloot commented on PR #25888: URL: https://github.com/apache/flink/pull/25888#issuecomment-2569785312 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [FLINK-36997] Add Log4j JSONTemplateLayout to flink-dist [flink]

2025-01-03 Thread via GitHub
ryanvanhuuksloot commented on PR #25888: URL: https://github.com/apache/flink/pull/25888#issuecomment-2569771750 First pass at the documentation change ![Screenshot 2025-01-03 at 3 23 35  PM](https://github.com/user-attachments/assets/288bbb9c-6f1c-4c51-8a02-3f481bc9f34d) -- This is

Re: [PR] [FLINK-36997] Add Log4j JSONTemplateLayout to flink-dist [flink]

2025-01-03 Thread via GitHub
ryanvanhuuksloot commented on PR #25888: URL: https://github.com/apache/flink/pull/25888#issuecomment-2569710963 I don't see any tests for the inclusion of the other log4j dependencies in the distribution. I've looked in runtime, core and dist. Do you know where else they could be? -- Th

Re: [PR] [FLINK-36997] Add Log4j JSONTemplateLayout to flink-dist [flink]

2025-01-03 Thread via GitHub
ryanvanhuuksloot commented on PR #25888: URL: https://github.com/apache/flink/pull/25888#issuecomment-2569689774 >I wonder why you have added this to the dist pom and not to the top level Flink pom, that might allow you to add a unit test to test the usage of this. I added it to both.

Re: [PR] [FLINK-36997] Add Log4j JSONTemplateLayout to flink-dist [flink]

2025-01-03 Thread via GitHub
ryanvanhuuksloot commented on PR #25888: URL: https://github.com/apache/flink/pull/25888#issuecomment-2569540892 >@ryanvanhuuksloot you can rerun CI jobs using flinkbot It looks like it was marked as SUCCESS but I've kicked it off again ![Screenshot 2025-01-03 at 11 58 34  AM](https

Re: [PR] [FLINK-36997] Add Log4j JSONTemplateLayout to flink-dist [flink]

2025-01-03 Thread via GitHub
ryanvanhuuksloot commented on PR #25888: URL: https://github.com/apache/flink/pull/25888#issuecomment-2569540238 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[jira] [Created] (FLINK-37005) Make StreamExecDeduplicate ouput insert only where possible

2025-01-03 Thread Piotr Nowojski (Jira)
Piotr Nowojski created FLINK-37005: -- Summary: Make StreamExecDeduplicate ouput insert only where possible Key: FLINK-37005 URL: https://issues.apache.org/jira/browse/FLINK-37005 Project: Flink

Re: [PR] [BP-1.20][FLINK-36739] Update the NodeJS to v22.11.0 (LTS) [flink]

2025-01-03 Thread via GitHub
afedulov commented on PR #25794: URL: https://github.com/apache/flink/pull/25794#issuecomment-2569512424 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (FLINK-37004) Implement Multithreaded SourceReader

2025-01-03 Thread Hong Liang Teoh (Jira)
Hong Liang Teoh created FLINK-37004: --- Summary: Implement Multithreaded SourceReader Key: FLINK-37004 URL: https://issues.apache.org/jira/browse/FLINK-37004 Project: Flink Issue Type: Improv

Re: [PR] [FLINK-36871][runtime] add rescale metrics in scheduler [flink]

2025-01-03 Thread via GitHub
mxm commented on code in PR #25770: URL: https://github.com/apache/flink/pull/25770#discussion_r1901860694 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java: ## @@ -1266,7 +1269,12 @@ public void goToRestarting(

Re: [PR] [hotfix][table-planner] Remove legacy table source in the plan when test AdaptiveJoinTest [flink]

2025-01-03 Thread via GitHub
xuyangzhong commented on PR #25891: URL: https://github.com/apache/flink/pull/25891#issuecomment-2569320885 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [FLINK-37003][Datastream] Implement async state version of Datastream Interval join [flink]

2025-01-03 Thread via GitHub
flinkbot commented on PR #25894: URL: https://github.com/apache/flink/pull/25894#issuecomment-2569242442 ## CI report: * 80d94e3f60505ca61cca9d66d441d6ce0ef91d1e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-37003) Implement async state version of Datastream Interval join

2025-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37003: --- Labels: pull-request-available (was: ) > Implement async state version of Datastream Interv

[PR] [FLINK-37003][Datastream] Implement async state version of Datastream Interval join [flink]

2025-01-03 Thread via GitHub
Zakelly opened a new pull request, #25894: URL: https://github.com/apache/flink/pull/25894 ## What is the purpose of the change As part of FLIP-488, this PR introduced the built-in interval join operator for datastream with async state access. - Also a hotfix of forst map

Re: [PR] [FLINK-37003][Datastream] Implement async state version of Datastream Interval join [flink]

2025-01-03 Thread via GitHub
Zakelly commented on PR #25894: URL: https://github.com/apache/flink/pull/25894#issuecomment-2569238656 @fredia Would you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Updated] (FLINK-37000) MySQL CDC could not handle date and time data prior to unix epoch

2025-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37000: --- Labels: pull-request-available (was: ) > MySQL CDC could not handle date and time data prio

[jira] [Updated] (FLINK-34194) Upgrade Flink CI Docker container to Ubuntu 22.04

2025-01-03 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34194: -- Fix Version/s: 1.20.1 > Upgrade Flink CI Docker container to Ubuntu 22.04 > --

[jira] [Commented] (FLINK-34194) Upgrade Flink CI Docker container to Ubuntu 22.04

2025-01-03 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909588#comment-17909588 ] Matthias Pohl commented on FLINK-34194: --- Updated merge history after merging the b

[jira] [Created] (FLINK-37003) Implement async state version of Datastream Interval join

2025-01-03 Thread Zakelly Lan (Jira)
Zakelly Lan created FLINK-37003: --- Summary: Implement async state version of Datastream Interval join Key: FLINK-37003 URL: https://issues.apache.org/jira/browse/FLINK-37003 Project: Flink Issue

Re: [PR] [BP-1.20][FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2025-01-03 Thread via GitHub
XComp merged PR #25827: URL: https://github.com/apache/flink/pull/25827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [BP-1.20][FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2025-01-03 Thread via GitHub
XComp commented on PR #25827: URL: https://github.com/apache/flink/pull/25827#issuecomment-2569210346 > Do we need to continue building 1.x line with JDK 8? Yes, only with 2.0 (current `master`) it was decided to deprecate JDK 8 -- This is an automated message from the Apache Git Se

Re: [PR] [hotfix][table-planner] Remove legacy table source in the plan when test AdaptiveJoinTest [flink]

2025-01-03 Thread via GitHub
xuyangzhong commented on PR #25891: URL: https://github.com/apache/flink/pull/25891#issuecomment-2569200628 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [FLINK-36979][rpc] Reverting pekko version bump in Flink 1.20 [flink]

2025-01-03 Thread via GitHub
He-Pin commented on PR #25866: URL: https://github.com/apache/flink/pull/25866#issuecomment-2569183097 another optimization in https://github.com/apache/pekko/pull/1667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] [BP-1.20][FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2025-01-03 Thread via GitHub
afedulov commented on PR #25827: URL: https://github.com/apache/flink/pull/25827#issuecomment-2569181925 If that is the case that LGTM, the second commit reverts back to 8 after resolving conflicts initially https://github.com/apache/flink/pull/25827/commits/565408f120180d245b935b09165a4

Re: [PR] [hotfix][docs] In match_recognize docs, remove extracting time attributes from list of limitations [flink]

2025-01-03 Thread via GitHub
alpinegizmo merged PR #25879: URL: https://github.com/apache/flink/pull/25879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [BP-1.20][FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2025-01-03 Thread via GitHub
afedulov commented on PR #25827: URL: https://github.com/apache/flink/pull/25827#issuecomment-2569167003 I am not quite sure what to read into this comment: https://github.com/apache/flink/pull/25708#issuecomment-2506155540 Do we need to continue building 1.x line with JDK 8? -- T

Re: [PR] [FLINK-36759][sql-gateway] Add REST API to deploy script in application mode [flink]

2025-01-03 Thread via GitHub
hackergin commented on code in PR #25730: URL: https://github.com/apache/flink/pull/25730#discussion_r1901750766 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/SqlGatewayServiceImpl.java: ## @@ -330,6 +337,46 @@ public OperationHandle refre

Re: [PR] [FLINK-36759][sql-gateway] Add REST API to deploy script in application mode [flink]

2025-01-03 Thread via GitHub
hackergin commented on code in PR #25730: URL: https://github.com/apache/flink/pull/25730#discussion_r1901743073 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/SqlGatewayServiceImpl.java: ## @@ -340,25 +340,25 @@ public OperationHandle refr

Re: [PR] [FLINK-36992][table] Migrate DecomposeGroupingSetsRule to java [flink]

2025-01-03 Thread via GitHub
flinkbot commented on PR #25893: URL: https://github.com/apache/flink/pull/25893#issuecomment-2569122975 ## CI report: * 8db402caf72887be282d25cbdc7d3ec35cd3c945 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-37002) Migrate DecomposeGroupingSetsRule

2025-01-03 Thread Jacky Lau (Jira)
Jacky Lau created FLINK-37002: - Summary: Migrate DecomposeGroupingSetsRule Key: FLINK-37002 URL: https://issues.apache.org/jira/browse/FLINK-37002 Project: Flink Issue Type: Sub-task Co

[PR] [FLINK-36992][table] Migrate DecomposeGroupingSetsRule to java [flink]

2025-01-03 Thread via GitHub
liuyongvs opened a new pull request, #25893: URL: https://github.com/apache/flink/pull/25893 ## What is the purpose of the change The PR migrates DecomposeGroupingSetsRule to java ## Verifying this change This change is already covered by existing tests ## Does thi

Re: [PR] [FLINK-36979][rpc] Reverting pekko version bump in Flink 1.20 [flink]

2025-01-03 Thread via GitHub
He-Pin commented on PR #25866: URL: https://github.com/apache/flink/pull/25866#issuecomment-2569115685 @XComp So it is better to turn on `-Dio.netty.leakDetection.level=PARANOID` to see who holds the buffers. and turn on `-Dio.netty.allocator.type=unpooled` too, then all ByteBuf lives in

Re: [PR] [FLINK-36998][table-planner] Set +I to data when restoring in values KeyedUpsertingSinkFunction [flink]

2025-01-03 Thread via GitHub
flinkbot commented on PR #25892: URL: https://github.com/apache/flink/pull/25892#issuecomment-2569108750 ## CI report: * 094a094b63c33420696ebf9c3bbdb3d1e9957922 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-36998) The RowKind of data about globalUpsertResult is different in KeyedUpsertingSinkFunction while being inserted or being restored

2025-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36998: --- Labels: pull-request-available (was: ) > The RowKind of data about globalUpsertResult is di

[PR] [FLINK-36998][table-planner] Set +I to data when restoring in values KeyedUpsertingSinkFunction [flink]

2025-01-03 Thread via GitHub
xuyangzhong opened a new pull request, #25892: URL: https://github.com/apache/flink/pull/25892 ## What is the purpose of the change *Set +I to data when restoring in values KeyedUpsertingSinkFunction* ## Brief change log - *Set +I to data when restoring in values Ke

Re: [PR] [hotfix][table-planner] Remove legacy table source in the plan when test AdaptiveJoinTest [flink]

2025-01-03 Thread via GitHub
flinkbot commented on PR #25891: URL: https://github.com/apache/flink/pull/25891#issuecomment-2569094204 ## CI report: * 6099a6288cda087fe8fb389b5172655fd826e9c7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix][table-planner] Remove legacy table source in the plan when test AdaptiveJoinTest [flink]

2025-01-03 Thread via GitHub
xuyangzhong opened a new pull request, #25891: URL: https://github.com/apache/flink/pull/25891 ## What is the purpose of the change *Remove legacy table source in the plan when test AdaptiveJoinTest* ## Brief change log - *Remove legacy table source in the plan when

Re: [PR] [FLINK-36979][rpc] Reverting pekko version bump in Flink 1.20 [flink]

2025-01-03 Thread via GitHub
XComp commented on PR #25866: URL: https://github.com/apache/flink/pull/25866#issuecomment-2569083088 @He-Pin are you sure? We see the following stacktrace in [this e2e test failure](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=64748&view=logs&j=e8e46ef5-75cc-564f-c

Re: [PR] [BP-1.20][FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2025-01-03 Thread via GitHub
XComp commented on PR #25827: URL: https://github.com/apache/flink/pull/25827#issuecomment-2569052895 Oops, that was my mistake. I didn't check the author of the commit 🤦 I assumed it was an old PR that was created by me. Sorry for the confusion. I reopened the PR -- This is an automated

Re: [PR] [FLINK-36871][runtime] add rescale metrics in scheduler [flink]

2025-01-03 Thread via GitHub
davidradl commented on code in PR #25770: URL: https://github.com/apache/flink/pull/25770#discussion_r1901668640 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java: ## @@ -1266,7 +1269,12 @@ public void goToRestarting(

Re: [PR] [DRAFT/test] fix for jackson-mapper-asl 1.9.13 [flink]

2025-01-03 Thread via GitHub
flinkbot commented on PR #25890: URL: https://github.com/apache/flink/pull/25890#issuecomment-2569010328 ## CI report: * 73d464899f8b20cc910b3fb4a59ffe15de353290 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-37001][table] Remove code related to registerTableSinkInternal in tests and remove this method in TableEnvironmentInternal [flink]

2025-01-03 Thread via GitHub
flinkbot commented on PR #25889: URL: https://github.com/apache/flink/pull/25889#issuecomment-2569002148 ## CI report: * 245b65a471eb3b161e93044c339cd9e194615b23 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [hotfix][docs] In match_recognize docs, remove extracting time attributes from list of limitations [flink]

2025-01-03 Thread via GitHub
davidradl commented on PR #25879: URL: https://github.com/apache/flink/pull/25879#issuecomment-2569001926 The failing CI tests seem unrelated to the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-36997] Add Log4j JSONTemplateLayout to flink-dist [flink]

2025-01-03 Thread via GitHub
davidradl commented on PR #25888: URL: https://github.com/apache/flink/pull/25888#issuecomment-2568990786 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-36997] Add Log4j JSONTemplateLayout to flink-dist [flink]

2025-01-03 Thread via GitHub
davidradl commented on PR #25888: URL: https://github.com/apache/flink/pull/25888#issuecomment-2568991537 @ryanvanhuuksloot you can rerun CI jobs using flinkbot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] [FLINK-36997] Add Log4j JSONTemplateLayout to flink-dist [flink]

2025-01-03 Thread via GitHub
davidradl commented on PR #25888: URL: https://github.com/apache/flink/pull/25888#issuecomment-2568988940 @ryanvanhuuksloot This sounds reasonable to me. I wonder why you have added this to the dist pom and not to the top level Flink pom, that might allow you to add a unit test to test the

[PR] [test] fix for jackson-mapper-asl 1.9.13 [flink]

2025-01-03 Thread via GitHub
anupamaggarwal opened a new pull request, #25890: URL: https://github.com/apache/flink/pull/25890 ## What is the purpose of the change Fix [CVE-2019-10202](https://nvd.nist.gov/vuln/detail/cve-2019-10202) in org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13 More details at ht

Re: [PR] [BP-1.20][FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2025-01-03 Thread via GitHub
afedulov commented on PR #25827: URL: https://github.com/apache/flink/pull/25827#issuecomment-2568987509 @XComp got it thanks. I think there was some misunderstanding since this PR contained this PR from Chesnay with some modifications and a follow-up commit that reverted them, so effective

[jira] [Updated] (FLINK-36999) Null pointer exception when the source field type is decimal and the value is null

2025-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36999: --- Labels: pull-request-available (was: ) > Null pointer exception when the source field type

Re: [PR] [FLINK-28897] [TABLE-SQL] Fail to use udf in added jar when enabling checkpoint [flink]

2025-01-03 Thread via GitHub
davidradl commented on code in PR #25656: URL: https://github.com/apache/flink/pull/25656#discussion_r1901618852 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java: ## @@ -1029,6 +1029,11 @@ private TableResultInternal

Re: [PR] [FLINK-28897] [TABLE-SQL] Fail to use udf in added jar when enabling checkpoint [flink]

2025-01-03 Thread via GitHub
davidradl commented on code in PR #25656: URL: https://github.com/apache/flink/pull/25656#discussion_r1901618852 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java: ## @@ -1029,6 +1029,11 @@ private TableResultInternal

[jira] [Updated] (FLINK-37001) Remove all direct uses of `TableEnvironmentInternal#registerTableSinkInternal` in table module

2025-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37001: --- Labels: pull-request-available (was: ) > Remove all direct uses of > `TableEnvironmentInte

Re: [PR] [FLINK-28897] [TABLE-SQL] Fail to use udf in added jar when enabling checkpoint [flink]

2025-01-03 Thread via GitHub
davidradl commented on code in PR #25656: URL: https://github.com/apache/flink/pull/25656#discussion_r1901618852 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java: ## @@ -1029,6 +1029,11 @@ private TableResultInternal

[PR] [FLINK-37001][table] Remove code related to registerTableSinkInternal in tests and remove this method in TableEnvironmentInternal [flink]

2025-01-03 Thread via GitHub
xuyangzhong opened a new pull request, #25889: URL: https://github.com/apache/flink/pull/25889 ## What is the purpose of the change Remove all direct uses of `TableEnvironmentInternal#registerTableSinkInternal` in table module. ## Brief change log - *Remove all direct

Re: [PR] [FLINK-28897] [TABLE-SQL] Fail to use udf in added jar when enabling checkpoint [flink]

2025-01-03 Thread via GitHub
davidradl commented on code in PR #25656: URL: https://github.com/apache/flink/pull/25656#discussion_r1901618852 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java: ## @@ -1029,6 +1029,11 @@ private TableResultInternal

Re: [PR] [FLINK-28897] [TABLE-SQL] Fail to use udf in added jar when enabling checkpoint [flink]

2025-01-03 Thread via GitHub
davidradl commented on code in PR #25656: URL: https://github.com/apache/flink/pull/25656#discussion_r1901618852 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java: ## @@ -1029,6 +1029,11 @@ private TableResultInternal

[jira] [Created] (FLINK-37001) Remove all direct uses of `TableEnvironmentInternal#registerTableSinkInternal` in table module

2025-01-03 Thread xuyang (Jira)
xuyang created FLINK-37001: -- Summary: Remove all direct uses of `TableEnvironmentInternal#registerTableSinkInternal` in table module Key: FLINK-37001 URL: https://issues.apache.org/jira/browse/FLINK-37001 Pr

Re: [PR] [FLINK-28897] [TABLE-SQL] Fail to use udf in added jar when enabling checkpoint [flink]

2025-01-03 Thread via GitHub
davidradl commented on code in PR #25656: URL: https://github.com/apache/flink/pull/25656#discussion_r1901618852 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java: ## @@ -1029,6 +1029,11 @@ private TableResultInternal

Re: [PR] [FLINK-28897] [TABLE-SQL] Fail to use udf in added jar when enabling checkpoint [flink]

2025-01-03 Thread via GitHub
davidradl commented on code in PR #25656: URL: https://github.com/apache/flink/pull/25656#discussion_r1901618852 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java: ## @@ -1029,6 +1029,11 @@ private TableResultInternal

[jira] [Resolved] (FLINK-36277) Remove all direct uses of `TableEnvironmentInternal#registerTableSourceInternal` in table module

2025-01-03 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu resolved FLINK-36277. --- Assignee: xuyang Resolution: Fixed > Remove all direct uses of > `TableEnvironmentInternal#re

[jira] [Commented] (FLINK-36277) Remove all direct uses of `TableEnvironmentInternal#registerTableSourceInternal` in table module

2025-01-03 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909525#comment-17909525 ] dalongliu commented on FLINK-36277: --- Merged in master branch: bbbd160ca7904a7e0a338183

Re: [PR] [FLINK-36277][table] Remove all direct uses of `TableEnvironmentInternal#registerTableSourceInternal` in table module [flink]

2025-01-03 Thread via GitHub
lsyldliu merged PR #25326: URL: https://github.com/apache/flink/pull/25326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Created] (FLINK-37000) MySQL CDC could not handle date and time data prior to unix epoch

2025-01-03 Thread yux (Jira)
yux created FLINK-37000: --- Summary: MySQL CDC could not handle date and time data prior to unix epoch Key: FLINK-37000 URL: https://issues.apache.org/jira/browse/FLINK-37000 Project: Flink Issue Type:

Re: [PR] [FLINK-36610] MySQL CDC supports parsing gh-ost / pt-osc generated schema changes [flink-cdc]

2025-01-03 Thread via GitHub
mielientiev commented on PR #3668: URL: https://github.com/apache/flink-cdc/pull/3668#issuecomment-2568928957 Hello @czy006 @MOBIN-F Any idea when this PR could be merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] [FLINK-36701][cdc-runtime] Add steps to get and emit schemaManager's latest evolvedSchema when SinkDataWriterOperator handles FlushEvent [flink-cdc]

2025-01-03 Thread via GitHub
Jzjsnow commented on PR #3802: URL: https://github.com/apache/flink-cdc/pull/3802#issuecomment-2568926798 The `Source E2E Tests#OceanBaseE2eITCase` test did not pass in this round of CIs, but it is not relevant to this PR. It seems that the 1 minute timeout set in the method `checkResultWit

[jira] [Closed] (FLINK-35249) Support DataGeneratorSource in PyFlink

2025-01-03 Thread Wei Yuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Yuan closed FLINK-35249. Release Note: There is a sample date gererator in Java code. I thought we only need complete the doc.

[jira] [Created] (FLINK-36999) Null pointer exception when the source field type is decimal and the value is null

2025-01-03 Thread Jira
林健昌 created FLINK-36999: --- Summary: Null pointer exception when the source field type is decimal and the value is null Key: FLINK-36999 URL: https://issues.apache.org/jira/browse/FLINK-36999 Project: Flink

Re: [PR] [FLINK-36836][Autoscaler] Supports config the upper and lower limits of target utilization [flink-kubernetes-operator]

2025-01-03 Thread via GitHub
1996fanrui commented on code in PR #921: URL: https://github.com/apache/flink-kubernetes-operator/pull/921#discussion_r1901579318 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -89,21 +89,41 @@ private static ConfigOptions.Opt

Re: [PR] [FLINK-34467] add lineage integration for jdbc connector [flink-connector-jdbc]

2025-01-03 Thread via GitHub
pawel-big-lebowski commented on code in PR #149: URL: https://github.com/apache/flink-connector-jdbc/pull/149#discussion_r1901564793 ## flink-connector-jdbc-cratedb/src/test/java/org/apache/flink/connector/jdbc/cratedb/database/lineage/CrateDBLocationExtractorTest.java: ## @@ -

Re: [PR] [FLINK-34467] add lineage integration for jdbc connector [flink-connector-jdbc]

2025-01-03 Thread via GitHub
pawel-big-lebowski commented on code in PR #149: URL: https://github.com/apache/flink-connector-jdbc/pull/149#discussion_r1867680880 ## flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/lineage/DefaultTypeDatasetFacet.java: ## @@ -0,0 +1,61 @@ +/* + * Lice

Re: [PR] [BP-1.20][FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2025-01-03 Thread via GitHub
XComp commented on PR #25827: URL: https://github.com/apache/flink/pull/25827#issuecomment-2568854853 > I assume the docs generation got addressed in that one? > I am curious to know if you are aware of any constraints for porting it back to the previous releases. Yes, @zentol pick

Re: [PR] [BP-1.20][FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2025-01-03 Thread via GitHub
XComp closed pull request #25827: [BP-1.20][FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) URL: https://github.com/apache/flink/pull/25827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[jira] [Updated] (FLINK-36998) The RowKind of data about globalUpsertResult is different in KeyedUpsertingSinkFunction while being inserted or being restored

2025-01-03 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-36998: --- Summary: The RowKind of data about globalUpsertResult is different in KeyedUpsertingSinkFunction while being

[jira] [Created] (FLINK-36998) The RowKind of data about globalUpsertResult is different in KeyedUpsertingSinkFunction while being inserted or be restored

2025-01-03 Thread xuyang (Jira)
xuyang created FLINK-36998: -- Summary: The RowKind of data about globalUpsertResult is different in KeyedUpsertingSinkFunction while being inserted or be restored Key: FLINK-36998 URL: https://issues.apache.org/jira/brows

Re: [PR] [FLINK-36863][autoscaler] Use the maximum parallelism in the past scale-down.interval window when scaling down [flink-kubernetes-operator]

2025-01-03 Thread via GitHub
1996fanrui commented on code in PR #922: URL: https://github.com/apache/flink-kubernetes-operator/pull/922#discussion_r1901559620 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -259,6 +220,9 @@ Map computeScalingSummary(

[PR] [hotfix] Add missing enumeration [flink-cdc]

2025-01-03 Thread via GitHub
ChaomingZhangCN opened a new pull request, #3832: URL: https://github.com/apache/flink-cdc/pull/3832 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [FLINK-36989][runtime] Fix scheduler benchmark regression caused by ConsumedSubpartitionContext [flink]

2025-01-03 Thread via GitHub
zhuzhurk commented on code in PR #25887: URL: https://github.com/apache/flink/pull/25887#discussion_r1901541146 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/ConsumedPartitionGroup.java: ## @@ -40,7 +40,7 @@ */ public class ConsumedPartitionGroup

Re: [PR] [FLINK-36946][Metrics] Optimize sink operator name truncate [flink]

2025-01-03 Thread via GitHub
1996fanrui commented on code in PR #25832: URL: https://github.com/apache/flink/pull/25832#discussion_r1901545914 ## flink-runtime/src/main/java/org/apache/flink/runtime/metrics/util/MetricUtils.java: ## @@ -366,6 +369,17 @@ private static void instantiateCPUMetrics(MetricGroup