ryanvanhuuksloot commented on PR #25888: URL: https://github.com/apache/flink/pull/25888#issuecomment-2569689774
>I wonder why you have added this to the dist pom and not to the top level Flink pom, that might allow you to add a unit test to test the usage of this. I added it to both. Although I may be missing something. In theory I could add a test in the flink-dist by overriding the `lo4j2-test.properties` ``` rootLogger.level = OFF rootLogger.appenderRef.test.ref = TestLogger appender.testlogger.name = TestLogger appender.testlogger.type = CONSOLE appender.testlogger.target = SYSTEM_ERR appender.testlogger.layout.type = JsonTemplateLayout appender.testlogger.layout.eventTemplateUri = classPath:layout.json ``` But this would be weird since it is different from all other modules. As far as I know you can't dynamically load a log4j2.properties per java test. >I think adding some documentation would be good, advising around readable pattern orientated logs and these unreadable production orientated settings. I'd add a first pass and we can iterate from there 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
