hackergin commented on code in PR #25730:
URL: https://github.com/apache/flink/pull/25730#discussion_r1901750766
##########
flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/SqlGatewayServiceImpl.java:
##########
@@ -330,6 +337,46 @@ public OperationHandle refreshMaterializedTable(
}
}
+ @Override
+ public <ClusterID> ClusterID deployScript(
+ SessionHandle sessionHandle,
+ @Nullable URI scriptUri,
+ @Nullable String script,
+ Configuration executionConfig)
+ throws SqlGatewayException {
+ Session session = sessionManager.getSession(sessionHandle);
+ if (scriptUri == null && script == null) {
+ throw new IllegalArgumentException("Please specify script path or
uri.");
+ }
+ if (scriptUri != null && !StringUtils.isNullOrWhitespaceOnly(script)) {
+ throw new IllegalArgumentException(
+ "Please specify either the script uri or the script
itself, but not both.");
Review Comment:
```suggestion
"Please specify either the script uri or the script
content, but not both.");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
