Re: [PR] [FLINK-12173][table] Optimize SELECT DISTINCT [flink]

2024-12-08 Thread via GitHub
yiyutian1 commented on code in PR #25752: URL: https://github.com/apache/flink/pull/25752#discussion_r1875520022 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/physical/stream/StreamLogicalOptimizeSelectDistinctRule.scala: ## @@ -0,0

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2024-12-08 Thread via GitHub
flinkbot commented on PR #25763: URL: https://github.com/apache/flink/pull/25763#issuecomment-2527181717 ## CI report: * 6c910de13b2e652f6e02f59ec7fa878af9a68f10 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-36862) Implement additional TO_TIMESTAMP_LTZ() functions

2024-12-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36862: --- Labels: pull-request-available (was: ) > Implement additional TO_TIMESTAMP_LTZ() functions

[PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2024-12-08 Thread via GitHub
yiyutian1 opened a new pull request, #25763: URL: https://github.com/apache/flink/pull/25763 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[jira] [Comment Edited] (FLINK-28927) Can not clean up the uploaded shared files when the checkpoint fails

2024-12-08 Thread yanpengshi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904048#comment-17904048 ] yanpengshi edited comment on FLINK-28927 at 12/9/24 7:46 AM: -

[jira] [Comment Edited] (FLINK-28927) Can not clean up the uploaded shared files when the checkpoint fails

2024-12-08 Thread yanpengshi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904048#comment-17904048 ] yanpengshi edited comment on FLINK-28927 at 12/9/24 7:45 AM: -

[jira] [Commented] (FLINK-28927) Can not clean up the uploaded shared files when the checkpoint fails

2024-12-08 Thread yanpengshi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904048#comment-17904048 ] yanpengshi commented on FLINK-28927: [~ChangjiGuo], This issue seems like the[FLINK

[jira] [Resolved] (FLINK-35652) FLIP-462: Support Custom Data Distribution for Input Stream of Lookup Join

2024-12-08 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo resolved FLINK-35652. Fix Version/s: 2.0.0 Resolution: Done master(2.0) via cfaa00e215e4b5fd72a0a4271449d2ca47eae

[jira] [Commented] (FLINK-35652) FLIP-462: Support Custom Data Distribution for Input Stream of Lookup Join

2024-12-08 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904043#comment-17904043 ] Weijie Guo commented on FLINK-35652: [~liming] Yes, 2.0-preview1 doesn't include thi

Re: [PR] [FLINK-35652] Support Custom Data Distribution for Input Stream of Lookup Join [flink]

2024-12-08 Thread via GitHub
reswqa commented on PR #25729: URL: https://github.com/apache/flink/pull/25729#issuecomment-2527141363 Thanks all for the review, merged into master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-35652] Support Custom Data Distribution for Input Stream of Lookup Join [flink]

2024-12-08 Thread via GitHub
reswqa closed pull request #25729: [FLINK-35652] Support Custom Data Distribution for Input Stream of Lookup Join URL: https://github.com/apache/flink/pull/25729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [FLINK-36749][state/forst] Implement rescaling for ForStStateBackend [flink]

2024-12-08 Thread via GitHub
fredia commented on code in PR #25676: URL: https://github.com/apache/flink/pull/25676#discussion_r1875399573 ## flink-runtime/src/test/java/org/apache/flink/runtime/state/v2/StateBackendTestV2Base.java: ## @@ -177,8 +182,8 @@ protected AsyncKeyedStateBackend restoreAsyncKeyed

[jira] [Commented] (FLINK-36370) Flink 1.18 fails with Empty server certificate chain when High Availability and mTLS both enabled

2024-12-08 Thread Aniruddh J (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904020#comment-17904020 ] Aniruddh J commented on FLINK-36370: [~gyfora] can you please share some insight on

Re: [PR] [FLINK-36860][State/v2] Make internal list state inherit the internal merging state [flink]

2024-12-08 Thread via GitHub
fredia commented on code in PR #25760: URL: https://github.com/apache/flink/pull/25760#discussion_r1875309207 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java: ## @@ -291,13 +291,21 @@ public InternalStateFuture handleRequest

Re: [PR] [FLINK-36836][Autoscaler] Supports config the upper and lower limits of target utilization [flink-kubernetes-operator]

2024-12-08 Thread via GitHub
huyuanfeng2018 commented on code in PR #921: URL: https://github.com/apache/flink-kubernetes-operator/pull/921#discussion_r1875302925 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -296,8 +297,14 @@ protected static void compute

[jira] [Created] (FLINK-36864) YAML Pipeline could not write number literals that exceeds Int32 range

2024-12-08 Thread yux (Jira)
yux created FLINK-36864: --- Summary: YAML Pipeline could not write number literals that exceeds Int32 range Key: FLINK-36864 URL: https://issues.apache.org/jira/browse/FLINK-36864 Project: Flink Issue T

Re: [PR] [FLINK-36836][Autoscaler] Supports config the upper and lower limits of target utilization [flink-kubernetes-operator]

2024-12-08 Thread via GitHub
1996fanrui commented on code in PR #921: URL: https://github.com/apache/flink-kubernetes-operator/pull/921#discussion_r1875279589 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -296,8 +297,14 @@ protected static void computeProc

Re: [PR] Handle map and array types binary record data [flink-cdc]

2024-12-08 Thread via GitHub
leonardBang commented on PR #3434: URL: https://github.com/apache/flink-cdc/pull/3434#issuecomment-2526768471 @umeshdangat Thanks for your updating, and we will have a final review for this PR ASAP. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] [minor][test] Remove duplicate test code [flink-cdc]

2024-12-08 Thread via GitHub
leonardBang commented on code in PR #3460: URL: https://github.com/apache/flink-cdc/pull/3460#discussion_r1875268855 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/test/java/org/apache/flink/cdc/connectors/mysql/source/NewlyAddedTableITCase.java:

Re: [PR] [FLINK-36178][pipeline-connector/mysql] Parse `CREATE TABLE ... LIKE …` syntax. [flink-cdc]

2024-12-08 Thread via GitHub
leonardBang commented on PR #3590: URL: https://github.com/apache/flink-cdc/pull/3590#issuecomment-2526757300 @ruanhang1993 Would you like to help review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [FLINK-36178][pipeline-connector/mysql] Parse `CREATE TABLE ... LIKE …` syntax. [flink-cdc]

2024-12-08 Thread via GitHub
lvyanquan opened a new pull request, #3590: URL: https://github.com/apache/flink-cdc/pull/3590 Support parsing SQL like following and emit new SchemaChangeEvent to downstream. ``` CREATE TABLE `user_log_copy` LIKE `user_log` ``` and ``` CREATE TABLE `user_log_copy` AS SELEC

[jira] [Updated] (FLINK-36863) Use the maximum parallelism in the past scale-down.interval window when scaling down

2024-12-08 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-36863: Description: FLINK-36535 uses the maximum parallelism since the scale down trigger when scaling down. Bec

[jira] [Updated] (FLINK-36863) Use the maximum parallelism in the past scale-down.interval window when scaling down

2024-12-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36863: --- Labels: pull-request-available (was: ) > Use the maximum parallelism in the past scale-down

[PR] [FLINK-36863][autoscaler] Use the maximum parallelism in the past scale-down.interval window when scaling down [flink-kubernetes-operator]

2024-12-08 Thread via GitHub
1996fanrui opened a new pull request, #922: URL: https://github.com/apache/flink-kubernetes-operator/pull/922 ## What is the purpose of the change [FLINK-36863][autoscaler] Use the maximum parallelism in the **_past scale-down.interval window_** when scaling down ## Brief chang

[jira] [Updated] (FLINK-36863) Use the maximum parallelism in the past scale-down.interval window when scaling down

2024-12-08 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-36863: Description: FLINK-36535 uses the maximum parallelism since the scale down trigger when scaling down. Bec

Re: [PR] [FLINK-34974][state] Support getOrCreateKeyedState for AsyncKeyedStateBackend [flink]

2024-12-08 Thread via GitHub
fredia commented on code in PR #25745: URL: https://github.com/apache/flink/pull/25745#discussion_r1875228444 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStKeyedStateBackend.java: ## @@ -227,6 +233,21 @@ public void setup(@Nonnu

[jira] [Updated] (FLINK-36863) Use the maximum parallelism in the past scale-down.interval window when scaling down

2024-12-08 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-36863: Description: FLINK-36535 uses the maximum parallelism since the scale down trigger when scaling down. Bec

[jira] [Commented] (FLINK-36859) Wrong epoch/watermark firing in async state processing

2024-12-08 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904007#comment-17904007 ] Zakelly Lan commented on FLINK-36859: - Merge d62dc68 into master. > Wrong epoch/wat

[jira] [Resolved] (FLINK-36859) Wrong epoch/watermark firing in async state processing

2024-12-08 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan resolved FLINK-36859. - Resolution: Fixed > Wrong epoch/watermark firing in async state processing > ---

[jira] [Created] (FLINK-36863) Use the maximum parallelism in the past scale-down.interval window when scaling down

2024-12-08 Thread Rui Fan (Jira)
Rui Fan created FLINK-36863: --- Summary: Use the maximum parallelism in the past scale-down.interval window when scaling down Key: FLINK-36863 URL: https://issues.apache.org/jira/browse/FLINK-36863 Project: F

Re: [PR] [FLINK-36859][Runtime] Fix wrong epoch/watermark firing in async state processing [flink]

2024-12-08 Thread via GitHub
Zakelly merged PR #25761: URL: https://github.com/apache/flink/pull/25761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

Re: [PR] [FLINK-36859][Runtime] Fix wrong epoch/watermark firing in async state processing [flink]

2024-12-08 Thread via GitHub
Zakelly commented on PR #25761: URL: https://github.com/apache/flink/pull/25761#issuecomment-2526722949 Thanks for the review, merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Resolved] (FLINK-36613) RescaleCheckpointManuallyITCase.testCheckpointRescalingInKeyedState fails on AZP

2024-12-08 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan resolved FLINK-36613. - Assignee: Zakelly Lan Resolution: Fixed > RescaleCheckpointManuallyITCase.testCheckpointRe

[jira] [Updated] (FLINK-36863) Use the maximum parallelism in the past scale-down.interval window when scaling down

2024-12-08 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-36863: Description: FLINK-36535 uses the maximum parallelism since the scale down trigger when scaling down. Bec

Re: [PR] [FLINK-36848][table] Remove FlinkLimit0RemoveRule [flink]

2024-12-08 Thread via GitHub
liuyongvs commented on code in PR #25742: URL: https://github.com/apache/flink/pull/25742#discussion_r1875174539 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/rules/logical/SortFetchZeroRuleTest.scala: ## @@ -22,11 +22,12 @@ import org.ap

Re: [PR] [FLINK-35652] Support Custom Data Distribution for Input Stream of Lookup Join [flink]

2024-12-08 Thread via GitHub
yunfengzhou-hub commented on PR #25729: URL: https://github.com/apache/flink/pull/25729#issuecomment-2526617613 Thanks for the update! LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [FLINK-35652] Support Custom Data Distribution for Input Stream of Lookup Join [flink]

2024-12-08 Thread via GitHub
reswqa commented on PR #25729: URL: https://github.com/apache/flink/pull/25729#issuecomment-2526621464 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FLINK-36791][table] Remove FlinkPruneEmptyRules. [flink]

2024-12-08 Thread via GitHub
liuyongvs commented on code in PR #25690: URL: https://github.com/apache/flink/pull/25690#discussion_r1875168910 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/rules/logical/PruneEmptyRulesTest.xml: ## Review Comment: if you think

Re: [PR] [FLINK-36791][table] Remove FlinkPruneEmptyRules. [flink]

2024-12-08 Thread via GitHub
liuyongvs commented on code in PR #25690: URL: https://github.com/apache/flink/pull/25690#discussion_r1875162913 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/rules/logical/PruneEmptyRulesTest.xml: ## Review Comment: @snuyanzin te

Re: [PR] [FLINK-36791][table] Remove FlinkPruneEmptyRules. [flink]

2024-12-08 Thread via GitHub
liuyongvs commented on code in PR #25690: URL: https://github.com/apache/flink/pull/25690#discussion_r1875162913 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/rules/logical/PruneEmptyRulesTest.xml: ## Review Comment: @snuyanzin Pr

Re: [PR] [FLINK-36178][pipeline-connector/mysql] Parse `CREATE TABLE ... LIKE …` syntax. [flink-cdc]

2024-12-08 Thread via GitHub
github-actions[bot] commented on PR #3590: URL: https://github.com/apache/flink-cdc/pull/3590#issuecomment-2526525052 This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encou

Re: [PR] [FLINK-36178][pipeline-connector/mysql] Parse `CREATE TABLE ... LIKE …` syntax. [flink-cdc]

2024-12-08 Thread via GitHub
github-actions[bot] closed pull request #3590: [FLINK-36178][pipeline-connector/mysql] Parse `CREATE TABLE ... LIKE …` syntax. URL: https://github.com/apache/flink-cdc/pull/3590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [HOTFIX][docs] Fix avro specification link in Docs [flink]

2024-12-08 Thread via GitHub
henneberger commented on PR #25616: URL: https://github.com/apache/flink/pull/25616#issuecomment-2526325155 It's was just a patch commit from the webui, i'll have to drop it. I took a look at the full scope and replacing all of the references is a bit more involved. If I get some time I'll

Re: [PR] [HOTFIX] Fix avro specification link in Docs [flink]

2024-12-08 Thread via GitHub
henneberger closed pull request #25616: [HOTFIX] Fix avro specification link in Docs URL: https://github.com/apache/flink/pull/25616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [FLINK-36845][flink-connector-test-utils] Set operatorUid to CollectStreamSink in SinkTestSuiteBase/SourceTestSuiteBase. [flink]

2024-12-08 Thread via GitHub
rmetzger commented on PR #25735: URL: https://github.com/apache/flink/pull/25735#issuecomment-2525938575 Are the test failures related to the change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-36484] [TABLE-SQL] Remove deprecated methods StreamTableEnvironment#registerFunction [flink]

2024-12-08 Thread via GitHub
rmetzger commented on PR #25529: URL: https://github.com/apache/flink/pull/25529#issuecomment-2525930576 @twalthr @wuchong is it okay to remove this method? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (FLINK-36508) Remove all deprecated methods in `SymbolType `

2024-12-08 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903912#comment-17903912 ] Robert Metzger commented on FLINK-36508: [~xuyangzhong] can you review the PR?

Re: [PR] [FLINK-36856][runtime] CollectSinkOperatorFactory batch size and socket timeout config fix [flink]

2024-12-08 Thread via GitHub
gaborgsomogyi commented on PR #25755: URL: https://github.com/apache/flink/pull/25755#issuecomment-2525556359 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [FLINK-36612][core] Fix TypeSerializer to detect lombok boolean with is prefix [flink]

2024-12-08 Thread via GitHub
snuyanzin commented on code in PR #25757: URL: https://github.com/apache/flink/pull/25757#discussion_r1874717063 ## flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java: ## @@ -2046,7 +2046,9 @@ private boolean isValidPojoField(Field f, Class clazz, L

Re: [PR] [FLINK-36634][table] Introduce AdaptiveBatchSchedulerFactory to support dynamic generate join operator at runtime. [flink]

2024-12-08 Thread via GitHub
zhuzhurk commented on code in PR #25593: URL: https://github.com/apache/flink/pull/25593#discussion_r1871331676 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/adaptive/AdaptiveJoinOperatorFactory.java: ## @@ -0,0 +1,125 @@ +/* + *

Re: [PR] [FLINK-36836][Autoscaler] Supports config the upper and lower limits of target utilization [flink-kubernetes-operator]

2024-12-08 Thread via GitHub
huyuanfeng2018 commented on code in PR #921: URL: https://github.com/apache/flink-kubernetes-operator/pull/921#discussion_r1874712171 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -296,8 +297,14 @@ protected static void compute

Re: [PR] [FLINK-36836][Autoscaler] Supports config the upper and lower limits of target utilization [flink-kubernetes-operator]

2024-12-08 Thread via GitHub
huyuanfeng2018 commented on code in PR #921: URL: https://github.com/apache/flink-kubernetes-operator/pull/921#discussion_r1874712096 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -296,8 +297,14 @@ protected static void compute