fredia commented on code in PR #25676: URL: https://github.com/apache/flink/pull/25676#discussion_r1875399573
########## flink-runtime/src/test/java/org/apache/flink/runtime/state/v2/StateBackendTestV2Base.java: ########## @@ -177,8 +182,8 @@ protected <K> AsyncKeyedStateBackend<K> restoreAsyncKeyedBackend( new JobID(), "test_op", keySerializer, - numberOfKeyGroups, - new KeyGroupRange(0, numberOfKeyGroups - 1), + keyGroupRange.getNumberOfKeyGroups(), + keyGroupRange, Review Comment: In this test `keyGroupRange` can be derived from `numberOfKeyGroups`. In practice, `numberOfKeyGroups` is come from `MaxNumberOfParallelSubtasks`, it may be different from `keyGroupRange.getNumberOfKeyGroups()`, so we do need both parameters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org