[jira] [Commented] (FLINK-36817) Give users ability to provide their own KafkaConsumer when using flink-connector-kafka

2024-12-05 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903569#comment-17903569 ] Levani Kokhreidze commented on FLINK-36817: --- Hi [~davidradl]  Thanks for gett

[jira] [Updated] (FLINK-36858) [pipeline-kafka] JsonRowDataSerializationSchema compatibility bug

2024-12-05 Thread MOBIN (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] MOBIN updated FLINK-36858: -- Description: I encountered this bug when I was working on MysqlToKafkaE2eITCase minimum repetition step: Flink

[jira] [Commented] (FLINK-36858) [pipeline-kafka] JsonRowDataSerializationSchema compatibility bug

2024-12-05 Thread MOBIN (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903568#comment-17903568 ] MOBIN commented on FLINK-36858: --- It seems that flink cdc has not yet fully adapted to flin

[jira] [Updated] (FLINK-36858) [pipeline-kafka] JsonRowDataSerializationSchema compatibility bug

2024-12-05 Thread MOBIN (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] MOBIN updated FLINK-36858: -- Description: minimum repetition step: Flink 1.20 Flink cdc master {code:java} source:   type: mysql   name: My

[jira] [Created] (FLINK-36858) [pipeline-kafka] JsonRowDataSerializationSchema compatibility bug

2024-12-05 Thread MOBIN (Jira)
MOBIN created FLINK-36858: - Summary: [pipeline-kafka] JsonRowDataSerializationSchema compatibility bug Key: FLINK-36858 URL: https://issues.apache.org/jira/browse/FLINK-36858 Project: Flink Issue Ty

Re: [PR] [cdc-connector][sqlserver]Flink cdc pipeline support sqlserver source [flink-cdc]

2024-12-05 Thread via GitHub
ChengJie1053 commented on PR #3445: URL: https://github.com/apache/flink-cdc/pull/3445#issuecomment-2522304690 Sorry, I will finish this work as soon as possible, I am a little busy at the moment, I will spare some time later -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

2024-12-05 Thread via GitHub
kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1872707329 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -83,9 +83,16 @@ public Collection getJobManage

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

2024-12-05 Thread via GitHub
kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1872704374 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -83,9 +83,16 @@ public Collection getJobManage

Re: [PR] [FLINK-34974][state] Support getOrCreateKeyedState for AsyncKeyedStateBackend [flink]

2024-12-05 Thread via GitHub
Zakelly commented on code in PR #25745: URL: https://github.com/apache/flink/pull/25745#discussion_r1872679104 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStKeyedStateBackend.java: ## @@ -227,6 +233,21 @@ public void setup(@Nonn

Re: [PR] [FLINK-34974][state] Support getOrCreateKeyedState for AsyncKeyedStateBackend [flink]

2024-12-05 Thread via GitHub
Zakelly commented on PR #25745: URL: https://github.com/apache/flink/pull/25745#issuecomment-2522253799 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-36315][cdc-base]The flink-cdc-base module supports source metric statistics [flink-cdc]

2024-12-05 Thread via GitHub
yuxiqian commented on PR #3619: URL: https://github.com/apache/flink-cdc/pull/3619#issuecomment-2522253294 Hi @liuxiao2shf, Seems current CI configuration doesn't really run test cases in `flink-cdc-base` package, and I couldn't get your newly added test case `MySqlSourceMetricsTest` to run

[jira] [Updated] (FLINK-36811) MySQL CDC source set is processing backlog during snapshot phase

2024-12-05 Thread Xuannan Su (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xuannan Su updated FLINK-36811: --- Affects Version/s: cdc-3.3.0 > MySQL CDC source set is processing backlog during snapshot phase > --

[jira] [Resolved] (FLINK-36315) The flink-cdc-base module supports source metric statistics

2024-12-05 Thread Ruan Hang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruan Hang resolved FLINK-36315. --- Resolution: Fixed master(3.3-SNAPSHOT) : ee9cd828c3ba822570cb349f7ce978234086aeb6 > The flink-cdc-b

[jira] [Updated] (FLINK-36315) The flink-cdc-base module supports source metric statistics

2024-12-05 Thread Ruan Hang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruan Hang updated FLINK-36315: -- Affects Version/s: cdc-3.2.0 > The flink-cdc-base module supports source metric statistics > -

Re: [PR] [FLINK-36315][cdc-base]The flink-cdc-base module supports source metric statistics [flink-cdc]

2024-12-05 Thread via GitHub
ruanhang1993 merged PR #3619: URL: https://github.com/apache/flink-cdc/pull/3619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flin

Re: [PR] [WIP] Introduce Generalized Watermark for DSv2 [flink]

2024-12-05 Thread via GitHub
codenohup commented on PR #25731: URL: https://github.com/apache/flink/pull/25731#issuecomment-2522016656 > out of curiosity is it somehow related to #24997 ? Hi, @snuyanzin The [FLIP-467](https://cwiki.apache.org/confluence/display/FLINK/FLIP-467%3A+Introduce+Generalized+Watermar

Re: [PR] [FLINK-36836][Autoscaler] Supports config the upper and lower limits of target utilization [flink-kubernetes-operator]

2024-12-05 Thread via GitHub
1996fanrui commented on code in PR #921: URL: https://github.com/apache/flink-kubernetes-operator/pull/921#discussion_r1872491367 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/validation/DefaultValidatorTest.java: ## @@ -972,8 +990,9 @@ private

Re: [PR] [FLINK-35652] Support Custom Data Distribution for Input Stream of Lookup Join [flink]

2024-12-05 Thread via GitHub
reswqa commented on code in PR #25729: URL: https://github.com/apache/flink/pull/25729#discussion_r1872499507 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/partitioner/RowDataCustomStreamPartitioner.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to

Re: [PR] [FLINK-35652] Support Custom Data Distribution for Input Stream of Lookup Join [flink]

2024-12-05 Thread via GitHub
hackergin commented on code in PR #25729: URL: https://github.com/apache/flink/pull/25729#discussion_r1872446264 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/partitioner/RowDataCustomStreamPartitioner.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed

Re: [PR] [FLINK-36784][common] Support to add metadata columns for data in the meta fields of DataChangeEvent at transform [flink-cdc]

2024-12-05 Thread via GitHub
yuxiqian commented on code in PR #3758: URL: https://github.com/apache/flink-cdc/pull/3758#discussion_r1872477658 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/TransformFilterProcessor.java: ## @@ -135,6 +159,19 @@ private Object[] generateP

Re: [PR] [FLINK-35167][cdc-connector] Introduce MaxCompute pipeline DataSink [flink-cdc]

2024-12-05 Thread via GitHub
lvyanquan commented on code in PR #3254: URL: https://github.com/apache/flink-cdc/pull/3254#discussion_r1872459342 ## flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/MaxComputeE2eITCase.java: ## @@ -0,0 +1,193 @@ +/* + * License

Re: [PR] [FLINK-35167][cdc-connector] Introduce MaxCompute pipeline DataSink [flink-cdc]

2024-12-05 Thread via GitHub
lvyanquan commented on code in PR #3254: URL: https://github.com/apache/flink-cdc/pull/3254#discussion_r1872455130 ## flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/MaxComputeE2eITCase.java: ## @@ -0,0 +1,193 @@ +/* + * License

Re: [PR] [hotfix] [docs] Correct inaccurate description of JobMaster's role in Flink JobManager [flink]

2024-12-05 Thread via GitHub
qiaqialuguo commented on PR #25607: URL: https://github.com/apache/flink/pull/25607#issuecomment-2521909471 > @qiaqialuguo CI is failing - maybe a rebase might help? Failing that raise a CI issue - as it seems unrelated to your change. Thanks for the suggestion, @davidradl! Rebase was

[jira] [Commented] (FLINK-36569) flink kafka connector do not close kafka produer when it checkpoint success

2024-12-05 Thread Jake.zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903532#comment-17903532 ] Jake.zhang commented on FLINK-36569: [~hackergin]  `org.apache.flink.connector.kafka

Re: [PR] [FLINK-19059]: Support non-time retract mode for OverAggregate operator [flink]

2024-12-05 Thread via GitHub
flinkbot commented on PR #25753: URL: https://github.com/apache/flink/pull/25753#issuecomment-2521880092 ## CI report: * 169870dd6e3c0b6e36530b9d639a14fbba7e061e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-19059) Support to consume retractions for OVER WINDOW operator

2024-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-19059: --- Labels: pull-request-available (was: ) > Support to consume retractions for OVER WINDOW ope

[PR] [FLINK-19059]: Support non-time retract mode for OverAggregate operator [flink]

2024-12-05 Thread via GitHub
bvarghese1 opened a new pull request, #25753: URL: https://github.com/apache/flink/pull/25753 ## What is the purpose of the change - Non-time attribute over aggregates can support retract mode - Time attribute over aggregates support only append mode - An example

Re: [PR] [FLINK-36224][docs] Add the version mapping between pipeline connectors and flink [flink-cdc]

2024-12-05 Thread via GitHub
github-actions[bot] closed pull request #3598: [FLINK-36224][docs] Add the version mapping between pipeline connectors and flink URL: https://github.com/apache/flink-cdc/pull/3598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] [FLINK-36224][docs] Add the version mapping between pipeline connectors and flink [flink-cdc]

2024-12-05 Thread via GitHub
github-actions[bot] commented on PR #3598: URL: https://github.com/apache/flink-cdc/pull/3598#issuecomment-2521764418 This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encou

Re: [PR] [FLINK-12173][table] Optimize SELECT DISTINCT [flink]

2024-12-05 Thread via GitHub
flinkbot commented on PR #25752: URL: https://github.com/apache/flink/pull/25752#issuecomment-2521579786 ## CI report: * 27811610e5fae4a2bfedb2ddd94065bc5a526285 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-12173) Optimize "SELECT DISTINCT" into Deduplicate with keep first row

2024-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12173: --- Labels: pull-request-available (was: ) > Optimize "SELECT DISTINCT" into Deduplicate with k

[PR] [FLINK-12173][table] Optimize SELECT DISTINCT [flink]

2024-12-05 Thread via GitHub
yiyutian1 opened a new pull request, #25752: URL: https://github.com/apache/flink/pull/25752 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[jira] [Updated] (FLINK-33956) Bump org.apache.zookeeper:zookeeper from 3.7.1 to 3.7.2

2024-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33956: --- Labels: pull-request-available (was: ) > Bump org.apache.zookeeper:zookeeper from 3.7.1 to

Re: [PR] fix(sec): upgrade com.google.guava:guava to 32.0.0-jre [flink]

2024-12-05 Thread via GitHub
snuyanzin commented on PR #23150: URL: https://github.com/apache/flink/pull/23150#issuecomment-2521522903 superseded by https://github.com/apache/flink/commit/34620fc5c5698d00e64c6b15f8ce84f807a2e0d7 -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] fix(sec): upgrade com.google.guava:guava to 32.0.0-jre [flink]

2024-12-05 Thread via GitHub
snuyanzin closed pull request #23150: fix(sec): upgrade com.google.guava:guava to 32.0.0-jre URL: https://github.com/apache/flink/pull/23150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Resolved] (FLINK-36537) Bump snappy-java from 1.1.10.4 to 1.1.10.7

2024-12-05 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-36537. - Fix Version/s: 2.0.0 Resolution: Fixed > Bump snappy-java from 1.1.10.4 to 1.1.10

Re: [PR] [FLINK-29420][Build] Upgrade Zookeeper to 3.7.2 [flink]

2024-12-05 Thread via GitHub
snuyanzin commented on PR #23741: URL: https://github.com/apache/flink/pull/23741#issuecomment-2521512391 superseded by https://github.com/apache/flink/commit/7e11de657153eb31de8e8c0cfbabce365eb1c57e#diff-d746de8964721a0a7ecfe91df19d3c5047d2adc9ba35384e2f751524037392ec -- This is an autom

Re: [PR] [FLINK-29420][Build] Upgrade Zookeeper to 3.7.2 [flink]

2024-12-05 Thread via GitHub
snuyanzin closed pull request #23741: [FLINK-29420][Build] Upgrade Zookeeper to 3.7.2 URL: https://github.com/apache/flink/pull/23741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [FLINK-33956] Bump org.apache.zookeeper:zookeeper from 3.7.1 to 3.7.2 [flink]

2024-12-05 Thread via GitHub
snuyanzin commented on PR #23939: URL: https://github.com/apache/flink/pull/23939#issuecomment-2521509648 superseded by https://github.com/apache/flink/commit/7e11de657153eb31de8e8c0cfbabce365eb1c57e -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] [FLINK-33956] Bump org.apache.zookeeper:zookeeper from 3.7.1 to 3.7.2 [flink]

2024-12-05 Thread via GitHub
dependabot[bot] commented on PR #23939: URL: https://github.com/apache/flink/pull/23939#issuecomment-2521509716 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] [FLINK-33956] Bump org.apache.zookeeper:zookeeper from 3.7.1 to 3.7.2 [flink]

2024-12-05 Thread via GitHub
snuyanzin closed pull request #23939: [FLINK-33956] Bump org.apache.zookeeper:zookeeper from 3.7.1 to 3.7.2 URL: https://github.com/apache/flink/pull/23939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.0 [flink]

2024-12-05 Thread via GitHub
dependabot[bot] commented on PR #24352: URL: https://github.com/apache/flink/pull/24352#issuecomment-2521505117 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.0 [flink]

2024-12-05 Thread via GitHub
snuyanzin commented on PR #24352: URL: https://github.com/apache/flink/pull/24352#issuecomment-2521505066 superseded by https://github.com/apache/flink/pull/24580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.0 [flink]

2024-12-05 Thread via GitHub
snuyanzin closed pull request #24352: Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.0 URL: https://github.com/apache/flink/pull/24352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Bump cookie and socket.io in /flink-runtime-web/web-dashboard [flink]

2024-12-05 Thread via GitHub
flinkbot commented on PR #25751: URL: https://github.com/apache/flink/pull/25751#issuecomment-2521486690 ## CI report: * 651e1b499832cb88d1727537e7b1dd8673cd03aa UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [WIP] Introduce Generalized Watermark for DSv2 [flink]

2024-12-05 Thread via GitHub
snuyanzin commented on PR #25731: URL: https://github.com/apache/flink/pull/25731#issuecomment-2521494896 out of curiosity is it somehow related to https://github.com/apache/flink/pull/24997 ? -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] Bump io.netty:netty-common from 4.1.46.Final to 4.1.115.Final in /flink-end-to-end-tests/flink-end-to-end-tests-hive [flink]

2024-12-05 Thread via GitHub
flinkbot commented on PR #25750: URL: https://github.com/apache/flink/pull/25750#issuecomment-2521486460 ## CI report: * 5d2a8f406497ee9c91350d72b7d95a5386c86719 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] Bump org.apache.avro:avro from 1.8.2 to 1.11.4 in /flink-connectors/flink-connector-hive [flink]

2024-12-05 Thread via GitHub
flinkbot commented on PR #25749: URL: https://github.com/apache/flink/pull/25749#issuecomment-2521486232 ## CI report: * a8118e94fe1a1820f2f7e5e3edcdf2f8b51eaf82 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] Bump org.apache.avro:avro from 1.8.2 to 1.11.4 in /flink-connectors/flink-connector-hive [flink]

2024-12-05 Thread via GitHub
dependabot[bot] opened a new pull request, #25749: URL: https://github.com/apache/flink/pull/25749 Bumps org.apache.avro:avro from 1.8.2 to 1.11.4. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.avro

[PR] Bump cookie and socket.io in /flink-runtime-web/web-dashboard [flink]

2024-12-05 Thread via GitHub
dependabot[bot] opened a new pull request, #25751: URL: https://github.com/apache/flink/pull/25751 Bumps [cookie](https://github.com/jshttp/cookie) and [socket.io](https://github.com/socketio/socket.io). These dependencies needed to be updated together. Updates `cookie` from 0.4.2 to 0.7

[PR] Bump io.netty:netty-common from 4.1.46.Final to 4.1.115.Final in /flink-end-to-end-tests/flink-end-to-end-tests-hive [flink]

2024-12-05 Thread via GitHub
dependabot[bot] opened a new pull request, #25750: URL: https://github.com/apache/flink/pull/25750 Bumps [io.netty:netty-common](https://github.com/netty/netty) from 4.1.46.Final to 4.1.115.Final. Commits https://github.com/netty/netty/commit/04f9b4a827d992ad439823eeba85d65d3a8

[jira] [Commented] (FLINK-36537) Bump snappy-java from 1.1.10.4 to 1.1.10.7

2024-12-05 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903486#comment-17903486 ] Sergey Nuyanzin commented on FLINK-36537: - Merged as [b25ef726b3204a03810f3d780

Re: [PR] [FLINK-36537] Bump snappy-java from 1.1.10.4 to 1.1.10.7 [flink]

2024-12-05 Thread via GitHub
snuyanzin merged PR #25549: URL: https://github.com/apache/flink/pull/25549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-36695][Formats] Bump Parquet dependency to 1.14.4 [flink]

2024-12-05 Thread via GitHub
snuyanzin commented on PR #25646: URL: https://github.com/apache/flink/pull/25646#issuecomment-2521382155 not sure that this is the right place to discuss it here... I have nothing against your comments in general. My point is: if there is already a comment requesting some changes

Re: [PR] [FLINK-36857] Bump scala version to 2.12.20 [flink]

2024-12-05 Thread via GitHub
snuyanzin commented on PR #25748: URL: https://github.com/apache/flink/pull/25748#issuecomment-2521020564 @MartijnVisser since you are involved in FLINK-36181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[PR] [FLINK-36857] Bump scala version to 2.12.20 [flink]

2024-12-05 Thread via GitHub
snuyanzin opened a new pull request, #25748: URL: https://github.com/apache/flink/pull/25748 ## What is the purpose of the change Since minimum java version was bumped to 11 at https://github.com/apache/flink/commit/50716d6ad8008c6080e9211d212f8c948dd8b614 ## Brief change log

Re: [PR] [FLINK-36857] Bump scala version to 2.12.20 [flink]

2024-12-05 Thread via GitHub
flinkbot commented on PR #25748: URL: https://github.com/apache/flink/pull/25748#issuecomment-2520996987 ## CI report: * ec291f337d01a4d46cf81999ca51ad1e745f6a98 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-36857) Bump scala version to 2.12.20

2024-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36857: --- Labels: pull-request-available (was: ) > Bump scala version to 2.12.20 > --

[jira] [Updated] (FLINK-36857) Bump scala version to 2.12.20

2024-12-05 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-36857: Description: As it was discussed in comments of parent jira issue for instance https://iss

[jira] [Created] (FLINK-36857) Bump scala version to 2.12.20

2024-12-05 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-36857: --- Summary: Bump scala version to 2.12.20 Key: FLINK-36857 URL: https://issues.apache.org/jira/browse/FLINK-36857 Project: Flink Issue Type: Sub-task

[PR] [FLINK-36455] Sinks retry synchronously [1.19] [flink]

2024-12-05 Thread via GitHub
AHeise opened a new pull request, #25747: URL: https://github.com/apache/flink/pull/25747 Unchanged backport of #25661. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [FLINK-36379] Improve (Global)Committer with UC disabled [1.19] [flink]

2024-12-05 Thread via GitHub
flinkbot commented on PR #25746: URL: https://github.com/apache/flink/pull/25746#issuecomment-2520927990 ## CI report: * df97ea57e47b8ac04aa8b356d6422898f5b91bca UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-36455] Sinks retry synchronously [1.19] [flink]

2024-12-05 Thread via GitHub
flinkbot commented on PR #25747: URL: https://github.com/apache/flink/pull/25747#issuecomment-2520928341 ## CI report: * f5f12793dac68c85511031d40313cf933625c9a2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-36856) CollectSinkOperatorFactory is not respecting batch size and socket timeout configs

2024-12-05 Thread Gabor Somogyi (Jira)
Gabor Somogyi created FLINK-36856: - Summary: CollectSinkOperatorFactory is not respecting batch size and socket timeout configs Key: FLINK-36856 URL: https://issues.apache.org/jira/browse/FLINK-36856

Re: [PR] solve bash-java-utils.sh can't get "env.java.home" in "config.yaml" since 1.20 [flink]

2024-12-05 Thread via GitHub
chn5944 commented on PR #25739: URL: https://github.com/apache/flink/pull/25739#issuecomment-2520882875 > before second commit I test "env.java.home" written both nested format with flattened format and mixed with other keys, template file is "config.yaml" in "flink-dist/src/test/resources/

[jira] [Assigned] (FLINK-36856) CollectSinkOperatorFactory is not respecting batch size and socket timeout configs

2024-12-05 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi reassigned FLINK-36856: - Assignee: Gabor Somogyi > CollectSinkOperatorFactory is not respecting batch size and s

Re: [PR] solve bash-java-utils.sh can't get "env.java.home" in "config.yaml" since 1.20 [flink]

2024-12-05 Thread via GitHub
chn5944 commented on PR #25739: URL: https://github.com/apache/flink/pull/25739#issuecomment-2520846199 before second commit I test "env.java.home" written both nested format with flattened format and mixed with other keys, template file is "config.yaml" in "flink-dist/src/test/resources/",

Re: [PR] [FLINK-36695][Formats] Bump Parquet dependency to 1.14.4 [flink]

2024-12-05 Thread via GitHub
davidradl commented on PR #25646: URL: https://github.com/apache/flink/pull/25646#issuecomment-2520689510 > > Reviewed by Chi on 05/12/24 Approve - looking for committer to merge > > @davidradl please do not confuse people with such comments as mentioned above there is still one comme

Re: [PR] [FLINK-36451][runtime] Replaces LeaderElection#hasLeadership with LeaderElection#runAsLeader [flink]

2024-12-05 Thread via GitHub
XComp commented on PR #25679: URL: https://github.com/apache/flink/pull/25679#issuecomment-2520677208 Last force-push ([diff](https://github.com/apache/flink/compare/db049380373e696613f7744730de59f8349cf344..6f75d6e713b95ce3177bf938ca06e3167f15b73f)) squashed the commits and ran `spotless:a

Re: [PR] [hotfix] [docs] Correct inaccurate description of JobMaster's role in Flink JobManager [flink]

2024-12-05 Thread via GitHub
qiaqialuguo commented on PR #25607: URL: https://github.com/apache/flink/pull/25607#issuecomment-2520603456 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [hotfix] [docs] Correct inaccurate description of JobMaster's role in Flink JobManager [flink]

2024-12-05 Thread via GitHub
qiaqialuguo commented on PR #25607: URL: https://github.com/apache/flink/pull/25607#issuecomment-2520643748 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [FLINK-36664][Window]Window with offset need deal offset when cal nextTriggerWatermark. [flink]

2024-12-05 Thread via GitHub
davidradl commented on code in PR #25629: URL: https://github.com/apache/flink/pull/25629#discussion_r1871587710 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/util/TimeWindowUtil.java: ## @@ -194,10 +198,12 @@ public static long getNextTriggerWa

Re: [PR] [FLINK-36455] Sinks retry synchronously [1.20] [flink]

2024-12-05 Thread via GitHub
AHeise commented on PR #25661: URL: https://github.com/apache/flink/pull/25661#issuecomment-2520593298 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [hotfix] [docs] Correct inaccurate description of JobMaster's role in Flink JobManager [flink]

2024-12-05 Thread via GitHub
davidradl commented on PR #25607: URL: https://github.com/apache/flink/pull/25607#issuecomment-2520503937 Reviewed by Chi on 05/12/24. Asked submitter questions . sorting out the CI test then LGTM -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] [hotfix] [docs] Correct inaccurate description of JobMaster's role in Flink JobManager [flink]

2024-12-05 Thread via GitHub
davidradl commented on PR #25607: URL: https://github.com/apache/flink/pull/25607#issuecomment-2520502821 @qiaqialuguo CI is failing - maybe a rebase might help? Failing that raise a CI issue - as it seems unrelated to your change. -- This is an automated message from the Apache Git Serv

Re: [PR] [FLINK-36664][Window]Window with offset need deal offset when cal nextTriggerWatermark. [flink]

2024-12-05 Thread via GitHub
xing1mo commented on code in PR #25629: URL: https://github.com/apache/flink/pull/25629#discussion_r1871489933 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/util/TimeWindowUtil.java: ## @@ -194,10 +198,12 @@ public static long getNextTriggerWate

Re: [PR] [FLINK-36675][table-planner] Always serialize dynamic options to exec json plan [flink]

2024-12-05 Thread via GitHub
davidradl commented on PR #25626: URL: https://github.com/apache/flink/pull/25626#issuecomment-2520483615 Reviewed by Chi on 05/12/24 Need a committer to review. On the face of it it looks like a good change, but we would like an expert in the are to confirm. -- This is an automated mess

Re: [PR] [FLINK-36451][runtime] Replaces LeaderElection#hasLeadership with LeaderElection#runAsLeader [flink]

2024-12-05 Thread via GitHub
XComp commented on code in PR #25679: URL: https://github.com/apache/flink/pull/25679#discussion_r1871483945 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunner.java: ## @@ -256,45 +255,29 @@ private void startJobMasterServiceProces

[jira] [Commented] (FLINK-36368) Fix subtask management in CommittableCollector

2024-12-05 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903391#comment-17903391 ] Arvid Heise commented on FLINK-36368: - Merged into 1.19 as ba410bc80eaf08098a917ada1

Re: [PR] [FLINK-36368] Do not prematurely merge CommittableManager [1.19] (#25405) [flink]

2024-12-05 Thread via GitHub
AHeise merged PR #25727: URL: https://github.com/apache/flink/pull/25727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-36675][table-planner] Always serialize dynamic options to exec json plan [flink]

2024-12-05 Thread via GitHub
davidradl commented on code in PR #25626: URL: https://github.com/apache/flink/pull/25626#discussion_r1871467566 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/spec/DynamicTableSinkSpec.java: ## @@ -59,18 +58,14 @@ public class Dy

[jira] [Updated] (FLINK-36368) Fix subtask management in CommittableCollector

2024-12-05 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arvid Heise updated FLINK-36368: Fix Version/s: 1.19.2 > Fix subtask management in CommittableCollector >

Re: [PR] [FLINK-36675][table-planner] Always serialize dynamic options to exec json plan [flink]

2024-12-05 Thread via GitHub
davidradl commented on code in PR #25626: URL: https://github.com/apache/flink/pull/25626#discussion_r1871467566 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/spec/DynamicTableSinkSpec.java: ## @@ -59,18 +58,14 @@ public class Dy

Re: [PR] [FLINK-36664][Window]Window with offset need deal offset when cal nextTriggerWatermark. [flink]

2024-12-05 Thread via GitHub
davidradl commented on PR #25629: URL: https://github.com/apache/flink/pull/25629#issuecomment-2520440505 Reviewed by Chi on 05/12/24. Asked submitter questions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] [FLINK-36663][Window]Fix the first processWatermark has extra data after restore by restore timeService's watermark. [flink]

2024-12-05 Thread via GitHub
davidradl commented on PR #25637: URL: https://github.com/apache/flink/pull/25637#issuecomment-2520416260 Reviewed by Chi on 05/12/24. Asked submitter questions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] [FLINK-36695][Formats] Bump Parquet dependency to 1.14.4 [flink]

2024-12-05 Thread via GitHub
snuyanzin commented on PR #25646: URL: https://github.com/apache/flink/pull/25646#issuecomment-2520428934 >Reviewed by Chi on 05/12/24 Approve - looking for committer to merge @davidradl please do not confuse people with such comments as mentioned above there is still one comment ex

Re: [PR] [FLINK-30371][Connector/JDBC] Fix the problem of JdbcOutputFormat database connection leak [flink-connector-jdbc]

2024-12-05 Thread via GitHub
simon-paradis-jive commented on PR #5: URL: https://github.com/apache/flink-connector-jdbc/pull/5#issuecomment-2520413773 Would that get eventually released in the `x.y.z-1.19` series ? After a database reboot, our Flink job took several minutes to recover from the dead connection. I

Re: [PR] [FLINK-36695][Formats] Bump Parquet dependency to 1.14.4 [flink]

2024-12-05 Thread via GitHub
davidradl commented on PR #25646: URL: https://github.com/apache/flink/pull/25646#issuecomment-2520414328 Reviewed by Chi on 05/12/24 Approve - looking for committer to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Created] (FLINK-36855) Implement Source API in Kudu connector

2024-12-05 Thread Ferenc Csaky (Jira)
Ferenc Csaky created FLINK-36855: Summary: Implement Source API in Kudu connector Key: FLINK-36855 URL: https://issues.apache.org/jira/browse/FLINK-36855 Project: Flink Issue Type: New Featur

Re: [PR] [FLINK-36845][flink-connector-test-utils] Set operatorUid to CollectStreamSink in SinkTestSuiteBase/SourceTestSuiteBase. [flink]

2024-12-05 Thread via GitHub
davidradl commented on PR #25735: URL: https://github.com/apache/flink/pull/25735#issuecomment-2520394570 Reviewed by Chi on 05/12/24 Approve - looking for committer to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-36072][runtime] Sort-merge shuffle supports accumulating small buffers to reduce network overhead. [flink]

2024-12-05 Thread via GitHub
davidradl commented on PR #25738: URL: https://github.com/apache/flink/pull/25738#issuecomment-2520392772 Reviewed by Chi on 05/12/24 in hand -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] solve bash-java-utils.sh can't get "env.java.home" in "config.yaml" since 1.20 [flink]

2024-12-05 Thread via GitHub
davidradl commented on PR #25739: URL: https://github.com/apache/flink/pull/25739#issuecomment-2520391303 Reviewed by Chi on 05/12/24. Asked submitter questions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] [FLINK-36848][table] Remove FlinkLimit0RemoveRule [flink]

2024-12-05 Thread via GitHub
davidradl commented on PR #25742: URL: https://github.com/apache/flink/pull/25742#issuecomment-2520389087 Reviewed by Chi on 05/12/24 Need a committer to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-34974][state] Support getOrCreateKeyedState for AsyncKeyedStateBackend [flink]

2024-12-05 Thread via GitHub
davidradl commented on PR #25745: URL: https://github.com/apache/flink/pull/25745#issuecomment-2520383930 Reviewed by Chi on 05/12/24 Need a committer to review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [WIP][table] Algin Calcite Rules. [flink]

2024-12-05 Thread via GitHub
davidradl commented on PR #25744: URL: https://github.com/apache/flink/pull/25744#issuecomment-2520385744 Reviewed by Chi on 05/12/24. Asked submitter questions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Bump d3-color, @antv/g-base and d3-interpolate in /flink-runtime-web/web-dashboard [flink]

2024-12-05 Thread via GitHub
MartijnVisser commented on PR #25740: URL: https://github.com/apache/flink/pull/25740#issuecomment-2520365552 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [FLINK-36854] Fix comments and default expressions missing after being transformed [flink-cdc]

2024-12-05 Thread via GitHub
aiwenmo commented on PR #3780: URL: https://github.com/apache/flink-cdc/pull/3780#issuecomment-2520331164 > Would @ruanhang1993 and @aiwenmo like to take a look? I will review it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] [FLINK-36664][Window]Window with offset need deal offset when cal nextTriggerWatermark. [flink]

2024-12-05 Thread via GitHub
xing1mo commented on code in PR #25629: URL: https://github.com/apache/flink/pull/25629#discussion_r1871374968 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/tvf/slicing/SliceAssigners.java: ## @@ -566,6 +592,11 @@ public long ge

Re: [PR] [FLINK-36455] Sinks retry synchronously [1.20] [flink]

2024-12-05 Thread via GitHub
AHeise commented on PR #25661: URL: https://github.com/apache/flink/pull/25661#issuecomment-2520274848 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [hotfix] [docs] Correct inaccurate description of JobMaster's role in Flink JobManager [flink]

2024-12-05 Thread via GitHub
qiaqialuguo commented on PR #25607: URL: https://github.com/apache/flink/pull/25607#issuecomment-2520238983 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

  1   2   >