xing1mo commented on code in PR #25629:
URL: https://github.com/apache/flink/pull/25629#discussion_r1871489933
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/util/TimeWindowUtil.java:
##########
@@ -194,10 +198,12 @@ public static long getNextTriggerWatermark(
if (useDayLightSaving) {
long utcWindowStart =
getWindowStartWithOffset(
- toUtcTimestampMills(currentWatermark,
shiftTimezone), 0L, interval);
Review Comment:
UT has tested utc and sh time zones, but lacks offset test. I only added a
simple offset test to reproduce the problem.
watermark time is always local which extract from record.
I think this use of Daylight saving consistent across all watermark
processing, because timerState storage UTC-time and trigger timer need to
excute the getNextTriggerWatermark(). I'm not sure about this conclusion, you
can double check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
