davidradl commented on PR #25646: URL: https://github.com/apache/flink/pull/25646#issuecomment-2520689510
> > Reviewed by Chi on 05/12/24 Approve - looking for committer to merge > > @davidradl please do not confuse people with such comments as mentioned above there is still one comment expecting a tiny change before merging [#25646 (comment)](https://github.com/apache/flink/pull/25646#discussion_r1863831314) > > UPD: I would consider a good approach to have an agreement on approval between participating reviewers before making decision that a committer is required for merging @snuyanzin thanks for the feedback. I see how this could be misleading. I guess PRs could have 1- no reviewers 2- some reviewers 3- some reviewers with a committer involved - like this one. So if there is an active committer moving the PR through - then this comment could be misleading as it implies something additional is needed, but everything is progressing. Maybe we just say `business as usual `or `in hand`, in this case; just to show we have looked at it. Maybe we have another comment. `Needs review approvals` for the 2nd case. And `needs committer review / merge`, if the reviewers have all approved. Am I understanding your concern correctly? WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
