[jira] [Closed] (FLINK-35886) Incorrect watermark idleness timeout accounting when subtask is backpressured/blocked

2024-08-20 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-35886. -- Fix Version/s: 2.0.0 1.19.2 1.20.1 Release Note: Fo

Re: [PR] (1.20 backport) [FLINK-35886][task] Fix watermark idleness timeout accounting when subtask is backpressured/blocked [flink]

2024-08-20 Thread via GitHub
pnowojski merged PR #25222: URL: https://github.com/apache/flink/pull/25222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] (1.19 backport) [FLINK-35886][task] Fix watermark idleness timeout accounting when subtask is backpressured/blocked [flink]

2024-08-20 Thread via GitHub
pnowojski commented on code in PR #25223: URL: https://github.com/apache/flink/pull/25223#discussion_r1724488059 ## pom.xml: ## @@ -2355,6 +2355,10 @@ under the License. @org.apache.flink.annotation.Experimental

Re: [PR] (1.19 backport) [FLINK-35886][task] Fix watermark idleness timeout accounting when subtask is backpressured/blocked [flink]

2024-08-20 Thread via GitHub
pnowojski merged PR #25223: URL: https://github.com/apache/flink/pull/25223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-36110][snapshot] Store periodic snapshot trigger timestamps in memory [flink-kubernetes-operator]

2024-08-20 Thread via GitHub
gyfora commented on code in PR #868: URL: https://github.com/apache/flink-kubernetes-operator/pull/868#discussion_r1724486711 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java: ## @@ -74,6 +77,11 @@

Re: [PR] (1.20 backport) [FLINK-35886][task] Fix watermark idleness timeout accounting when subtask is backpressured/blocked [flink]

2024-08-20 Thread via GitHub
pnowojski commented on code in PR #25222: URL: https://github.com/apache/flink/pull/25222#discussion_r1724485136 ## flink-core/src/main/java/org/apache/flink/api/common/eventtime/WatermarkGeneratorSupplier.java: ## @@ -54,5 +55,14 @@ interface Context { * @see MetricGr

Re: [PR] (1.20 backport) [FLINK-35886][task] Fix watermark idleness timeout accounting when subtask is backpressured/blocked [flink]

2024-08-20 Thread via GitHub
pnowojski commented on code in PR #25222: URL: https://github.com/apache/flink/pull/25222#discussion_r1724485136 ## flink-core/src/main/java/org/apache/flink/api/common/eventtime/WatermarkGeneratorSupplier.java: ## @@ -54,5 +55,14 @@ interface Context { * @see MetricGr

Re: [PR] [FLINK-35772][filesystem] Drop DuplicatingFileSystem in favour of the newer PathsCopyingFileSystem [flink]

2024-08-20 Thread via GitHub
pnowojski merged PR #25224: URL: https://github.com/apache/flink/pull/25224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[jira] [Updated] (FLINK-36104) flink 1.20 MDC not suport logback

2024-08-20 Thread xuhaiLong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuhaiLong updated FLINK-36104: -- Summary: flink 1.20 MDC not suport logback (was: flink 1.20 not suport logback) > flink 1.20 MDC not

[jira] [Updated] (FLINK-36018) Support lazy scale down to avoid frequent rescaling

2024-08-20 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-36018: Description: {*}{color:#de350b}Core idea{color}{*}: Make scaling up sensitive to prevent lags, and make s

Re: [PR] [FLINK-36112][connector/filesystem].Add Support for CreateFlag.NO_LOCAL_WRITE in FLINK on YARN's File Creation to Manage Disk Space and Network Load in Labeled YARN Nodes [flink]

2024-08-20 Thread via GitHub
liangyu-1 commented on PR #25226: URL: https://github.com/apache/flink/pull/25226#issuecomment-2301216817 @flinkbot run azure re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-36094] CDC SchemaRegistryRequestHandler should throw exception which is not SchemaEvolveException [flink-cdc]

2024-08-20 Thread via GitHub
ruanhang1993 commented on code in PR #3558: URL: https://github.com/apache/flink-cdc/pull/3558#discussion_r1724437471 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/schema/coordinator/SchemaRegistry.java: ## @@ -275,6 +277,8 @@ public void resetToCheck

[jira] [Commented] (FLINK-36115) Allow to scan newly table DDL during incremental reading stage.

2024-08-20 Thread LvYanquan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875353#comment-17875353 ] LvYanquan commented on FLINK-36115: --- I'm willing to support it. > Allow to scan newly

[jira] [Updated] (FLINK-36115) Allow to scan newly table DDL during incremental reading stage.

2024-08-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36115: --- Labels: pull-request-available (was: ) > Allow to scan newly table DDL during incremental r

Re: [PR] [FLINK-36064][streaming] Refactor Collect sink to eliminate dependency on OperatorID. [flink]

2024-08-20 Thread via GitHub
flinkbot commented on PR #25227: URL: https://github.com/apache/flink/pull/25227#issuecomment-2301168752 ## CI report: * c4a354b9d4fc207281d375dfc45482c225611dbe UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-36064) Refactor CollectResultIterator to eliminate dependency on OperatorID

2024-08-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36064: --- Labels: pull-request-available (was: ) > Refactor CollectResultIterator to eliminate depend

[PR] [FLINK-36064][streaming] Refactor Collect sink to eliminate dependency on OperatorID. [flink]

2024-08-20 Thread via GitHub
JunRuiLee opened a new pull request, #25227: URL: https://github.com/apache/flink/pull/25227 ## What is the purpose of the change [FLINK-36064][streaming] Refactor Collect sink to eliminate dependency on OperatorID. ## Verifying this change This change is alr

[jira] [Updated] (FLINK-36113) Condition 'transform instanceof PhysicalTransformation' is always 'false'

2024-08-20 Thread tiancx (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] tiancx updated FLINK-36113: --- Affects Version/s: (was: 1.20.0) Priority: Major (was: Minor) > Condition 'transform insta

[jira] [Updated] (FLINK-36083) Fix kafka table api doc's Connector Options table broken

2024-08-20 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhongqiang Gong updated FLINK-36083: Fix Version/s: kafka-3.3.0 > Fix kafka table api doc's Connector Options table broken > --

[jira] [Updated] (FLINK-36083) Fix kafka table api doc's Connector Options table broken

2024-08-20 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhongqiang Gong updated FLINK-36083: Affects Version/s: kafka-3.3.0 > Fix kafka table api doc's Connector Options table broken

[jira] [Resolved] (FLINK-36083) Fix kafka table api doc's Connector Options table broken

2024-08-20 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhongqiang Gong resolved FLINK-36083. - Fix Version/s: kafka-3.2.0 Resolution: Resolved Merged to master via : b5b8076d28

Re: [PR] [FLINK-36083][docs] Fix kafka table api doc's Connector Options table broken [flink-connector-kafka]

2024-08-20 Thread via GitHub
GOODBOY008 merged PR #112: URL: https://github.com/apache/flink-connector-kafka/pull/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Commented] (FLINK-35056) when initial sqlserver table that's primary key is datetime type, it org.apache.flink.table.api.ValidationException: Timestamp precision must be between 0 and 9 (both

2024-08-20 Thread Thorne (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875339#comment-17875339 ] Thorne commented on FLINK-35056: The version of flink-cdc is to old, can u try the lates

Re: [PR] [FLINK-35965][table] Add the built-in function ENDSWITH [flink]

2024-08-20 Thread via GitHub
dylanhz closed pull request #25157: [FLINK-35965][table] Add the built-in function ENDSWITH URL: https://github.com/apache/flink/pull/25157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] [FLINK-36112][connector/filesystem].Add Support for CreateFlag.NO_LOCAL_WRITE in FLINK on YARN's File Creation to Manage Disk Space and Network Load in Labeled YARN Nodes [flink]

2024-08-20 Thread via GitHub
liangyu-1 commented on PR #25226: URL: https://github.com/apache/flink/pull/25226#issuecomment-2300435271 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33536] Fix Flink Table API CSV streaming sink fails with IOException: Stream closed [flink]

2024-08-20 Thread via GitHub
stayrascal commented on code in PR #23725: URL: https://github.com/apache/flink/pull/23725#discussion_r1724293957 ## flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/writer/S3RecoverableFsDataOutputStream.java: ## @@ -131,8 +131,7 @@ public void syn

Re: [PR] [FLINK-36094] CDC SchemaRegistryRequestHandler should throw exception which is not SchemaEvolveException [flink-cdc]

2024-08-20 Thread via GitHub
ruanhang1993 commented on code in PR #3558: URL: https://github.com/apache/flink-cdc/pull/3558#discussion_r1724282834 ## flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/operators/schema/SchemaEvolveTest.java: ## @@ -1040,6 +1040,8 @@ tableId, buildRecord(INT, 2, STR

[jira] [Closed] (FLINK-36095) KeyedLookupJoinWrapper should shuffle by input upsertKey instead of join key to avoid changelog disordering

2024-08-20 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-36095. --- Resolution: Fixed fixed in master: 624bc5001c831d3d04a5680c03910c634a0c988b > KeyedLookupJoinWrappe

Re: [PR] [FLINK-36095][table-planner] KeyedLookupJoinWrapper should shuffle by input upsertKey instead of join key to avoid changelog disordering [flink]

2024-08-20 Thread via GitHub
lincoln-lil merged PR #25217: URL: https://github.com/apache/flink/pull/25217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

[jira] [Resolved] (FLINK-36081) Flink CDC MySQL source connector missing some columns data of newly added tables

2024-08-20 Thread Ruan Hang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruan Hang resolved FLINK-36081. --- Resolution: Fixed Fixed in master(3.3-SNAPSHOT): 77c63385d947f3bb8e726561a7f01cd383941a96 > Flink C

Re: [PR] [FLINK-36095][table-planner] KeyedLookupJoinWrapper should shuffle by input upsertKey instead of join key to avoid changelog disordering [flink]

2024-08-20 Thread via GitHub
lincoln-lil commented on PR #25217: URL: https://github.com/apache/flink/pull/25217#issuecomment-2300369497 @xuyangzhong thank you for reviewing this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-36081][cdc-base][mysql] Fix that MySQL source connector missing some columns data of newly added tables [flink-cdc]

2024-08-20 Thread via GitHub
ruanhang1993 merged PR #3548: URL: https://github.com/apache/flink-cdc/pull/3548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flin

Re: [PR] [FLINK-36094] CDC SchemaRegistryRequestHandler should throw exception which is not SchemaEvolveException [flink-cdc]

2024-08-20 Thread via GitHub
loserwang1024 commented on code in PR #3558: URL: https://github.com/apache/flink-cdc/pull/3558#discussion_r1724275532 ## flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/operators/schema/SchemaEvolveTest.java: ## @@ -1040,6 +1040,8 @@ tableId, buildRecord(INT, 2, ST

Re: [PR] [FLINK-36112][connector/filesystem].Add Support for CreateFlag.NO_LOCAL_WRITE in FLINK on YARN's File Creation to Manage Disk Space and Network Load in Labeled YARN Nodes [flink]

2024-08-20 Thread via GitHub
liangyu-1 commented on PR #25226: URL: https://github.com/apache/flink/pull/25226#issuecomment-2300261222 @xuyangzhong Hi, would you please help me check this issue? thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [FLINK-36063][runtime] Migrate StreamGraph and its related classes from flink-streaming-java to flink-runtime. [flink]

2024-08-20 Thread via GitHub
JunRuiLee commented on PR #25219: URL: https://github.com/apache/flink/pull/25219#issuecomment-2300241040 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (FLINK-36115) Allow to scan newly table DDL during incremental reading stage.

2024-08-20 Thread LvYanquan (Jira)
LvYanquan created FLINK-36115: - Summary: Allow to scan newly table DDL during incremental reading stage. Key: FLINK-36115 URL: https://issues.apache.org/jira/browse/FLINK-36115 Project: Flink Is

Re: [PR] [FLINK-27146] [Filesystem] Migrate to Junit5 [flink]

2024-08-20 Thread via GitHub
Jiabao-Sun commented on code in PR #22789: URL: https://github.com/apache/flink/pull/22789#discussion_r1724162979 ## flink-filesystems/flink-gs-fs-hadoop/src/test/java/org/apache/flink/fs/gs/writer/GSRecoverableWriterCommitterTest.java: ## @@ -122,7 +121,7 @@ public void before(

[jira] [Resolved] (FLINK-36106) t_flink_autoscaler_event_handler is not cleaned after each testing

2024-08-20 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-36106. - Fix Version/s: kubernetes-operator-1.10.0 Resolution: Fixed Merged to main(1.10.0) via: 84c1934d6

Re: [PR] [FLINK-36106][autoscaler] Clean up the t_flink_autoscaler_event_handler table after each test [flink-kubernetes-operator]

2024-08-20 Thread via GitHub
1996fanrui merged PR #866: URL: https://github.com/apache/flink-kubernetes-operator/pull/866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

Re: [PR] [FLINK-27146] [Filesystem] Migrate to Junit5 [flink]

2024-08-20 Thread via GitHub
Jiabao-Sun commented on code in PR #22789: URL: https://github.com/apache/flink/pull/22789#discussion_r1722593053 ## flink-filesystems/flink-oss-fs-hadoop/src/test/java/org/apache/flink/fs/osshadoop/HadoopOSSRecoverableWriterExceptionITCase.java: ## @@ -36,14 +36,14 @@ * Tests

Re: [PR] [FLINK-36095][table-planner] KeyedLookupJoinWrapper should shuffle by input upsertKey instead of join key to avoid changelog disordering [flink]

2024-08-20 Thread via GitHub
xuyangzhong commented on code in PR #25217: URL: https://github.com/apache/flink/pull/25217#discussion_r1724169227 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/UpsertKeyUtil.java: ## @@ -42,8 +43,17 @@ public class UpsertKeyUtil {

Re: [PR] FLINK-36112.Add Support for CreateFlag.NO_LOCAL_WRITE in FLINK on YARN's File Creation to Manage Disk Space and Network Load in Labeled YARN Nodes [flink]

2024-08-20 Thread via GitHub
flinkbot commented on PR #25226: URL: https://github.com/apache/flink/pull/25226#issuecomment-2300046645 ## CI report: * 47dde90482d1f83cf35caeee55e6d7f94994139e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-36114) Schema registry should block when handling existing requests

2024-08-20 Thread yux (Jira)
yux created FLINK-36114: --- Summary: Schema registry should block when handling existing requests Key: FLINK-36114 URL: https://issues.apache.org/jira/browse/FLINK-36114 Project: Flink Issue Type: Impro

[jira] [Updated] (FLINK-36112) Add Support for CreateFlag.NO_LOCAL_WRITE in FLINK on YARN's File Creation to Manage Disk Space and Network Load in Labeled YARN Nodes

2024-08-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36112: --- Labels: pull-request-available (was: ) > Add Support for CreateFlag.NO_LOCAL_WRITE in FLINK

[PR] FLINK-36112.Add Support for CreateFlag.NO_LOCAL_WRITE in FLINK on YARN's File Creation to Manage Disk Space and Network Load in Labeled YARN Nodes [flink]

2024-08-20 Thread via GitHub
liangyu-1 opened a new pull request, #25226: URL: https://github.com/apache/flink/pull/25226 Add Support for CreateFlag.NO_LOCAL_WRITE in FLINK on YARN's File Creation to Manage Disk Space and Network Load in Labeled YARN Nodes this patch is to solve [FLINK-36112](https://issues.apac

[jira] [Commented] (FLINK-35056) when initial sqlserver table that's primary key is datetime type, it org.apache.flink.table.api.ValidationException: Timestamp precision must be between 0 and 9 (both

2024-08-20 Thread Sergei Morozov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875320#comment-17875320 ] Sergei Morozov commented on FLINK-35056: Here's a source table example that will

Re: [PR] [FLINK-35490][cdc][JUnit5 Migration] For `flink-cdc-connect/flink-cdc-source-connectors` module [flink-cdc]

2024-08-20 Thread via GitHub
github-actions[bot] commented on PR #3395: URL: https://github.com/apache/flink-cdc/pull/3395#issuecomment-2299962809 This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. --

[jira] [Updated] (FLINK-36113) Condition 'transform instanceof PhysicalTransformation' is always 'false'

2024-08-20 Thread tiancx (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] tiancx updated FLINK-36113: --- Fix Version/s: 1.20.1 Affects Version/s: 1.20.0 Description: The legacyTransform method in

Re: [PR] [FLINK-35716] Adds a rule which splits out async calls from join cond… [flink]

2024-08-20 Thread via GitHub
AlanConfluent commented on PR #24992: URL: https://github.com/apache/flink/pull/24992#issuecomment-2299926457 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [FLINK-36031] [kubernetes-client] Migrate to Fabric8 interceptor API [flink-kubernetes-operator]

2024-08-20 Thread via GitHub
SamBarker commented on PR #863: URL: https://github.com/apache/flink-kubernetes-operator/pull/863#issuecomment-2299881752 @mateczagany, @gyfora, @morhidi or @csviri could one of you kindly approve the PR to run through the workflow, I think its good to go but would appreciate the the confi

Re: [PR] [FLINK-36110][snapshot] Store periodic snapshot trigger timestamps in memory [flink-kubernetes-operator]

2024-08-20 Thread via GitHub
mateczagany commented on code in PR #868: URL: https://github.com/apache/flink-kubernetes-operator/pull/868#discussion_r1723908699 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/SnapshotTriggerTimestampStore.java: ## @@ -0,0 +1,114 @@

Re: [PR] [FLINK-36110][snapshot] Store periodic snapshot trigger timestamps in memory [flink-kubernetes-operator]

2024-08-20 Thread via GitHub
gyfora commented on code in PR #868: URL: https://github.com/apache/flink-kubernetes-operator/pull/868#discussion_r1723878464 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/SnapshotTriggerTimestampStore.java: ## @@ -0,0 +1,114 @@ +/*

Re: [PR] [FLINK-36110][snapshot] Store periodic snapshot trigger timestamps in memory [flink-kubernetes-operator]

2024-08-20 Thread via GitHub
gyfora commented on code in PR #868: URL: https://github.com/apache/flink-kubernetes-operator/pull/868#discussion_r1723877842 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/SnapshotTriggerTimestampStore.java: ## @@ -0,0 +1,114 @@ +/*

Re: [PR] (1.20 backport) [FLINK-35886][task] Fix watermark idleness timeout accounting when subtask is backpressured/blocked [flink]

2024-08-20 Thread via GitHub
rkhachatryan commented on code in PR #25222: URL: https://github.com/apache/flink/pull/25222#discussion_r1723776966 ## flink-core/src/main/java/org/apache/flink/api/common/eventtime/WatermarkGeneratorSupplier.java: ## @@ -54,5 +55,14 @@ interface Context { * @see Metri

Re: [PR] (1.19 backport) [FLINK-35886][task] Fix watermark idleness timeout accounting when subtask is backpressured/blocked [flink]

2024-08-20 Thread via GitHub
rkhachatryan commented on code in PR #25223: URL: https://github.com/apache/flink/pull/25223#discussion_r1723771139 ## pom.xml: ## @@ -2355,6 +2355,10 @@ under the License. @org.apache.flink.annotation.Experimental

[jira] [Comment Edited] (FLINK-36010) Duplicate Job Submission returns Succeeded on single execution even if Global state is FAILED

2024-08-20 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875237#comment-17875237 ] Ahmed Hamdy edited comment on FLINK-36010 at 8/20/24 6:23 PM:

[jira] [Created] (FLINK-36113) Condition 'transform instanceof PhysicalTransformation' is always 'false'

2024-08-20 Thread tiancx (Jira)
tiancx created FLINK-36113: -- Summary: Condition 'transform instanceof PhysicalTransformation' is always 'false' Key: FLINK-36113 URL: https://issues.apache.org/jira/browse/FLINK-36113 Project: Flink

Re: [PR] [FLINK-36110][snapshot] Store periodic snapshot trigger timestamps in memory [flink-kubernetes-operator]

2024-08-20 Thread via GitHub
mateczagany commented on code in PR #868: URL: https://github.com/apache/flink-kubernetes-operator/pull/868#discussion_r1723640077 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconcilerTest.java: ## @@ -654,28

Re: [PR] [FLINK-35493][snapshot] Fix cleanup for snapshots without status field [flink-kubernetes-operator]

2024-08-20 Thread via GitHub
mateczagany closed pull request #867: [FLINK-35493][snapshot] Fix cleanup for snapshots without status field URL: https://github.com/apache/flink-kubernetes-operator/pull/867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Comment Edited] (FLINK-36010) Duplicate Job Submission returns Succeeded on single execution even if Global state is FAILED

2024-08-20 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875237#comment-17875237 ] Ahmed Hamdy edited comment on FLINK-36010 at 8/20/24 4:23 PM:

[jira] [Commented] (FLINK-36010) Duplicate Job Submission returns Succeeded on single execution even if Global state is FAILED

2024-08-20 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875237#comment-17875237 ] Ahmed Hamdy commented on FLINK-36010: - h2.Root Cause Analysis 1- Job manager receiv

Re: [PR] [FLINK-35266][snapshot] Add E2E tests for FlinkStateSnapshot [flink-kubernetes-operator]

2024-08-20 Thread via GitHub
mateczagany commented on PR #862: URL: https://github.com/apache/flink-kubernetes-operator/pull/862#issuecomment-2299245301 I will push a fix in a few minutes for the failures, sorry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (FLINK-36105) CDC pipeline job could not restore from state in Flink 1.20

2024-08-20 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875235#comment-17875235 ] Leonard Xu commented on FLINK-36105: I change this issue type to bug as the issue lo

[jira] [Updated] (FLINK-36105) CDC pipeline job could not restore from state in Flink 1.20

2024-08-20 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-36105: --- Issue Type: Bug (was: Improvement) > CDC pipeline job could not restore from state in Flink 1.20 >

[jira] [Assigned] (FLINK-36105) CDC pipeline job could not restore from state in Flink 1.20

2024-08-20 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-36105: -- Assignee: yux > CDC pipeline job could not restore from state in Flink 1.20 > ---

[jira] [Commented] (FLINK-36111) fix: adjust MultiTableCommittableChannelComputer Topology name

2024-08-20 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875233#comment-17875233 ] Leonard Xu commented on FLINK-36111: master: aedccb698e318d8bef58a40df1666d2c051ee55

Re: [PR] [FLINK-36111][Paimon] adjust MultiTableCommittableChannelComputer Topology name [flink-cdc]

2024-08-20 Thread via GitHub
leonardBang merged PR #3559: URL: https://github.com/apache/flink-cdc/pull/3559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[jira] [Assigned] (FLINK-36111) fix: adjust MultiTableCommittableChannelComputer Topology name

2024-08-20 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-36111: -- Assignee: MOBIN > fix: adjust MultiTableCommittableChannelComputer Topology name > -

[jira] [Updated] (FLINK-36110) Periodic save points trigger continuously

2024-08-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36110: --- Labels: pull-request-available (was: ) > Periodic save points trigger continuously > -

[PR] [FLINK-36110][snapshot] Store periodic snapshot trigger timestamps in memory [flink-kubernetes-operator]

2024-08-20 Thread via GitHub
mateczagany opened a new pull request, #868: URL: https://github.com/apache/flink-kubernetes-operator/pull/868 ## What is the purpose of the change SnapshotObserver uses deprecated fields as the latest timestamp of triggered snapshots. These fields are not updated when using FlinkStat

Re: [PR] [FLINK-36095][table-planner] KeyedLookupJoinWrapper should shuffle by input upsertKey instead of join key to avoid changelog disordering [flink]

2024-08-20 Thread via GitHub
lincoln-lil commented on code in PR #25217: URL: https://github.com/apache/flink/pull/25217#discussion_r1723515590 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/UpsertKeyUtil.java: ## @@ -42,8 +43,17 @@ public class UpsertKeyUtil {

Re: [PR] [FLINK-36095][table-planner] KeyedLookupJoinWrapper should shuffle by input upsertKey instead of join key to avoid changelog disordering [flink]

2024-08-20 Thread via GitHub
lincoln-lil commented on code in PR #25217: URL: https://github.com/apache/flink/pull/25217#discussion_r1723494445 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/UpsertKeyUtil.java: ## @@ -42,8 +43,17 @@ public class UpsertKeyUtil {

Re: [PR] [FLINK-36100][table] Support ESCAPE in built-in function LIKE [flink]

2024-08-20 Thread via GitHub
flinkbot commented on PR #25225: URL: https://github.com/apache/flink/pull/25225#issuecomment-2298887813 ## CI report: * 53ecf5699a5228c7980cc448fc40f204e9d9a9a9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-36100) Support ESCAPE in built-in function LIKE formally

2024-08-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36100: --- Labels: pull-request-available (was: ) > Support ESCAPE in built-in function LIKE formally

[PR] [FLINK-36100][table] Support ESCAPE in built-in function LIKE [flink]

2024-08-20 Thread via GitHub
dylanhz opened a new pull request, #25225: URL: https://github.com/apache/flink/pull/25225 ## What is the purpose of the change Support ESCAPE in built-in function LIKE. (Table API & SQL) Examples: ```SQL > SELECT 'TE-ST' LIKE '%E\_S%' ESCAPE '\'; FALSE > SELECT 'TE_ST'

Re: [PR] [FLINK-36095][table-planner] KeyedLookupJoinWrapper should shuffle by input upsertKey instead of join key to avoid changelog disordering [flink]

2024-08-20 Thread via GitHub
xuyangzhong commented on code in PR #25217: URL: https://github.com/apache/flink/pull/25217#discussion_r1723274397 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/UpsertKeyUtil.java: ## @@ -42,8 +43,17 @@ public class UpsertKeyUtil {

Re: [PR] [FLINK-36094] CDC SchemaRegistryRequestHandler should throw exception which is not SchemaEvolveException [flink-cdc]

2024-08-20 Thread via GitHub
ruanhang1993 commented on code in PR #3558: URL: https://github.com/apache/flink-cdc/pull/3558#discussion_r1723272737 ## flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/operators/schema/SchemaEvolveTest.java: ## @@ -1040,6 +1040,8 @@ tableId, buildRecord(INT, 2, STR

Re: [PR] [FLINK-35772][filesystem] Drop DuplicatingFileSystem in favour of the newer PathsCopyingFileSystem [flink]

2024-08-20 Thread via GitHub
flinkbot commented on PR #25224: URL: https://github.com/apache/flink/pull/25224#issuecomment-2298792524 ## CI report: * 6c1a1f6ad261bf903da6f2f04fc5dfae30390521 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-35772) Deprecate/remove DuplicatingFileSystem

2024-08-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35772: --- Labels: pull-request-available (was: ) > Deprecate/remove DuplicatingFileSystem > -

[PR] [FLINK-35772][filesystem] Drop DuplicatingFileSystem in favour of the newer PathsCopyingFileSystem [flink]

2024-08-20 Thread via GitHub
pnowojski opened a new pull request, #25224: URL: https://github.com/apache/flink/pull/25224 ## What is the purpose of the change As described in https://cwiki.apache.org/confluence/display/FLINK/FLIP-444%3A+Native+file+copy+support, `PathsCopyingFileSystem` supersedes `DuplicatingFi

Re: [PR] (1.19 backport) [FLINK-35886][task] Fix watermark idleness timeout accounting when subtask is backpressured/blocked [flink]

2024-08-20 Thread via GitHub
flinkbot commented on PR #25223: URL: https://github.com/apache/flink/pull/25223#issuecomment-2298676411 ## CI report: * 2f64401e30c571adf949de9b705b531f8a267256 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] (1.19 backport) [FLINK-35886][task] Fix watermark idleness timeout accounting when subtask is backpressured/blocked [flink]

2024-08-20 Thread via GitHub
pnowojski commented on code in PR #25223: URL: https://github.com/apache/flink/pull/25223#discussion_r172318 ## pom.xml: ## @@ -2355,6 +2355,10 @@ under the License. @org.apache.flink.annotation.Experimental

[PR] (1.19 backport) [FLINK-35886][task] Fix watermark idleness timeout accounting when subtask is backpressured/blocked [flink]

2024-08-20 Thread via GitHub
pnowojski opened a new pull request, #25223: URL: https://github.com/apache/flink/pull/25223 this is a backport of https://github.com/apache/flink/pull/25167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] [FLINK-36092] Let schema evolve work with transform [flink-cdc]

2024-08-20 Thread via GitHub
leonardBang commented on code in PR #3557: URL: https://github.com/apache/flink-cdc/pull/3557#discussion_r1723178889 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/parser/TransformParser.java: ## @@ -585,4 +590,95 @@ public static String normalizeFilter(String p

[jira] [Resolved] (FLINK-36085) Refactor SHOW operations with LIKE/ILIKE

2024-08-20 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-36085. - Fix Version/s: 2.0.0 Resolution: Fixed > Refactor SHOW operations with LIKE/ILIKE

[jira] [Resolved] (FLINK-36050) Support enhanced `show views` statement

2024-08-20 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-36050. - Fix Version/s: 2.0.0 Resolution: Fixed > Support enhanced `show views` statement

[jira] [Commented] (FLINK-36050) Support enhanced `show views` statement

2024-08-20 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875159#comment-17875159 ] Sergey Nuyanzin commented on FLINK-36050: - Merged as [04b385b3a080efcfdcb30

Re: [PR] [FLINK-36050][table] Support enhanced `SHOW VIEW` syntax [flink]

2024-08-20 Thread via GitHub
snuyanzin closed pull request #25200: [FLINK-36050][table] Support enhanced `SHOW VIEW` syntax URL: https://github.com/apache/flink/pull/25200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[jira] [Assigned] (FLINK-33748) Remove legacy TableSource/TableSink API in 2.0

2024-08-20 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee reassigned FLINK-33748: --- Assignee: xuyang > Remove legacy TableSource/TableSink API in 2.0 > ---

[jira] [Commented] (FLINK-33748) Remove legacy TableSource/TableSink API in 2.0

2024-08-20 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875157#comment-17875157 ] lincoln lee commented on FLINK-33748: - [~xuyangzhong] thanks for volunteering!Assign

Re: [PR] [FLINK-36094] CDC SchemaRegistryRequestHandler should throw exception which is not SchemaEvolveException [flink-cdc]

2024-08-20 Thread via GitHub
loserwang1024 commented on PR #3558: URL: https://github.com/apache/flink-cdc/pull/3558#issuecomment-2298641518 > Could you please modify these parts together? done it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-36094] CDC SchemaRegistryRequestHandler should throw exception which is not SchemaEvolveException [flink-cdc]

2024-08-20 Thread via GitHub
loserwang1024 commented on code in PR #3558: URL: https://github.com/apache/flink-cdc/pull/3558#discussion_r1723162468 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/schema/coordinator/SchemaRegistryRequestHandler.java: ## @@ -147,17 +146,27 @@ private

Re: [PR] [FLINK-36094] CDC SchemaRegistryRequestHandler should throw exception which is not SchemaEvolveException [flink-cdc]

2024-08-20 Thread via GitHub
loserwang1024 commented on code in PR #3558: URL: https://github.com/apache/flink-cdc/pull/3558#discussion_r1723162033 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/schema/coordinator/SchemaRegistryRequestHandler.java: ## @@ -437,6 +444,25 @@ private

Re: [PR] [FLINK-36094] CDC SchemaRegistryRequestHandler should throw exception which is not SchemaEvolveException [flink-cdc]

2024-08-20 Thread via GitHub
yuxiqian commented on code in PR #3558: URL: https://github.com/apache/flink-cdc/pull/3558#discussion_r1723024778 ## flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/operators/schema/SchemaEvolveTest.java: ## @@ -1040,8 +1040,10 @@ tableId, buildRecord(INT, 2, STRING

[jira] [Updated] (FLINK-36107) schema event support custom callback

2024-08-20 Thread melin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] melin updated FLINK-36107: -- Description: User-defined callback is supported. sink obtains the schema event and invokes the callback imple

Re: [PR] [FLINK-36094] CDC SchemaRegistryRequestHandler should throw exception which is not SchemaEvolveException [flink-cdc]

2024-08-20 Thread via GitHub
ruanhang1993 commented on code in PR #3558: URL: https://github.com/apache/flink-cdc/pull/3558#discussion_r1723121548 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/schema/coordinator/SchemaRegistryRequestHandler.java: ## @@ -147,17 +146,27 @@ private

[jira] [Updated] (FLINK-36112) Add Support for CreateFlag.NO_LOCAL_WRITE in FLINK on YARN's File Creation to Manage Disk Space and Network Load in Labeled YARN Nodes

2024-08-20 Thread liang yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liang yu updated FLINK-36112: - Description: {*}Description{*}: I am currently using Apache Flink to write files into Hadoop. The Flink

[jira] [Updated] (FLINK-36112) Add Support for CreateFlag.NO_LOCAL_WRITE in FLINK on YARN's File Creation to Manage Disk Space and Network Load in Labeled YARN Nodes

2024-08-20 Thread liang yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liang yu updated FLINK-36112: - Description: {*}Description{*}: I am currently using Apache Flink to write files into Hadoop. The Flink

[jira] [Updated] (FLINK-36112) Add Support for CreateFlag.NO_LOCAL_WRITE in FLINK on YARN's File Creation to Manage Disk Space and Network Load in Labeled YARN Nodes

2024-08-20 Thread liang yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liang yu updated FLINK-36112: - Attachment: image-2024-08-20-18-51-11-864.png > Add Support for CreateFlag.NO_LOCAL_WRITE in FLINK on YA

[jira] [Updated] (FLINK-36112) Add Support for CreateFlag.NO_LOCAL_WRITE in FLINK on YARN's File Creation to Manage Disk Space and Network Load in Labeled YARN Nodes

2024-08-20 Thread liang yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liang yu updated FLINK-36112: - Description: {*}Description{*}: I am currently using Apache Flink to write files into Hadoop. The Flink

  1   2   >