rkhachatryan commented on code in PR #25223:
URL: https://github.com/apache/flink/pull/25223#discussion_r1723771139
##########
pom.xml:
##########
@@ -2355,6 +2355,10 @@ under the License.
<exclude>@org.apache.flink.annotation.Experimental</exclude>
<exclude>@org.apache.flink.annotation.Internal</exclude>
<!-- MARKER:
start exclusions; these will be wiped by
tools/releasing/update_japicmp_configuration.sh -->
+ <!-- New method
has been added to the interface, but this interface shouldn't be implemented by
users, only used/called, so this doesn't break API compatibility. -->
+
<exclude>org.apache.flink.api.common.eventtime.WatermarkGeneratorSupplier$Context</exclude>
+ <!-- Base
interface has been extracted from the existing Clock class. This interface
shouldn't affect user code. -->
+
<exclude>org.apache.flink.util.clock.Clock</exclude>
Review Comment:
It would be nice to return System clock from the new method
(`WatermarkGeneratorSupplier.Context#getInputActivityClock`) to avoid breaking
existing implementations.
I think it's not impossible that there are custom implementations of this
interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
