pnowojski commented on code in PR #25223:
URL: https://github.com/apache/flink/pull/25223#discussion_r1724488059
##########
pom.xml:
##########
@@ -2355,6 +2355,10 @@ under the License.
<exclude>@org.apache.flink.annotation.Experimental</exclude>
<exclude>@org.apache.flink.annotation.Internal</exclude>
<!-- MARKER:
start exclusions; these will be wiped by
tools/releasing/update_japicmp_configuration.sh -->
+ <!-- New method
has been added to the interface, but this interface shouldn't be implemented by
users, only used/called, so this doesn't break API compatibility. -->
+
<exclude>org.apache.flink.api.common.eventtime.WatermarkGeneratorSupplier$Context</exclude>
+ <!-- Base
interface has been extracted from the existing Clock class. This interface
shouldn't affect user code. -->
+
<exclude>org.apache.flink.util.clock.Clock</exclude>
Review Comment:
This context is provided by Flink to operators/functions, so I don't see any
legitimate way how user should be interested in implementing it's own context.
This could only happen if someone forks Flink and extends it somehow in this
area AFAIU. I will merge it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
