Re: [PR] [FLINK-35638] Refactor OceanBase test cases and remove dependency on host network [flink-cdc]

2024-08-14 Thread via GitHub
GOODBOY008 commented on code in PR #3439: URL: https://github.com/apache/flink-cdc/pull/3439#discussion_r1718041749 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-oceanbase-cdc/src/test/java/org/apache/flink/cdc/connectors/oceanbase/testutils/UniqueDatabase.java: #

Re: [PR] [FLINK-35493][snapshot] Add historical cleanup for FlinkStateSnapshot CRs [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
gyfora commented on code in PR #860: URL: https://github.com/apache/flink-kubernetes-operator/pull/860#discussion_r1718038855 ## docs/layouts/shortcodes/generated/dynamic_section.html: ## @@ -8,6 +8,24 @@ + +kubernetes.operator.checkpoi

Re: [PR] [FLINK-35493][snapshot] Add historical cleanup for FlinkStateSnapshot CRs [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
mateczagany commented on code in PR #860: URL: https://github.com/apache/flink-kubernetes-operator/pull/860#discussion_r1718035018 ## docs/layouts/shortcodes/generated/dynamic_section.html: ## @@ -8,6 +8,24 @@ + +kubernetes.operator.che

[jira] [Created] (FLINK-36061) Support Apache iceberg for pipeline connector

2024-08-14 Thread ZhengYu Chen (Jira)
ZhengYu Chen created FLINK-36061: Summary: Support Apache iceberg for pipeline connector Key: FLINK-36061 URL: https://issues.apache.org/jira/browse/FLINK-36061 Project: Flink Issue Type: New

[jira] [Updated] (FLINK-36059) SqlClientITCase failed due to could not create/start container

2024-08-14 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-36059: --- Affects Version/s: 1.20.1 (was: 2.0.0) > SqlClientITCase failed due to co

[jira] [Updated] (FLINK-36059) SqlClientITCase failed due to could not create/start container

2024-08-14 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-36059: --- Description: {code:java} Aug 14 04:57:22 Caused by: org.rnorth.ducttape.RetryCountExceededException

[jira] [Created] (FLINK-36059) SqlClientITCase failed due to could not create/start container

2024-08-14 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-36059: -- Summary: SqlClientITCase failed due to could not create/start container Key: FLINK-36059 URL: https://issues.apache.org/jira/browse/FLINK-36059 Project: Flink I

Re: [PR] [FLINK-36051] Re-prepare invalid statement even if connection is valid [flink-connector-jdbc]

2024-08-14 Thread via GitHub
whhe commented on code in PR #138: URL: https://github.com/apache/flink-connector-jdbc/pull/138#discussion_r1717945339 ## flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/internal/JdbcOutputFormat.java: ## @@ -178,14 +178,12 @@ public synchronized void fl

Re: [PR] [FLINK-36039][autoscaler] Support clean historical event handler records in JDBC event handler [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
1996fanrui commented on code in PR #865: URL: https://github.com/apache/flink-kubernetes-operator/pull/865#discussion_r1717934379 ## flink-autoscaler-plugin-jdbc/src/main/java/org/apache/flink/autoscaler/jdbc/event/JdbcAutoScalerEventHandler.java: ## @@ -38,13 +47,34 @@ * @pa

Re: [PR] [FLINK-36039][autoscaler] Support clean historical event handler records in JDBC event handler [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
RocMarshal commented on code in PR #865: URL: https://github.com/apache/flink-kubernetes-operator/pull/865#discussion_r1717923090 ## flink-autoscaler-plugin-jdbc/src/main/java/org/apache/flink/autoscaler/jdbc/event/JdbcAutoScalerEventHandler.java: ## @@ -38,13 +47,34 @@ * @pa

Re: [PR] [FLINK-36039][autoscaler] Support clean historical event handler records in JDBC event handler [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
RocMarshal commented on code in PR #865: URL: https://github.com/apache/flink-kubernetes-operator/pull/865#discussion_r1717923090 ## flink-autoscaler-plugin-jdbc/src/main/java/org/apache/flink/autoscaler/jdbc/event/JdbcAutoScalerEventHandler.java: ## @@ -38,13 +47,34 @@ * @pa

Re: [PR] [FLINK-36051] Re-prepare invalid statement even if connection is valid [flink-connector-jdbc]

2024-08-14 Thread via GitHub
morozov commented on code in PR #138: URL: https://github.com/apache/flink-connector-jdbc/pull/138#discussion_r1717922674 ## flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/internal/JdbcOutputFormat.java: ## @@ -178,14 +178,12 @@ public synchronized void

Re: [PR] [FLINK-36039][autoscaler] Support clean historical event handler records in JDBC event handler [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
1996fanrui commented on code in PR #865: URL: https://github.com/apache/flink-kubernetes-operator/pull/865#discussion_r1717913230 ## flink-autoscaler-plugin-jdbc/src/main/java/org/apache/flink/autoscaler/jdbc/event/JdbcAutoScalerEventHandler.java: ## @@ -38,13 +47,34 @@ * @pa

Re: [PR] [FLINK-36039][autoscaler] Support clean historical event handler records in JDBC event handler [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
1996fanrui commented on code in PR #865: URL: https://github.com/apache/flink-kubernetes-operator/pull/865#discussion_r1717905926 ## flink-autoscaler-plugin-jdbc/src/main/java/org/apache/flink/autoscaler/jdbc/event/JdbcAutoScalerEventHandler.java: ## @@ -38,13 +47,34 @@ * @pa

Re: [PR] [FLINK-36039][autoscaler] Support clean historical event handler records in JDBC event handler [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
RocMarshal commented on code in PR #865: URL: https://github.com/apache/flink-kubernetes-operator/pull/865#discussion_r171705 ## flink-autoscaler-plugin-jdbc/src/main/java/org/apache/flink/autoscaler/jdbc/event/JdbcAutoScalerEventHandler.java: ## @@ -38,13 +47,34 @@ * @pa

Re: [PR] [FLINK-36051] Re-prepare invalid statement even if connection is valid [flink-connector-jdbc]

2024-08-14 Thread via GitHub
whhe commented on code in PR #138: URL: https://github.com/apache/flink-connector-jdbc/pull/138#discussion_r1717847137 ## flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/internal/JdbcOutputFormat.java: ## @@ -178,14 +178,12 @@ public synchronized void fl

Re: [PR] [FLINK-35638] Refactor OceanBase test cases and remove dependency on host network [flink-cdc]

2024-08-14 Thread via GitHub
whhe commented on code in PR #3439: URL: https://github.com/apache/flink-cdc/pull/3439#discussion_r1717838862 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-oceanbase-cdc/src/test/java/org/apache/flink/cdc/connectors/oceanbase/testutils/UniqueDatabase.java: ##

[PR] Add release announcement for CDC 3.2.0 [flink-web]

2024-08-14 Thread via GitHub
yuxiqian opened a new pull request, #753: URL: https://github.com/apache/flink-web/pull/753 This PR adds release announcement post, and updates metadata info for the coming CDC 3.2.0 release. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] [FLINK-30481][FLIP-277] GlueCatalog Implementation [flink-connector-aws]

2024-08-14 Thread via GitHub
Samrat002 commented on code in PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#discussion_r1717819509 ## flink-catalog-aws/flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/operator/GlueFunctionOperator.java: ## @@ -0,0 +1,272 @@ +/* +

[jira] [Comment Edited] (FLINK-33424) Resolved an issue in YarnClusterDescriptor where temporary files created locally by flink-conf.yaml are treated as remote files

2024-08-14 Thread slankka (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873770#comment-17873770 ] slankka edited comment on FLINK-33424 at 8/15/24 2:26 AM: -- Plea

[jira] [Comment Edited] (FLINK-33424) Resolved an issue in YarnClusterDescriptor where temporary files created locally by flink-conf.yaml are treated as remote files

2024-08-14 Thread slankka (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873770#comment-17873770 ] slankka edited comment on FLINK-33424 at 8/15/24 2:25 AM: -- Plea

[jira] [Comment Edited] (FLINK-33424) Resolved an issue in YarnClusterDescriptor where temporary files created locally by flink-conf.yaml are treated as remote files

2024-08-14 Thread slankka (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873770#comment-17873770 ] slankka edited comment on FLINK-33424 at 8/15/24 2:22 AM: -- Plea

[jira] [Closed] (FLINK-36055) Change flink.connector.elasticsearch.version to a release version

2024-08-14 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren closed FLINK-36055. - Fix Version/s: cdc-3.2.0 cdc-3.3.0 Resolution: Fixed > Change flink.co

[jira] [Commented] (FLINK-36055) Change flink.connector.elasticsearch.version to a release version

2024-08-14 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873771#comment-17873771 ] Qingsheng Ren commented on FLINK-36055: --- flink-cdc master: c5396fbf29ae3a48bb13e38

[jira] [Commented] (FLINK-33424) Resolved an issue in YarnClusterDescriptor where temporary files created locally by flink-conf.yaml are treated as remote files

2024-08-14 Thread slankka (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873770#comment-17873770 ] slankka commented on FLINK-33424: - Please be aware of that `registerSingleLocalResource`

[jira] [Assigned] (FLINK-36055) Change flink.connector.elasticsearch.version to a release version

2024-08-14 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren reassigned FLINK-36055: - Assignee: wuzexian > Change flink.connector.elasticsearch.version to a release version

[jira] [Commented] (FLINK-36054) Cleanup Flink CDC pom and release scripts

2024-08-14 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873769#comment-17873769 ] Qingsheng Ren commented on FLINK-36054: --- flink-cdc master: d99e718951f7541ba23321c

[jira] [Closed] (FLINK-36054) Cleanup Flink CDC pom and release scripts

2024-08-14 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren closed FLINK-36054. - Resolution: Fixed > Cleanup Flink CDC pom and release scripts >

[jira] [Updated] (FLINK-36054) Cleanup Flink CDC pom and release scripts

2024-08-14 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren updated FLINK-36054: -- Fix Version/s: cdc-3.2.0 cdc-3.3.0 > Cleanup Flink CDC pom and release scri

Re: [PR] [FLINK-35993][table] Add the built-in function UNHEX [flink]

2024-08-14 Thread via GitHub
dylanhz commented on code in PR #25176: URL: https://github.com/apache/flink/pull/25176#discussion_r1717787895 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/EncodingUtils.java: ## @@ -187,6 +187,33 @@ public static String hex(byte[] bytes) {

[jira] [Updated] (FLINK-36056) change flink.connector.elasticsearch.version to a release version in branch release-3.2

2024-08-14 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-36056: --- Component/s: Flink CDC > change flink.connector.elasticsearch.version to a release version in branch

[jira] [Updated] (FLINK-36056) change flink.connector.elasticsearch.version to a release version in branch release-3.2

2024-08-14 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-36056: --- Description: Currently, the es connector version is incorrectly set as a SNPASHOT version, we should

[jira] [Updated] (FLINK-36056) change flink.connector.elasticsearch.version to a release version in branch release-3.2

2024-08-14 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-36056: --- Fix Version/s: cdc-3.2.0 > change flink.connector.elasticsearch.version to a release version in bran

Re: [PR] [FLINK-35935][table-planner] Fix RTAS not supporting LIMIT [flink]

2024-08-14 Thread via GitHub
flinkbot commented on PR #25202: URL: https://github.com/apache/flink/pull/25202#issuecomment-2290338149 ## CI report: * 2382cdfb0cf3924777e0ae21b7f390692c14fa05 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Assigned] (FLINK-36056) change flink.connector.elasticsearch.version to a release version in branch release-3.2

2024-08-14 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-36056: -- Assignee: wuzexian > change flink.connector.elasticsearch.version to a release version in bra

Re: [PR] [FLINK-36055] change flink.connector.elasticsearch.version to a release version [flink-cdc]

2024-08-14 Thread via GitHub
leonardBang merged PR #3542: URL: https://github.com/apache/flink-cdc/pull/3542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

Re: [PR] [FLINK-35935][table-planner] Fix RTAS not supporting LIMIT [flink]

2024-08-14 Thread via GitHub
flinkbot commented on PR #25201: URL: https://github.com/apache/flink/pull/25201#issuecomment-2290322342 ## CI report: * b70b743b4747fcfedf393b02bfc896dd54fb724e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35935][table-planner] Fix RTAS not supporting LIMIT [flink]

2024-08-14 Thread via GitHub
xuyangzhong opened a new pull request, #25202: URL: https://github.com/apache/flink/pull/25202 ## What is the purpose of the change BP for https://github.com/apache/flink/pull/25185 *When using `SqlReplaceTableAsConverter` to convert SqlNode, `SqlReplaceTableAsConverter` wrong

[PR] [FLINK-35935][table-planner] Fix RTAS not supporting LIMIT [flink]

2024-08-14 Thread via GitHub
xuyangzhong opened a new pull request, #25201: URL: https://github.com/apache/flink/pull/25201 ## What is the purpose of the change BP for https://github.com/apache/flink/pull/25185. *When using `SqlReplaceTableAsConverter` to convert SqlNode, `SqlReplaceTableAsConverter` wron

[jira] [Commented] (FLINK-35935) CREATE TABLE AS doesn't work with LIMIT

2024-08-14 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873762#comment-17873762 ] lincoln lee commented on FLINK-35935: - [~xuyangzhong] Could you also backport this f

[jira] [Commented] (FLINK-35935) CREATE TABLE AS doesn't work with LIMIT

2024-08-14 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873763#comment-17873763 ] lincoln lee commented on FLINK-35935: - Fixed in master: 729b8b81a77ba6c32711216b88a1

[jira] [Updated] (FLINK-35935) CREATE TABLE AS doesn't work with LIMIT

2024-08-14 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-35935: Fix Version/s: 2.0.0 1.19.2 1.20.1 > CREATE TABLE AS doesn't

Re: [PR] [FLINK-35935][table] Fix RTAS not supporting LIMIT [flink]

2024-08-14 Thread via GitHub
lincoln-lil merged PR #25185: URL: https://github.com/apache/flink/pull/25185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-30481][FLIP-277] GlueCatalog Implementation [flink-connector-aws]

2024-08-14 Thread via GitHub
foxus commented on PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#issuecomment-2290055417 > @foxus Please review whenever time Thanks for the effort responding to the comments, there's only one which I think has been marked as resolved but still appears not to hav

Re: [PR] [FLINK-30481][FLIP-277] GlueCatalog Implementation [flink-connector-aws]

2024-08-14 Thread via GitHub
foxus commented on code in PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#discussion_r1717620730 ## flink-catalog-aws/flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/util/GlueUtils.java: ## @@ -0,0 +1,384 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-35716] Adds a rule which splits out async calls from join cond… [flink]

2024-08-14 Thread via GitHub
AlanConfluent commented on PR #24992: URL: https://github.com/apache/flink/pull/24992#issuecomment-228701 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [FLINK-36031] [kubernetes-client] Migrate to Fabric8 interceptor API [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
SamBarker commented on code in PR #863: URL: https://github.com/apache/flink-kubernetes-operator/pull/863#discussion_r1716706322 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/metrics/KubernetesClientMetrics.java: ## @@ -118,32 +139,91 @@ public

Re: [PR] [FLINK-22748] Allow dynamic target topic selection in SQL Kafka sinks [flink-connector-kafka]

2024-08-14 Thread via GitHub
klam-shop commented on PR #109: URL: https://github.com/apache/flink-connector-kafka/pull/109#issuecomment-2289926046 Friendly ping, do you have time to take a look @AHeise 🙏 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-36050][table] Support enhanced `SHOW VIEW` syntax [flink]

2024-08-14 Thread via GitHub
jnh5y commented on code in PR #25200: URL: https://github.com/apache/flink/pull/25200#discussion_r1717551998 ## docs/content.zh/docs/dev/table/sql/show.md: ## @@ -913,10 +913,17 @@ SHOW PROCEDURES [ ( FROM | IN ) [catalog_name.]database_name ] [ [NOT] (LIKE | I ## SHOW VIEWS

Re: [PR] [FLINK-36050][table] Support enhanced `SHOW VIEW` syntax [flink]

2024-08-14 Thread via GitHub
jnh5y commented on code in PR #25200: URL: https://github.com/apache/flink/pull/25200#discussion_r1717550570 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlOtherOperationConverterTest.java: ## @@ -222,26 +226,30 @@ void testShowView

[jira] [Commented] (FLINK-36058) OperatorTestHarness is always using checkpointId=0 for state recovery

2024-08-14 Thread Rodrigo Meneses (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873728#comment-17873728 ] Rodrigo Meneses commented on FLINK-36058: - [~gaborgsomogyi] Correct! > Operator

[jira] [Commented] (FLINK-36058) OperatorTestHarness is always using checkpointId=0 for state recovery

2024-08-14 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873727#comment-17873727 ] Gabor Somogyi commented on FLINK-36058: --- If I understand correctly this has no Fli

[jira] [Created] (FLINK-36058) OperatorTestHarness is always using checkpointId=0 for state recovery

2024-08-14 Thread Rodrigo Meneses (Jira)
Rodrigo Meneses created FLINK-36058: --- Summary: OperatorTestHarness is always using checkpointId=0 for state recovery Key: FLINK-36058 URL: https://issues.apache.org/jira/browse/FLINK-36058 Project:

[jira] [Resolved] (FLINK-33607) Add checksum verification for Maven wrapper as well

2024-08-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-33607. --- Fix Version/s: 2.0.0 Resolution: Fixed master: [e9dd4683|https://github.com/apache/f

Re: [PR] [FLINK-36050][table] Support enhanced `SHOW VIEW` syntax [flink]

2024-08-14 Thread via GitHub
snuyanzin commented on code in PR #25200: URL: https://github.com/apache/flink/pull/25200#discussion_r1717450763 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowViewsOperation.java: ## @@ -19,23 +19,125 @@ package org.apache.flink.table.o

Re: [PR] [FLINK-33607][build] Updates Maven wrapper version and enables checksum verification for Maven wrapper [flink]

2024-08-14 Thread via GitHub
XComp merged PR #24852: URL: https://github.com/apache/flink/pull/24852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [FLINK-36050][table] Support enhanced `SHOW VIEW` syntax [flink]

2024-08-14 Thread via GitHub
jnh5y commented on PR #25200: URL: https://github.com/apache/flink/pull/25200#issuecomment-2289317826 From a read through, just found the one issue and asked the one question. Overall, this looks good and is consistent with https://github.com/apache/flink/pull/18361 -- This is an automa

Re: [PR] [FLINK-36050][table] Support enhanced `SHOW VIEW` syntax [flink]

2024-08-14 Thread via GitHub
jnh5y commented on code in PR #25200: URL: https://github.com/apache/flink/pull/25200#discussion_r1717264997 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowViewsOperation.java: ## @@ -19,23 +19,125 @@ package org.apache.flink.table.opera

Re: [PR] [FLINK-36050][table] Support enhanced `SHOW VIEW` syntax [flink]

2024-08-14 Thread via GitHub
snuyanzin commented on code in PR #25200: URL: https://github.com/apache/flink/pull/25200#discussion_r1717251475 ## docs/content.zh/docs/dev/table/sql/show.md: ## @@ -913,10 +913,17 @@ SHOW PROCEDURES [ ( FROM | IN ) [catalog_name.]database_name ] [ [NOT] (LIKE | I ## SHOW VIE

Re: [PR] [FLINK-36050][table] Support enhanced `SHOW VIEW` syntax [flink]

2024-08-14 Thread via GitHub
jnh5y commented on code in PR #25200: URL: https://github.com/apache/flink/pull/25200#discussion_r1717244214 ## docs/content.zh/docs/dev/table/sql/show.md: ## @@ -913,10 +913,17 @@ SHOW PROCEDURES [ ( FROM | IN ) [catalog_name.]database_name ] [ [NOT] (LIKE | I ## SHOW VIEWS

Re: [PR] [FLINK-33201][Connectors/Kafka] Fix memory leak in CachingTopicSelector [flink-connector-kafka]

2024-08-14 Thread via GitHub
cnmckee13 commented on PR #55: URL: https://github.com/apache/flink-connector-kafka/pull/55#issuecomment-2289196957 Hey All- We're experiencing some memory issues and wondering if this could be the cause. Will this PR be reviewed soon? @MartijnVisser @tzulitai -- This is an automated me

Re: [PR] [FLINK-35886][task] Fix watermark idleness timeout accounting when subtask is backpressured/blocked [flink]

2024-08-14 Thread via GitHub
pnowojski commented on PR #25167: URL: https://github.com/apache/flink/pull/25167#issuecomment-2289079697 @rkhachatryan , as we discussed offline, I've changed the code to fire `StartStopListener` from under the `TimerGauge` lock ([fixup commit](https://github.com/apache/flink/pull/25167/co

Re: [PR] [FLINK-35993][table] Add the built-in function UNHEX [flink]

2024-08-14 Thread via GitHub
lincoln-lil commented on code in PR #25176: URL: https://github.com/apache/flink/pull/25176#discussion_r1717019309 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/MathFunctionsITCase.java: ## @@ -141,4 +178,57 @@ Stream getTestSetSpecs()

Re: [PR] [FLINK-35920][table] Add PRINTF function [flink]

2024-08-14 Thread via GitHub
lincoln-lil commented on code in PR #25133: URL: https://github.com/apache/flink/pull/25133#discussion_r1716810021 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -1244,6 +1244,19 @@ ANY, and(logical(Logical

Re: [PR] [FLINK-35937] RBAC cleanup [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
timsn commented on code in PR #857: URL: https://github.com/apache/flink-kubernetes-operator/pull/857#discussion_r1716816424 ## helm/flink-kubernetes-operator/templates/rbac.yaml: ## @@ -89,6 +81,7 @@ rules: - update - patch - delete + - deletecollecti

[jira] [Closed] (FLINK-36037) Add compability for 1.9 last savepoint info on upgrade/recovery

2024-08-14 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-36037. -- Fix Version/s: kubernetes-operator-1.10.0 Assignee: Mate Czagany Resolution: Fixed mer

Re: [PR] [FLINK-36037][snapshot] Add backwards compatibility for job upgrades [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
gyfora merged PR #864: URL: https://github.com/apache/flink-kubernetes-operator/pull/864 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [FLINK-35993][table] Add the built-in function UNHEX [flink]

2024-08-14 Thread via GitHub
lincoln-lil commented on code in PR #25176: URL: https://github.com/apache/flink/pull/25176#discussion_r1716967423 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -1856,6 +1856,19 @@ ANY, and(logical(Logical

Re: [PR] [FLINK-36050][table] Support enhanced `SHOW VIEW` syntax [flink]

2024-08-14 Thread via GitHub
snuyanzin commented on code in PR #25200: URL: https://github.com/apache/flink/pull/25200#discussion_r1716954372 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dql/SqlShowTables.java: ## @@ -101,10 +101,8 @@ public List getOperandList() {

Re: [PR] [FLINK-36050][table] Support enhanced `SHOW VIEW` syntax [flink]

2024-08-14 Thread via GitHub
flinkbot commented on PR #25200: URL: https://github.com/apache/flink/pull/25200#issuecomment-2288779628 ## CI report: * 2af84b098ee9f3c64f7da181fa8da4e8b5935ef9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-36050) Support enhanced `show views` statement

2024-08-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36050: --- Labels: pull-request-available (was: ) > Support enhanced `show views` statement >

[PR] [FLINK-36050][table] Support enhanced `SHOW VIEW` syntax [flink]

2024-08-14 Thread via GitHub
snuyanzin opened a new pull request, #25200: URL: https://github.com/apache/flink/pull/25200 ## What is the purpose of the change Support enhanced `SHOW VIEWS` syntax like `SHOW VIEWS FROM catalog1.db1 LIKE 't%'` in a way similar to existing `SHOW TABLES` syntax ## Brie

[jira] [Updated] (FLINK-36053) Support multi-version integration test in mongodb connector

2024-08-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36053: --- Labels: pull-request-available (was: ) > Support multi-version integration test in mongodb

[PR] [FLINK-36053][connectors/mongodb] Support multi-version integration test in mongodb connector [flink-connector-mongodb]

2024-08-14 Thread via GitHub
Jiabao-Sun opened a new pull request, #41: URL: https://github.com/apache/flink-connector-mongodb/pull/41 [FLINK-36053][connectors/mongodb] Support multi-version integration test in mongodb connector -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] [FLINK-35935][table] Fix RTAS not supporting LIMIT [flink]

2024-08-14 Thread via GitHub
xuyangzhong commented on PR #25185: URL: https://github.com/apache/flink/pull/25185#issuecomment-2288685516 @lincoln-lil You're right. I have replaced all `limit` with `sort limit` in IT cases. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [FLINK-35993][table] Add the built-in function UNHEX [flink]

2024-08-14 Thread via GitHub
dylanhz commented on code in PR #25176: URL: https://github.com/apache/flink/pull/25176#discussion_r1716832479 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -1856,6 +1856,19 @@ ANY, and(logical(LogicalType

Re: [PR] [FLINK-35389][State/ForSt] Async list state [flink]

2024-08-14 Thread via GitHub
Zakelly commented on PR #25126: URL: https://github.com/apache/flink/pull/25126#issuecomment-2288595953 Conflicts resolved by rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [FLINK-35920][table] Add PRINTF function [flink]

2024-08-14 Thread via GitHub
lincoln-lil commented on code in PR #25133: URL: https://github.com/apache/flink/pull/25133#discussion_r1716809004 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -1244,6 +1244,19 @@ ANY, and(logical(Logical

Re: [PR] [FLINK-35937] RBAC cleanup [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
timsn commented on code in PR #857: URL: https://github.com/apache/flink-kubernetes-operator/pull/857#discussion_r1716816424 ## helm/flink-kubernetes-operator/templates/rbac.yaml: ## @@ -89,6 +81,7 @@ rules: - update - patch - delete + - deletecollecti

Re: [PR] [FLINK-35937] RBAC cleanup [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
timsn commented on code in PR #857: URL: https://github.com/apache/flink-kubernetes-operator/pull/857#discussion_r1716816424 ## helm/flink-kubernetes-operator/templates/rbac.yaml: ## @@ -89,6 +81,7 @@ rules: - update - patch - delete + - deletecollecti

Re: [PR] [FLINK-35993][table] Add the built-in function UNHEX [flink]

2024-08-14 Thread via GitHub
lincoln-lil commented on code in PR #25176: URL: https://github.com/apache/flink/pull/25176#discussion_r1716812157 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -1856,6 +1856,19 @@ ANY, and(logical(Logical

Re: [PR] [FLINK-35016] catalog changes for model resource [flink]

2024-08-14 Thread via GitHub
twalthr commented on code in PR #25036: URL: https://github.com/apache/flink/pull/25036#discussion_r1716774191 ## flink-python/pyflink/table/catalog.py: ## @@ -449,6 +449,101 @@ def drop_function(self, function_path: 'ObjectPath', ignore_if_not_exists: bool) """

Re: [PR] [FLINK-35937] RBAC cleanup [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
gyfora commented on code in PR #857: URL: https://github.com/apache/flink-kubernetes-operator/pull/857#discussion_r1716792135 ## helm/flink-kubernetes-operator/templates/rbac.yaml: ## @@ -89,6 +81,7 @@ rules: - update - patch - delete + - deletecollect

Re: [PR] [FLINK-35493][snapshot] Add historical cleanup for FlinkStateSnapshot CRs [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
gyfora commented on code in PR #860: URL: https://github.com/apache/flink-kubernetes-operator/pull/860#discussion_r1716790329 ## docs/layouts/shortcodes/generated/dynamic_section.html: ## @@ -8,6 +8,24 @@ + +kubernetes.operator.checkpoi

Re: [PR] [FLINK-35935][table] Fix RTAS not supporting LIMIT [flink]

2024-08-14 Thread via GitHub
lincoln-lil commented on PR #25185: URL: https://github.com/apache/flink/pull/25185#issuecomment-2288531176 @xuyangzhong So at least we can use a sort clause for batch tests to get the stable result? -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (FLINK-35265) Implement FlinkStateSnapshot custom resource

2024-08-14 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873506#comment-17873506 ] Gyula Fora commented on FLINK-35265: d10918c626c19964635a340fd99a627691fedf54 > Imp

Re: [PR] [FLINK-35265][snapshot] Create FlinkStateSnapshot in the namespace of job [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
gyfora merged PR #861: URL: https://github.com/apache/flink-kubernetes-operator/pull/861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [FLINK-35886][task] Fix watermark idleness timeout accounting when subtask is backpressured/blocked [flink]

2024-08-14 Thread via GitHub
rkhachatryan commented on code in PR #25167: URL: https://github.com/apache/flink/pull/25167#discussion_r1716779008 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/source/ProgressiveTimestampsAndWatermarks.java: ## @@ -273,6 +322,16 @@ void emitPer

Re: [PR] [FLINK-35993][table] Add the built-in function UNHEX [flink]

2024-08-14 Thread via GitHub
lincoln-lil commented on code in PR #25176: URL: https://github.com/apache/flink/pull/25176#discussion_r1716717356 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UnhexFunction.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apa

Re: [PR] [FLINK-35886][task] Fix watermark idleness timeout accounting when subtask is backpressured/blocked [flink]

2024-08-14 Thread via GitHub
pnowojski commented on code in PR #25167: URL: https://github.com/apache/flink/pull/25167#discussion_r1716724011 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/source/ProgressiveTimestampsAndWatermarks.java: ## @@ -273,6 +322,16 @@ void emitPeriod

Re: [PR] [FLINK-36031] [kubernetes-client] Migrate to Fabric8 interceptor API [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
SamBarker commented on code in PR #863: URL: https://github.com/apache/flink-kubernetes-operator/pull/863#discussion_r1716706322 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/metrics/KubernetesClientMetrics.java: ## @@ -118,32 +139,91 @@ public

Re: [PR] [FLINK-36031] [kubernetes-client] Migrate to Fabric8 interceptor API [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
mateczagany commented on PR #863: URL: https://github.com/apache/flink-kubernetes-operator/pull/863#issuecomment-2288422179 Also, if you run the command `mvn -B clean install javadoc:javadoc -Pgenerate-docs -DskipTests`, that will regenerate the Kubernetes CRDs for you. With the fabric8 up

Re: [PR] [FLINK-36039][autoscaler] Support clean historical event handler records in JDBC event handler [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
1996fanrui commented on PR #865: URL: https://github.com/apache/flink-kubernetes-operator/pull/865#issuecomment-2288420464 CI is failed, please take a look as well, thanks~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-36039][autoscaler] Support clean historical event handler records in JDBC event handler [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
1996fanrui commented on code in PR #865: URL: https://github.com/apache/flink-kubernetes-operator/pull/865#discussion_r1716685312 ## flink-autoscaler-plugin-jdbc/src/test/java/org/apache/flink/autoscaler/jdbc/event/AbstractJdbcAutoscalerEventHandlerITCase.java: ## @@ -430,6 +44

Re: [PR] [FLINK-36031] [kubernetes-client] Migrate to Fabric8 interceptor API [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
mateczagany commented on code in PR #863: URL: https://github.com/apache/flink-kubernetes-operator/pull/863#discussion_r1716694875 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/metrics/KubernetesClientMetrics.java: ## @@ -118,32 +139,91 @@ publ

[jira] [Updated] (FLINK-36056) change flink.connector.elasticsearch.version to a release version in branch release-3.2

2024-08-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36056: --- Labels: pull-request-available (was: ) > change flink.connector.elasticsearch.version to a

Re: [PR] [FLINK-36056] change flink.connector.elasticsearch.version to a release version [flink-cdc]

2024-08-14 Thread via GitHub
PatrickRen merged PR #3543: URL: https://github.com/apache/flink-cdc/pull/3543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [FLINK-35963][table] Add REGEXP_SUBSTR function [flink]

2024-08-14 Thread via GitHub
dylanhz commented on code in PR #25146: URL: https://github.com/apache/flink/pull/25146#discussion_r1716642861 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/RegexpSubstrFunction.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the

Re: [PR] [FLINK-35962][table] Add REGEXP_INSTR function [flink]

2024-08-14 Thread via GitHub
dylanhz commented on code in PR #25144: URL: https://github.com/apache/flink/pull/25144#discussion_r1716642672 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/RegexpInstrFunction.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-36039][autoscaler] Support clean historical event handler records in JDBC event handler [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
RocMarshal commented on code in PR #865: URL: https://github.com/apache/flink-kubernetes-operator/pull/865#discussion_r1716442200 ## flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/StandaloneAutoscalerExecutor.java: ## @@ -113,6 +113,8 @@ public

  1   2   >