snuyanzin commented on code in PR #25200:
URL: https://github.com/apache/flink/pull/25200#discussion_r1716954372
##########
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dql/SqlShowTables.java:
##########
@@ -101,10 +101,8 @@ public List<SqlNode> getOperandList() {
: Collections.singletonList(databaseName);
}
- public String[] fullDatabaseName() {
- return Objects.isNull(this.databaseName)
- ? new String[] {}
Review Comment:
probably it's better to reuse lists rather than create arrays per call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
