dylanhz commented on code in PR #25176:
URL: https://github.com/apache/flink/pull/25176#discussion_r1717787895
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/EncodingUtils.java:
##########
@@ -187,6 +187,33 @@ public static String hex(byte[] bytes) {
return new String(hexChars);
}
+ /**
+ * Inspired from {@link EncodingUtils#decodeHex(String)}, but returns null
instead of throwing
Review Comment:
Should we keep consistent with existed method `hex`, as with the built-in
functions `HEX` and `UNHEX`?
And maybe we can create a function `unhex(byte[] bytes, boolean
throwOnFailure)` to call both implementations and change the signature of
`decodeHex` to `byte[]`, because in the original implementation `String` is
also converted to a char array for calling. This also ensures performance for
`BinaryStringData`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
