Re: [PR] [FLINK-32084][checkpoint] Migrate current file merging of channel state snapshot into the unify file merging framework [flink]

2024-05-08 Thread via GitHub
Zakelly commented on code in PR #24653: URL: https://github.com/apache/flink/pull/24653#discussion_r1595029937 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java: ## @@ -483,27 +485,54 @@ protected StreamTask( }

Re: [PR] [FLINK-32084][checkpoint] Migrate current file merging of channel state snapshot into the unify file merging framework [flink]

2024-05-08 Thread via GitHub
Zakelly commented on PR #24653: URL: https://github.com/apache/flink/pull/24653#issuecomment-2102053717 > When passing `CheckpointStorageWorkerView` directly to `ChannelStateWriteRequestDispatcher`, `UnalignedCheckpointRescaleITCase` might throw exceptions when the task exits. > > Th

[jira] [Updated] (FLINK-35316) Add CDC e2e test case for on Flink 1.19

2024-05-08 Thread yux (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yux updated FLINK-35316: Priority: Minor (was: Major) > Add CDC e2e test case for on Flink 1.19 > ---

[jira] [Updated] (FLINK-35316) Add CDC e2e test case for on Flink 1.19

2024-05-08 Thread yux (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yux updated FLINK-35316: Issue Type: Improvement (was: Bug) > Add CDC e2e test case for on Flink 1.19 > --

Re: [PR] [FLINK-35030][runtime] Introduce Epoch Manager under async execution [flink]

2024-05-08 Thread via GitHub
fredia commented on code in PR #24748: URL: https://github.com/apache/flink/pull/24748#discussion_r1595026752 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AbstractEpochManager.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] [FLINK-35281][hotfix][cdc-common] FlinkEnvironmentUtils#addJar add each jar only once [flink-cdc]

2024-05-08 Thread via GitHub
loserwang1024 commented on code in PR #3301: URL: https://github.com/apache/flink-cdc/pull/3301#discussion_r1595022843 ## flink-cdc-composer/src/main/java/org/apache/flink/cdc/composer/flink/FlinkEnvironmentUtils.java: ## @@ -22,29 +22,48 @@ import org.apache.flink.configuratio

[jira] [Updated] (FLINK-35318) incorrect timezone handling for TIMESTAMP_WITH_LOCAL_TIME_ZONE type during predicate pushdown

2024-05-08 Thread linshangquan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] linshangquan updated FLINK-35318: - Description: In our scenario, we have an Iceberg table that contains a column named 'time' of t

[jira] [Updated] (FLINK-35318) incorrect timezone handling for TIMESTAMP_WITH_LOCAL_TIME_ZONE type during predicate pushdown

2024-05-08 Thread linshangquan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] linshangquan updated FLINK-35318: - Attachment: image-2024-05-09-14-22-59-370.png > incorrect timezone handling for TIMESTAMP_WITH_L

[jira] [Updated] (FLINK-35318) incorrect timezone handling for TIMESTAMP_WITH_LOCAL_TIME_ZONE type during predicate pushdown

2024-05-08 Thread linshangquan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] linshangquan updated FLINK-35318: - Attachment: image-2024-05-09-14-22-14-417.png > incorrect timezone handling for TIMESTAMP_WITH_L

[jira] [Updated] (FLINK-35318) incorrect timezone handling for TIMESTAMP_WITH_LOCAL_TIME_ZONE type during predicate pushdown

2024-05-08 Thread linshangquan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] linshangquan updated FLINK-35318: - Description: In our scenario, we have an Iceberg table that contains a column named 'time' of t

[jira] [Created] (FLINK-35318) incorrect timezone handling for TIMESTAMP_WITH_LOCAL_TIME_ZONE type during predicate pushdown

2024-05-08 Thread linshangquan (Jira)
linshangquan created FLINK-35318: Summary: incorrect timezone handling for TIMESTAMP_WITH_LOCAL_TIME_ZONE type during predicate pushdown Key: FLINK-35318 URL: https://issues.apache.org/jira/browse/FLINK-35318

[jira] [Created] (FLINK-35317) Flink CDC CLI Supports submitting multiple YAML job at once

2024-05-08 Thread yux (Jira)
yux created FLINK-35317: --- Summary: Flink CDC CLI Supports submitting multiple YAML job at once Key: FLINK-35317 URL: https://issues.apache.org/jira/browse/FLINK-35317 Project: Flink Issue Type: Improv

[jira] [Commented] (FLINK-35313) Add upsert changelog mode to avoid UPDATE_BEFORE records push down

2024-05-08 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844872#comment-17844872 ] Hongshun Wang commented on FLINK-35313: --- I don't understand whether we need to do

[jira] [Created] (FLINK-35316) Add CDC e2e test case for on Flink 1.19

2024-05-08 Thread yux (Jira)
yux created FLINK-35316: --- Summary: Add CDC e2e test case for on Flink 1.19 Key: FLINK-35316 URL: https://issues.apache.org/jira/browse/FLINK-35316 Project: Flink Issue Type: Bug Components: F

Re: [PR] [FLINK-35293][hive] Hive source supports dynamic parallelism inference [flink]

2024-05-08 Thread via GitHub
SinBex commented on PR #24764: URL: https://github.com/apache/flink/pull/24764#issuecomment-2101999082 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[jira] [Updated] (FLINK-35315) MemoryManagerConcurrentModReleaseTest executes more than 15 minutes

2024-05-08 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-35315: Fix Version/s: 1.20.0 > MemoryManagerConcurrentModReleaseTest executes more than 15 minutes >

[jira] [Created] (FLINK-35315) MemoryManagerConcurrentModReleaseTest executes more than 15 minutes

2024-05-08 Thread Rui Fan (Jira)
Rui Fan created FLINK-35315: --- Summary: MemoryManagerConcurrentModReleaseTest executes more than 15 minutes Key: FLINK-35315 URL: https://issues.apache.org/jira/browse/FLINK-35315 Project: Flink Is

Re: [PR] [FLINK-32084][checkpoint] Migrate current file merging of channel state snapshot into the unify file merging framework [flink]

2024-05-08 Thread via GitHub
1996fanrui commented on code in PR #24653: URL: https://github.com/apache/flink/pull/24653#discussion_r1594926835 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCheckpointStorageAccess.java: ## @@ -232,7 +232,9 @@ public FsMergingCheckpointStorageAcce

Re: [PR] [FLINK-34212][autoscaler] Autoscaler Standalone cleans up stopped jobs to prevent memory leaks [flink-kubernetes-operator]

2024-05-08 Thread via GitHub
1996fanrui commented on code in PR #824: URL: https://github.com/apache/flink-kubernetes-operator/pull/824#discussion_r1594925851 ## flink-autoscaler-standalone/src/test/java/org/apache/flink/autoscaler/standalone/StandaloneAutoscalerExecutorTest.java: ## @@ -227,6 +229,160 @@

Re: [PR] [FLINK-32084][checkpoint] Migrate current file merging of channel state snapshot into the unify file merging framework [flink]

2024-05-08 Thread via GitHub
fredia commented on code in PR #24653: URL: https://github.com/apache/flink/pull/24653#discussion_r1594925847 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCheckpointStorageAccess.java: ## @@ -232,7 +232,9 @@ public FsMergingCheckpointStorageAccess

Re: [PR] [FLINK-35293][hive] Hive source supports dynamic parallelism inference [flink]

2024-05-08 Thread via GitHub
flinkbot commented on PR #24764: URL: https://github.com/apache/flink/pull/24764#issuecomment-2101872572 ## CI report: * 263d2baa4e11fc1c11fb0efcec298ba5c79e8b4a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35293][hive] Hive source supports dynamic parallelism inference [flink]

2024-05-08 Thread via GitHub
SinBex commented on PR #24764: URL: https://github.com/apache/flink/pull/24764#issuecomment-2101871143 @zhuzhurk Could you please help to review this pr in your free time? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[jira] [Created] (FLINK-35314) Add Flink CDC pipeline transform user document

2024-05-08 Thread Wenkai Qi (Jira)
Wenkai Qi created FLINK-35314: - Summary: Add Flink CDC pipeline transform user document Key: FLINK-35314 URL: https://issues.apache.org/jira/browse/FLINK-35314 Project: Flink Issue Type: New Feat

[jira] [Updated] (FLINK-35293) FLIP-445: Support dynamic parallelism inference for HiveSource

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35293: --- Labels: pull-request-available (was: ) > FLIP-445: Support dynamic parallelism inference fo

[PR] [FLINK-35293][hive] Hive source supports dynamic parallelism inference [flink]

2024-05-08 Thread via GitHub
SinBex opened a new pull request, #24764: URL: https://github.com/apache/flink/pull/24764 ## What is the purpose of the change [FLIP-379](https://cwiki.apache.org/confluence/display/FLINK/FLIP-379%3A+Dynamic+source+parallelism+inference+for+batch+jobs) introduces dynamic source paral

[jira] [Closed] (FLINK-35270) Enrich information in logs, making it easier for debugging

2024-05-08 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-35270. --- Resolution: Fixed 547e4b53ebe36c39066adcf3a98123a1f7890c15 > Enrich information in logs, making it easier f

Re: [PR] [FLINK-35270]Enrich information in logs, making it easier for debugging [flink]

2024-05-08 Thread via GitHub
zhuzhurk merged PR #24747: URL: https://github.com/apache/flink/pull/24747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Assigned] (FLINK-35270) Enrich information in logs, making it easier for debugging

2024-05-08 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-35270: --- Assignee: Haifei Chen > Enrich information in logs, making it easier for debugging > --

[jira] [Updated] (FLINK-35270) Enrich information in logs, making it easier for debugging

2024-05-08 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-35270: Component/s: API / Core > Enrich information in logs, making it easier for debugging > ---

[jira] [Updated] (FLINK-35270) Enrich information in logs, making it easier for debugging

2024-05-08 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-35270: Labels: pull-request-available starter (was: pull-request-available) > Enrich information in logs, making

[jira] [Updated] (FLINK-35270) Enrich information in logs, making it easier for debugging

2024-05-08 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-35270: Fix Version/s: 1.20.0 > Enrich information in logs, making it easier for debugging > -

[jira] [Comment Edited] (FLINK-35313) Add upsert changelog mode to avoid UPDATE_BEFORE records push down

2024-05-08 Thread JJJJude (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844843#comment-17844843 ] ude edited comment on FLINK-35313 at 5/9/24 3:14 AM: - migrat

[jira] [Commented] (FLINK-35313) Add upsert changelog mode to avoid UPDATE_BEFORE records push down

2024-05-08 Thread JJJJude (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844843#comment-17844843 ] ude commented on FLINK-35313: - migrate from[ https://github.com/apache/flink-cdc/is

[jira] [Created] (FLINK-35313) Add upsert changelog mode to avoid UPDATE_BEFORE records push down

2024-05-08 Thread JJJJude (Jira)
ude created FLINK-35313: --- Summary: Add upsert changelog mode to avoid UPDATE_BEFORE records push down Key: FLINK-35313 URL: https://issues.apache.org/jira/browse/FLINK-35313 Project: Flink Iss

Re: [PR] [FLINK-35164][table] Support `ALTER CATALOG RESET` syntax [flink]

2024-05-08 Thread via GitHub
liyubin117 commented on PR #24763: URL: https://github.com/apache/flink/pull/24763#issuecomment-2101830016 @LadyForest Hi, I have finished the feature, Looking forward to your review, thanks :) -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [FLINK-34212][autoscaler] Autoscaler Standalone cleans up stopped jobs to prevent memory leaks [flink-kubernetes-operator]

2024-05-08 Thread via GitHub
RocMarshal commented on code in PR #824: URL: https://github.com/apache/flink-kubernetes-operator/pull/824#discussion_r1594866016 ## flink-autoscaler-standalone/src/test/java/org/apache/flink/autoscaler/standalone/StandaloneAutoscalerExecutorTest.java: ## @@ -227,6 +229,160 @@

Re: [PR] [FLINK-35164][table] Support `ALTER CATALOG RESET` syntax [flink]

2024-05-08 Thread via GitHub
flinkbot commented on PR #24763: URL: https://github.com/apache/flink/pull/24763#issuecomment-2101826274 ## CI report: * 4ff585eb2e42856f6cf6d76e5ff4ac39937d99b2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-35040) The performance of serializerHeavyString regresses since April 3

2024-05-08 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-35040: Attachment: (was: result5.html) > The performance of serializerHeavyString regresses since April 3 > -

[jira] [Updated] (FLINK-35040) The performance of serializerHeavyString regresses since April 3

2024-05-08 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-35040: Attachment: (was: result6.html) > The performance of serializerHeavyString regresses since April 3 > -

[jira] [Updated] (FLINK-35040) The performance of serializerHeavyString regresses since April 3

2024-05-08 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-35040: Attachment: (was: result4.html) > The performance of serializerHeavyString regresses since April 3 > -

[jira] [Updated] (FLINK-35040) The performance of serializerHeavyString regresses since April 3

2024-05-08 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-35040: Attachment: (was: result2.html) > The performance of serializerHeavyString regresses since April 3 > -

[jira] [Updated] (FLINK-35040) The performance of serializerHeavyString regresses since April 3

2024-05-08 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-35040: Attachment: (was: result3.html) > The performance of serializerHeavyString regresses since April 3 > -

[jira] [Updated] (FLINK-35040) The performance of serializerHeavyString regresses since April 3

2024-05-08 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-35040: Attachment: (was: result1.html) > The performance of serializerHeavyString regresses since April 3 > -

[jira] [Updated] (FLINK-35164) Support `ALTER CATALOG RESET` syntax

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35164: --- Labels: pull-request-available (was: ) > Support `ALTER CATALOG RESET` syntax > ---

[PR] [FLINK-35164][table] Support `ALTER CATALOG RESET` syntax [flink]

2024-05-08 Thread via GitHub
liyubin117 opened a new pull request, #24763: URL: https://github.com/apache/flink/pull/24763 ## What is the purpose of the change Reset one or more properties to its default value in the specified catalog. ## Brief change log * ALTER CATALOG catalog_name SET (key1=val1,

[jira] [Updated] (FLINK-35040) The performance of serializerHeavyString regresses since April 3

2024-05-08 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-35040: Attachment: result4.html result5.html result1.html result2.

[jira] [Resolved] (FLINK-34916) Support `ALTER CATALOG SET` syntax

2024-05-08 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan resolved FLINK-34916. --- Fix Version/s: 1.20.0 Resolution: Fixed Fixed in master 4611817591c38019c27ffad6d8cdc68292f07

[jira] [Closed] (FLINK-34916) Support `ALTER CATALOG SET` syntax

2024-05-08 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan closed FLINK-34916. - > Support `ALTER CATALOG SET` syntax > -- > > Key: FLINK-349

Re: [PR] [FLINK-34916][table] Support `ALTER CATALOG SET` syntax [flink]

2024-05-08 Thread via GitHub
LadyForest merged PR #24735: URL: https://github.com/apache/flink/pull/24735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[jira] [Commented] (FLINK-35312) Insufficient number of arguments were supplied for the procedure or function cdc.fn_cdc_get_all_changes_

2024-05-08 Thread vmaster.cc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844837#comment-17844837 ] vmaster.cc commented on FLINK-35312: > An exception occurred in the change event pro

Re: [PR] [FLINK-35149][cdc-composer] Fix DataSinkTranslator#sinkTo ignoring pre-write topology if not TwoPhaseCommittingSink [flink-cdc]

2024-05-08 Thread via GitHub
loserwang1024 commented on code in PR #3233: URL: https://github.com/apache/flink-cdc/pull/3233#discussion_r1594884935 ## flink-cdc-composer/src/main/java/org/apache/flink/cdc/composer/flink/translator/DataSinkTranslator.java: ## @@ -71,7 +72,9 @@ public void translate(

[jira] [Created] (FLINK-35312) Insufficient number of arguments were supplied for the procedure or function cdc.fn_cdc_get_all_changes_

2024-05-08 Thread yux (Jira)
yux created FLINK-35312: --- Summary: Insufficient number of arguments were supplied for the procedure or function cdc.fn_cdc_get_all_changes_ Key: FLINK-35312 URL: https://issues.apache.org/jira/browse/FLINK-35312

Re: [PR] [FLINK-32084][checkpoint] Migrate current file merging of channel state snapshot into the unify file merging framework [flink]

2024-05-08 Thread via GitHub
1996fanrui commented on code in PR #24653: URL: https://github.com/apache/flink/pull/24653#discussion_r1594880568 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCheckpointStorageAccess.java: ## @@ -232,7 +232,9 @@ public FsMergingCheckpointStorageAcce

Re: [PR] [FLINK-35149][cdc-composer] Fix DataSinkTranslator#sinkTo ignoring pre-write topology if not TwoPhaseCommittingSink [flink-cdc]

2024-05-08 Thread via GitHub
loserwang1024 commented on code in PR #3233: URL: https://github.com/apache/flink-cdc/pull/3233#discussion_r1594878296 ## flink-cdc-composer/src/test/java/org/apache/flink/cdc/composer/flink/translator/DataSinkTranslatorTest.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apac

Re: [PR] [FLINK-32084][checkpoint] Migrate current file merging of channel state snapshot into the unify file merging framework [flink]

2024-05-08 Thread via GitHub
1996fanrui commented on code in PR #24653: URL: https://github.com/apache/flink/pull/24653#discussion_r1594875205 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCheckpointStorageAccess.java: ## @@ -232,7 +232,9 @@ public FsMergingCheckpointStorageAcce

Re: [PR] [FLINK-35291] Improve the ROW data deserialization performance of DebeziumEventDeserializationScheme [flink-cdc]

2024-05-08 Thread via GitHub
lzshlzsh commented on PR #3289: URL: https://github.com/apache/flink-cdc/pull/3289#issuecomment-2101795518 @ruanhang1993 Would you help have a look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Resolved] (FLINK-33463) Support the implementation of dynamic source tables based on the new source

2024-05-08 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-33463. - Fix Version/s: jdbc-3.3.0 Resolution: Fixed > Support the implementation of dynamic source tables

[jira] [Commented] (FLINK-33463) Support the implementation of dynamic source tables based on the new source

2024-05-08 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844836#comment-17844836 ] Rui Fan commented on FLINK-33463: - Merged to main(3.3.0) via: * bde28e6a92ffa75ae45bc8d

Re: [PR] [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source [flink-connector-jdbc]

2024-05-08 Thread via GitHub
1996fanrui merged PR #117: URL: https://github.com/apache/flink-connector-jdbc/pull/117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

Re: [PR] [FLINK-34212][autoscaler] Autoscaler Standalone cleans up stopped jobs to prevent memory leaks [flink-kubernetes-operator]

2024-05-08 Thread via GitHub
RocMarshal commented on code in PR #824: URL: https://github.com/apache/flink-kubernetes-operator/pull/824#discussion_r1594866016 ## flink-autoscaler-standalone/src/test/java/org/apache/flink/autoscaler/standalone/StandaloneAutoscalerExecutorTest.java: ## @@ -227,6 +229,160 @@

Re: [PR] [mysql-cdc] Add upsert changelog mode to avoid UPDATE_BEFORE records … [flink-cdc]

2024-05-08 Thread via GitHub
yuxiqian commented on PR #1907: URL: https://github.com/apache/flink-cdc/pull/1907#issuecomment-2101764510 Hi @yeezychao, seems MySQL CI job is failing, could you please take a look? https://github.com/apache/flink-cdc/actions/runs/8844257194/job/24756979040?pr=1907 (The markdown lint

[jira] [Closed] (FLINK-35232) Support for retry settings on GCS connector

2024-05-08 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-35232. Fix Version/s: 1.20.0 Resolution: Done master (1.20): f2c0c3ddcdd78c1e2876087139e56534fe3f8

[jira] [Updated] (FLINK-35232) Support for retry settings on GCS connector

2024-05-08 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song updated FLINK-35232: - Affects Version/s: (was: 1.15.3) (was: 1.16.2)

Re: [PR] [FLINK-35232] Add retry settings for GCS connector [flink]

2024-05-08 Thread via GitHub
xintongsong closed pull request #24753: [FLINK-35232] Add retry settings for GCS connector URL: https://github.com/apache/flink/pull/24753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[PR] Module 1 labs - Enrichment and Filtering [flink-training]

2024-05-08 Thread via GitHub
manoellins opened a new pull request, #80: URL: https://github.com/apache/flink-training/pull/80 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] [FLINK-33759] [flink-parquet] Add support for nested array with row type [flink]

2024-05-08 Thread via GitHub
ukby1234 commented on PR #24029: URL: https://github.com/apache/flink/pull/24029#issuecomment-2101240856 Yes I would love to have review/test on this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] [BP-1.18][FLINK-34324][ci] Replaces AWS-based S3 e2e tests with Minio-backed version [flink]

2024-05-08 Thread via GitHub
XComp commented on PR #24604: URL: https://github.com/apache/flink/pull/24604#issuecomment-2101181186 I verified that the Minio-based and non-s3 tests ran in CI ([#1](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=58725&view=logs&j=af184cdd-c6d8-5084-0b69-7e9c67b35f7a

Re: [PR] [BP-1.19][FLINK-34324][ci] Replaces AWS-based S3 e2e tests with Minio-backed version [flink]

2024-05-08 Thread via GitHub
XComp commented on PR #24605: URL: https://github.com/apache/flink/pull/24605#issuecomment-2101172459 I verified that the Minio-based and non-s3 tests ran in CI ([#1](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=58726&view=logs&j=af184cdd-c6d8-5084-0b69-7e9c67b35f7a

Re: [PR] [FLINK-33759] [flink-parquet] Add support for nested array with row type [flink]

2024-05-08 Thread via GitHub
ViktorCosenza commented on PR #24029: URL: https://github.com/apache/flink/pull/24029#issuecomment-2101016302 Hi, we're having this exact issue in our team and found this PR fixing it, is there a expected timeframe for this to be merged? If any help is needed to test/review this I'm happy

Re: [PR] Lab 1 with filtering and enrichment [flink-training]

2024-05-08 Thread via GitHub
manoellins closed pull request #79: Lab 1 with filtering and enrichment URL: https://github.com/apache/flink-training/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-33759] flink parquet writer support write nested array or map type [flink]

2024-05-08 Thread via GitHub
ViktorCosenza commented on PR #23881: URL: https://github.com/apache/flink/pull/23881#issuecomment-2100970888 Hi, I'm having a issue directly related to the empty "write" methods when trying to write a Parquet with an array of row. I've noticed you fixed the issue for the Map and Arra

Re: [PR] [FLINK-33212][runtime] add job status changed listener for lineage [flink]

2024-05-08 Thread via GitHub
gyfora commented on code in PR #24754: URL: https://github.com/apache/flink/pull/24754#discussion_r1594287283 ## flink-clients/src/main/java/org/apache/flink/client/program/MiniClusterClient.java: ## @@ -74,7 +75,7 @@ public Configuration getFlinkConfiguration() { }

Re: [PR] [FLINK-35270]Enrich information in logs, making it easier for debugging [flink]

2024-05-08 Thread via GitHub
HCTommy commented on PR #24747: URL: https://github.com/apache/flink/pull/24747#issuecomment-2100853984 Hi @zhuzhurk , kooking for your review again. Tkanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Created] (FLINK-35311) FLIP-454: New Apicurio Avro format

2024-05-08 Thread david radley (Jira)
david radley created FLINK-35311: Summary: FLIP-454: New Apicurio Avro format Key: FLINK-35311 URL: https://issues.apache.org/jira/browse/FLINK-35311 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-35310) Replace RBAC verb wildcards with actual verbs

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35310: --- Labels: pull-request-available (was: ) > Replace RBAC verb wildcards with actual verbs > --

[PR] [FLINK-35310] Replace RBAC verb wildcards with actual verbs [flink-kubernetes-operator]

2024-05-08 Thread via GitHub
timsn opened a new pull request, #826: URL: https://github.com/apache/flink-kubernetes-operator/pull/826 ## What is the purpose of the change Replace all wildcards in the RBAC HELM template of the flink-operator with it's proper verb names. ## Brief change log

[jira] [Created] (FLINK-35310) Replace RBAC verb wildcards with actual verbs

2024-05-08 Thread Tim (Jira)
Tim created FLINK-35310: --- Summary: Replace RBAC verb wildcards with actual verbs Key: FLINK-35310 URL: https://issues.apache.org/jira/browse/FLINK-35310 Project: Flink Issue Type: Improvement

Re: [PR] [FLINK-35198][table] Support the execution of refresh materialized table [flink]

2024-05-08 Thread via GitHub
xuyangzhong commented on code in PR #24760: URL: https://github.com/apache/flink/pull/24760#discussion_r1594070565 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManager.java: ## @@ -169,6 +181,83 @@ priva

Re: [PR] [FLINK-35198][table] Support the execution of refresh materialized table [flink]

2024-05-08 Thread via GitHub
xuyangzhong commented on code in PR #24760: URL: https://github.com/apache/flink/pull/24760#discussion_r1594064792 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManager.java: ## @@ -169,6 +181,83 @@ priva

[jira] [Commented] (FLINK-35215) The performance of serializerKryo and serializerKryoWithoutRegistration are regressed

2024-05-08 Thread Kenneth William Krugler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844662#comment-17844662 ] Kenneth William Krugler commented on FLINK-35215: - Hi [~fanrui] - I adde

Re: [PR] [FLINK-35215][core] Fix the bug when Kryo serialize length is 0 [flink]

2024-05-08 Thread via GitHub
kkrugler commented on PR #24717: URL: https://github.com/apache/flink/pull/24717#issuecomment-2100600574 I'm leaving in 2 days for a 4+ month backpack trip (hiking the PCT), otherwise what I'd do is try to hook up a test that uses JMH to accurately assess the impact of the change. To respon

Re: [PR] [FLINK-27741][table-planner] Fix NPE when use dense_rank() and rank()… [flink]

2024-05-08 Thread via GitHub
snuyanzin commented on PR #19797: URL: https://github.com/apache/flink/pull/19797#issuecomment-2100597095 @chenzihao5 thanks for your contribution and sorry for the late reply May i ask you to rebase and then we can make another review iteration? -- This is an automated message f

[jira] [Updated] (FLINK-35198) Support the execution of refresh materialized table

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35198: --- Labels: pull-request-available (was: ) > Support the execution of refresh materialized tabl

Re: [PR] [FLINK-35198][table] Support the execution of refresh materialized table [flink]

2024-05-08 Thread via GitHub
xuyangzhong commented on code in PR #24760: URL: https://github.com/apache/flink/pull/24760#discussion_r1594018523 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlAlterMaterializedTableRefresh.java: ## @@ -58,4 +58,9 @@ public void unparse(SqlWri

[jira] [Commented] (FLINK-35199) Support the execution of create materialized table in full refresh mode

2024-05-08 Thread Yubin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844652#comment-17844652 ] Yubin Li commented on FLINK-35199: -- [~lsy] Hi, This indeed is a valuable feature, Could

Re: [PR] Custom delta ingress embedded [flink-statefun]

2024-05-08 Thread via GitHub
mohammadmahdihn closed pull request #342: Custom delta ingress embedded URL: https://github.com/apache/flink-statefun/pull/342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FLINK-35149][cdc-composer] Fix DataSinkTranslator#sinkTo ignoring pre-write topology if not TwoPhaseCommittingSink [flink-cdc]

2024-05-08 Thread via GitHub
pvary commented on code in PR #3233: URL: https://github.com/apache/flink-cdc/pull/3233#discussion_r1593954989 ## flink-cdc-composer/src/test/java/org/apache/flink/cdc/composer/flink/translator/DataSinkTranslatorTest.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Softw

Re: [PR] [FLINK-35149][cdc-composer] Fix DataSinkTranslator#sinkTo ignoring pre-write topology if not TwoPhaseCommittingSink [flink-cdc]

2024-05-08 Thread via GitHub
pvary commented on code in PR #3233: URL: https://github.com/apache/flink-cdc/pull/3233#discussion_r1593952991 ## flink-cdc-composer/src/test/java/org/apache/flink/cdc/composer/flink/translator/DataSinkTranslatorTest.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Softw

Re: [PR] [FLINK-35149][cdc-composer] Fix DataSinkTranslator#sinkTo ignoring pre-write topology if not TwoPhaseCommittingSink [flink-cdc]

2024-05-08 Thread via GitHub
pvary commented on code in PR #3233: URL: https://github.com/apache/flink-cdc/pull/3233#discussion_r1593951427 ## flink-cdc-composer/src/main/java/org/apache/flink/cdc/composer/flink/translator/DataSinkTranslator.java: ## @@ -71,7 +72,9 @@ public void translate( }

[jira] [Commented] (FLINK-35158) Error handling in StateFuture's callback

2024-05-08 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844638#comment-17844638 ] Yanfei Lei commented on FLINK-35158: pr [24698|https://github.com/apache/flink/pull/

[jira] [Resolved] (FLINK-35158) Error handling in StateFuture's callback

2024-05-08 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanfei Lei resolved FLINK-35158. Resolution: Resolved > Error handling in StateFuture's callback >

Re: [PR] [FLINK-35112][python] Fix membership for Row class PyFlink [flink]

2024-05-08 Thread via GitHub
wzorgdrager commented on code in PR #24756: URL: https://github.com/apache/flink/pull/24756#discussion_r1593928221 ## flink-python/pyflink/common/types.py: ## @@ -177,7 +177,10 @@ def of_kind(row_kind: RowKind, *args, **kwargs): return row def __contains__(self,

Re: [PR] [FLINK-35158][runtime] Error handling in StateFuture's callback [flink]

2024-05-08 Thread via GitHub
fredia closed pull request #24698: [FLINK-35158][runtime] Error handling in StateFuture's callback URL: https://github.com/apache/flink/pull/24698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-34549][API] Introduce config, context and processingTimerService for DataStream API V2 [flink]

2024-05-08 Thread via GitHub
xintongsong commented on code in PR #24541: URL: https://github.com/apache/flink/pull/24541#discussion_r1593914163 ## flink-datastream-api/src/main/java/org/apache/flink/datastream/api/context/NonPartitionedRuntimeContext.java: ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-35302][rest] Ignore unknown fields in REST request deserialization [flink]

2024-05-08 Thread via GitHub
gaborgsomogyi commented on PR #24759: URL: https://github.com/apache/flink/pull/24759#issuecomment-2100398349 If there are no further comments then merging it in 2 days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-32084][checkpoint] Migrate current file merging of channel state snapshot into the unify file merging framework [flink]

2024-05-08 Thread via GitHub
fredia commented on PR #24653: URL: https://github.com/apache/flink/pull/24653#issuecomment-2100331363 When passing `CheckpointStorageWorkerView` directly to `ChannelStateWriteRequestDispatcher`, `checkpointStorage` `UnalignedCheckpointRescaleITCase` might throw exceptions when the task ex

Re: [PR] [FLINK-32087][checkpoint] Introduce space amplification statistics of file merging [flink]

2024-05-08 Thread via GitHub
Zakelly commented on code in PR #24762: URL: https://github.com/apache/flink/pull/24762#discussion_r1593698417 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManager.java: ## @@ -268,4 +269,78 @@ public String toString() {

Re: [PR] [FLINK-35243][cdc] Support table schema change events & PreSchema backfill [flink-cdc]

2024-05-08 Thread via GitHub
yuxiqian commented on PR #3296: URL: https://github.com/apache/flink-cdc/pull/3296#issuecomment-2100267362 @PatrickRen @ruanhang1993 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source [flink-connector-jdbc]

2024-05-08 Thread via GitHub
RocMarshal commented on code in PR #117: URL: https://github.com/apache/flink-connector-jdbc/pull/117#discussion_r1593792023 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactoryTest.java: ## @@ -144,7 +146,8 @@ void testJdbcReadPro

[jira] [Updated] (FLINK-35309) Enable Notice file ci check and fix Notice

2024-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35309: --- Labels: pull-request-available (was: ) > Enable Notice file ci check and fix Notice >

  1   2   >