Zakelly commented on code in PR #24653:
URL: https://github.com/apache/flink/pull/24653#discussion_r1595029937


##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java:
##########
@@ -483,27 +485,54 @@ protected StreamTask(
             }
 
             this.systemTimerService = createTimerService("System Time Trigger 
for " + getName());
-
+            final CheckpointStorageAccess finalCheckpointStorageAccess = 
checkpointStorageAccess;
+
+            ChannelStateWriter channelStateWriter =
+                    configuration.isUnalignedCheckpointsEnabled()
+                            ? openChannelStateWriter(
+                                    getName(),
+                                    // Note: don't pass 
checkpointStorageAccess directly to channel
+                                    // state writer.
+                                    // The fileSystem of 
checkpointStorageAccess may be an instance
+                                    // of SafetyNetWrapperFileSystem, which 
close all held streams
+                                    // when thread exits. Chanel state writers 
are invoked in other

Review Comment:
   ```suggestion
                                       // when thread exits. Channel state 
writers are invoked in other
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to