1996fanrui commented on code in PR #24653:
URL: https://github.com/apache/flink/pull/24653#discussion_r1594926835
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCheckpointStorageAccess.java:
##########
@@ -232,7 +232,9 @@ public FsMergingCheckpointStorageAccess
toFileMergingStorage(
FileMergingSnapshotManager mergingSnapshotManager, Environment
environment)
throws IOException {
return new FsMergingCheckpointStorageAccess(
- fileSystem,
+ /* Multiple subtask/threads would share one output stream,
+ SafetyNetWrapperFileSystem cannot be used to prevent different
threads from interfering with each other when exiting. */
+
FileSystem.getUnguardedFileSystem(checkpointsDirectory.toUri()),
Review Comment:
> FileMergingSnapshotManager takes this responsibility,
FileMergingSnapshotManager would close all held physical files and streams when
the task executor close/shutdown.
Sorry, I'm not familiar with `FileMergingSnapshotManager`, thanks for the
clarification. Sounds good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
