[GitHub] [flink] flinkbot commented on pull request #23277: [BP-1.16][FLINK-32869][e2e] Fix Kubernetes tests on aarch64

2023-08-23 Thread via GitHub
flinkbot commented on PR #23277: URL: https://github.com/apache/flink/pull/23277#issuecomment-1691114511 ## CI report: * edb428113d1c7174908271002570f79f5b80b6f7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #23276: [BP-1.17][FLINK-32869][e2e] Fix Kubernetes tests on aarch64

2023-08-23 Thread via GitHub
flinkbot commented on PR #23276: URL: https://github.com/apache/flink/pull/23276#issuecomment-1691114369 ## CI report: * 8dd5583924a4551676e8b1f8af85cbf0161dcc80 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #23275: [BP-1.18][FLINK-32869][e2e] Fix Kubernetes tests on aarch64

2023-08-23 Thread via GitHub
flinkbot commented on PR #23275: URL: https://github.com/apache/flink/pull/23275#issuecomment-1691114214 ## CI report: * df5b2272c9674b2b34905c93fa9c0a2630257ba3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #250: [FLINK-32810] Improve memory allocation in ListStateWithCache

2023-08-23 Thread via GitHub
jiangxin369 commented on code in PR #250: URL: https://github.com/apache/flink-ml/pull/250#discussion_r1303885405 ## flink-ml-iteration/flink-ml-iteration-common/src/main/java/org/apache/flink/iteration/datacache/nonkeyed/ListStateWithCache.java: ## @@ -95,13 +92,18 @@ public Li

[jira] [Commented] (FLINK-32296) Flink SQL handle array of row incorrectly

2023-08-23 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758396#comment-17758396 ] Sergey Nuyanzin commented on FLINK-32296: - 1.18: [8715f0a1e8c3bb6595d26c69ef4ef

[jira] [Updated] (FLINK-32296) Flink SQL handle array of row incorrectly

2023-08-23 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-32296: Fix Version/s: 1.18.0 > Flink SQL handle array of row incorrectly > --

[GitHub] [flink] mimaomao commented on pull request #23235: [FLINK-32869][e2e] Fix Kubernetes tests on aarch64

2023-08-23 Thread via GitHub
mimaomao commented on PR #23235: URL: https://github.com/apache/flink/pull/23235#issuecomment-1691107067 Thanks for the instructions! I have created another three separate PRs for 1.18, 1.17, 1.16 as the following: * https://github.com/apache/flink/pull/23275 * https://github.com/apach

[GitHub] [flink] mimaomao opened a new pull request, #23276: [FLINK-32869][e2e] Fix Kubernetes tests on aarch64

2023-08-23 Thread via GitHub
mimaomao opened a new pull request, #23276: URL: https://github.com/apache/flink/pull/23276 ## What is the purpose of the change See https://github.com/apache/flink/pull/23235. This is backport for 1.17. -- This is an automated message from the Apache Git Service. To res

[GitHub] [flink] snuyanzin merged pull request #23273: [BP-1.18][FLINK-32296][table] Support cast of collections with row element typ…

2023-08-23 Thread via GitHub
snuyanzin merged PR #23273: URL: https://github.com/apache/flink/pull/23273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[jira] [Updated] (FLINK-31406) Do not delete jobgraph on scale only last-state upgrades

2023-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31406: --- Labels: pull-request-available (was: ) > Do not delete jobgraph on scale only last-state up

[GitHub] [flink] mimaomao opened a new pull request, #23277: [FLINK-32869][e2e] Fix Kubernetes tests on aarch64

2023-08-23 Thread via GitHub
mimaomao opened a new pull request, #23277: URL: https://github.com/apache/flink/pull/23277 ## What is the purpose of the change See https://github.com/apache/flink/pull/23235. This is backport for 1.16. -- This is an automated message from the Apache Git Service. To res

[GitHub] [flink] mimaomao opened a new pull request, #23275: [FLINK-32869][e2e] Fix Kubernetes tests on aarch64

2023-08-23 Thread via GitHub
mimaomao opened a new pull request, #23275: URL: https://github.com/apache/flink/pull/23275 ## What is the purpose of the change See https://github.com/apache/flink/pull/23235. This is backport for 1.18. -- This is an automated message from the Apache Git Service. To res

[GitHub] [flink-kubernetes-operator] SteNicholas opened a new pull request, #657: [FLINK-31406] Do not delete jobgraph on scale only last-state upgrades

2023-08-23 Thread via GitHub
SteNicholas opened a new pull request, #657: URL: https://github.com/apache/flink-kubernetes-operator/pull/657 ## What is the purpose of the change Currently the Flink service always deletes the jobgraph from HA metadata so that it's regenerated for last-state upgrades. This is unnece

[jira] [Resolved] (FLINK-32889) BinaryClassificationEvaluator gives wrong weighted AUC value

2023-08-23 Thread Zhipeng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhipeng Zhang resolved FLINK-32889. --- Fix Version/s: ml-2.4.0 Assignee: Fan Hong Resolution: Fixed > BinaryClassif

[jira] [Commented] (FLINK-32889) BinaryClassificationEvaluator gives wrong weighted AUC value

2023-08-23 Thread Zhipeng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758393#comment-17758393 ] Zhipeng Zhang commented on FLINK-32889: --- Solved on master via 5619c3b8591b220e78a0

[jira] [Updated] (FLINK-28866) Use DDL instead of legacy method to register the test source in JoinITCase

2023-08-23 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-28866: Fix Version/s: 1.19.0 > Use DDL instead of legacy method to register the test source in JoinITCase

[jira] [Comment Edited] (FLINK-32296) Flink SQL handle array of row incorrectly

2023-08-23 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758390#comment-17758390 ] Sergey Nuyanzin edited comment on FLINK-32296 at 8/24/23 6:42 AM:

[jira] [Commented] (FLINK-32296) Flink SQL handle array of row incorrectly

2023-08-23 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758390#comment-17758390 ] Sergey Nuyanzin commented on FLINK-32296: - [~renqs] agree and also think so in f

[GitHub] [flink-ml] zhipeng93 merged pull request #252: [FLINK-32889] Fix calcuation of weighted areaUnderROC and areaUnderPRC in BinaryClassificationEvaluator

2023-08-23 Thread via GitHub
zhipeng93 merged PR #252: URL: https://github.com/apache/flink-ml/pull/252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink-ml] zhipeng93 commented on pull request #252: [FLINK-32889] Fix calcuation of weighted areaUnderROC and areaUnderPRC in BinaryClassificationEvaluator

2023-08-23 Thread via GitHub
zhipeng93 commented on PR #252: URL: https://github.com/apache/flink-ml/pull/252#issuecomment-1691090215 Thanks for the PR. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [flink] fsk119 commented on a diff in pull request #23250: [FLINK-32897][table-runtime]Fix RowToRowCastRule get wrong result error while cast Array(Row()) type

2023-08-23 Thread via GitHub
fsk119 commented on code in PR #23250: URL: https://github.com/apache/flink/pull/23250#discussion_r1303828192 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/RowToRowCastRule.java: ## @@ -221,7 +221,8 @@ protected String generate

[GitHub] [flink] XComp commented on pull request #23271: [FLINK-32909] [dist] fix the bug of Pass arguments to jobmanager.sh failed

2023-08-23 Thread via GitHub
XComp commented on PR #23271: URL: https://github.com/apache/flink/pull/23271#issuecomment-1691089519 The ones I listed in [my previous post](https://github.com/apache/flink/pull/23271#pullrequestreview-1591829561) :wink: * `release-1.18` * `release-1.17` * `release-1.16` -- Th

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #252: [FLINK-32889] Fix calcuation of weighted areaUnderROC and areaUnderPRC in BinaryClassificationEvaluator

2023-08-23 Thread via GitHub
Fanoid commented on code in PR #252: URL: https://github.com/apache/flink-ml/pull/252#discussion_r1303866889 ## flink-ml-lib/src/test/java/org/apache/flink/ml/evaluation/BinaryClassificationEvaluatorTest.java: ## @@ -297,14 +298,20 @@ public void testEvaluateWithMultiScore() {

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #250: [FLINK-32810] Improve memory allocation in ListStateWithCache

2023-08-23 Thread via GitHub
jiangxin369 commented on code in PR #250: URL: https://github.com/apache/flink-ml/pull/250#discussion_r1303865404 ## flink-ml-iteration/flink-ml-iteration-common/src/main/java/org/apache/flink/iteration/datacache/nonkeyed/OperatorScopeManagedMemoryManager.java: ## @@ -18,33 +18,

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #250: [FLINK-32810] Improve memory allocation in ListStateWithCache

2023-08-23 Thread via GitHub
jiangxin369 commented on code in PR #250: URL: https://github.com/apache/flink-ml/pull/250#discussion_r1303865404 ## flink-ml-iteration/flink-ml-iteration-common/src/main/java/org/apache/flink/iteration/datacache/nonkeyed/OperatorScopeManagedMemoryManager.java: ## @@ -18,33 +18,

[GitHub] [flink] XComp commented on pull request #23235: [FLINK-32869][e2e] Fix Kubernetes tests on aarch64

2023-08-23 Thread via GitHub
XComp commented on PR #23235: URL: https://github.com/apache/flink/pull/23235#issuecomment-1691084506 You should be allowed to fork the entire repo. You would clone the repo then and add Flink's upstream repository as a remote location: ``` # this creates a remote reference "origin" by

[jira] [Created] (FLINK-32950) statsd reporter does not follow spec for counters

2023-08-23 Thread Paymahn (Jira)
Paymahn created FLINK-32950: --- Summary: statsd reporter does not follow spec for counters Key: FLINK-32950 URL: https://issues.apache.org/jira/browse/FLINK-32950 Project: Flink Issue Type: Bug

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #252: [FLINK-32889] Fix calcuation of weighted areaUnderROC and areaUnderPRC in BinaryClassificationEvaluator

2023-08-23 Thread via GitHub
zhipeng93 commented on code in PR #252: URL: https://github.com/apache/flink-ml/pull/252#discussion_r1303858586 ## flink-ml-lib/src/test/java/org/apache/flink/ml/evaluation/BinaryClassificationEvaluatorTest.java: ## @@ -297,14 +298,20 @@ public void testEvaluateWithMultiScore()

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #252: [FLINK-32889] Fix calcuation of weighted areaUnderROC and areaUnderPRC in BinaryClassificationEvaluator

2023-08-23 Thread via GitHub
zhipeng93 commented on code in PR #252: URL: https://github.com/apache/flink-ml/pull/252#discussion_r1303854514 ## flink-ml-lib/src/test/java/org/apache/flink/ml/evaluation/BinaryClassificationEvaluatorTest.java: ## @@ -297,14 +298,20 @@ public void testEvaluateWithMultiScore()

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #252: [FLINK-32889] Fix calcuation of weighted areaUnderROC and areaUnderPRC in BinaryClassificationEvaluator

2023-08-23 Thread via GitHub
zhipeng93 commented on code in PR #252: URL: https://github.com/apache/flink-ml/pull/252#discussion_r1303854514 ## flink-ml-lib/src/test/java/org/apache/flink/ml/evaluation/BinaryClassificationEvaluatorTest.java: ## @@ -297,14 +298,20 @@ public void testEvaluateWithMultiScore()

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #252: [FLINK-32889] Fix calcuation of weighted areaUnderROC and areaUnderPRC in BinaryClassificationEvaluator

2023-08-23 Thread via GitHub
zhipeng93 commented on code in PR #252: URL: https://github.com/apache/flink-ml/pull/252#discussion_r1303854514 ## flink-ml-lib/src/test/java/org/apache/flink/ml/evaluation/BinaryClassificationEvaluatorTest.java: ## @@ -297,14 +298,20 @@ public void testEvaluateWithMultiScore()

[GitHub] [flink] lindong28 commented on a diff in pull request #22931: [FLINK-32514] Support configuring checkpointing interval during process backlog

2023-08-23 Thread via GitHub
lindong28 commented on code in PR #22931: URL: https://github.com/apache/flink/pull/22931#discussion_r1303844187 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/ExecutionCheckpointingOptions.java: ## @@ -126,6 +126,23 @@ public class ExecutionChe

[jira] [Commented] (FLINK-32897) RowToRowCastRule will get wrong result while cast Array(Row()) type

2023-08-23 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758378#comment-17758378 ] Qingsheng Ren commented on FLINK-32897: --- [~337361...@qq.com] Thanks for the contri

[jira] [Closed] (FLINK-32897) RowToRowCastRule will get wrong result while cast Array(Row()) type

2023-08-23 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren closed FLINK-32897. - Resolution: Duplicate > RowToRowCastRule will get wrong result while cast Array(Row()) type > --

[GitHub] [flink-ml] Fanoid commented on pull request #252: [FLINK-32889] Fix calcuation of weighted areaUnderROC and areaUnderPRC in BinaryClassificationEvaluator

2023-08-23 Thread via GitHub
Fanoid commented on PR #252: URL: https://github.com/apache/flink-ml/pull/252#issuecomment-1691053812 hi, @zhipeng93 would you take an look on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #654: [FLINK-32890] Correct HA patch check for zookeeper metadata store

2023-08-23 Thread via GitHub
gyfora commented on PR #654: URL: https://github.com/apache/flink-kubernetes-operator/pull/654#issuecomment-1691042203 we could also back port this to the `release-1.6` branch, in case we have a bug fix release it would be nice to have it included This fix alone probably doesn't warr

[jira] [Assigned] (FLINK-30680) Consider using the autoscaler to detect slow taskmanagers

2023-08-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-30680: -- Assignee: Matt Wang > Consider using the autoscaler to detect slow taskmanagers > ---

[GitHub] [flink] maosuhan commented on a diff in pull request #23162: [FLINK-32650][protobuf]Added the ability to split flink-protobuf code…

2023-08-23 Thread via GitHub
maosuhan commented on code in PR #23162: URL: https://github.com/apache/flink/pull/23162#discussion_r1303828350 ## flink-formats/flink-protobuf/src/main/java/org/apache/flink/formats/protobuf/deserialize/PbCodegenRowDeserializer.java: ## @@ -100,6 +102,85 @@ public String codege

[jira] [Commented] (FLINK-30680) Consider using the autoscaler to detect slow taskmanagers

2023-08-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758362#comment-17758362 ] Gyula Fora commented on FLINK-30680: Sure [~wangm92] , I will assign this to you. I

[GitHub] [flink] LadyForest commented on a diff in pull request #23214: [FLINK-32860][flink-table-api] Add missing visibility annotation for Table APIs

2023-08-23 Thread via GitHub
LadyForest commented on code in PR #23214: URL: https://github.com/apache/flink/pull/23214#discussion_r1303807530 ## flink-architecture-tests/flink-architecture-tests-production/src/main/java/org/apache/flink/architecture/rules/TableApiRules.java: ## @@ -39,6 +48,10 @@ /** Ru

[GitHub] [flink] dianfu commented on pull request #23141: [FLINK-32758][python] Remove PyFlink dependencies' upper bounds

2023-08-23 Thread via GitHub
dianfu commented on PR #23141: URL: https://github.com/apache/flink/pull/23141#issuecomment-1691003379 @deepyaman All the tests passed after the changes of cython. BTW, it seems that there is one minor problem for the latest update. It should be `cython>=0.29.24,<3` instead of `cytho

[GitHub] [flink] LadyForest commented on a diff in pull request #23214: [FLINK-32860][flink-table-api] Add missing visibility annotation for Table APIs

2023-08-23 Thread via GitHub
LadyForest commented on code in PR #23214: URL: https://github.com/apache/flink/pull/23214#discussion_r1303790650 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/lookup/cache/trigger/PeriodicCacheReloadTrigger.java: ## @@ -128,6 +131,7 @@

[jira] [Comment Edited] (FLINK-32798) Release Testing: Verify FLIP-294: Support Customized Catalog Modification Listener

2023-08-23 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758339#comment-17758339 ] Hang Ruan edited comment on FLINK-32798 at 8/24/23 4:12 AM:

[jira] [Comment Edited] (FLINK-32798) Release Testing: Verify FLIP-294: Support Customized Catalog Modification Listener

2023-08-23 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758339#comment-17758339 ] Hang Ruan edited comment on FLINK-32798 at 8/24/23 4:00 AM:

[jira] [Comment Edited] (FLINK-32798) Release Testing: Verify FLIP-294: Support Customized Catalog Modification Listener

2023-08-23 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758339#comment-17758339 ] Hang Ruan edited comment on FLINK-32798 at 8/24/23 3:57 AM:

[jira] [Commented] (FLINK-32798) Release Testing: Verify FLIP-294: Support Customized Catalog Modification Listener

2023-08-23 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758339#comment-17758339 ] Hang Ruan commented on FLINK-32798: --- Hi, all. I have done some tests about this featur

[jira] [Updated] (FLINK-32798) Release Testing: Verify FLIP-294: Support Customized Catalog Modification Listener

2023-08-23 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hang Ruan updated FLINK-32798: -- Attachment: result.png > Release Testing: Verify FLIP-294: Support Customized Catalog Modification >

[jira] [Updated] (FLINK-32798) Release Testing: Verify FLIP-294: Support Customized Catalog Modification Listener

2023-08-23 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hang Ruan updated FLINK-32798: -- Attachment: sqls.png > Release Testing: Verify FLIP-294: Support Customized Catalog Modification > Li

[GitHub] [flink] deepyaman commented on pull request #23141: [FLINK-32758][python] Remove PyFlink dependencies' upper bounds

2023-08-23 Thread via GitHub
deepyaman commented on PR #23141: URL: https://github.com/apache/flink/pull/23141#issuecomment-1690955164 > @deepyaman Thanks a lot for the PR. Big +1 for this improvement. The PR LGTM overall. > > I found that the change of Cython may break the tests, see https://dev.azure.com/dianf

[GitHub] [flink] deepyaman commented on a diff in pull request #23141: [FLINK-32758][python] Remove PyFlink dependencies' upper bounds

2023-08-23 Thread via GitHub
deepyaman commented on code in PR #23141: URL: https://github.com/apache/flink/pull/23141#discussion_r1303757967 ## flink-python/pyproject.toml: ## @@ -18,12 +18,12 @@ [build-system] # Minimum requirements for the build system to execute. requires = [ -"packaging==20.5; p

[GitHub] [flink] deepyaman commented on a diff in pull request #23141: [FLINK-32758][python] Remove PyFlink dependencies' upper bounds

2023-08-23 Thread via GitHub
deepyaman commented on code in PR #23141: URL: https://github.com/apache/flink/pull/23141#discussion_r1303757617 ## flink-python/dev/dev-requirements.txt: ## @@ -15,20 +15,20 @@ pip>=20.3 setuptools>=18.0 wheel -apache-beam==2.43.0 -cython==0.29.24 +apache-beam>=2.43.0,<2.49.

[GitHub] [flink] huwh commented on a diff in pull request #23259: [hotfix][docs] Update the parameter type of JobVertex#finalizeOnMaster in JavaDocs

2023-08-23 Thread via GitHub
huwh commented on code in PR #23259: URL: https://github.com/apache/flink/pull/23259#discussion_r1303740987 ## flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/FinalizeOnMasterTest.java: ## @@ -42,8 +42,8 @@ import static org.mockito.Mockito.verify; /** -

[GitHub] [flink] jiangxin369 commented on pull request #23268: [FLINK-32945][runtime] Fix NPE when task reached end-of-data but checkpoint failed

2023-08-23 Thread via GitHub
jiangxin369 commented on PR #23268: URL: https://github.com/apache/flink/pull/23268#issuecomment-1690937283 @lindong28 Could you help review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] (FLINK-32296) Flink SQL handle array of row incorrectly

2023-08-23 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32296 ] Yunhong Zheng deleted comment on FLINK-32296: --- was (Author: JIRAUSER287975): Hi, [~Sergey Nuyanzin]. Sorry for I'm not checking whether there are same issue in jira at the beginning, becau

[jira] [Commented] (FLINK-32897) RowToRowCastRule will get wrong result while cast Array(Row()) type

2023-08-23 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758324#comment-17758324 ] Yunhong Zheng commented on FLINK-32897: --- Hi, [~Sergey Nuyanzin]. Sorry for I'm not

[jira] [Commented] (FLINK-32296) Flink SQL handle array of row incorrectly

2023-08-23 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758323#comment-17758323 ] Yunhong Zheng commented on FLINK-32296: --- Hi, [~Sergey Nuyanzin]. Sorry for I'm not

[GitHub] [flink] mimaomao commented on pull request #23235: [FLINK-32869][e2e] Fix Kubernetes tests on aarch64

2023-08-23 Thread via GitHub
mimaomao commented on PR #23235: URL: https://github.com/apache/flink/pull/23235#issuecomment-1690929130 Hi @XComp, thanks for review! It seems I'm only allowed to fork one repo for Flink. And in this fork, I only forked the master branch. This change can be simply cherry-picked to target r

[GitHub] [flink] huwh merged pull request #23260: [hotfix][docs] Update the parameter types of startRemoteMetricsRpcService in javadocs

2023-08-23 Thread via GitHub
huwh merged PR #23260: URL: https://github.com/apache/flink/pull/23260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.o

[jira] [Commented] (FLINK-30680) Consider using the autoscaler to detect slow taskmanagers

2023-08-23 Thread Matt Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758320#comment-17758320 ] Matt Wang commented on FLINK-30680: --- [~gyfora] [~mxm] Hi, can I take this Jira? I am i

[GitHub] [flink] wuqqq commented on pull request #23271: [FLINK-32909] [dist] fix the bug of Pass arguments to jobmanager.sh failed

2023-08-23 Thread via GitHub
wuqqq commented on PR #23271: URL: https://github.com/apache/flink/pull/23271#issuecomment-1690914553 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] wuqqq commented on pull request #23271: [FLINK-32909] [dist] fix the bug of Pass arguments to jobmanager.sh failed

2023-08-23 Thread via GitHub
wuqqq commented on PR #23271: URL: https://github.com/apache/flink/pull/23271#issuecomment-1690914214 Sure, which branches should I create backports for? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (FLINK-32827) Operator fusion codegen may not take effect when enable runtime filter

2023-08-23 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758317#comment-17758317 ] Lijie Wang commented on FLINK-32827: Fixed via master: 679436390db2ac1b54584dbafb6e1

[jira] [Closed] (FLINK-32827) Operator fusion codegen may not take effect when enable runtime filter

2023-08-23 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang closed FLINK-32827. -- Fix Version/s: 1.18.0 Resolution: Fixed > Operator fusion codegen may not take effect when enab

[GitHub] [flink] wanglijie95 closed pull request #23225: [FLINK-32827][table-runtime] Fix the operator fusion codegen may not take effect when enabling runtime filter

2023-08-23 Thread via GitHub
wanglijie95 closed pull request #23225: [FLINK-32827][table-runtime] Fix the operator fusion codegen may not take effect when enabling runtime filter URL: https://github.com/apache/flink/pull/23225 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] qinf commented on a diff in pull request #23219: [FLINK-20681][yarn] Support specifying the hdfs path when ship archives or files

2023-08-23 Thread via GitHub
qinf commented on code in PR #23219: URL: https://github.com/apache/flink/pull/23219#discussion_r1303712644 ## flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java: ## @@ -272,17 +272,24 @@ public class YarnConfigOptions { .noD

[GitHub] [flink] qinf commented on a diff in pull request #23219: [FLINK-20681][yarn] Support specifying the hdfs path when ship archives or files

2023-08-23 Thread via GitHub
qinf commented on code in PR #23219: URL: https://github.com/apache/flink/pull/23219#discussion_r1303713170 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -156,9 +158,9 @@ public class YarnClusterDescriptor implements ClusterDescriptor {

[GitHub] [flink] qinf commented on a diff in pull request #23219: [FLINK-20681][yarn] Support specifying the hdfs path when ship archives or files

2023-08-23 Thread via GitHub
qinf commented on code in PR #23219: URL: https://github.com/apache/flink/pull/23219#discussion_r1303713063 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -202,16 +204,27 @@ public YarnClusterDescriptor( this.nodeLabel = flinkConfig

[GitHub] [flink] qinf commented on a diff in pull request #23219: [FLINK-20681][yarn] Support specifying the hdfs path when ship archives or files

2023-08-23 Thread via GitHub
qinf commented on code in PR #23219: URL: https://github.com/apache/flink/pull/23219#discussion_r1303712839 ## flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java: ## @@ -272,17 +272,25 @@ public class YarnConfigOptions { .noD

[GitHub] [flink] qinf commented on a diff in pull request #23219: [FLINK-20681][yarn] Support specifying the hdfs path when ship archives or files

2023-08-23 Thread via GitHub
qinf commented on code in PR #23219: URL: https://github.com/apache/flink/pull/23219#discussion_r1303712644 ## flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java: ## @@ -272,17 +272,24 @@ public class YarnConfigOptions { .noD

[jira] [Commented] (FLINK-32796) Release Testing: Verify FLIP-295: Support lazy initialization of catalogs and persistence of catalog configurations

2023-08-23 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758309#comment-17758309 ] Qingsheng Ren commented on FLINK-32796: --- [~ferenc-csaky] Thanks for volunteering!

[jira] [Commented] (FLINK-32798) Release Testing: Verify FLIP-294: Support Customized Catalog Modification Listener

2023-08-23 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758308#comment-17758308 ] Qingsheng Ren commented on FLINK-32798: --- [~zjureel] Thanks for the work. Please cr

[GitHub] [flink] flinkbot commented on pull request #23274: [BP-1.18][FLINK-32905][table-runtime] Fix the bug of broadcast hash join doesn't support spill to disk when enable operator fusion codegn

2023-08-23 Thread via GitHub
flinkbot commented on PR #23274: URL: https://github.com/apache/flink/pull/23274#issuecomment-1690871218 ## CI report: * 3ee3326469582bc77d86a7360a5f18a6e46ef9dd UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-32296) Flink SQL handle array of row incorrectly

2023-08-23 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758306#comment-17758306 ] Qingsheng Ren commented on FLINK-32296: --- [~Sergey Nuyanzin] I think we also need t

[GitHub] [flink-ml] weibozhao commented on a diff in pull request #252: [FLINK-32889] Fix calcuation of weighted areaUnderROC and areaUnderPRC in BinaryClassificationEvaluator

2023-08-23 Thread via GitHub
weibozhao commented on code in PR #252: URL: https://github.com/apache/flink-ml/pull/252#discussion_r1303696802 ## flink-ml-lib/src/main/java/org/apache/flink/ml/evaluation/binaryclassification/BinaryClassificationEvaluator.java: ## @@ -520,13 +354,16 @@ private static long[] r

[GitHub] [flink-ml] weibozhao commented on pull request #252: [FLINK-32889] Fix calcuation of weighted areaUnderROC and areaUnderPRC in BinaryClassificationEvaluator

2023-08-23 Thread via GitHub
weibozhao commented on PR #252: URL: https://github.com/apache/flink-ml/pull/252#issuecomment-1690868790 Thanks for the update. LGTM overall. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] lsyldliu commented on pull request #23274: [FLINK-32905][table-runtime] Fix the bug of broadcast hash join doesn't support spill to disk when enable operator fusion codegn

2023-08-23 Thread via GitHub
lsyldliu commented on PR #23274: URL: https://github.com/apache/flink/pull/23274#issuecomment-1690868294 cc @wuchong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [flink] lsyldliu opened a new pull request, #23274: [FLINK-32905][table-runtime] Fix the bug of broadcast hash join doesn't support spill to disk when enable operator fusion codegn

2023-08-23 Thread via GitHub
lsyldliu opened a new pull request, #23274: URL: https://github.com/apache/flink/pull/23274 This closes #23251 cherry picked from commit 2cf32e82773254b79af4dad7ee317db4878d6f8a -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Updated] (FLINK-32949) Allow specifying the ServerSocket port for the collect function when accessing the TaskManager from the client.

2023-08-23 Thread JiaJian He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] JiaJian He updated FLINK-32949: --- Flags: (was: Patch) > Allow specifying the ServerSocket port for the collect function when > acce

[jira] [Created] (FLINK-32949) Allow specifying the ServerSocket port for the collect function when accessing the TaskManager from the client.

2023-08-23 Thread JiaJian He (Jira)
JiaJian He created FLINK-32949: -- Summary: Allow specifying the ServerSocket port for the collect function when accessing the TaskManager from the client. Key: FLINK-32949 URL: https://issues.apache.org/jira/browse/FL

[GitHub] [flink] dianfu commented on pull request #23141: [FLINK-32758][python] Remove PyFlink dependencies' upper bounds

2023-08-23 Thread via GitHub
dianfu commented on PR #23141: URL: https://github.com/apache/flink/pull/23141#issuecomment-1690832931 @deepyaman Thanks a lot for the PR. Big +1 for this improvement. The PR LGTM overall. I found that the change of Cython may break the tests, see https://dev.azure.com/dianfu/Flink/

[GitHub] [flink-connector-elasticsearch] mtfelisb commented on pull request #53: [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support

2023-08-23 Thread via GitHub
mtfelisb commented on PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1690822793 > What's the progress of this? Hi @reswqa, thanks for asking. I'm writing the retry mechanism inspired by the PR that @reta shared here. After that, I'll writ

[jira] [Commented] (FLINK-32840) [JUnit5 Migration] The executiongraph package of flink-runtime module

2023-08-23 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758292#comment-17758292 ] Rui Fan commented on FLINK-32840: - Merged 4532e3494dd97fdb7c5ad86f63458ba7024279b3 > [

[jira] [Resolved] (FLINK-32840) [JUnit5 Migration] The executiongraph package of flink-runtime module

2023-08-23 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-32840. - Fix Version/s: 1.19.0 Resolution: Fixed > [JUnit5 Migration] The executiongraph package of flink-

[GitHub] [flink] 1996fanrui merged pull request #23227: [FLINK-32840][runtime][JUnit5 Migration] The executiongraph package of flink-runtime module

2023-08-23 Thread via GitHub
1996fanrui merged PR #23227: URL: https://github.com/apache/flink/pull/23227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[jira] [Updated] (FLINK-21608) YARNHighAvailabilityITCase.testClusterClientRetrieval fails with "There is at least one application..."

2023-08-23 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-21608: --- Labels: auto-deprioritized-major auto-deprioritized-minor test-stability (was: auto-depri

[jira] [Updated] (FLINK-28984) FsCheckpointStateOutputStream is not being released normally

2023-08-23 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-28984: --- Labels: auto-deprioritized-major pull-request-available (was: pull-request-available stal

[jira] [Updated] (FLINK-31174) [Doc] Inconsistent data format between flink-training-repo and learn-flink doc

2023-08-23 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-31174: --- Labels: pull-request-available stale-minor (was: pull-request-available) I am the [Flink Ji

[jira] [Updated] (FLINK-22701) "bin/flink savepoint -d :savepointpath" cannot locate savepointpath arg

2023-08-23 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-22701: --- Labels: auto-deprioritized-major auto-deprioritized-minor (was: auto-deprioritized-major

[jira] [Updated] (FLINK-21693) TestStreamEnvironment does not implement executeAsync

2023-08-23 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-21693: --- Labels: auto-deprioritized-major auto-deprioritized-minor (was: auto-deprioritized-major

[jira] [Updated] (FLINK-22742) Lookup join condition with process time throws org.codehaus.commons.compiler.CompileException

2023-08-23 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-22742: --- Labels: auto-deprioritized-major auto-deprioritized-minor (was: auto-deprioritized-major

[jira] [Updated] (FLINK-30433) HiveDialectITCase#testCreateDatabase fails with "Could not execute CREATE DATABASE"

2023-08-23 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-30433: --- Labels: stale-critical test-stability (was: test-stability) I am the [Flink Jira Bot|https:

[jira] [Updated] (FLINK-21995) YARNSessionFIFOSecuredITCase>YARNSessionFIFOITCase.checkForProhibitedLogContents: File channel manager has shutdown.

2023-08-23 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-21995: --- Labels: auto-deprioritized-major auto-deprioritized-minor test-stability (was: auto-depri

[jira] [Updated] (FLINK-21834) org.apache.flink.core.fs.AbstractRecoverableWriterTest.testResumeWithWrongOffset fail

2023-08-23 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-21834: --- Labels: auto-deprioritized-critical auto-deprioritized-major auto-deprioritized-minor test

[jira] [Updated] (FLINK-22679) code optimization:Transformation.equals

2023-08-23 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-22679: --- Labels: auto-deprioritized-minor pull-request-available (was: auto-deprioritized-minor pu

[jira] [Updated] (FLINK-21513) Rethink up-/down-/restartingTime metrics

2023-08-23 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-21513: --- Labels: auto-deprioritized-major auto-deprioritized-minor reactive (was: auto-deprioritiz

[jira] [Updated] (FLINK-18896) Translate "stateful-functions" page into Chinese

2023-08-23 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-18896: --- Labels: pull-request-available stale-minor (was: pull-request-available) I am the [Flink Ji

[jira] [Updated] (FLINK-22336) [umbrella] Enhance testing for built-in functions

2023-08-23 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-22336: --- Labels: auto-deprioritized-major auto-deprioritized-minor (was: auto-deprioritized-major

[jira] [Updated] (FLINK-22588) There is a configuration description error in the document

2023-08-23 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-22588: --- Labels: auto-deprioritized-minor pull-request-available (was: pull-request-available stal

[jira] [Updated] (FLINK-32893) Make client.id configurable from KafkaSource

2023-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32893: --- Labels: pull-request-available (was: ) > Make client.id configurable from KafkaSource > ---

[GitHub] [flink-connector-kafka] boring-cyborg[bot] commented on pull request #45: [FLINK-32893][Connectors/Kafka] Allow the clientid to be fully configurable

2023-08-23 Thread via GitHub
boring-cyborg[bot] commented on PR #45: URL: https://github.com/apache/flink-connector-kafka/pull/45#issuecomment-1690653396 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is a

  1   2   3   >