deepyaman commented on PR #23141: URL: https://github.com/apache/flink/pull/23141#issuecomment-1690955164
> @deepyaman Thanks a lot for the PR. Big +1 for this improvement. The PR LGTM overall. > > I found that the change of Cython may break the tests, see https://dev.azure.com/dianfu/Flink/_build/results?buildId=729&view=logs&j=fba17979-6d2e-591d-72f1-97cf42797c11&t=727942b6-6137-54f7-1ef9-e66e706ea068 (I have triggered nightly tests which will run more tests. Cython tests are skipped in the PR CI) for more details. > > It seems related to recently released cython 3.0.0. After changing `cython>=0.29.24` to `cython>=0.29.24,<3`, all the tests passed: https://dev.azure.com/dianfu/Flink/_build/results?buildId=733&view=logs&j=fba17979-6d2e-591d-72f1-97cf42797c11&t=727942b6-6137-54f7-1ef9-e66e706ea068 @dianfu Sounds great! Let me know if the nightly job raises any other issues. In the meantime, I've gone ahead and updated `cython>=0.29.24` to `cython>=0.29.24,<3` in this PR, too, as you found necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
