maosuhan commented on code in PR #23162:
URL: https://github.com/apache/flink/pull/23162#discussion_r1303828350
##########
flink-formats/flink-protobuf/src/main/java/org/apache/flink/formats/protobuf/deserialize/PbCodegenRowDeserializer.java:
##########
@@ -100,6 +102,85 @@ public String codegen(String resultVar, String
pbObjectCode, int indent)
return appender.code();
}
+ @Override
+ public String codegenSplit(
Review Comment:
@ljw-hit Why we still need original codegen methods which are not
splittable? Are there any advantages to use original ones? If we only preserve
one way to generate code, it will be simpler to maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
