[jira] [Commented] (FLINK-32523) NotifyCheckpointAbortedITCase.testNotifyCheckpointAborted fails with timeout on AZP

2023-08-03 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750975#comment-17750975 ] Sergey Nuyanzin commented on FLINK-32523: - https://dev.azure.com/apache-flink/ap

[GitHub] [flink] xuzifu666 closed pull request #23136: [FLINK-32750] fix resouces not fix in testcase

2023-08-03 Thread via GitHub
xuzifu666 closed pull request #23136: [FLINK-32750] fix resouces not fix in testcase URL: https://github.com/apache/flink/pull/23136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Updated] (FLINK-32750) fix resouces not fix in testcase

2023-08-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32750: --- Labels: pull-request-available (was: ) > fix resouces not fix in testcase > ---

[GitHub] [flink] xuzifu666 opened a new pull request, #23136: [FLINK-32750] fix resouces not fix in testcase

2023-08-03 Thread via GitHub
xuzifu666 opened a new pull request, #23136: URL: https://github.com/apache/flink/pull/23136 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[GitHub] [flink] pegasas commented on pull request #23135: [FLINK-32741]Remove DataSet related descriptions in doc

2023-08-03 Thread via GitHub
pegasas commented on PR #23135: URL: https://github.com/apache/flink/pull/23135#issuecomment-1665086019 Hi, @xintongsong, @WencongLiu , I deprecated all files on /dev/dataset on content/ and content.zh in my private view, all dataset sub-document should be deprecated now. http

[GitHub] [flink] LadyForest commented on pull request #23065: [FLINK-32656][table] Deprecate ManagedTable related APIs

2023-08-03 Thread via GitHub
LadyForest commented on PR #23065: URL: https://github.com/apache/flink/pull/23065#issuecomment-1665065167 @tsreaper @JingsongLi Hi Paimon PMCs, could you have time to take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Created] (FLINK-32750) fix resouces not fix in testcase

2023-08-03 Thread xy (Jira)
xy created FLINK-32750: -- Summary: fix resouces not fix in testcase Key: FLINK-32750 URL: https://issues.apache.org/jira/browse/FLINK-32750 Project: Flink Issue Type: Bug Components: Tests

[GitHub] [flink] flinkbot commented on pull request #23135: [FLINK-32741]Remove DataSet related descriptions in doc

2023-08-03 Thread via GitHub
flinkbot commented on PR #23135: URL: https://github.com/apache/flink/pull/23135#issuecomment-1665062098 ## CI report: * 08e4c5c5f26e7c5f51341a8732f1458841e3154c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-32730) BatchExecMultipleInput may contain unsupported SourceTransformation

2023-08-03 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750964#comment-17750964 ] dalongliu commented on FLINK-32730: --- [~Weijie Guo] Thanks for report, I will fix it.

[GitHub] [flink] pegasas commented on a diff in pull request #23026: [FLINK-32558][flink-java] Deprecate all DataSet API

2023-08-03 Thread via GitHub
pegasas commented on code in PR #23026: URL: https://github.com/apache/flink/pull/23026#discussion_r1284013387 ## flink-examples/flink-examples-batch/pom.xml: ## @@ -48,25 +48,6 @@ under the License. - -

[jira] [Updated] (FLINK-32741) Remove DataSet related descriptions in doc

2023-08-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32741: --- Labels: 2.0-related pull-request-available (was: 2.0-related) > Remove DataSet related desc

[GitHub] [flink] pegasas opened a new pull request, #23135: [FLINK-32741]Remove DataSet related descriptions in doc

2023-08-03 Thread via GitHub
pegasas opened a new pull request, #23135: URL: https://github.com/apache/flink/pull/23135 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on

[jira] [Resolved] (FLINK-29527) Make unknownFieldsIndices work for single ParquetReader

2023-08-03 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen resolved FLINK-29527. --- Resolution: Fixed master via 50622df1f01cd9cade78bfe2add5a7faff678e3e Shall we pick to other versio

[jira] [Updated] (FLINK-29527) Make unknownFieldsIndices work for single ParquetReader

2023-08-03 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen updated FLINK-29527: -- Fix Version/s: 1.19.0 > Make unknownFieldsIndices work for single ParquetReader >

[GitHub] [flink] reswqa commented on a diff in pull request #23100: [FLINK-32708][network] Fix the write logic in remote tier of hybrid shuffle

2023-08-03 Thread via GitHub
reswqa commented on code in PR #23100: URL: https://github.com/apache/flink/pull/23100#discussion_r1284006406 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/remote/RemoteStorageScanner.java: ## @@ -236,15 +254,24 @@ private boolea

[jira] [Commented] (FLINK-28915) Make application mode could support remote DFS schema(e.g. S3, OSS, HDFS, etc.)

2023-08-03 Thread Junyao Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750960#comment-17750960 ] Junyao Huang commented on FLINK-28915: -- Hi, [~hjw], [~wangyang0918], What is the st

[GitHub] [flink] reswqa commented on a diff in pull request #23100: [FLINK-32708][network] Fix the write logic in remote tier of hybrid shuffle

2023-08-03 Thread via GitHub
reswqa commented on code in PR #23100: URL: https://github.com/apache/flink/pull/23100#discussion_r1284002092 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/remote/RemoteStorageScanner.java: ## @@ -236,15 +254,24 @@ private boolea

[GitHub] [flink] reswqa commented on a diff in pull request #23100: [FLINK-32708][network] Fix the write logic in remote tier of hybrid shuffle

2023-08-03 Thread via GitHub
reswqa commented on code in PR #23100: URL: https://github.com/apache/flink/pull/23100#discussion_r1284000935 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/remote/RemoteStorageScanner.java: ## @@ -109,7 +118,11 @@ private FileSys

[jira] [Closed] (FLINK-32735) Flink SQL Gateway for Native Kubernetes Application Mode

2023-08-03 Thread Junyao Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junyao Huang closed FLINK-32735. Tracked by FLIP-316. > Flink SQL Gateway for Native Kubernetes Application Mode > --

[jira] [Resolved] (FLINK-32735) Flink SQL Gateway for Native Kubernetes Application Mode

2023-08-03 Thread Junyao Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junyao Huang resolved FLINK-32735. -- Release Note: tracked by FLIP-316. Resolution: Fixed > Flink SQL Gateway for Native Kube

[jira] [Commented] (FLINK-32735) Flink SQL Gateway for Native Kubernetes Application Mode

2023-08-03 Thread Junyao Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750956#comment-17750956 ] Junyao Huang commented on FLINK-32735: -- Thanks [~lsy]! Your answer exactly fits my

[jira] [Closed] (FLINK-32739) restarting not work

2023-08-03 Thread Spongebob (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Spongebob closed FLINK-32739. - Resolution: Not A Problem > restarting not work > --- > > Key: FLINK-327

[jira] [Created] (FLINK-32749) Sql gateway supports default catalog loaded by CatalogStore

2023-08-03 Thread Fang Yong (Jira)
Fang Yong created FLINK-32749: - Summary: Sql gateway supports default catalog loaded by CatalogStore Key: FLINK-32749 URL: https://issues.apache.org/jira/browse/FLINK-32749 Project: Flink Issue

[GitHub] [flink] WencongLiu commented on a diff in pull request #23100: [FLINK-32708][network] Fix the write logic in remote tier of hybrid shuffle

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #23100: URL: https://github.com/apache/flink/pull/23100#discussion_r1283977914 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/remote/RemoteStorageScanner.java: ## @@ -236,15 +254,24 @@ private bo

[GitHub] [flink] WencongLiu commented on a diff in pull request #23100: [FLINK-32708][network] Fix the write logic in remote tier of hybrid shuffle

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #23100: URL: https://github.com/apache/flink/pull/23100#discussion_r1283977912 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/remote/RemoteStorageScanner.java: ## @@ -236,15 +254,24 @@ private bo

[jira] [Commented] (FLINK-32735) Flink SQL Gateway for Native Kubernetes Application Mode

2023-08-03 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750945#comment-17750945 ] dalongliu commented on FLINK-32735: --- [~pegasas]  As stated in the documentation you l

[GitHub] [flink] WencongLiu commented on a diff in pull request #23026: [FLINK-32558][flink-java] Deprecate all DataSet API

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #23026: URL: https://github.com/apache/flink/pull/23026#discussion_r1283910488 ## flink-examples/flink-examples-batch/pom.xml: ## @@ -48,25 +48,6 @@ under the License. - -

[GitHub] [flink] WencongLiu commented on a diff in pull request #23026: [FLINK-32558][flink-java] Deprecate all DataSet API

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #23026: URL: https://github.com/apache/flink/pull/23026#discussion_r1283959998 ## flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java: ## @@ -544,6 +544,13 @@ public ExecutionConfig setExecutionRetryDelay(long executionRe

[GitHub] [flink] WencongLiu commented on a diff in pull request #23026: [FLINK-32558][flink-java] Deprecate all DataSet API

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #23026: URL: https://github.com/apache/flink/pull/23026#discussion_r1283910488 ## flink-examples/flink-examples-batch/pom.xml: ## @@ -48,25 +48,6 @@ under the License. - -

[GitHub] [flink] xuzifu666 closed pull request #23134: [FLINK-32748] WriteSinkFunction::cleanFile need close write automaticly

2023-08-03 Thread via GitHub
xuzifu666 closed pull request #23134: [FLINK-32748] WriteSinkFunction::cleanFile need close write automaticly URL: https://github.com/apache/flink/pull/23134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [flink] xuzifu666 commented on pull request #23134: [FLINK-32748] WriteSinkFunction::cleanFile need close write automaticly

2023-08-03 Thread via GitHub
xuzifu666 commented on PR #23134: URL: https://github.com/apache/flink/pull/23134#issuecomment-1664944270 would open a new pr to fix these -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[jira] [Closed] (FLINK-32748) WriteSinkFunction::cleanFile need close write automaticly

2023-08-03 Thread xy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xy closed FLINK-32748. -- Resolution: Incomplete > WriteSinkFunction::cleanFile need close write automaticly > -

[GitHub] [flink] WencongLiu commented on a diff in pull request #23026: [FLINK-32558][flink-java] Deprecate all DataSet API

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #23026: URL: https://github.com/apache/flink/pull/23026#discussion_r1283910551 ## flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java: ## @@ -913,6 +920,18 @@ public LinkedHashSet> getRegisteredPojoTypes() { retur

[GitHub] [flink] reswqa commented on a diff in pull request #23100: [FLINK-32708][network] Fix the write logic in remote tier of hybrid shuffle

2023-08-03 Thread via GitHub
reswqa commented on code in PR #23100: URL: https://github.com/apache/flink/pull/23100#discussion_r1283940833 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/remote/RemoteStorageScanner.java: ## @@ -236,15 +254,24 @@ private boolea

[jira] [Updated] (FLINK-32746) Enable ZGC in JDK17 to solve long time class unloading STW

2023-08-03 Thread xiangyu feng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiangyu feng updated FLINK-32746: - Summary: Enable ZGC in JDK17 to solve long time class unloading STW (was: Enable ZGC in JDK17 t

[GitHub] [flink] WencongLiu commented on a diff in pull request #23026: [FLINK-32558][flink-java] Deprecate all DataSet API

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #23026: URL: https://github.com/apache/flink/pull/23026#discussion_r1283910579 ## flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java: ## @@ -544,6 +544,13 @@ public ExecutionConfig setExecutionRetryDelay(long executionRe

[GitHub] [flink] WencongLiu commented on a diff in pull request #23026: [FLINK-32558][flink-java] Deprecate all DataSet API

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #23026: URL: https://github.com/apache/flink/pull/23026#discussion_r1283910526 ## flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java: ## @@ -556,7 +556,14 @@ public void setExecutionMode(ExecutionMode executionMode) {

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283948678 ## flink-runtime/src/test/java/org/apache/flink/runtime/testutils/TestingJobResultStore.java: ## @@ -116,58 +111,53 @@ public static TestingJobResultStore.Builder bu

[GitHub] [flink] Tartarus0zm commented on pull request #23116: [FLINK-32581][docs] Add docs for atomic CTAS and RTAS

2023-08-03 Thread via GitHub
Tartarus0zm commented on PR #23116: URL: https://github.com/apache/flink/pull/23116#issuecomment-1664931262 @luoyuxia thanks for your review. I have updated the pr, PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283947288 ## flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/JobResultStoreContractTest.java: ## @@ -46,72 +47,97 @@ public interface JobResultStoreContr

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283946578 ## flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStoreFileOperationsTest.java: ## @@ -116,46 +123,74 @@ public void testB

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283945744 ## flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherResourceCleanupTest.java: ## @@ -579,10 +587,15 @@ public void testErrorHandlingIfJobCa

[jira] [Commented] (FLINK-32739) restarting not work

2023-08-03 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750942#comment-17750942 ] Junrui Li commented on FLINK-32739: --- [~SpongebobZ] It will just restart tasks in the o

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283944785 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunner.java: ## @@ -277,18 +277,11 @@ private void startJobMasterServiceP

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283937477 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/embedded/EmbeddedJobResultStore.java: ## Review Comment: Done. -- This is an

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283935357 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/embedded/EmbeddedJobResultStore.java: ## @@ -57,17 +61,17 @@ public void markResultAsC

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283935250 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/embedded/EmbeddedJobResultStore.java: ## @@ -57,17 +61,17 @@ public void markResultAsC

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283934746 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultStore.java: ## @@ -43,69 +44,70 @@ public interface JobResultStore { * Regist

[jira] [Commented] (FLINK-32667) Use standalone store and embedding writer for jobs with no-restart-strategy in session cluster

2023-08-03 Thread Fang Yong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750938#comment-17750938 ] Fang Yong commented on FLINK-32667: --- [~mapohl] We have an internally e2e test for olap

[jira] [Commented] (FLINK-32739) restarting not work

2023-08-03 Thread Spongebob (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750937#comment-17750937 ] Spongebob commented on FLINK-32739: --- Thanks [~JunRuiLi] , this option helps. When one

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283928788 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultStore.java: ## @@ -43,69 +44,70 @@ public interface JobResultStore { * Regist

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283927882 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultStore.java: ## @@ -43,69 +44,70 @@ public interface JobResultStore { * Regist

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283926936 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultStore.java: ## @@ -43,69 +44,70 @@ public interface JobResultStore { * Regist

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283926122 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultStore.java: ## @@ -43,69 +44,70 @@ public interface JobResultStore { * Regist

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283925581 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStore.java: ## @@ -181,21 +185,19 @@ public void markResultAsCleanInterna

[jira] [Commented] (FLINK-32738) PROTOBUF format supports projection push down

2023-08-03 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750934#comment-17750934 ] dalongliu commented on FLINK-32738: --- [~zhoujira86] Looks good to me if we can support

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283925443 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStore.java: ## @@ -181,21 +185,19 @@ public void markResultAsCleanInterna

[jira] [Updated] (FLINK-32746) Enable ZGC in JDK17 to solve long time class unloading STW during fullgc

2023-08-03 Thread xiangyu feng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiangyu feng updated FLINK-32746: - Description: In a OLAP session cluster, a TM need to frequently create new classloaders and  ge

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283100724 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java: ## @@ -1390,29 +1392,71 @@ private CompletableFuture registerGloballyTerminatedJ

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1283923614 ## flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherResourceCleanupTest.java: ## @@ -332,11 +332,16 @@ public void testJobBeingMarkedAsDirty

[GitHub] [flink] flinkbot commented on pull request #23134: [FLINK-32748] WriteSinkFunction::cleanFile need close write automaticly

2023-08-03 Thread via GitHub
flinkbot commented on PR #23134: URL: https://github.com/apache/flink/pull/23134#issuecomment-1664900125 ## CI report: * 30978f125a7b9d816e5875a4ce28f8b359341115 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #23133: [FLINK-32747][table] Suport ddl for catalog which is loaded from CatalogStore

2023-08-03 Thread via GitHub
flinkbot commented on PR #23133: URL: https://github.com/apache/flink/pull/23133#issuecomment-1664899703 ## CI report: * 651315783f96f5c01dabba6702dfaf01190f5942 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32748) WriteSinkFunction::cleanFile need close write automaticly

2023-08-03 Thread xy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xy updated FLINK-32748: --- Component/s: API / Core > WriteSinkFunction::cleanFile need close write automaticly > --

[jira] [Assigned] (FLINK-32747) Support ddl for catalog from CatalogStore

2023-08-03 Thread Fang Yong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fang Yong reassigned FLINK-32747: - Assignee: Fang Yong > Support ddl for catalog from CatalogStore > -

[GitHub] [flink] xuzifu666 commented on pull request #23134: [FLINK-32748] WriteSinkFunction::cleanFile need close write automaticly

2023-08-03 Thread via GitHub
xuzifu666 commented on PR #23134: URL: https://github.com/apache/flink/pull/23134#issuecomment-1664896044 cc @reswqa have a review plz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-32748) WriteSinkFunction::cleanFile need close write automaticly

2023-08-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32748: --- Labels: pull-request-available (was: ) > WriteSinkFunction::cleanFile need close write auto

[jira] [Updated] (FLINK-32746) Enable ZGC in JDK17 to solve long time class unloading STW during fullgc

2023-08-03 Thread xiangyu feng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiangyu feng updated FLINK-32746: - Description: In a OLAP session cluster, a TM need to frequently create new classloaders and  ge

[GitHub] [flink] xuzifu666 opened a new pull request, #23134: [FLINK-32748] WriteSinkFunction::cleanFile need close write automaticly

2023-08-03 Thread via GitHub
xuzifu666 opened a new pull request, #23134: URL: https://github.com/apache/flink/pull/23134 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[jira] [Updated] (FLINK-32747) Support ddl for catalog from CatalogStore

2023-08-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32747: --- Labels: pull-request-available (was: ) > Support ddl for catalog from CatalogStore > --

[GitHub] [flink] FangYongs opened a new pull request, #23133: [FLINK-32747][table] Suport ddl for catalog which is loaded from CatalogStore

2023-08-03 Thread via GitHub
FangYongs opened a new pull request, #23133: URL: https://github.com/apache/flink/pull/23133 ## What is the purpose of the change Currently `CatalogManager` can load catalog from `CatalogStore`, but we cannot perform ddl for the loaded catalog. This pr aims to support these operation

[jira] [Created] (FLINK-32748) WriteSinkFunction::cleanFile need close write automaticly

2023-08-03 Thread xy (Jira)
xy created FLINK-32748: -- Summary: WriteSinkFunction::cleanFile need close write automaticly Key: FLINK-32748 URL: https://issues.apache.org/jira/browse/FLINK-32748 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-32747) Support ddl for catalog from CatalogStore

2023-08-03 Thread Fang Yong (Jira)
Fang Yong created FLINK-32747: - Summary: Support ddl for catalog from CatalogStore Key: FLINK-32747 URL: https://issues.apache.org/jira/browse/FLINK-32747 Project: Flink Issue Type: Sub-task

[jira] [Comment Edited] (FLINK-32741) Remove DataSet related descriptions in doc

2023-08-03 Thread Junyao Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750930#comment-17750930 ] Junyao Huang edited comment on FLINK-32741 at 8/4/23 2:33 AM:

[jira] [Commented] (FLINK-32741) Remove DataSet related descriptions in doc

2023-08-03 Thread Junyao Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750930#comment-17750930 ] Junyao Huang commented on FLINK-32741: -- Thanks! will start immediately. > Remove D

[GitHub] [flink] FangYongs commented on pull request #23063: [FLINK-32660][table] Introduce external FS compatible FileCatalogStore implementation

2023-08-03 Thread via GitHub
FangYongs commented on PR #23063: URL: https://github.com/apache/flink/pull/23063#issuecomment-1664886934 Thanks @ferenc-csaky , left some comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] WencongLiu commented on pull request #23026: [FLINK-32558][flink-java] Deprecate all DataSet API

2023-08-03 Thread via GitHub
WencongLiu commented on PR #23026: URL: https://github.com/apache/flink/pull/23026#issuecomment-1664886800 > I think being used in test cases probably should not block the deprecation of the classes. In this specific case, I don't it's necessary to move them to another module. There are man

[GitHub] [flink] WencongLiu commented on a diff in pull request #23026: [FLINK-32558][flink-java] Deprecate all DataSet API

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #23026: URL: https://github.com/apache/flink/pull/23026#discussion_r1283910595 ## flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java: ## @@ -77,12 +80,23 @@ * Broadcast variables in bulk

[GitHub] [flink] WencongLiu commented on a diff in pull request #23026: [FLINK-32558][flink-java] Deprecate all DataSet API

2023-08-03 Thread via GitHub
WencongLiu commented on code in PR #23026: URL: https://github.com/apache/flink/pull/23026#discussion_r1283910488 ## flink-examples/flink-examples-batch/pom.xml: ## @@ -48,25 +48,6 @@ under the License. - -

[GitHub] [flink] FangYongs commented on a diff in pull request #23063: [FLINK-32660][table] Introduce external FS compatible FileCatalogStore implementation

2023-08-03 Thread via GitHub
FangYongs commented on code in PR #23063: URL: https://github.com/apache/flink/pull/23063#discussion_r1283909486 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FileCatalogStoreFactory.java: ## @@ -20,42 +20,39 @@ import org.apache.flink.confi

[GitHub] [flink] FangYongs commented on a diff in pull request #23063: [FLINK-32660][table] Introduce external FS compatible FileCatalogStore implementation

2023-08-03 Thread via GitHub
FangYongs commented on code in PR #23063: URL: https://github.com/apache/flink/pull/23063#discussion_r1283908619 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FileCatalogStore.java: ## @@ -217,32 +253,10 @@ public Set listCatalogs() throws Cata

[GitHub] [flink] FangYongs commented on a diff in pull request #23063: [FLINK-32660][table] Introduce external FS compatible FileCatalogStore implementation

2023-08-03 Thread via GitHub
FangYongs commented on code in PR #23063: URL: https://github.com/apache/flink/pull/23063#discussion_r1283907327 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FileCatalogStore.java: ## @@ -201,8 +222,23 @@ public Optional getCatalog(String cat

[GitHub] [flink] FangYongs commented on a diff in pull request #23063: [FLINK-32660][table] Introduce external FS compatible FileCatalogStore implementation

2023-08-03 Thread via GitHub
FangYongs commented on code in PR #23063: URL: https://github.com/apache/flink/pull/23063#discussion_r1283906870 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FileCatalogStore.java: ## @@ -172,22 +185,30 @@ public void removeCatalog(String cata

[GitHub] [flink] FangYongs commented on a diff in pull request #23063: [FLINK-32660][table] Introduce external FS compatible FileCatalogStore implementation

2023-08-03 Thread via GitHub
FangYongs commented on code in PR #23063: URL: https://github.com/apache/flink/pull/23063#discussion_r1283906615 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FileCatalogStore.java: ## @@ -132,31 +153,23 @@ public void storeCatalog(String catal

[GitHub] [flink] FangYongs commented on a diff in pull request #23063: [FLINK-32660][table] Introduce external FS compatible FileCatalogStore implementation

2023-08-03 Thread via GitHub
FangYongs commented on code in PR #23063: URL: https://github.com/apache/flink/pull/23063#discussion_r1283906508 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FileCatalogStore.java: ## @@ -97,25 +114,29 @@ public void storeCatalog(String catalo

[GitHub] [flink] FangYongs commented on a diff in pull request #23063: [FLINK-32660][table] Introduce external FS compatible FileCatalogStore implementation

2023-08-03 Thread via GitHub
FangYongs commented on code in PR #23063: URL: https://github.com/apache/flink/pull/23063#discussion_r1283903488 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FileCatalogStore.java: ## @@ -46,42 +49,56 @@ public class FileCatalogStore extends A

[jira] [Created] (FLINK-32746) Enable ZGC in JDK17 to solve long time class unloading STW during fullgc

2023-08-03 Thread xiangyu feng (Jira)
xiangyu feng created FLINK-32746: Summary: Enable ZGC in JDK17 to solve long time class unloading STW during fullgc Key: FLINK-32746 URL: https://issues.apache.org/jira/browse/FLINK-32746 Project: Fli

[GitHub] [flink] xintongsong commented on a diff in pull request #23026: [FLINK-32558][flink-java] Deprecate all DataSet API

2023-08-03 Thread via GitHub
xintongsong commented on code in PR #23026: URL: https://github.com/apache/flink/pull/23026#discussion_r1283896762 ## flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java: ## @@ -77,12 +80,23 @@ * Broadcast variables in bulk

[GitHub] [flink] wanglijie95 merged pull request #22992: [hotfix] Fix typo in JobManagerOptions

2023-08-03 Thread via GitHub
wanglijie95 merged PR #22992: URL: https://github.com/apache/flink/pull/22992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

[jira] [Commented] (FLINK-32741) Remove DataSet related descriptions in doc

2023-08-03 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750921#comment-17750921 ] Xintong Song commented on FLINK-32741: -- Thanks for volunteering, [~pegasas]. You ar

[jira] [Assigned] (FLINK-32741) Remove DataSet related descriptions in doc

2023-08-03 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song reassigned FLINK-32741: Assignee: Junyao Huang > Remove DataSet related descriptions in doc > ---

[jira] [Updated] (FLINK-32741) Remove DataSet related descriptions in doc

2023-08-03 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song updated FLINK-32741: - Fix Version/s: 1.18.0 (was: 2.0.0) > Remove DataSet related descriptions

[jira] [Commented] (FLINK-32740) Introduce literal null value for flink-conf.yaml

2023-08-03 Thread Yao Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750916#comment-17750916 ] Yao Zhang commented on FLINK-32740: --- Hi [~JunRuiLi], Good question. It is also my con

[GitHub] [flink] flinkbot commented on pull request #23132: [python] Relax `grpcio` requirement to build on M2

2023-08-03 Thread via GitHub
flinkbot commented on PR #23132: URL: https://github.com/apache/flink/pull/23132#issuecomment-1664610864 ## CI report: * 6d68021f5f4f27459374090329157bc8d05b9e63 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] deepyaman opened a new pull request, #23132: [python] Relax `grpcio` requirement to build on M2

2023-08-03 Thread via GitHub
deepyaman opened a new pull request, #23132: URL: https://github.com/apache/flink/pull/23132 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[jira] [Updated] (FLINK-32729) allow create an initial deployment with suspend state

2023-08-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32729: --- Labels: pull-request-available (was: ) > allow create an initial deployment with suspend st

[GitHub] [flink-kubernetes-operator] bjhaid opened a new pull request, #641: [FLINK-32729] allow starting a flink job in a suspended state.

2023-08-03 Thread via GitHub
bjhaid opened a new pull request, #641: URL: https://github.com/apache/flink-kubernetes-operator/pull/641 In our setup we intend migrating flinkDeployments from one cluster to the other, as part of doing this we want to start the flinkDeploments in a suspended state with an initialSavePoint

[GitHub] [flink] netvl commented on pull request #22854: [FLINK-32137] Added filtering of lambdas when building the flame graph

2023-08-03 Thread via GitHub
netvl commented on PR #22854: URL: https://github.com/apache/flink/pull/22854#issuecomment-1664427570 Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [flink-web] dannycranmer commented on a diff in pull request #668: [FLINK-32736] Externalized connectors

2023-08-03 Thread via GitHub
dannycranmer commented on code in PR #668: URL: https://github.com/apache/flink-web/pull/668#discussion_r1283535822 ## docs/content/posts/2023-08-03-externalized-connectors.md: ## @@ -0,0 +1,77 @@ +--- +title: "Announcing three new Apache Flink connectors, the new connector ver

[jira] [Commented] (FLINK-32741) Remove DataSet related descriptions in doc

2023-08-03 Thread Junyao Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750841#comment-17750841 ] Junyao Huang commented on FLINK-32741: -- Hi, [~Wencong Liu] , May I work on this is

[GitHub] [flink-web] elphastori commented on a diff in pull request #668: [FLINK-32736] Externalized connectors

2023-08-03 Thread via GitHub
elphastori commented on code in PR #668: URL: https://github.com/apache/flink-web/pull/668#discussion_r1283509741 ## docs/content/posts/2023-08-03-connector-updates.md: ## @@ -0,0 +1,68 @@ +--- +title: "DynamoDB, MongoDB and OpenSearch externalized connectors" +date: "2023-08-03

  1   2   >