WencongLiu commented on code in PR #23026:
URL: https://github.com/apache/flink/pull/23026#discussion_r1283910488
##########
flink-examples/flink-examples-batch/pom.xml:
##########
@@ -48,25 +48,6 @@ under the License.
<build>
<plugins>
- <!-- Fail compilation on deprecation warnings to
prevent from showing users outdated examples. -->
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-compiler-plugin</artifactId>
- <executions>
- <execution>
- <id>compile</id>
- <phase>process-sources</phase>
- <goals>
- <goal>compile</goal>
- </goals>
- <configuration>
-
<compilerArgument>-Xlint:deprecation</compilerArgument>
-
<failOnWarning>true</failOnWarning>
- </configuration>
- </execution>
- </executions>
- </plugin>
-
Review Comment:
1. The classes in `flink-examples-batch` module is still utilized for
testing purpose. I have added the warning log in all batch example classes to
remind the developer that the DataSet API is deprecated. I also have added the
note to `bin.xml` in `flink-disk` module to explain the batch examples in
example package is only for tests.
2. I have created an issue
[FLINK-32741](https://issues.apache.org/jira/browse/FLINK-32741) to track the
removal of DataSet related documentations. Currently the issue is assigned to
@pegasas .
##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -556,7 +556,14 @@ public void setExecutionMode(ExecutionMode executionMode) {
* <p>The default execution mode is {@link ExecutionMode#PIPELINED}.
*
* @return The execution mode for the program.
+ * @deprecated All Flink DataSet APIs are deprecated since Flink 1.18 and
will be removed in a
+ * future Flink major version. You can still build your application in
DataSet, but you
+ * should move to either the DataStream and/or Table API.
+ * @see <a
href="https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158866741";>
+ * FLIP-131: Consolidate the user-facing Dataflow SDKs/APIs (and
deprecate the DataSet
+ * API</a>
*/
+ @Deprecated
Review Comment:
1. `ExecutionMode` and `setExecutionMode ` are both deprecated.
2. The class JavaDoc of execution mode is updated.
##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -913,6 +920,18 @@ public LinkedHashSet<Class<?>> getRegisteredPojoTypes() {
return registeredPojoTypes;
}
+ /**
+ * Get if the auto type registration is disabled.
+ *
+ * @return if the auto type registration is disabled.
+ * @deprecated All Flink DataSet APIs are deprecated since Flink 1.18 and
will be removed in a
+ * future Flink major version. You can still build your application in
DataSet, but you
+ * should move to either the DataStream and/or Table API.
+ * @see <a
href="https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158866741";>
+ * FLIP-131: Consolidate the user-facing Dataflow SDKs/APIs (and
deprecate the DataSet
+ * API</a>
+ */
+ @Deprecated
Review Comment:
Both `disableAutoTypeRegistration ` and `AUTO_TYPE_REGISTRATION ` are
deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
