reswqa commented on code in PR #23100:
URL: https://github.com/apache/flink/pull/23100#discussion_r1284006406
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/remote/RemoteStorageScanner.java:
##########
@@ -236,15 +254,24 @@ private boolean checkSegmentExist(
partitionId,
subpartitionId.getSubpartitionId(),
segmentId);
- boolean isExist;
+ boolean isExist = false;
try {
isExist = remoteFileSystem.exists(segmentPath);
- } catch (IOException e) {
- throw new RuntimeException("Failed to check segment file. " +
segmentPath, e);
+ currentRetryTime = 0;
+ } catch (Throwable t) {
Review Comment:
To be honest, I don't like this way, but I can't think of a better way also.
In theory, `FileSystem` should handle (or wrap) exceptions that can be retried
by itself, but it doesn't help us do this. 😞
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/remote/RemoteStorageScanner.java:
##########
@@ -236,15 +254,24 @@ private boolean checkSegmentExist(
partitionId,
subpartitionId.getSubpartitionId(),
segmentId);
- boolean isExist;
+ boolean isExist = false;
try {
isExist = remoteFileSystem.exists(segmentPath);
- } catch (IOException e) {
- throw new RuntimeException("Failed to check segment file. " +
segmentPath, e);
+ currentRetryTime = 0;
+ } catch (Throwable t) {
Review Comment:
To be honest, I don't like this way, but I can't think of a better way also.
In theory, `FileSystem` should handle (or wrap) exceptions that can be retried
by itself, but it doesn't help us do this. 😞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
