[jira] [Commented] (FLINK-31166) array_contains element type error

2023-02-21 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692003#comment-17692003 ] Martijn Visser commented on FLINK-31166: [~jackylau] So this is specifically abo

[jira] [Commented] (FLINK-31041) Race condition in DefaultScheduler results in memory leak and busy loop

2023-02-21 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691998#comment-17691998 ] Danny Cranmer commented on FLINK-31041: --- Merged commit [{{b3e1492}}|https://githu

[GitHub] [flink] liuyongvs commented on pull request #21993: [FLINK-31166][table] Fix array_contains does not support null argumen…

2023-02-21 Thread via GitHub
liuyongvs commented on PR #21993: URL: https://github.com/apache/flink/pull/21993#issuecomment-1439574746 hi @snuyanzin after dig into the code, i fix it now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Updated] (FLINK-31166) array_contains element type error

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31166: --- Labels: pull-request-available (was: ) > array_contains element type error > --

[GitHub] [flink] dannycranmer merged pull request #21970: [FLINK-31041][runtime] Fix multiple restoreState when GlobalFailure occurs in a short period.

2023-02-21 Thread via GitHub
dannycranmer merged PR #21970: URL: https://github.com/apache/flink/pull/21970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

[GitHub] [flink] liuyongvs opened a new pull request, #21993: [FLINK-31166][table] Fix array_contains does not support null argumen…

2023-02-21 Thread via GitHub
liuyongvs opened a new pull request, #21993: URL: https://github.com/apache/flink/pull/21993 ## What is the purpose of the change *Fix array_contains does not support null argument when the array element type is not null.* ## Brief change log *(for example:)* -

[GitHub] [flink] dannycranmer commented on pull request #21970: [FLINK-31041][runtime] Fix multiple restoreState when GlobalFailure occurs in a short period.

2023-02-21 Thread via GitHub
dannycranmer commented on PR #21970: URL: https://github.com/apache/flink/pull/21970#issuecomment-1439572097 Thanks @huwh, seems like all open questions are resolved and CI passes. Merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #210: [FLINK-31010] Add Transformer and Estimator for GBTClassifier and GBTRegressor

2023-02-21 Thread via GitHub
Fanoid commented on code in PR #210: URL: https://github.com/apache/flink-ml/pull/210#discussion_r1113947913 ## flink-ml-lib/src/main/java/org/apache/flink/ml/common/gbt/GBTModelParams.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [flink] flinkbot commented on pull request #21992: [BP-1.17][FLINK-31132] Let hive compact operator without setting parallelism subject to sink operator's configured parallelism.

2023-02-21 Thread via GitHub
flinkbot commented on PR #21992: URL: https://github.com/apache/flink/pull/21992#issuecomment-1439566892 ## CI report: * 2da857058638b87b37c50be1cc402022fdc3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-31169) KubernetesResourceManagerDriverTest.testOnPodDeleted fails fatally due to 239 exit code

2023-02-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691994#comment-17691994 ] Matthias Pohl commented on FLINK-31169: --- https://dev.azure.com/apache-flink/apache

[jira] [Created] (FLINK-31180) Fail early when installing minikube and check whether we can retry

2023-02-21 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-31180: - Summary: Fail early when installing minikube and check whether we can retry Key: FLINK-31180 URL: https://issues.apache.org/jira/browse/FLINK-31180 Project: Flink

[GitHub] [flink] MartijnVisser commented on pull request #21985: [FLINK-31162][yarn] Use currUsr.getCredentials.getTokens instead of currUsr.getTokens

2023-02-21 Thread via GitHub
MartijnVisser commented on PR #21985: URL: https://github.com/apache/flink/pull/21985#issuecomment-1439560715 > The issue here is different and is only specific to `1.16` So this issue only occurs in 1.16 and not in 1.17 and later? Then we're good yes :) -- This is an automated mes

[GitHub] [flink] reswqa opened a new pull request, #21992: [BP-1.17][FLINK-31132] Let hive compact operator without setting parallelism subject to sink operator's configured parallelism.

2023-02-21 Thread via GitHub
reswqa opened a new pull request, #21992: URL: https://github.com/apache/flink/pull/21992 Backport FLINK-31132 to release-1.17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [flink-table-store] JingsongLi commented on pull request #547: [FLINK-31128] Add Create Table As for flink table store

2023-02-21 Thread via GitHub
JingsongLi commented on PR #547: URL: https://github.com/apache/flink-table-store/pull/547#issuecomment-1439554535 > Thanks @zhangjun0x01 , at present, the biggest problem with CTAS is that it cannot specify the primary key and partition column, which makes it almost unavailable for produc

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #546: [FLINK-31009] Add recordCount to snapshot meta

2023-02-21 Thread via GitHub
JingsongLi commented on code in PR #546: URL: https://github.com/apache/flink-table-store/pull/546#discussion_r1113926517 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreCommitImpl.java: ## @@ -477,12 +477,20 @@ private boolean tryCom

[GitHub] [flink] flinkbot commented on pull request #21991: [BP-1.17][FLINK-31091][sql-gateway] Add Ser/de for Interval types (#21945)

2023-02-21 Thread via GitHub
flinkbot commented on PR #21991: URL: https://github.com/apache/flink/pull/21991#issuecomment-1439549889 ## CI report: * f2a617eb6560c48e85f0dbff2cc1d550194bf67b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] snuyanzin opened a new pull request, #21991: [BP-1.17][FLINK-31091][sql-gateway] Add Ser/de for Interval types (#21945)

2023-02-21 Thread via GitHub
snuyanzin opened a new pull request, #21991: URL: https://github.com/apache/flink/pull/21991 This is a backport of 14adc1679fb3d025a2808af91f23f14e7c6f6e24 to 1.17.0 branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Created] (FLINK-31179) Make data structures serializable

2023-02-21 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-31179: Summary: Make data structures serializable Key: FLINK-31179 URL: https://issues.apache.org/jira/browse/FLINK-31179 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-31179) Make data structures serializable

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31179: --- Labels: pull-request-available (was: ) > Make data structures serializable > --

[GitHub] [flink-table-store] JingsongLi opened a new pull request, #551: [FLINK-31179] Make data structures serializable

2023-02-21 Thread via GitHub
JingsongLi opened a new pull request, #551: URL: https://github.com/apache/flink-table-store/pull/551 This can make our internal data structures easy to use. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Closed] (FLINK-31079) Release Testing: Verify FLINK-29663 Further improvements of adaptive batch scheduler

2023-02-21 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang closed FLINK-31079. -- Resolution: Done > Release Testing: Verify FLINK-29663 Further improvements of adaptive batch > sched

[jira] [Comment Edited] (FLINK-31079) Release Testing: Verify FLINK-29663 Further improvements of adaptive batch scheduler

2023-02-21 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691969#comment-17691969 ] Lijie Wang edited comment on FLINK-31079 at 2/22/23 7:14 AM: -

[jira] [Commented] (FLINK-31079) Release Testing: Verify FLINK-29663 Further improvements of adaptive batch scheduler

2023-02-21 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691969#comment-17691969 ] Lijie Wang commented on FLINK-31079: Thanks [~lsy]. Currently, the [{{execution.bat

[jira] [Comment Edited] (FLINK-31079) Release Testing: Verify FLINK-29663 Further improvements of adaptive batch scheduler

2023-02-21 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691969#comment-17691969 ] Lijie Wang edited comment on FLINK-31079 at 2/22/23 7:14 AM: -

[jira] [Updated] (FLINK-30129) Push projection through ChangelogNormalize

2023-02-21 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-30129: Fix Version/s: 1.18.0 > Push projection through ChangelogNormalize > -

[jira] [Commented] (FLINK-31167) Verify that no exclusions were erroneously added to the japicmp plugin

2023-02-21 Thread Biao Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691970#comment-17691970 ] Biao Liu commented on FLINK-31167: -- Hi [~mapohl] , As you mentioned, the new method wi

[GitHub] [flink-ml] lindong28 commented on pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-21 Thread via GitHub
lindong28 commented on PR #214: URL: https://github.com/apache/flink-ml/pull/214#issuecomment-1439531423 @zhipeng93 Can you help review this PR? If this PR looks good to you, I will need to send an email to the FLIP-289 voting thread to discuss the proposed API change (e.g. let `setModelDat

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-21 Thread via GitHub
lindong28 commented on code in PR #214: URL: https://github.com/apache/flink-ml/pull/214#discussion_r1113911222 ## flink-ml-servable-core/src/main/java/org/apache/flink/ml/servable/api/ModelServable.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-21 Thread via GitHub
lindong28 commented on code in PR #214: URL: https://github.com/apache/flink-ml/pull/214#discussion_r1113910042 ## flink-ml-servable-core/src/main/java/org/apache/flink/ml/servable/api/DataFrame.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Created] (FLINK-31178) Public Writer API

2023-02-21 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-31178: Summary: Public Writer API Key: FLINK-31178 URL: https://issues.apache.org/jira/browse/FLINK-31178 Project: Flink Issue Type: Improvement Component

[jira] [Updated] (FLINK-31177) To introduce a formatter for Markdown files

2023-02-21 Thread CHEN Zhongpu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] CHEN Zhongpu updated FLINK-31177: - Description: Currently, markdown files in *docs* are maintained and updated by many contributor

[GitHub] [flink] shuiqiangchen commented on pull request #21962: [FLINK-31124][Connectors/Hive] Add IT sase for HiveTableSink speculative execution

2023-02-21 Thread via GitHub
shuiqiangchen commented on PR #21962: URL: https://github.com/apache/flink/pull/21962#issuecomment-1439524626 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [flink] ChenZhongPu commented on a diff in pull request #21989: [FLINK-31174][Doc] Resolve inconsistent data format between Learn-Flink Doc and flink-training-repo

2023-02-21 Thread via GitHub
ChenZhongPu commented on code in PR #21989: URL: https://github.com/apache/flink/pull/21989#discussion_r1113906467 ## docs/content.zh/docs/learn-flink/etl.md: ## @@ -223,11 +215,11 @@ minutesByStartCell 在 Flink 不参与管理状态的情况下,你的应用也可以使用状态,但 Flink 为其管理状态提供了一些引人注目的特性: -* **本地性**:

[jira] [Created] (FLINK-31177) To introduce a formatter for Markdown files

2023-02-21 Thread CHEN Zhongpu (Jira)
CHEN Zhongpu created FLINK-31177: Summary: To introduce a formatter for Markdown files Key: FLINK-31177 URL: https://issues.apache.org/jira/browse/FLINK-31177 Project: Flink Issue Type: Impro

[jira] [Closed] (FLINK-31061) Release Testing: Verify FLINK-30376 Introduce a new flink bushy join reorder rule which based on greedy algorithm

2023-02-21 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yunhong Zheng closed FLINK-31061. - Resolution: Fixed > Release Testing: Verify FLINK-30376 Introduce a new flink bushy join reorder

[jira] [Commented] (FLINK-31061) Release Testing: Verify FLINK-30376 Introduce a new flink bushy join reorder rule which based on greedy algorithm

2023-02-21 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691961#comment-17691961 ] Yunhong Zheng commented on FLINK-31061: --- Thanks, [~JunRuiLi]  for your careful tes

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-21 Thread via GitHub
jiangxin369 commented on code in PR #214: URL: https://github.com/apache/flink-ml/pull/214#discussion_r1113903069 ## flink-ml-servable-core/src/main/java/org/apache/flink/ml/servable/api/ModelServable.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21970: [FLINK-31041][runtime] Fix multiple restoreState when GlobalFailure occurs in a short period.

2023-02-21 Thread via GitHub
zhuzhurk commented on code in PR #21970: URL: https://github.com/apache/flink/pull/21970#discussion_r1113903871 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java: ## @@ -377,6 +377,10 @@ private void restartTasks( final Set vertices

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21970: [FLINK-31041][runtime] Fix multiple restoreState when GlobalFailure occurs in a short period.

2023-02-21 Thread via GitHub
zhuzhurk commented on code in PR #21970: URL: https://github.com/apache/flink/pull/21970#discussion_r1112513443 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java: ## @@ -377,6 +377,10 @@ private void restartTasks( final Set vertices

[GitHub] [flink] flinkbot commented on pull request #21990: [Flink 31170] [docs]The spelling error of the document word causes sql to fail to execute

2023-02-21 Thread via GitHub
flinkbot commented on PR #21990: URL: https://github.com/apache/flink/pull/21990#issuecomment-1439515422 ## CI report: * 9dd7ee22fcd390e9a32e54fe914640ef2d7b888f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-21 Thread via GitHub
jiangxin369 commented on code in PR #214: URL: https://github.com/apache/flink-ml/pull/214#discussion_r1113895887 ## flink-ml-servable-core/src/main/java/org/apache/flink/ml/servable/api/DataFrame.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [flink] BoYiZhang closed pull request #21984: [Flink 31170] [docs]The spelling error of the document word causes sql to fail to execute

2023-02-21 Thread via GitHub
BoYiZhang closed pull request #21984: [Flink 31170] [docs]The spelling error of the document word causes sql to fail to execute URL: https://github.com/apache/flink/pull/21984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [flink] BoYiZhang opened a new pull request, #21990: [Flink 31170] [docs]The spelling error of the document word causes sql to fail to execute

2023-02-21 Thread via GitHub
BoYiZhang opened a new pull request, #21990: URL: https://github.com/apache/flink/pull/21990 [Flink 31170] [docs]The spelling error of the document word causes sql to fail to execute -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Commented] (FLINK-31079) Release Testing: Verify FLINK-29663 Further improvements of adaptive batch scheduler

2023-02-21 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691943#comment-17691943 ] dalongliu commented on FLINK-31079: --- But I have a confusion, does the option `[{{exec

[GitHub] [flink] ChenZhongPu commented on a diff in pull request #21989: [FLINK-31174][Doc] Resolve inconsistent data format between Learn-Flink Doc and flink-training-repo

2023-02-21 Thread via GitHub
ChenZhongPu commented on code in PR #21989: URL: https://github.com/apache/flink/pull/21989#discussion_r1113872631 ## docs/content.zh/docs/learn-flink/etl.md: ## @@ -156,56 +154,50 @@ keyBy(ride -> GeoUtils.mapToGridCell(ride.startLon, ride.startLat)) ### Keyed Stream 的聚合

[jira] [Commented] (FLINK-31079) Release Testing: Verify FLINK-29663 Further improvements of adaptive batch scheduler

2023-02-21 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691941#comment-17691941 ] dalongliu commented on FLINK-31079: --- I have finished the verification work, it works w

[jira] [Updated] (FLINK-31079) Release Testing: Verify FLINK-29663 Further improvements of adaptive batch scheduler

2023-02-21 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu updated FLINK-31079: -- Attachment: image-2023-02-22-14-00-13-646.png > Release Testing: Verify FLINK-29663 Further improvemen

[GitHub] [flink-ml] lindong28 commented on pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-21 Thread via GitHub
lindong28 commented on PR #214: URL: https://github.com/apache/flink-ml/pull/214#issuecomment-1439477023 @jiangxin369 Thanks for the review. Can you take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-21 Thread via GitHub
lindong28 commented on code in PR #214: URL: https://github.com/apache/flink-ml/pull/214#discussion_r1113864514 ## flink-ml-servable-core/src/main/java/org/apache/flink/ml/servable/api/DataFrame.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink] huwh commented on a diff in pull request #21989: [FLINK-31174][Doc] Resolve inconsistent data format between Learn-Flink Doc and flink-training-repo

2023-02-21 Thread via GitHub
huwh commented on code in PR #21989: URL: https://github.com/apache/flink/pull/21989#discussion_r1113866534 ## docs/content.zh/docs/learn-flink/etl.md: ## @@ -156,56 +154,50 @@ keyBy(ride -> GeoUtils.mapToGridCell(ride.startLon, ride.startLat)) ### Keyed Stream 的聚合 -以下代码为每

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-21 Thread via GitHub
lindong28 commented on code in PR #214: URL: https://github.com/apache/flink-ml/pull/214#discussion_r1113864514 ## flink-ml-servable-core/src/main/java/org/apache/flink/ml/servable/api/DataFrame.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink] ChenZhongPu commented on a diff in pull request #21989: [FLINK-31174][Doc] Resolve inconsistent data format between Learn-Flink Doc and flink-training-repo

2023-02-21 Thread via GitHub
ChenZhongPu commented on code in PR #21989: URL: https://github.com/apache/flink/pull/21989#discussion_r1113866401 ## docs/content.zh/docs/learn-flink/etl.md: ## @@ -223,11 +215,11 @@ minutesByStartCell 在 Flink 不参与管理状态的情况下,你的应用也可以使用状态,但 Flink 为其管理状态提供了一些引人注目的特性: -* **本地性**:

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-21 Thread via GitHub
lindong28 commented on code in PR #214: URL: https://github.com/apache/flink-ml/pull/214#discussion_r1113864514 ## flink-ml-servable-core/src/main/java/org/apache/flink/ml/servable/api/DataFrame.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-21 Thread via GitHub
lindong28 commented on code in PR #214: URL: https://github.com/apache/flink-ml/pull/214#discussion_r1113864514 ## flink-ml-servable-core/src/main/java/org/apache/flink/ml/servable/api/DataFrame.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink] ChenZhongPu commented on a diff in pull request #21989: [FLINK-31174][Doc] Resolve inconsistent data format between Learn-Flink Doc and flink-training-repo

2023-02-21 Thread via GitHub
ChenZhongPu commented on code in PR #21989: URL: https://github.com/apache/flink/pull/21989#discussion_r1113864830 ## docs/content.zh/docs/learn-flink/etl.md: ## @@ -156,56 +154,50 @@ keyBy(ride -> GeoUtils.mapToGridCell(ride.startLon, ride.startLat)) ### Keyed Stream 的聚合

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-21 Thread via GitHub
lindong28 commented on code in PR #214: URL: https://github.com/apache/flink-ml/pull/214#discussion_r1113864514 ## flink-ml-servable-core/src/main/java/org/apache/flink/ml/servable/api/DataFrame.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-21 Thread via GitHub
lindong28 commented on code in PR #214: URL: https://github.com/apache/flink-ml/pull/214#discussion_r1113864514 ## flink-ml-servable-core/src/main/java/org/apache/flink/ml/servable/api/DataFrame.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink] ChenZhongPu commented on a diff in pull request #21989: [FLINK-31174][Doc] Resolve inconsistent data format between Learn-Flink Doc and flink-training-repo

2023-02-21 Thread via GitHub
ChenZhongPu commented on code in PR #21989: URL: https://github.com/apache/flink/pull/21989#discussion_r1113864240 ## docs/content.zh/docs/learn-flink/etl.md: ## @@ -156,56 +154,50 @@ keyBy(ride -> GeoUtils.mapToGridCell(ride.startLon, ride.startLat)) ### Keyed Stream 的聚合

[GitHub] [flink] ChenZhongPu commented on a diff in pull request #21989: [FLINK-31174][Doc] Resolve inconsistent data format between Learn-Flink Doc and flink-training-repo

2023-02-21 Thread via GitHub
ChenZhongPu commented on code in PR #21989: URL: https://github.com/apache/flink/pull/21989#discussion_r1113863744 ## docs/content.zh/docs/learn-flink/etl.md: ## @@ -156,56 +154,50 @@ keyBy(ride -> GeoUtils.mapToGridCell(ride.startLon, ride.startLat)) ### Keyed Stream 的聚合

[GitHub] [flink] huwh commented on a diff in pull request #21970: [FLINK-31041][runtime] Fix multiple restoreState when GlobalFailure occurs in a short period.

2023-02-21 Thread via GitHub
huwh commented on code in PR #21970: URL: https://github.com/apache/flink/pull/21970#discussion_r1113861894 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java: ## @@ -377,6 +377,10 @@ private void restartTasks( final Set verticesToRe

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-21 Thread via GitHub
lindong28 commented on code in PR #214: URL: https://github.com/apache/flink-ml/pull/214#discussion_r1113860034 ## flink-ml-servable-core/src/main/java/org/apache/flink/ml/servable/api/DataFrame.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink] huwh commented on a diff in pull request #21989: [FLINK-31174][Doc] Resolve inconsistent data format between Learn-Flink Doc and flink-training-repo

2023-02-21 Thread via GitHub
huwh commented on code in PR #21989: URL: https://github.com/apache/flink/pull/21989#discussion_r1113855268 ## docs/content.zh/docs/learn-flink/etl.md: ## @@ -156,56 +154,50 @@ keyBy(ride -> GeoUtils.mapToGridCell(ride.startLon, ride.startLat)) ### Keyed Stream 的聚合 -以下代码为每

[GitHub] [flink] Mulavar commented on pull request #21545: [FLINK-30396][table]make alias hint take effect in correlate

2023-02-21 Thread via GitHub
Mulavar commented on PR #21545: URL: https://github.com/apache/flink/pull/21545#issuecomment-1439466347 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-21 Thread via GitHub
lindong28 commented on code in PR #214: URL: https://github.com/apache/flink-ml/pull/214#discussion_r1113836050 ## flink-ml-servable-core/src/main/java/org/apache/flink/ml/servable/api/ModelServable.java: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-21 Thread via GitHub
lindong28 commented on code in PR #214: URL: https://github.com/apache/flink-ml/pull/214#discussion_r1113836050 ## flink-ml-servable-core/src/main/java/org/apache/flink/ml/servable/api/ModelServable.java: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [flink] flinkbot commented on pull request #21989: [FLINK-31174][Doc] Resolve inconsistent data format between Learn-Flink Doc and flink-training-repo

2023-02-21 Thread via GitHub
flinkbot commented on PR #21989: URL: https://github.com/apache/flink/pull/21989#issuecomment-1439440986 ## CI report: * 53c3a395894405df70b621306f2e48ea296addf2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31174) [Doc] Inconsistent data format between flink-training-repo and learn-flink doc

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31174: --- Labels: pull-request-available (was: ) > [Doc] Inconsistent data format between flink-train

[GitHub] [flink] ChenZhongPu opened a new pull request, #21989: [FLINK-31174][Doc] Resolve FLINK-31174

2023-02-21 Thread via GitHub
ChenZhongPu opened a new pull request, #21989: URL: https://github.com/apache/flink/pull/21989 This pull request is to resolve [FLINK-31174](https://issues.apache.org/jira/browse/FLINK-31174) in which [Data Pipelines & ETL](https://nightlies.apache.org/flink/flink-docs-release-1.16/docs/l

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #210: [FLINK-31010] Add Transformer and Estimator for GBTClassifier and GBTRegressor

2023-02-21 Thread via GitHub
lindong28 commented on code in PR #210: URL: https://github.com/apache/flink-ml/pull/210#discussion_r1113828872 ## flink-ml-lib/src/main/java/org/apache/flink/ml/common/gbt/defs/Split.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #210: [FLINK-31010] Add Transformer and Estimator for GBTClassifier and GBTRegressor

2023-02-21 Thread via GitHub
lindong28 commented on code in PR #210: URL: https://github.com/apache/flink-ml/pull/210#discussion_r1113738451 ## flink-ml-lib/src/main/java/org/apache/flink/ml/common/gbt/GBTModelParams.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [flink] WencongLiu commented on a diff in pull request #21983: [FLINK-31176] [javadocs]correct the description of sql gateway configuration

2023-02-21 Thread via GitHub
WencongLiu commented on code in PR #21983: URL: https://github.com/apache/flink/pull/21983#discussion_r1113823776 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/header/session/TriggerSessionHeartbeatHeaders.java: ## @@ -27,7 +27,7 @@ import

[jira] [Commented] (FLINK-31176) correct the description of sql gateway configuration

2023-02-21 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691919#comment-17691919 ] Wencong Liu commented on FLINK-31176: - Thanks [~wangkang] ! I'll take a look. > cor

[jira] [Commented] (FLINK-31144) Slow scheduling on large-scale batch jobs

2023-02-21 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691916#comment-17691916 ] Zhu Zhu commented on FLINK-31144: - Thanks for reporting this issue! [~jto] What's the th

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #214: [FLINK-31127] Add public API classes for FLIP-289

2023-02-21 Thread via GitHub
jiangxin369 commented on code in PR #214: URL: https://github.com/apache/flink-ml/pull/214#discussion_r389168 ## flink-ml-servable-core/src/main/java/org/apache/flink/ml/servable/api/ModelServable.java: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [flink] ChenZhongPu closed pull request #21451: [hotfix][docs] Update the link for `concepts'

2023-02-21 Thread via GitHub
ChenZhongPu closed pull request #21451: [hotfix][docs] Update the link for `concepts' URL: https://github.com/apache/flink/pull/21451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Updated] (FLINK-31176) correct the description of sql gateway configuration

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31176: --- Labels: pull-request-available (was: ) > correct the description of sql gateway configurati

[GitHub] [flink] reswqa commented on pull request #21983: [FLINK-31176] [javadocs]correct the description of sql gateway configuration

2023-02-21 Thread via GitHub
reswqa commented on PR #21983: URL: https://github.com/apache/flink/pull/21983#issuecomment-1439410037 @WencongLiu Would you mind taking a look this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] reswqa commented on pull request #21984: [Flink 31170] [docs]The spelling error of the document word causes sql to fail to execute

2023-02-21 Thread via GitHub
reswqa commented on PR #21984: URL: https://github.com/apache/flink/pull/21984#issuecomment-1439408568 Thanks @BoYiZhang for the fix, would you mind referring [Apache Flink development guidelines](https://cwiki.apache.org/confluence/display/FLINK/Apache+Flink+development+guidelines) to mod

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21968: [FLINK-31123][connector/files] Add IT cases for FileSink speculative …

2023-02-21 Thread via GitHub
zhuzhurk commented on code in PR #21968: URL: https://github.com/apache/flink/pull/21968#discussion_r1113791853 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/sink/FileSinkSpeculativeITCase.java: ## @@ -100,14 +96,6 @@ void testFileSinkSp

[jira] [Commented] (FLINK-31144) Slow scheduling on large-scale batch jobs

2023-02-21 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691902#comment-17691902 ] Weihua Hu commented on FLINK-31144: --- {quote}however it seems like a configurable thres

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21968: [FLINK-31123][connector/files] Add IT cases for FileSink speculative …

2023-02-21 Thread via GitHub
zhuzhurk commented on code in PR #21968: URL: https://github.com/apache/flink/pull/21968#discussion_r1113789930 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/sink/FileSinkSpeculativeITCase.java: ## @@ -100,14 +96,6 @@ void testFileSinkSp

[GitHub] [flink] JunRuiLee commented on a diff in pull request #21977: [FLINK-31132] Compact without setting parallelism does not follow the configured sink parallelism for HiveTableSink

2023-02-21 Thread via GitHub
JunRuiLee commented on code in PR #21977: URL: https://github.com/apache/flink/pull/21977#discussion_r1113790013 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamNode.java: ## @@ -402,7 +402,7 @@ public Optional getCoordinatorProvider( }

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21968: [FLINK-31123][connector/files] Add IT cases for FileSink speculative …

2023-02-21 Thread via GitHub
zhuzhurk commented on code in PR #21968: URL: https://github.com/apache/flink/pull/21968#discussion_r1113789930 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/sink/FileSinkSpeculativeITCase.java: ## @@ -100,14 +96,6 @@ void testFileSinkSp

[GitHub] [flink] flinkbot commented on pull request #21988: [FLINK-31175][doc] Fix link doesn't work in hive_reaad_write doc

2023-02-21 Thread via GitHub
flinkbot commented on PR #21988: URL: https://github.com/apache/flink/pull/21988#issuecomment-1439388066 ## CI report: * fa7ca14faa1af410b919c7299b75c8ce2f618ada UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-31120) ConcurrentModificationException occurred in StringFunctionsITCase.test

2023-02-21 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691900#comment-17691900 ] Caizhi Weng commented on FLINK-31120: - I've left my review in the github PR. My main

[jira] [Updated] (FLINK-31176) correct the description of sql gateway configuration

2023-02-21 Thread wangkang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangkang updated FLINK-31176: - Description: correct the description of sql gateway configuration: 1.sql-gateway.session.idle-timeout 、s

[jira] [Updated] (FLINK-31176) correct the description of sql gateway configuration

2023-02-21 Thread wangkang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangkang updated FLINK-31176: - Description: correct the description of sql gateway configuration: 1.sql-gateway.session.idle-timeout 、s

[jira] [Updated] (FLINK-31175) Fix link doesn't work in hive_reaad_write doc

2023-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31175: --- Labels: pull-request-available (was: ) > Fix link doesn't work in hive_reaad_write doc > --

[jira] [Created] (FLINK-31176) correct the description of sql gateway configuration

2023-02-21 Thread wangkang (Jira)
wangkang created FLINK-31176: Summary: correct the description of sql gateway configuration Key: FLINK-31176 URL: https://issues.apache.org/jira/browse/FLINK-31176 Project: Flink Issue Type: Impr

[GitHub] [flink] reswqa commented on a diff in pull request #21977: [FLINK-31132] Compact without setting parallelism does not follow the configured sink parallelism for HiveTableSink

2023-02-21 Thread via GitHub
reswqa commented on code in PR #21977: URL: https://github.com/apache/flink/pull/21977#discussion_r1113785798 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamNode.java: ## @@ -402,7 +402,7 @@ public Optional getCoordinatorProvider( }

[GitHub] [flink] fsk119 opened a new pull request, #21988: [FLINK-31175][doc] Fix link doesn't work in hive_reaad_write doc

2023-02-21 Thread via GitHub
fsk119 opened a new pull request, #21988: URL: https://github.com/apache/flink/pull/21988 ## What is the purpose of the change *Fix document link problem and typo.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Created] (FLINK-31175) Fix link doesn't work in hive_reaad_write doc

2023-02-21 Thread Shengkai Fang (Jira)
Shengkai Fang created FLINK-31175: - Summary: Fix link doesn't work in hive_reaad_write doc Key: FLINK-31175 URL: https://issues.apache.org/jira/browse/FLINK-31175 Project: Flink Issue Type: I

[GitHub] [flink] reswqa commented on a diff in pull request #21977: [FLINK-31132] Compact without setting parallelism does not follow the configured sink parallelism for HiveTableSink

2023-02-21 Thread via GitHub
reswqa commented on code in PR #21977: URL: https://github.com/apache/flink/pull/21977#discussion_r1113785798 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamNode.java: ## @@ -402,7 +402,7 @@ public Optional getCoordinatorProvider( }

[GitHub] [flink-table-store] zhangjun0x01 commented on pull request #547: [FLINK-31128] Add Create Table As for flink table store

2023-02-21 Thread via GitHub
zhangjun0x01 commented on PR #547: URL: https://github.com/apache/flink-table-store/pull/547#issuecomment-1439381803 > Thanks @zhangjun0x01 , at present, the biggest problem with CTAS is that it cannot specify the primary key and partition column, which makes it almost unavailable for prod

[jira] [Updated] (FLINK-31174) [Doc] Inconsistent data format between flink-training-repo and learn-flink doc

2023-02-21 Thread CHEN Zhongpu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] CHEN Zhongpu updated FLINK-31174: - Description: The data format specified in [flink-training-repo|[https://github.com/apache/flink

[jira] [Updated] (FLINK-31174) [Doc] Inconsistent data format between flink-training-repo and learn-flink doc

2023-02-21 Thread CHEN Zhongpu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] CHEN Zhongpu updated FLINK-31174: - Description: The data format specified in [flink-training-repo|[https://github.com/apache/flink

[GitHub] [flink] flinkbot commented on pull request #21987: Cherry pick FLINK-31136 to master

2023-02-21 Thread via GitHub
flinkbot commented on PR #21987: URL: https://github.com/apache/flink/pull/21987#issuecomment-1439376909 ## CI report: * 03c696d26fabbc1af96056308c837481c7a845fa UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31174) [Doc] Inconsistent data format between flink-training-repo and learn-flink doc

2023-02-21 Thread CHEN Zhongpu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] CHEN Zhongpu updated FLINK-31174: - Description: The data format specified in [flink-training-repo|[https://github.com/apache/flink

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21970: [FLINK-31041][runtime] Fix multiple restoreState when GlobalFailure occurs in a short period.

2023-02-21 Thread via GitHub
zhuzhurk commented on code in PR #21970: URL: https://github.com/apache/flink/pull/21970#discussion_r1113780430 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java: ## @@ -377,6 +377,10 @@ private void restartTasks( final Set vertices

[jira] [Created] (FLINK-31174) [Doc] Inconsistent data format between flink-training-repo and learn-flink doc

2023-02-21 Thread CHEN Zhongpu (Jira)
CHEN Zhongpu created FLINK-31174: Summary: [Doc] Inconsistent data format between flink-training-repo and learn-flink doc Key: FLINK-31174 URL: https://issues.apache.org/jira/browse/FLINK-31174 Projec

  1   2   3   4   >