lindong28 commented on code in PR #214: URL: https://github.com/apache/flink-ml/pull/214#discussion_r1113836050
########## flink-ml-servable-core/src/main/java/org/apache/flink/ml/servable/api/ModelServable.java: ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.ml.servable.api; + +import org.apache.flink.annotation.PublicEvolving; + +import java.io.InputStream; + +/** + * A ModelServable is a TransformerServable with the extra API to set model data. + * + * @param <T> The class type of the ModelServable implementation itself. + */ +@PublicEvolving +public interface ModelServable<T extends ModelServable<T>> extends TransformerServable<T> { + + /** Sets model data using the serialized model data from the given input stream. */ + default T setModelData(InputStream modelData) { Review Comment: Good point. I agree we need to make setModelData() take multiple InputSreams. And we need to let these methods throw IOException. I have updated the method to the this: `default T setModelData(InputStream... modelDataInputs) throws IOException` I will send an email update to the voting thread when this PR is mostly ready for merge. ########## flink-ml-servable-core/src/main/java/org/apache/flink/ml/servable/api/ModelServable.java: ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.ml.servable.api; + +import org.apache.flink.annotation.PublicEvolving; + +import java.io.InputStream; + +/** + * A ModelServable is a TransformerServable with the extra API to set model data. + * + * @param <T> The class type of the ModelServable implementation itself. + */ +@PublicEvolving +public interface ModelServable<T extends ModelServable<T>> extends TransformerServable<T> { + + /** Sets model data using the serialized model data from the given input stream. */ + default T setModelData(InputStream modelData) { Review Comment: Good point. I agree we need to make setModelData() take multiple InputSreams. And we need to let these methods throw IOException. I have updated the method to the this: `default T setModelData(InputStream... modelDataInputs) throws IOException` I will send an email update to the voting thread when this PR is mostly ready for merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
