zhuzhurk commented on code in PR #21968:
URL: https://github.com/apache/flink/pull/21968#discussion_r1113789930


##########
flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/sink/FileSinkSpeculativeITCase.java:
##########
@@ -100,14 +96,6 @@ void testFileSinkSpeculative()
             miniCluster.executeJobBlocking(jobGraph);

Review Comment:
   It's better to use `MiniClusterExtension` and execute the job direct with 
`StreamExecutionEnvironment#execute(...)`, instead of manually maintaining and 
using a `MiniCluster`. A reference can be `RateLimitedSourceReaderITCase`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to