[GitHub] [flink] 1996fanrui commented on pull request #21690: [FLINK-30623][runtime][bug] The canEmitBatchOfRecords should check recordWriter and changelogWriterAvailabilityProvider are available

2023-01-24 Thread via GitHub
1996fanrui commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1403215622 > Ok, let's go with the `CanEmitBatchOfRecordsChecker` Hi @pnowojski , thanks for your feedback, I will update the PR today. > Just to double check, is this PR near

[jira] [Updated] (FLINK-24438) Port Kinesis Source to new Source API (FLIP-27)

2023-01-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24438: --- Labels: pull-request-available (was: ) > Port Kinesis Source to new Source API (FLIP-27) >

[GitHub] [flink-connector-aws] hlteoh37 opened a new pull request, #49: [FLINK-24438] Add Kinesis connector using FLIP-27

2023-01-24 Thread via GitHub
hlteoh37 opened a new pull request, #49: URL: https://github.com/apache/flink-connector-aws/pull/49 ## What is the purpose of the change - Implement FlinkKinesisSource using the new FLIP-27 Source interface ## Verifying this change ## Does this pull request potentially affect

[GitHub] [flink] flinkbot commented on pull request #21754: [hotfix][docs][table] Fix location typo in flink hive-dialect

2023-01-24 Thread via GitHub
flinkbot commented on PR #21754: URL: https://github.com/apache/flink/pull/21754#issuecomment-1403087860 ## CI report: * b6af133b388b8a58a5eb21847bb3cc3157fa3fa0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] Samrat002 opened a new pull request, #21754: [hotfix][docs][table] Fix location typo in flink hive-dialect

2023-01-24 Thread via GitHub
Samrat002 opened a new pull request, #21754: URL: https://github.com/apache/flink/pull/21754 ## What is the purpose of the change Fix typo in flink doc. ## Verifying this change ## Does this pull request potentially affect one of the following parts:

[GitHub] [flink] SinBex commented on pull request #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

2023-01-24 Thread via GitHub
SinBex commented on PR #21695: URL: https://github.com/apache/flink/pull/21695#issuecomment-1402996470 @zhuzhurk Thanks for reviewing, I have fixed the problems you commented. PTAL~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[jira] [Resolved] (FLINK-30301) TaskExecutorTest.testSharedResourcesLifecycle failed with TaskException

2023-01-24 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan resolved FLINK-30301. --- Fix Version/s: 1.17.0 Resolution: Fixed Merged into master as b4fe4a4288777c4

[GitHub] [flink] rkhachatryan merged pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

2023-01-24 Thread via GitHub
rkhachatryan merged PR #21467: URL: https://github.com/apache/flink/pull/21467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

[GitHub] [flink] SinBex commented on a diff in pull request #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

2023-01-24 Thread via GitHub
SinBex commented on code in PR #21695: URL: https://github.com/apache/flink/pull/21695#discussion_r1086123499 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/slowtaskdetector/ExecutionTimeBasedSlowTaskDetector.java: ## @@ -219,7 +220,8 @@ private List findExec

[GitHub] [flink] SinBex commented on a diff in pull request #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

2023-01-24 Thread via GitHub
SinBex commented on code in PR #21695: URL: https://github.com/apache/flink/pull/21695#discussion_r1086119088 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/slowtaskdetector/ExecutionTimeBasedSlowTaskDetector.java: ## @@ -168,21 +168,34 @@ private double getFi

[GitHub] [flink-kubernetes-operator] jbusche commented on pull request #510: FLINK-30577 unable to access flink artifacts dir

2023-01-24 Thread via GitHub
jbusche commented on PR #510: URL: https://github.com/apache/flink-kubernetes-operator/pull/510#issuecomment-1402839750 I tested on an OpenShift 4.10.46 Cluster, both with the helm install method, as well as building a bundle and installing in multiple namespaces. It looked good in all ca

[jira] [Commented] (FLINK-30577) OpenShift FlinkSessionJob artifact write error on non-default namespaces

2023-01-24 Thread James Busche (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680389#comment-17680389 ] James Busche commented on FLINK-30577: -- I've switched to your branch [~tagarr] and

[GitHub] [flink] rkhachatryan commented on pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

2023-01-24 Thread via GitHub
rkhachatryan commented on PR #21467: URL: https://github.com/apache/flink/pull/21467#issuecomment-1402765296 Since the previous feedback was addressed I'm going to merge the PR. Thanks for reviewing! -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Resolved] (FLINK-30328) TaskManagerWideRocksDbMemorySharingITCase.testBlockCache failed

2023-01-24 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan resolved FLINK-30328. --- Fix Version/s: 1.17.0 Resolution: Fixed Merged into master as f8105bb584f8e7b

[GitHub] [flink] rkhachatryan merged pull request #21733: [FLINK-30328][tests] Assert memory usage deviation is within bounds instead of min/max

2023-01-24 Thread via GitHub
rkhachatryan merged PR #21733: URL: https://github.com/apache/flink/pull/21733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

[GitHub] [flink] rkhachatryan commented on pull request #21733: [FLINK-30328][tests] Assert memory usage deviation is within bounds instead of min/max

2023-01-24 Thread via GitHub
rkhachatryan commented on PR #21733: URL: https://github.com/apache/flink/pull/21733#issuecomment-1402758440 Thanks for the review @AlanConfluent, merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21733: [FLINK-30328][tests] Assert memory usage deviation is within bounds instead of min/max

2023-01-24 Thread via GitHub
rkhachatryan commented on code in PR #21733: URL: https://github.com/apache/flink/pull/21733#discussion_r1085994402 ## flink-tests/src/test/java/org/apache/flink/test/state/TaskManagerWideRocksDbMemorySharingITCase.java: ## @@ -125,36 +129,45 @@ public void testBlockCache() thro

[GitHub] [flink] flinkbot commented on pull request #21753: [FLINK-30782] Use https for schemaLocations

2023-01-24 Thread via GitHub
flinkbot commented on PR #21753: URL: https://github.com/apache/flink/pull/21753#issuecomment-1402753784 ## CI report: * 02a83862bc6c3c9a4feeb90ccf8d44364552ee1f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30782) Use https for schemaLocations

2023-01-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30782: --- Labels: pull-request-available (was: ) > Use https for schemaLocations > --

[GitHub] [flink] snuyanzin opened a new pull request, #21753: [FLINK-30782] Use https for schemaLocations

2023-01-24 Thread via GitHub
snuyanzin opened a new pull request, #21753: URL: https://github.com/apache/flink/pull/21753 ## What is the purpose of the change The PR makes use `https` rather than `http` for schemalocation in pom.xml ## Verifying this change This change is a trivial rework / code clea

[jira] [Created] (FLINK-30782) Use https for schemaLocations

2023-01-24 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-30782: --- Summary: Use https for schemaLocations Key: FLINK-30782 URL: https://issues.apache.org/jira/browse/FLINK-30782 Project: Flink Issue Type: Technical Deb

[jira] [Closed] (FLINK-30766) Only parameterize tests with Flink 1.14 and 1.15

2023-01-24 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-30766. -- Fix Version/s: kubernetes-operator-1.4.0 Resolution: Fixed merged to main cb30a70dc961e6f61ddd3

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #511: [FLINK-30766][tests] Do not parameterize tests with all Flink versions

2023-01-24 Thread via GitHub
gyfora merged PR #511: URL: https://github.com/apache/flink-kubernetes-operator/pull/511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Closed] (FLINK-22137) Execute unaligned checkpoint test on a cluster

2023-01-24 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arvid Heise closed FLINK-22137. --- Resolution: Done Thanks for reminding. This has been done eons ago ;) > Execute unaligned checkpoin

[GitHub] [flink-connector-opensearch] dependabot[bot] opened a new pull request, #6: Bump opensearch from 1.3.0 to 2.5.0 in /flink-connector-opensearch

2023-01-24 Thread dependabot
dependabot[bot] opened a new pull request, #6: URL: https://github.com/apache/flink-connector-opensearch/pull/6 Bumps [opensearch](https://github.com/opensearch-project/OpenSearch) from 1.3.0 to 2.5.0. Release notes Sourced from https://github.com/opensearch-project/OpenSearch/rele

[GitHub] [flink] snuyanzin commented on a diff in pull request #21519: [FLINK-29932][table] Upgrade Calcite to 1.29.0

2023-01-24 Thread via GitHub
snuyanzin commented on code in PR #21519: URL: https://github.com/apache/flink/pull/21519#discussion_r1085686175 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java: ## @@ -1973,10 +1972,6 @@ public void onMatch(RelOptRuleCall call) {

[GitHub] [flink] snuyanzin commented on a diff in pull request #21519: [FLINK-29932][table] Upgrade Calcite to 1.29.0

2023-01-24 Thread via GitHub
snuyanzin commented on code in PR #21519: URL: https://github.com/apache/flink/pull/21519#discussion_r1085679541 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkFilterJoinRule.java: ## @@ -431,13 +431,16 @@ public void onMa

[GitHub] [flink] twalthr commented on a diff in pull request #21519: [FLINK-29932][table] Upgrade Calcite to 1.29.0

2023-01-24 Thread via GitHub
twalthr commented on code in PR #21519: URL: https://github.com/apache/flink/pull/21519#discussion_r1085506331 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java: ## @@ -1973,10 +1972,6 @@ public void onMatch(RelOptRuleCall call) {

[jira] [Assigned] (FLINK-30781) Add completed checkpoint check to cluster health check

2023-01-24 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi reassigned FLINK-30781: - Assignee: Gabor Somogyi > Add completed checkpoint check to cluster health check >

[jira] [Created] (FLINK-30781) Add completed checkpoint check to cluster health check

2023-01-24 Thread Gabor Somogyi (Jira)
Gabor Somogyi created FLINK-30781: - Summary: Add completed checkpoint check to cluster health check Key: FLINK-30781 URL: https://issues.apache.org/jira/browse/FLINK-30781 Project: Flink Issu

[jira] [Commented] (FLINK-18568) Add Support for Azure Data Lake Store Gen 2 in File Sink

2023-01-24 Thread Robert Sims (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680281#comment-17680281 ] Robert Sims commented on FLINK-18568: - Is this issue awaiting the sub-task 3 to comp

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-24 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1085316765 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/reader/CassandraSplitReader.java: ## @@ -0,0 +1,280 @@ +/* + * Lic

[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #509: [FLINK-30653] Trigger resource Events on autoscaler actions

2023-01-24 Thread via GitHub
mxm commented on code in PR #509: URL: https://github.com/apache/flink-kubernetes-operator/pull/509#discussion_r1085603239 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingExecutor.java: ## @@ -99,14 +103,27 @@ public boolean sca

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-24 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1085585517 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/reader/CassandraSplitReader.java: ## @@ -0,0 +1,280 @@ +/* + * Lic

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-24 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1085595610 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/reader/CassandraSplitReader.java: ## @@ -0,0 +1,280 @@ +/* + * Lic

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-24 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1085595610 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/reader/CassandraSplitReader.java: ## @@ -0,0 +1,280 @@ +/* + * Lic

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-24 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1085585517 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/reader/CassandraSplitReader.java: ## @@ -0,0 +1,280 @@ +/* + * Lic

[GitHub] [flink] masteryhx commented on a diff in pull request #21635: [FLINK-30613] Improve resolving schema compatibility -- Milestone one

2023-01-24 Thread via GitHub
masteryhx commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1085579491 ## flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializerSnapshot.java: ## @@ -124,11 +124,40 @@ void readSnapshot(int readVersion, DataInputVi

[GitHub] [flink] masteryhx commented on a diff in pull request #21635: [FLINK-30613] Improve resolving schema compatibility -- Milestone one

2023-01-24 Thread via GitHub
masteryhx commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1085568912 ## flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerSnapshot.java: ## @@ -290,26 +332,26 @@ protected void readOuterSnapshot(

[jira] [Closed] (FLINK-30278) Unexpected config mutation in SinkTransformationTranslator

2023-01-24 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-30278. -- Fix Version/s: 1.17.0 Resolution: Fixed Merged to master as f38c2370e85 > Unexpected c

[jira] [Updated] (FLINK-30278) Unexpected config mutation in SinkTransformationTranslator

2023-01-24 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-30278: --- Affects Version/s: (was: 1.16.0) > Unexpected config mutation in SinkTransformationTrans

[GitHub] [flink] SinBex commented on pull request #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

2023-01-24 Thread via GitHub
SinBex commented on PR #21695: URL: https://github.com/apache/flink/pull/21695#issuecomment-1402211968 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [flink] pnowojski merged pull request #21445: [FLINK-30278][streaming] Unset parallelism in the SinkTransformationTranslator if it wasn't set before

2023-01-24 Thread via GitHub
pnowojski merged PR #21445: URL: https://github.com/apache/flink/pull/21445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[GitHub] [flink] masteryhx commented on a diff in pull request #21635: [FLINK-30613] Improve resolving schema compatibility -- Milestone one

2023-01-24 Thread via GitHub
masteryhx commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1085553601 ## flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializerSnapshot.java: ## @@ -124,11 +124,40 @@ void readSnapshot(int readVersion, DataInputVi

[GitHub] [flink] kristoffSC commented on a diff in pull request #21393: [FLINK-27246][TableSQL/Runtime][master] - Include WHILE blocks in split generated java methods

2023-01-24 Thread via GitHub
kristoffSC commented on code in PR #21393: URL: https://github.com/apache/flink/pull/21393#discussion_r1085531144 ## flink-table/flink-table-code-splitter/src/main/java/org/apache/flink/table/codesplit/BlockStatementSplitter.java: ## @@ -0,0 +1,326 @@ +/* + * Licensed to the Apa

[GitHub] [flink-connector-aws] z3d1k commented on a diff in pull request #48: [FLINK-30762][ci] Add nightly build workflow

2023-01-24 Thread via GitHub
z3d1k commented on code in PR #48: URL: https://github.com/apache/flink-connector-aws/pull/48#discussion_r1085539586 ## .github/workflows/nightly.yml: ## @@ -0,0 +1,33 @@ + +# Licensed to the Apach

[GitHub] [flink] masteryhx commented on a diff in pull request #21635: [FLINK-30613] Improve resolving schema compatibility -- Milestone one

2023-01-24 Thread via GitHub
masteryhx commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1085539860 ## flink-core/src/test/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerSnapshotTest.java: ## @@ -232,14 +232,11 @@ public void testRestoreCompositeT

[GitHub] [flink-connector-aws] z3d1k commented on a diff in pull request #48: [FLINK-30762][ci] Add nightly build workflow

2023-01-24 Thread via GitHub
z3d1k commented on code in PR #48: URL: https://github.com/apache/flink-connector-aws/pull/48#discussion_r1085538878 ## .github/workflows/common.yml: ## @@ -16,66 +16,87 @@ # limitations under the License. #

[GitHub] [flink] kristoffSC commented on a diff in pull request #21393: [FLINK-27246][TableSQL/Runtime][master] - Include WHILE blocks in split generated java methods

2023-01-24 Thread via GitHub
kristoffSC commented on code in PR #21393: URL: https://github.com/apache/flink/pull/21393#discussion_r1085531144 ## flink-table/flink-table-code-splitter/src/main/java/org/apache/flink/table/codesplit/BlockStatementSplitter.java: ## @@ -0,0 +1,326 @@ +/* + * Licensed to the Apa

[GitHub] [flink] kristoffSC commented on a diff in pull request #21393: [FLINK-27246][TableSQL/Runtime][master] - Include WHILE blocks in split generated java methods

2023-01-24 Thread via GitHub
kristoffSC commented on code in PR #21393: URL: https://github.com/apache/flink/pull/21393#discussion_r1085531144 ## flink-table/flink-table-code-splitter/src/main/java/org/apache/flink/table/codesplit/BlockStatementSplitter.java: ## @@ -0,0 +1,326 @@ +/* + * Licensed to the Apa

[GitHub] [flink] snuyanzin commented on pull request #20773: [FLINK-29215][Table SQL/API] Use config based constructors for converter rules instead of deprecated

2023-01-24 Thread via GitHub
snuyanzin commented on PR #20773: URL: https://github.com/apache/flink/pull/20773#issuecomment-1402168038 Thanks for the feedback, rebased -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (FLINK-25343) HBaseConnectorITCase.testTableSourceSinkWithDDL fail on azure

2023-01-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680267#comment-17680267 ] Matthias Pohl commented on FLINK-25343: --- You have a point here. But the instabilit

[jira] [Commented] (FLINK-30778) Add Configuration into FunctionContext

2023-01-24 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680265#comment-17680265 ] Timo Walther commented on FLINK-30778: -- Even though `Configuration` is not deprecat

[jira] [Commented] (FLINK-22137) Execute unaligned checkpoint test on a cluster

2023-01-24 Thread Anton Kalashnikov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680263#comment-17680263 ] Anton Kalashnikov commented on FLINK-22137: --- I don't remember why we didn't cl

[jira] [Commented] (FLINK-25343) HBaseConnectorITCase.testTableSourceSinkWithDDL fail on azure

2023-01-24 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680261#comment-17680261 ] Ferenc Csaky commented on FLINK-25343: -- Hi! No, I was not able to spend time on thi

[jira] [Commented] (FLINK-30727) JoinReorderITCase.testBushyTreeJoinReorder failed due to IOException

2023-01-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680259#comment-17680259 ] Matthias Pohl commented on FLINK-30727: --- https://dev.azure.com/apache-flink/apache

[jira] [Commented] (FLINK-30727) JoinReorderITCase.testBushyTreeJoinReorder failed due to IOException

2023-01-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680258#comment-17680258 ] Matthias Pohl commented on FLINK-30727: --- https://dev.azure.com/apache-flink/apache

[jira] [Commented] (FLINK-30733) The AzureCI Slack bot does not list all failed builds in the Slack channel

2023-01-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680256#comment-17680256 ] Matthias Pohl commented on FLINK-30733: --- Two additional builds were missed (which

[jira] [Comment Edited] (FLINK-25343) HBaseConnectorITCase.testTableSourceSinkWithDDL fail on azure

2023-01-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679716#comment-17679716 ] Matthias Pohl edited comment on FLINK-25343 at 1/24/23 3:13 PM: --

[GitHub] [flink] XComp commented on pull request #21751: [FLINK-30619][tests] Add retry

2023-01-24 Thread via GitHub
XComp commented on PR #21751: URL: https://github.com/apache/flink/pull/21751#issuecomment-1402104138 What speaks against replacing the `Thread.sleep(10L)` with a waiting condition in the test? ``` CommonTestUtils.waitUtil( () -> upTimeGauge.getValue() > 0L,

[GitHub] [flink] flinkbot commented on pull request #21752: [FLINK-30691][sql-client] Supports the gateway mode in the sql-client

2023-01-24 Thread via GitHub
flinkbot commented on PR #21752: URL: https://github.com/apache/flink/pull/21752#issuecomment-1402057786 ## CI report: * 59acfe5e0467444b5c187967dde3cbd30dad1e5c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-24 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1085417186 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/reader/CassandraSplitReader.java: ## @@ -0,0 +1,280 @@ +/* + * Lic

[jira] [Updated] (FLINK-30691) SQL Client supports to specify endpoint address

2023-01-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30691: --- Labels: pull-request-available (was: ) > SQL Client supports to specify endpoint address >

[GitHub] [flink] fsk119 opened a new pull request, #21752: [FLINK-30691][sql-client] Supports the gateway mode in the sql-client

2023-01-24 Thread via GitHub
fsk119 opened a new pull request, #21752: URL: https://github.com/apache/flink/pull/21752 ## What is the purpose of the change *Supports the SQL Client gateway mode to allow the SQL Client connects to the SQL Gateway.* ## Brief change log - *Add command lin

[GitHub] [flink] MartijnVisser commented on pull request #21690: [FLINK-30623][runtime][bug] The canEmitBatchOfRecords should check recordWriter and changelogWriterAvailabilityProvider are available

2023-01-24 Thread via GitHub
MartijnVisser commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1402048507 Just to double check, is this PR nearing a stage where it can be merged soon? Especially since this performance regression has been open for quite some time and is a blocker for the

[jira] [Commented] (FLINK-30733) The AzureCI Slack bot does not list all failed builds in the Slack channel

2023-01-24 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680233#comment-17680233 ] Martijn Visser commented on FLINK-30733: Created #builds-debug to see if both ch

[GitHub] [flink] dawidwys commented on a diff in pull request #21635: [FLINK-30613] Improve resolving schema compatibility -- Milestone one

2023-01-24 Thread via GitHub
dawidwys commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1085396914 ## flink-core/src/test/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerSnapshotTest.java: ## @@ -232,14 +232,11 @@ public void testRestoreCompositeTy

[jira] [Updated] (FLINK-30619) AdaptiveSchedulerTest.testStatusMetrics is not stable

2023-01-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30619: --- Labels: pull-request-available test-stability (was: test-stability) > AdaptiveSchedulerTest

[GitHub] [flink] flinkbot commented on pull request #21751: [FLINK-30619][tests] Add retry

2023-01-24 Thread via GitHub
flinkbot commented on PR #21751: URL: https://github.com/apache/flink/pull/21751#issuecomment-1402034380 ## CI report: * 3503146c403a36a3466538801ee71623954c1355 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-30619) AdaptiveSchedulerTest.testStatusMetrics is not stable

2023-01-24 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680232#comment-17680232 ] Chesnay Schepler commented on FLINK-30619: -- Can't reproduce it locally. Either

[jira] [Created] (FLINK-30780) Develop ElasticCatalog to connect Flink with Elastic tables and ecosystem

2023-01-24 Thread Jira
Grzegorz Kołakowski created FLINK-30780: --- Summary: Develop ElasticCatalog to connect Flink with Elastic tables and ecosystem Key: FLINK-30780 URL: https://issues.apache.org/jira/browse/FLINK-30780

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #511: [FLINK-30766][tests] Do not parameterize tests with all Flink versions

2023-01-24 Thread via GitHub
gyfora commented on PR #511: URL: https://github.com/apache/flink-kubernetes-operator/pull/511#issuecomment-1402009883 cc @gaborgsomogyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [flink] dawidwys commented on a diff in pull request #21635: [FLINK-30613] Improve resolving schema compatibility -- Milestone one

2023-01-24 Thread via GitHub
dawidwys commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1085369657 ## flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerSnapshot.java: ## @@ -290,26 +332,26 @@ protected void readOuterSnapshot(

[GitHub] [flink] dawidwys commented on a diff in pull request #21635: [FLINK-30613] Improve resolving schema compatibility -- Milestone one

2023-01-24 Thread via GitHub
dawidwys commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1085369657 ## flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerSnapshot.java: ## @@ -290,26 +332,26 @@ protected void readOuterSnapshot(

[jira] [Updated] (FLINK-30766) Only parameterize tests with Flink 1.14 and 1.15

2023-01-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30766: --- Labels: pull-request-available (was: ) > Only parameterize tests with Flink 1.14 and 1.15 >

[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #511: [FLINK-30766][tests] Do not parameterize tests with all Flink versions

2023-01-24 Thread via GitHub
gyfora opened a new pull request, #511: URL: https://github.com/apache/flink-kubernetes-operator/pull/511 ## What is the purpose of the change - Improve test speed by only parameterizing with FlinkVersions that have different operator behaviour. - Fix flaky rollback test and make

[jira] [Updated] (FLINK-30779) Bump josdk version to 4.3.2

2023-01-24 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-30779: --- Summary: Bump josdk version to 4.3.2 (was: Bomp josdk version to 4.3.2) > Bump josdk version to 4.3

[jira] [Created] (FLINK-30779) Bomp josdk version to 4.3.2

2023-01-24 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-30779: -- Summary: Bomp josdk version to 4.3.2 Key: FLINK-30779 URL: https://issues.apache.org/jira/browse/FLINK-30779 Project: Flink Issue Type: Improvement Com

[jira] [Comment Edited] (FLINK-29540) SubQueryAntiJoinTest started to fail after Calcite 1.27

2023-01-24 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680219#comment-17680219 ] Sergey Nuyanzin edited comment on FLINK-29540 at 1/24/23 1:28 PM:

[jira] [Commented] (FLINK-29540) SubQueryAntiJoinTest started to fail after Calcite 1.27

2023-01-24 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680219#comment-17680219 ] Sergey Nuyanzin commented on FLINK-29540: - I workarounded it in Flink code howev

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-24 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1085316765 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/reader/CassandraSplitReader.java: ## @@ -0,0 +1,280 @@ +/* + * Lic

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-01-24 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1085311136 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/reader/CassandraSplitReader.java: ## @@ -0,0 +1,280 @@ +/* + * Lic

[jira] [Assigned] (FLINK-29215) Use config based constructors for flink calcite Converter rules

2023-01-24 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-29215: Assignee: Sergey Nuyanzin > Use config based constructors for flink calcite Converter rul

[jira] [Commented] (FLINK-30733) The AzureCI Slack bot does not list all failed builds in the Slack channel

2023-01-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680209#comment-17680209 ] Matthias Pohl commented on FLINK-30733: --- Just for documentation purposes: One requ

[jira] [Closed] (FLINK-30763) Make TestingLeaderElectionService comply to how the LeaderElectionService interface is intended

2023-01-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl closed FLINK-30763. - Resolution: Duplicate > Make TestingLeaderElectionService comply to how the LeaderElectionServic

[jira] [Resolved] (FLINK-30761) Remove JVM asserts from leader election code

2023-01-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-30761. --- Fix Version/s: 1.17.0 Resolution: Fixed master: b26c695b5332dd44f9c744cf7d7c0db539892

[GitHub] [flink] XComp merged pull request #21738: [FLINK-30761][coordination,test] Replaces JVM assert with Preconditions in leader election code

2023-01-24 Thread via GitHub
XComp merged PR #21738: URL: https://github.com/apache/flink/pull/21738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

[jira] [Commented] (FLINK-30760) Fix @GuardedBy and @Nullable annotations in DefaultLeaderElectionService

2023-01-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680203#comment-17680203 ] Matthias Pohl commented on FLINK-30760: --- I didn't backport this change despite it

[jira] [Resolved] (FLINK-30760) Fix @GuardedBy and @Nullable annotations in DefaultLeaderElectionService

2023-01-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-30760. --- Fix Version/s: 1.17.0 Resolution: Fixed master: bf1fc7ad206421509433346351dcd8f6f23ea

[GitHub] [flink] dawidwys commented on a diff in pull request #21635: [FLINK-30613] Improve resolving schema compatibility -- Milestone one

2023-01-24 Thread via GitHub
dawidwys commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1085267360 ## flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializerSnapshot.java: ## @@ -124,11 +124,40 @@ void readSnapshot(int readVersion, DataInputVie

[GitHub] [flink] XComp merged pull request #21737: [FLINK-30760][runtime] Fixes wrongly used @GuardedBy annotation

2023-01-24 Thread via GitHub
XComp merged PR #21737: URL: https://github.com/apache/flink/pull/21737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

[jira] [Resolved] (FLINK-30759) Merge DispatcherRunnerLeaderElectionLifecycleManager into DefaultDispatcherRunner

2023-01-24 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-30759. --- Fix Version/s: 1.17.0 Resolution: Fixed master: 2d1d61c68d81eba0f721b10eaf2a7246aa081

[GitHub] [flink] XComp merged pull request #21740: [FLINK-30759][runtime] Merges DispatcherRunnerLeaderElectionLifecycleManager into DefaultDispatcherRunner

2023-01-24 Thread via GitHub
XComp merged PR #21740: URL: https://github.com/apache/flink/pull/21740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

[GitHub] [flink] XComp commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2023-01-24 Thread via GitHub
XComp commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1085241002 ## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/functions/table/fullcache/inputformat/InputFormatCacheLoaderTest.java: ## @@ -123,46 +127,

[GitHub] [flink] fsk119 commented on pull request #21717: [FLINK-29945][sql-client] Supports to submit SQL to a embedded SQL Ga…

2023-01-24 Thread via GitHub
fsk119 commented on PR #21717: URL: https://github.com/apache/flink/pull/21717#issuecomment-1401848129 I also run the TPC-h e2e test in my private pipeline. It all passes. I think with the commit a94aff3, the sql client exits without the risk of the resource leak if the connection is stable

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #509: [FLINK-30653] Trigger resource Events on autoscaler actions

2023-01-24 Thread via GitHub
gyfora commented on code in PR #509: URL: https://github.com/apache/flink-kubernetes-operator/pull/509#discussion_r1085187769 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingExecutor.java: ## @@ -99,14 +103,27 @@ public boolean

[GitHub] [flink] zentol merged pull request #21749: Remove redundant char

2023-01-24 Thread via GitHub
zentol merged PR #21749: URL: https://github.com/apache/flink/pull/21749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #509: [FLINK-30653] Trigger resource Events on autoscaler actions

2023-01-24 Thread via GitHub
mxm commented on code in PR #509: URL: https://github.com/apache/flink-kubernetes-operator/pull/509#discussion_r1085133129 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingExecutor.java: ## @@ -116,6 +133,20 @@ public boolean sca

[GitHub] [flink] MartijnVisser commented on pull request #21295: [Typo] Fix the typo 'retriable', which means 'retryable'.

2023-01-24 Thread via GitHub
MartijnVisser commented on PR #21295: URL: https://github.com/apache/flink/pull/21295#issuecomment-1401715188 Closing this PR because the Pulsar connector has been externalized to https://github.com/apache/flink-connector-pulsar/ -- This is an automated message from the Apache Git Service

[GitHub] [flink] MartijnVisser closed pull request #21295: [Typo] Fix the typo 'retriable', which means 'retryable'.

2023-01-24 Thread via GitHub
MartijnVisser closed pull request #21295: [Typo] Fix the typo 'retriable', which means 'retryable'. URL: https://github.com/apache/flink/pull/21295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

  1   2   >