gyfora commented on code in PR #509:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/509#discussion_r1085187769
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingExecutor.java:
##########
@@ -99,14 +103,27 @@ public boolean scaleResource(
return false;
}
+ var scalingReport = scalingReport(scalingSummaries);
+ eventRecorder.triggerEvent(
+ resource,
+ EventRecorder.Type.Normal,
+ EventRecorder.Reason.ScalingReport,
+ EventRecorder.Component.Operator,
+ scalingReport);
+
+ if (!conf.get(SCALING_ENABLED)) {
+ return false;
+ }
Review Comment:
I think that is completely expected. This will make events useful in case
the user prefers to trigger actions manually. For instance when trying out the
autoscaler initially.
When scaling actions are disabled events are actually actionable to the user
this way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
