mxm commented on code in PR #509:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/509#discussion_r1085603239
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingExecutor.java:
##########
@@ -99,14 +103,27 @@ public boolean scaleResource(
return false;
}
+ var scalingReport = scalingReport(scalingSummaries);
+ eventRecorder.triggerEvent(
+ resource,
+ EventRecorder.Type.Normal,
+ EventRecorder.Reason.ScalingReport,
+ EventRecorder.Component.Operator,
+ scalingReport);
+
+ if (!conf.get(SCALING_ENABLED)) {
+ return false;
+ }
Review Comment:
Absolutely, I think this is a great addition, but only if we inform the
users that the scaling wasn’t actually executed. We can include this in the
event message. Otherwise I foresee confusion around whether the scaling was
executed or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
