[jira] [Commented] (FLINK-30498) frocksdb throw an UnsatisfiedLinkError

[ https://issues.apache.org/jira/browse/FLINK-30498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651955#comment-17651955 ] tanjialiang commented on FLINK-30498: - Hi [~Yanfei Lei] , i made a stupid mistake, i

[GitHub] [flink] swuferhong commented on a diff in pull request #21489: [FLINK-30365][table-planner] New dynamic partition pruning strategy to support more dpp patterns

swuferhong commented on code in PR #21489: URL: https://github.com/apache/flink/pull/21489#discussion_r1057120484 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/utils/DynamicPartitionPruningUtils.java: ## @@ -275,6 +400,19 @@ && isSuitableFilter

[GitHub] [flink] swuferhong commented on a diff in pull request #21489: [FLINK-30365][table-planner] New dynamic partition pruning strategy to support more dpp patterns

swuferhong commented on code in PR #21489: URL: https://github.com/apache/flink/pull/21489#discussion_r1057118501 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/utils/DynamicPartitionPruningUtils.java: ## @@ -201,33 +224,128 @@ private static voi

[jira] [Created] (FLINK-30503) KafkaSourceITCase$IntegrationTests.testSavepoint failed with timeout

Qingsheng Ren created FLINK-30503: - Summary: KafkaSourceITCase$IntegrationTests.testSavepoint failed with timeout Key: FLINK-30503 URL: https://issues.apache.org/jira/browse/FLINK-30503 Project: Flink

[GitHub] [flink] chucheng92 commented on pull request #21464: [FLINK-30334][runtime] Fix SourceCoordinator#handleRequestSplitEvent hasNoMoreSplits check not consider the hybridsource situation

chucheng92 commented on PR #21464: URL: https://github.com/apache/flink/pull/21464#issuecomment-1364967557 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [flink] swuferhong commented on a diff in pull request #21489: [FLINK-30365][table-planner] New dynamic partition pruning strategy to support more dpp patterns

swuferhong commented on code in PR #21489: URL: https://github.com/apache/flink/pull/21489#discussion_r1057114326 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/utils/DynamicPartitionPruningUtils.java: ## @@ -60,138 +68,153 @@ public class Dynam

[GitHub] [flink] swuferhong commented on a diff in pull request #21489: [FLINK-30365][table-planner] New dynamic partition pruning strategy to support more dpp patterns

swuferhong commented on code in PR #21489: URL: https://github.com/apache/flink/pull/21489#discussion_r1057113411 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/utils/DynamicPartitionPruningUtils.java: ## @@ -60,138 +68,153 @@ public class Dynam

[GitHub] [flink] fsk119 commented on a diff in pull request #20652: [FLINK-22315][table] Support ADD column/constraint/watermark for ALTER TABLE statement

fsk119 commented on code in PR #20652: URL: https://github.com/apache/flink/pull/20652#discussion_r1057106746 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/AlterSchemaConverter.java: ## @@ -0,0 +1,436 @@ +/* + * Licensed to the Apache

[GitHub] [flink] swuferhong commented on a diff in pull request #21489: [FLINK-30365][table-planner] New dynamic partition pruning strategy to support more dpp patterns

swuferhong commented on code in PR #21489: URL: https://github.com/apache/flink/pull/21489#discussion_r1057112096 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/optimize/program/FlinkChainedProgram.scala: ## @@ -59,6 +59,10 @@ class FlinkCh

[GitHub] [flink] swuferhong commented on a diff in pull request #21489: [FLINK-30365][table-planner] New dynamic partition pruning strategy to support more dpp patterns

swuferhong commented on code in PR #21489: URL: https://github.com/apache/flink/pull/21489#discussion_r1057111849 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/optimize/program/FlinkBatchProgram.scala: ## @@ -40,6 +40,7 @@ object FlinkBatc

[GitHub] [flink] swuferhong commented on a diff in pull request #21489: [FLINK-30365][table-planner] New dynamic partition pruning strategy to support more dpp patterns

swuferhong commented on code in PR #21489: URL: https://github.com/apache/flink/pull/21489#discussion_r1057111352 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/program/FlinkDynamicPartitionPruningConverterProgram.java: ## @@ -0,0 +

[GitHub] [flink] swuferhong commented on a diff in pull request #21489: [FLINK-30365][table-planner] New dynamic partition pruning strategy to support more dpp patterns

swuferhong commented on code in PR #21489: URL: https://github.com/apache/flink/pull/21489#discussion_r1057109304 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/program/FlinkDynamicPartitionPruningConverterProgram.java: ## @@ -0,0 +

[jira] [Created] (FLINK-30502) Checkpoint state Continued to increase

heyu dou created FLINK-30502: Summary: Checkpoint state Continued to increase Key: FLINK-30502 URL: https://issues.apache.org/jira/browse/FLINK-30502 Project: Flink Issue Type: Bug Envir

[GitHub] [flink] godfreyhe commented on a diff in pull request #21490: [FLINK-30368][table-planner] Fix calcite method RelMdUtil$numDistinctVals() wrongly return zero if the method input domainSize mu

godfreyhe commented on code in PR #21490: URL: https://github.com/apache/flink/pull/21490#discussion_r1057104671 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/FlinkRelMdUtil.scala: ## @@ -247,6 +248,77 @@ object FlinkRelMdUtil {

[GitHub] [flink] chucheng92 commented on a diff in pull request #21464: [FLINK-30334][runtime] Fix SourceCoordinator#handleRequestSplitEvent hasNoMoreSplits check not consider the hybridsource situati

chucheng92 commented on code in PR #21464: URL: https://github.com/apache/flink/pull/21464#discussion_r1057102434 ## flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorContext.java: ## @@ -289,6 +290,20 @@ public void signalNoMoreSplits(int

[GitHub] [flink] huwh commented on pull request #21496: [FLINK-29869][ResourceManager] make ResourceAllocator declarative.

huwh commented on PR #21496: URL: https://github.com/apache/flink/pull/21496#issuecomment-1364945022 Thanks, @xintongsong, comments are addressed except the XXXWithDely, we can address this in another PR. I force pushed the new commits since it is not easy to avoid conflict while mov

[GitHub] [flink] chucheng92 commented on pull request #21464: [FLINK-30334][runtime] Fix SourceCoordinator#handleRequestSplitEvent hasNoMoreSplits check not consider the hybridsource situation

chucheng92 commented on PR #21464: URL: https://github.com/apache/flink/pull/21464#issuecomment-1364941930 @zhuzhurk thanks for reviewing, i have fixed the problem you commented. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] godfreyhe commented on a diff in pull request #21489: [FLINK-30365][table-planner] New dynamic partition pruning strategy to support more dpp patterns

godfreyhe commented on code in PR #21489: URL: https://github.com/apache/flink/pull/21489#discussion_r1057087887 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/optimize/program/FlinkChainedProgram.scala: ## @@ -59,6 +59,10 @@ class FlinkCha

[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #188: [FLINK-30249] Fix TableUtils.getRowTypeInfo by using ExternalTypeInfo.of()

yunfengzhou-hub commented on code in PR #188: URL: https://github.com/apache/flink-ml/pull/188#discussion_r1057097049 ## flink-ml-core/src/test/java/org/apache/flink/ml/common/datastream/TableUtilsTest.java: ## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] fsk119 commented on pull request #21523: [FLINK-30449][sql-gateway] Introduce ResultInfo to improve the serialization and deserialization of FetchResultsResponseBody

fsk119 commented on PR #21523: URL: https://github.com/apache/flink/pull/21523#issuecomment-1364933540 I add a commit to improve the codes. @yuzelin Please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [flink] fsk119 commented on a diff in pull request #21523: [FLINK-30449][sql-gateway] Introduce ResultInfo to improve the serialization and deserialization of FetchResultsResponseBody

fsk119 commented on code in PR #21523: URL: https://github.com/apache/flink/pull/21523#discussion_r1057089320 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/serde/ResultInfoJsonSerDeTest.java: ## @@ -75,80 +79,73 @@ /** Tests for {@link Res

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21464: [FLINK-30334][runtime] Fix SourceCoordinator#handleRequestSplitEvent hasNoMoreSplits check not consider the hybridsource situation

zhuzhurk commented on code in PR #21464: URL: https://github.com/apache/flink/pull/21464#discussion_r1057088280 ## flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorContext.java: ## @@ -289,6 +290,20 @@ public void signalNoMoreSplits(int su

[GitHub] [flink] luoyuxia commented on pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive

luoyuxia commented on PR #21542: URL: https://github.com/apache/flink/pull/21542#issuecomment-1364921704 > Theses change looks good to me. I perfer to find some times to verify it will still work in my hive test env. I'm back. I have verified with Hive 2.3.9 & Hive 3.1.3, it still wor

[jira] [Commented] (FLINK-30360) A null pointer exception is thrown when data is written to the HBase table using the specified column name

[ https://issues.apache.org/jira/browse/FLINK-30360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651931#comment-17651931 ] Jichao Wang commented on FLINK-30360: - Yes, the NullPointerException is present beca

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21464: [FLINK-30334][runtime] Fix SourceCoordinator#handleRequestSplitEvent hasNoMoreSplits check not consider the hybridsource situation

zhuzhurk commented on code in PR #21464: URL: https://github.com/apache/flink/pull/21464#discussion_r1057075092 ## flink-core/src/test/java/org/apache/flink/api/connector/source/mocks/MockSplitEnumeratorContext.java: ## @@ -120,7 +123,14 @@ public void assignSplits(SplitsAssignm

[GitHub] [flink] chucheng92 commented on pull request #21464: [FLINK-30334][runtime] Fix SourceCoordinator#handleRequestSplitEvent hasNoMoreSplits check not consider the hybridsource situation

chucheng92 commented on PR #21464: URL: https://github.com/apache/flink/pull/21464#issuecomment-1364908830 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Commented] (FLINK-30475) Improved speed of RocksDBMapState clear() using rocksDB.deleteRange

[ https://issues.apache.org/jira/browse/FLINK-30475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651921#comment-17651921 ] Yanfei Lei commented on FLINK-30475: Hi [~b923],  this optimization may increase the

[GitHub] [flink] swuferhong commented on a diff in pull request #21487: [FLINK-30270][table-planner] Fix FlinkJoinToMultiJoinRule incorrectly combines Left/Right outer join to MultiJoin error

swuferhong commented on code in PR #21487: URL: https://github.com/apache/flink/pull/21487#discussion_r1057056150 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/rules/logical/FlinkJoinToMultiJoinRuleTest.xml: ## @@ -548,6 +549,46 @@ Log

[GitHub] [flink] godfreyhe commented on a diff in pull request #21545: [FLINK-30396][table]make alias hint take effect in correlate

godfreyhe commented on code in PR #21545: URL: https://github.com/apache/flink/pull/21545#discussion_r1057055251 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/hint/FlinkHints.java: ## @@ -189,18 +191,33 @@ public static RelNode capitalizeJoinHin

[GitHub] [flink] chucheng92 commented on pull request #21464: [FLINK-30334][runtime] Fix SourceCoordinator#handleRequestSplitEvent hasNoMoreSplits check not consider the hybridsource situation

chucheng92 commented on PR #21464: URL: https://github.com/apache/flink/pull/21464#issuecomment-1364874178 > @chucheng92 F.I.Y. the community is preparing to release 1.16.1. I hope we can get this issue fixed in this release. Would you try if the suggested way can work? Yes, done wit

[jira] [Commented] (FLINK-30498) frocksdb throw an UnsatisfiedLinkError

[ https://issues.apache.org/jira/browse/FLINK-30498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651919#comment-17651919 ] Yanfei Lei commented on FLINK-30498: Hi [~tanjialiang] , I guess it may be caused by

[GitHub] [flink] swuferhong commented on a diff in pull request #21487: [FLINK-30270][table-planner] Fix FlinkJoinToMultiJoinRule incorrectly combines Left/Right outer join to MultiJoin error

swuferhong commented on code in PR #21487: URL: https://github.com/apache/flink/pull/21487#discussion_r1057053036 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkJoinToMultiJoinRule.java: ## @@ -178,6 +193,60 @@ public void

[GitHub] [flink] swuferhong commented on a diff in pull request #21487: [FLINK-30270][table-planner] Fix FlinkJoinToMultiJoinRule incorrectly combines Left/Right outer join to MultiJoin error

swuferhong commented on code in PR #21487: URL: https://github.com/apache/flink/pull/21487#discussion_r1057051388 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkJoinToMultiJoinRule.java: ## @@ -178,6 +193,60 @@ public void

[GitHub] [flink] fsk119 commented on a diff in pull request #21525: [FLINK-30416][sql-gateway] Add configureSession REST API in the SQL Gateway

fsk119 commented on code in PR #21525: URL: https://github.com/apache/flink/pull/21525#discussion_r1057036923 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/util/SqlGatewayRestAPIVersion.java: ## @@ -34,8 +39,14 @@ implements RestAPIV

[GitHub] [flink-ml] weibozhao commented on a diff in pull request #189: [FLINK-30348] Refine Transformer for RandomSplitter

weibozhao commented on code in PR #189: URL: https://github.com/apache/flink-ml/pull/189#discussion_r1057047880 ## flink-ml-lib/src/test/java/org/apache/flink/ml/feature/RandomSplitterTest.java: ## @@ -95,7 +96,7 @@ public void testOutputSchema() { @Test public void te

[GitHub] [flink] godfreyhe commented on a diff in pull request #21487: [FLINK-30270][table-planner] Fix FlinkJoinToMultiJoinRule incorrectly combines Left/Right outer join to MultiJoin error

godfreyhe commented on code in PR #21487: URL: https://github.com/apache/flink/pull/21487#discussion_r1057047679 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkJoinToMultiJoinRule.java: ## @@ -178,6 +193,60 @@ public void

[GitHub] [flink] godfreyhe commented on a diff in pull request #21487: [FLINK-30270][table-planner] Fix FlinkJoinToMultiJoinRule incorrectly combines Left/Right outer join to MultiJoin error

godfreyhe commented on code in PR #21487: URL: https://github.com/apache/flink/pull/21487#discussion_r1057046977 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkJoinToMultiJoinRule.java: ## @@ -178,6 +193,60 @@ public void

[GitHub] [flink-ml] weibozhao commented on a diff in pull request #189: [FLINK-30348] Refine Transformer for RandomSplitter

weibozhao commented on code in PR #189: URL: https://github.com/apache/flink-ml/pull/189#discussion_r1057045262 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/randomsplitter/RandomSplitter.java: ## @@ -83,11 +84,12 @@ public Table[] transform(Table... inputs) {

[GitHub] [flink] xintongsong commented on a diff in pull request #21496: [FLINK-29869][ResourceManager] make ResourceAllocator declarative.

xintongsong commented on code in PR #21496: URL: https://github.com/apache/flink/pull/21496#discussion_r1057033790 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/active/ActiveResourceManager.java: ## @@ -290,13 +321,79 @@ public void onError(Throwable ex

[jira] [Commented] (FLINK-23411) Expose Flink checkpoint details metrics

[ https://issues.apache.org/jira/browse/FLINK-23411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651915#comment-17651915 ] Hangxiang Yu commented on FLINK-23411: -- I think it's helpful for users to find the

[GitHub] [flink-table-store] tsreaper merged pull request #410: [FLINK-30247] Introduce time travel reading for table store

tsreaper merged PR #410: URL: https://github.com/apache/flink-table-store/pull/410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@fl

[GitHub] [flink] chucheng92 commented on pull request #21464: [FLINK-30334][runtime] Fix SourceCoordinator#handleRequestSplitEvent hasNoMoreSplits check not consider the hybridsource situation

chucheng92 commented on PR #21464: URL: https://github.com/apache/flink/pull/21464#issuecomment-1364828231 > @chucheng92 F.I.Y. the community is preparing to release 1.16.1. I hope we can get this issue fixed in this release. Would you try if the suggested way can work? Yes, almost d

[jira] [Commented] (FLINK-27246) Code of method "processElement(Lorg/apache/flink/streaming/runtime/streamrecord/StreamRecord;)V" of class "HashAggregateWithKeys$9211" grows beyond 64 KB

[ https://issues.apache.org/jira/browse/FLINK-27246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651905#comment-17651905 ] Caizhi Weng commented on FLINK-27246: - Hi [~KristoffSC]! Sorry for the long delay a

[GitHub] [flink] swuferhong commented on a diff in pull request #21487: [FLINK-30270][table-planner] Fix FlinkJoinToMultiJoinRule incorrectly combines Left/Right outer join to MultiJoin error

swuferhong commented on code in PR #21487: URL: https://github.com/apache/flink/pull/21487#discussion_r1057034318 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/rules/logical/FlinkJoinToMultiJoinRuleTest.scala: ## @@ -268,4 +291,19 @@ class

[GitHub] [flink] swuferhong commented on a diff in pull request #21487: [FLINK-30270][table-planner] Fix FlinkJoinToMultiJoinRule incorrectly combines Left/Right outer join to MultiJoin error

swuferhong commented on code in PR #21487: URL: https://github.com/apache/flink/pull/21487#discussion_r1057032129 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkJoinToMultiJoinRule.java: ## @@ -378,25 +513,53 @@ private Li

[GitHub] [flink] swuferhong commented on a diff in pull request #21487: [FLINK-30270][table-planner] Fix FlinkJoinToMultiJoinRule incorrectly combines Left/Right outer join to MultiJoin error

swuferhong commented on code in PR #21487: URL: https://github.com/apache/flink/pull/21487#discussion_r1057031860 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkJoinToMultiJoinRule.java: ## @@ -348,22 +456,49 @@ private vo

[jira] [Commented] (FLINK-28863) Snapshot result of RocksDB native savepoint should have empty shared-state

[ https://issues.apache.org/jira/browse/FLINK-28863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651901#comment-17651901 ] Yun Tang commented on FLINK-28863: -- merged in release-1.16: bb17c3baab727c23059db978ca4

[GitHub] [flink] swuferhong commented on a diff in pull request #21487: [FLINK-30270][table-planner] Fix FlinkJoinToMultiJoinRule incorrectly combines Left/Right outer join to MultiJoin error

swuferhong commented on code in PR #21487: URL: https://github.com/apache/flink/pull/21487#discussion_r1057030213 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkJoinToMultiJoinRule.java: ## @@ -178,6 +193,60 @@ public void

[GitHub] [flink] lsyldliu commented on pull request #21401: [FLINK-29718][table] Supports hive sum function by native implementation

lsyldliu commented on PR #21401: URL: https://github.com/apache/flink/pull/21401#issuecomment-1364803660 @luoyuxia Thanks for your review, I've addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [flink] lsyldliu commented on a diff in pull request #21401: [FLINK-29718][table] Supports hive sum function by native implementation

lsyldliu commented on code in PR #21401: URL: https://github.com/apache/flink/pull/21401#discussion_r1057025938 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectAggITCase.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache

[GitHub] [flink] lsyldliu commented on a diff in pull request #21401: [FLINK-29718][table] Supports hive sum function by native implementation

lsyldliu commented on code in PR #21401: URL: https://github.com/apache/flink/pull/21401#discussion_r1057025779 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectAggITCase.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache

[GitHub] [flink] swuferhong commented on a diff in pull request #21487: [FLINK-30270][table-planner] Fix FlinkJoinToMultiJoinRule incorrectly combines Left/Right outer join to MultiJoin error

swuferhong commented on code in PR #21487: URL: https://github.com/apache/flink/pull/21487#discussion_r1057024501 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkJoinToMultiJoinRule.java: ## @@ -178,6 +193,60 @@ public void

[GitHub] [flink] lsyldliu commented on a diff in pull request #21401: [FLINK-29718][table] Supports hive sum function by native implementation

lsyldliu commented on code in PR #21401: URL: https://github.com/apache/flink/pull/21401#discussion_r1057025152 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveSumAggFunction.java: ## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apac

[GitHub] [flink] swuferhong commented on a diff in pull request #21487: [FLINK-30270][table-planner] Fix FlinkJoinToMultiJoinRule incorrectly combines Left/Right outer join to MultiJoin error

swuferhong commented on code in PR #21487: URL: https://github.com/apache/flink/pull/21487#discussion_r1057024501 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkJoinToMultiJoinRule.java: ## @@ -178,6 +193,60 @@ public void

[GitHub] [flink] swuferhong commented on a diff in pull request #21487: [FLINK-30270][table-planner] Fix FlinkJoinToMultiJoinRule incorrectly combines Left/Right outer join to MultiJoin error

swuferhong commented on code in PR #21487: URL: https://github.com/apache/flink/pull/21487#discussion_r1057024501 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkJoinToMultiJoinRule.java: ## @@ -178,6 +193,60 @@ public void

[GitHub] [flink] lsyldliu commented on a diff in pull request #21401: [FLINK-29718][table] Supports hive sum function by native implementation

lsyldliu commented on code in PR #21401: URL: https://github.com/apache/flink/pull/21401#discussion_r1057024307 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectAggITCase.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache

[GitHub] [flink] lsyldliu commented on a diff in pull request #21401: [FLINK-29718][table] Supports hive sum function by native implementation

lsyldliu commented on code in PR #21401: URL: https://github.com/apache/flink/pull/21401#discussion_r1057023325 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectAggITCase.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache

[GitHub] [flink] rkhachatryan commented on pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

rkhachatryan commented on PR #21467: URL: https://github.com/apache/flink/pull/21467#issuecomment-1364749575 Thanks for the review @XComp. I've addressed your comments, could you take another look? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

rkhachatryan commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1057006570 ## flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/NoOpHeartbeatServices.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

rkhachatryan commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1057005130 ## flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatMonitorImpl.java: ## @@ -39,6 +39,8 @@ private static final Logger LOG = LoggerF

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

rkhachatryan commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1057006287 ## flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterTest.java: ## @@ -202,8 +203,8 @@ static void setupAll() { rpcService = new Tes

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

rkhachatryan commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1057006257 ## flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java: ## @@ -2896,7 +2899,9 @@ private TaskExecutorTestingContext createTask

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

rkhachatryan commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1057005130 ## flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatMonitorImpl.java: ## @@ -39,6 +39,8 @@ private static final Logger LOG = LoggerF

[jira] [Updated] (FLINK-30329) flink-kubernetes-operator helm chart does not work with dynamic config because of use of volumeMount subPath

[ https://issues.apache.org/jira/browse/FLINK-30329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-30329: --- Fix Version/s: kubernetes-operator-1.2.1 > flink-kubernetes-operator helm chart does not work with d

[jira] [Updated] (FLINK-30329) flink-kubernetes-operator helm chart does not work with dynamic config because of use of volumeMount subPath

[ https://issues.apache.org/jira/browse/FLINK-30329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-30329: --- Fix Version/s: kubernetes-operator-1.3.1 (was: kubernetes-operator-1.2.1) > f

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #494: [backport][FLINK-30329] Mount flink-operator-config-volume at /opt/flink/conf without subPath

gyfora merged PR #494: URL: https://github.com/apache/flink-kubernetes-operator/pull/494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [flink] zhuzhurk commented on pull request #21464: [FLINK-30334][runtime] Fix SourceCoordinator#handleRequestSplitEvent hasNoMoreSplits check not consider the hybridsource situation

zhuzhurk commented on PR #21464: URL: https://github.com/apache/flink/pull/21464#issuecomment-1364686045 @chucheng92 F.I.Y. the community is preparing to release 1.16.1. I hope we can get this issue fixed in this release. Would you try if the suggested way can work? -- This is an autom

[GitHub] [flink] lincoln-lil commented on a diff in pull request #21545: [FLINK-30396][table]make alias hint take effect in correlate

lincoln-lil commented on code in PR #21545: URL: https://github.com/apache/flink/pull/21545#discussion_r1056946337 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/alias/ClearJoinHintWithInvalidPropagationShuttle.java: ## @@ -66,7 +78,7 @@ public R

[jira] [Updated] (FLINK-30501) Set requireJavaVersion in pom.xml to be at least 11

[ https://issues.apache.org/jira/browse/FLINK-30501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-30501: - Component/s: Build System / CI > Set requireJavaVersion in pom.xml to be at least 11 > -

[jira] [Updated] (FLINK-30501) Set requireJavaVersion in pom.xml to be at least 11

[ https://issues.apache.org/jira/browse/FLINK-30501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-30501: - Fix Version/s: 1.17.0 > Set requireJavaVersion in pom.xml to be at least 11 > --

[jira] [Updated] (FLINK-30501) Set requireJavaVersion in pom.xml to be at least 11

[ https://issues.apache.org/jira/browse/FLINK-30501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-30501: - Parent: FLINK-25244 Issue Type: Sub-task (was: Improvement) > Set requireJavaVersion in pom.xml

[GitHub] [flink] lindong28 commented on pull request #21557: [FLINK-30501] Set requireJavaVersion in pom.xml to be at least 11

lindong28 commented on PR #21557: URL: https://github.com/apache/flink/pull/21557#issuecomment-1364664826 The CI failed because the container is still using Java 8 to build Flink sources [1]. Since our README is already asking users to use Java 11 to build Flink [2], maybe we should also up

[GitHub] [flink] lindong28 commented on pull request #21557: [FLINK-30501] Set requireJavaVersion in pom.xml to be at least 11

lindong28 commented on PR #21557: URL: https://github.com/apache/flink/pull/21557#issuecomment-1364663739 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot commented on pull request #21557: [FLINK-30501] Set requireJavaVersion in pom.xml to be at least 11

flinkbot commented on PR #21557: URL: https://github.com/apache/flink/pull/21557#issuecomment-1364657682 ## CI report: * 51c8c73f3dc785c5ad8f79e37fae7f7e2fc806a0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] lindong28 commented on pull request #21557: [FLINK-30501] Set requireJavaVersion in pom.xml to be at least 11

lindong28 commented on PR #21557: URL: https://github.com/apache/flink/pull/21557#issuecomment-1364657600 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] lindong28 commented on pull request #21557: [FLINK-30501] Set requireJavaVersion in pom.xml to be at least 11

lindong28 commented on PR #21557: URL: https://github.com/apache/flink/pull/21557#issuecomment-1364657346 @zentol Would you have time to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (FLINK-30501) Set requireJavaVersion in pom.xml to be at least 11

[ https://issues.apache.org/jira/browse/FLINK-30501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30501: --- Labels: pull-request-available (was: ) > Set requireJavaVersion in pom.xml to be at least 1

[GitHub] [flink] lindong28 opened a new pull request, #21557: [FLINK-30501] Set requireJavaVersion in pom.xml to be at least 11

lindong28 opened a new pull request, #21557: URL: https://github.com/apache/flink/pull/21557 ## What is the purpose of the change `mvn install` should report Java version mismatch if users are building Flink source with JDK version below 11. This can help users quickly identify the r

[jira] [Updated] (FLINK-30501) Set requireJavaVersion in pom.xml to be at least 11

[ https://issues.apache.org/jira/browse/FLINK-30501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-30501: - Summary: Set requireJavaVersion in pom.xml to be at least 11 (was: Update pom.xml to require JDK versio

[jira] [Updated] (FLINK-30501) Update pom.xml to require JDK version 11 or higher

[ https://issues.apache.org/jira/browse/FLINK-30501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-30501: - Description: Flink 1.15 and later versions require at least Java 11 to build from sources [1]. However,

[jira] [Updated] (FLINK-30501) Update pom.xml to require JDK version 11 or higher

[ https://issues.apache.org/jira/browse/FLINK-30501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-30501: - Description: Flink 1.15 and later versions require at least Java 11 to build from sources [1]. However,

[jira] [Updated] (FLINK-30501) Update pom.xml to require JDK version 11 or higher

[ https://issues.apache.org/jira/browse/FLINK-30501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-30501: - Description: Flink 1.15 and later versions require at least Java 11 to build from sources [1]. However,

[jira] [Updated] (FLINK-30501) Update pom.xml to require JDK version 11 or higher

[ https://issues.apache.org/jira/browse/FLINK-30501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-30501: - Description: Flink 1.15 and later versions require at least Java 11 to build from sources [1]. However,

[jira] [Updated] (FLINK-30501) Update pom.xml to require JDK version 11 or higher

[ https://issues.apache.org/jira/browse/FLINK-30501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-30501: - Summary: Update pom.xml to require JDK version 11 or higher (was: Update pom.xml to use Java 11 by defa

[jira] [Updated] (FLINK-30501) Update pom.xml to use Java 11 by default

[ https://issues.apache.org/jira/browse/FLINK-30501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-30501: - Description: Flink 1.15 and later versions require at least Java 11 to build from sources [1]. However,

[jira] [Assigned] (FLINK-30501) Update pom.xml to use Java 11 by default

[ https://issues.apache.org/jira/browse/FLINK-30501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin reassigned FLINK-30501: Assignee: Dong Lin > Update pom.xml to use Java 11 by default > -

[jira] [Created] (FLINK-30501) Update pom.xml to use Java 11 by default

Dong Lin created FLINK-30501: Summary: Update pom.xml to use Java 11 by default Key: FLINK-30501 URL: https://issues.apache.org/jira/browse/FLINK-30501 Project: Flink Issue Type: Improvement