lsyldliu commented on code in PR #21401: URL: https://github.com/apache/flink/pull/21401#discussion_r1057024307
########## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectAggITCase.java: ########## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connectors.hive; + +import org.apache.flink.types.Row; +import org.apache.flink.util.CollectionUtil; + +import org.junit.Test; + +import java.util.List; + +import static org.apache.flink.table.planner.utils.TableTestUtil.readFromResource; +import static org.assertj.core.api.Assertions.assertThat; + +/** Test for native hive agg function compatibility. */ +public class HiveDialectAggITCase extends HiveDialectITCaseBase { + + @Test + public void testSumAggFunctionPlan() { + // test explain + String actualPlan = explainSql("select x, sum(y) from foo group by x"); + assertThat(actualPlan).isEqualTo(readFromResource("/explain/testSumAggFunctionPlan.out")); + } + + @Test + public void testSimpleSumAggFunction() throws Exception { Review Comment: I have run these tests using the hive sum udaf, the results are consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org