[GitHub] [flink] rkhachatryan commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

[GitBox]

rkhachatryan commented on code in PR #21467:
URL: https://github.com/apache/flink/pull/21467#discussion_r1057006257


##########
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java:
##########
@@ -2896,7 +2899,9 @@ private TaskExecutorTestingContext 
createTaskExecutorTestingContext(
                                 .setTaskStateManager(stateStoresManager)
                                 
.setTaskChangelogStoragesManager(changelogStoragesManager)
                                 .build(),
-                        HEARTBEAT_SERVICES,
+                        // prevent heartbeat timeouts from failing the tests 
focused on other
+                        // aspects
+                        HeartbeatServices.noOp(),

Review Comment:
   Done in 9a33560928fb01405164b13023e874a6a8e6fa66.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org