[GitHub] [flink] godfreyhe commented on pull request #21490: [FLINK-30368][table-planner] Fix calcite method RelMdUtil$numDistinctVals() wrongly return zero if the method input domainSize much larger

2022-12-21 Thread GitBox
godfreyhe commented on PR #21490: URL: https://github.com/apache/flink/pull/21490#issuecomment-1362522963 @swuferhong Currently, we had copied `RelMdUtil#numDistinctVals` to `FlinkRelMdUtil.numDistinctVals` and do some changes. does it not meet your requirements ? -- This is an automated

[GitHub] [flink] XComp closed pull request #21478: [FLINK-28352][tests] Disable PulsarSourceUnorderedE2ECase, PulsarUnorderedPartitionSplitReaderTest and PulsarUnorderedSourceITCase

2022-12-21 Thread GitBox
XComp closed pull request #21478: [FLINK-28352][tests] Disable PulsarSourceUnorderedE2ECase, PulsarUnorderedPartitionSplitReaderTest and PulsarUnorderedSourceITCase URL: https://github.com/apache/flink/pull/21478 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] XComp commented on pull request #21478: [FLINK-28352][tests] Disable PulsarSourceUnorderedE2ECase, PulsarUnorderedPartitionSplitReaderTest and PulsarUnorderedSourceITCase

2022-12-21 Thread GitBox
XComp commented on PR #21478: URL: https://github.com/apache/flink/pull/21478#issuecomment-1362512313 Closing this one in favor of PR #21501 where we remove the pulsar-related code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [flink] Myasuka commented on pull request #21516: [FLINK-28863][state]Add comments about why snapshot result of RocksDB native savepoint doesn't have empty shared-state

2022-12-21 Thread GitBox
Myasuka commented on PR #21516: URL: https://github.com/apache/flink/pull/21516#issuecomment-1362509538 @ljz2051 do you have a local green CI? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-connector-kafka] mas-chen commented on a diff in pull request #1: [FLINK-30052][Connectors/Kafka] Move existing Kafka connector code from Flink repo to dedicated Kafka repo

2022-12-21 Thread GitBox
mas-chen commented on code in PR #1: URL: https://github.com/apache/flink-connector-kafka/pull/1#discussion_r1055166044 ## flink-connector-kafka-e2e-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/SQLClientKafkaITCase.java: ## @@ -82,15

[GitHub] [flink] 1996fanrui commented on pull request #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default

2022-12-21 Thread GitBox
1996fanrui commented on PR #21540: URL: https://github.com/apache/flink/pull/21540#issuecomment-1362490165 > I think even before this PR, the sort order is also the desc by default. @yuchen-ecnu could you also take a look at this PR? Thanks for your feedback, the `sortByBusyRatio` is

[jira] [Commented] (FLINK-30475) Improved speed of RocksDBMapState clear() using rocksDB.deleteRange

2022-12-21 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651102#comment-17651102 ] Hangxiang Yu commented on FLINK-30475: -- Hi, Have you compared the whole performance

[GitHub] [flink] Myasuka commented on pull request #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default

2022-12-21 Thread GitBox
Myasuka commented on PR #21540: URL: https://github.com/apache/flink/pull/21540#issuecomment-1362471115 I think even before this PR, the sort order is also the desc by default. @yuchen-ecnu could you also take a look at this PR? -- This is an automated message from the Apache Git Service.

[jira] [Closed] (FLINK-30188) Partition finished state in ConsumedPartitionGroup is not updated correctly in dynamic graph

2022-12-21 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-30188. Fix Version/s: 1.17.0 Resolution: Fixed master (1.17): 4ea67f63eb1c43d7adf07c37946b20b525fb

[GitHub] [flink] xintongsong closed pull request #21388: [FLINK-30188][coordination] Set partition finished state in ConsumedPartitionGroup for dynamic graph correctly.

2022-12-21 Thread GitBox
xintongsong closed pull request #21388: [FLINK-30188][coordination] Set partition finished state in ConsumedPartitionGroup for dynamic graph correctly. URL: https://github.com/apache/flink/pull/21388 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [flink] xintongsong commented on pull request #21508: [FLINK-30128] Introduce Azure Data Lake Gen2 APIs in the Hadoop Recoverable path

2022-12-21 Thread GitBox
xintongsong commented on PR #21508: URL: https://github.com/apache/flink/pull/21508#issuecomment-1362444049 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[jira] [Comment Edited] (FLINK-24932) Frocksdb cannot run on Apple M1

2022-12-21 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651084#comment-17651084 ] Yuan Mei edited comment on FLINK-24932 at 12/22/22 5:28 AM:

[jira] [Comment Edited] (FLINK-24932) Frocksdb cannot run on Apple M1

2022-12-21 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651084#comment-17651084 ] Yuan Mei edited comment on FLINK-24932 at 12/22/22 5:28 AM:

[jira] [Commented] (FLINK-24932) Frocksdb cannot run on Apple M1

2022-12-21 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651084#comment-17651084 ] Yuan Mei commented on FLINK-24932: -- Thanks [~Yanfei Lei] continue pushing forwards the

[jira] [Commented] (FLINK-30443) Expand list of sensitive keys

2022-12-21 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651078#comment-17651078 ] Jiabao Sun commented on FLINK-30443: I think it makes sense to expend sensitive conf

[jira] [Commented] (FLINK-26372) Allow to configure Changelog Storage per program

2022-12-21 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651077#comment-17651077 ] Yanfei Lei commented on FLINK-26372: [~roman] [~Feifan Wang]  I‘d like to continue t

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-12-21 Thread GitBox
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1055087635 ## flink-connector-mongodb/src/test/java/org/apache/flink/connector/mongodb/table/converter/MongoConvertersTest.java: ## @@ -146,28 +146,31 @@ public void

[GitHub] [flink] liuml07 commented on pull request #21549: [FLINK-30479][doc] Document flink-connector-files for local execution

2022-12-21 Thread GitBox
liuml07 commented on PR #21549: URL: https://github.com/apache/flink/pull/21549#issuecomment-1362394086 CC: @twalthr @fapaul -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (FLINK-30482) Update catalog documentation

2022-12-21 Thread Samrat Deb (Jira)
Samrat Deb created FLINK-30482: -- Summary: Update catalog documentation Key: FLINK-30482 URL: https://issues.apache.org/jira/browse/FLINK-30482 Project: Flink Issue Type: Sub-task Comp

[jira] [Created] (FLINK-30481) create base aws-glue catalog implementation in flink-connector-aws

2022-12-21 Thread Samrat Deb (Jira)
Samrat Deb created FLINK-30481: -- Summary: create base aws-glue catalog implementation in flink-connector-aws Key: FLINK-30481 URL: https://issues.apache.org/jira/browse/FLINK-30481 Project: Flink

[jira] [Updated] (FLINK-29549) Add Aws Glue Catalog support in Flink

2022-12-21 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samrat Deb updated FLINK-29549: --- Component/s: Connectors / AWS (was: Connectors / Hive) > Add Aws Glue Catalog s

[jira] [Updated] (FLINK-29549) Add Aws Glue Catalog support in Flink

2022-12-21 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samrat Deb updated FLINK-29549: --- Issue Type: New Feature (was: Improvement) > Add Aws Glue Catalog support in Flink > --

[jira] [Commented] (FLINK-30480) Add benchmarks for adaptive batch scheduler

2022-12-21 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651066#comment-17651066 ] Zhu Zhu commented on FLINK-30480: - Thanks for volunteering. [~xiasun] I have assigned yo

[jira] [Assigned] (FLINK-30480) Add benchmarks for adaptive batch scheduler

2022-12-21 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-30480: --- Assignee: xingbe > Add benchmarks for adaptive batch scheduler > --

[jira] [Commented] (FLINK-30480) Add benchmarks for adaptive batch scheduler

2022-12-21 Thread xingbe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651065#comment-17651065 ] xingbe commented on FLINK-30480: Hi, I would like to work on this issue, could you assig

[jira] [Created] (FLINK-30480) Add benchmarks for adaptive batch scheduler

2022-12-21 Thread Zhu Zhu (Jira)
Zhu Zhu created FLINK-30480: --- Summary: Add benchmarks for adaptive batch scheduler Key: FLINK-30480 URL: https://issues.apache.org/jira/browse/FLINK-30480 Project: Flink Issue Type: Improvement

[GitHub] [flink-ml] Fanoid commented on pull request #191: [FLINK-30401] Add Estimator and Transformer for MinHashLSH

2022-12-21 Thread GitBox
Fanoid commented on PR #191: URL: https://github.com/apache/flink-ml/pull/191#issuecomment-1362362456 @zhipeng93 Thanks for your valuable comments. I've made some updates, please check them. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] ljz2051 commented on pull request #21516: [FLINK-28863][state]Add comments about why snapshot result of RocksDB native savepoint doesn't have empty shared-state

2022-12-21 Thread GitBox
ljz2051 commented on PR #21516: URL: https://github.com/apache/flink/pull/21516#issuecomment-1362349616 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] ljz2051 commented on pull request #21516: [FLINK-28863][state]Add comments about why snapshot result of RocksDB native savepoint doesn't have empty shared-state

2022-12-21 Thread GitBox
ljz2051 commented on PR #21516: URL: https://github.com/apache/flink/pull/21516#issuecomment-1362328413 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Closed] (FLINK-30458) Refactor Table Store Documentation

2022-12-21 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng closed FLINK-30458. --- Resolution: Fixed master: 4c607a7356a5fd43364f93d70264d1ede98113ab > Refactor Table Store Documenta

[GitHub] [flink-table-store] tsreaper merged pull request #443: [FLINK-30458] Refactor Table Store Documentation

2022-12-21 Thread GitBox
tsreaper merged PR #443: URL: https://github.com/apache/flink-table-store/pull/443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@fl

[GitHub] [flink] ljz2051 commented on pull request #21516: [FLINK-28863][state]Add comments about why snapshot result of RocksDB native savepoint doesn't have empty shared-state

2022-12-21 Thread GitBox
ljz2051 commented on PR #21516: URL: https://github.com/apache/flink/pull/21516#issuecomment-1362323900 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] masteryhx commented on pull request #21468: [FLINK-30345][state/changelog] Avoid using sync DataOutputViewStreamWrapper to serialize records to changelog

2022-12-21 Thread GitBox
masteryhx commented on PR #21468: URL: https://github.com/apache/flink/pull/21468#issuecomment-1362320855 @Myasuka Do you have other suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #410: [FLINK-30247] Introduce time travel reading for table store

2022-12-21 Thread GitBox
tsreaper commented on code in PR #410: URL: https://github.com/apache/flink-table-store/pull/410#discussion_r1055030061 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/table/source/snapshot/ContinuousFromSnapshotStartingScanner.java: ## @@ -0,0 +1,49 @@ +/*

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #410: [FLINK-30247] Introduce time travel reading for table store

2022-12-21 Thread GitBox
tsreaper commented on code in PR #410: URL: https://github.com/apache/flink-table-store/pull/410#discussion_r1053120573 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/CoreOptions.java: ## @@ -543,6 +550,8 @@ public static StartupMode startupMode(ReadableCon

[jira] [Commented] (FLINK-25421) Port JDBC Sink to new Unified Sink API (FLIP-143)

2022-12-21 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651050#comment-17651050 ] RocMarshal commented on FLINK-25421: Hi [~eskabetxe] Is here any new progress about

[jira] [Commented] (FLINK-27731) Remove Hugo Modules integration

2022-12-21 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651039#comment-17651039 ] Xintong Song commented on FLINK-27731: -- Thanks for the pointer and explanation. Sou

[jira] [Updated] (FLINK-30479) Document flink-connector-files for local execution

2022-12-21 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated FLINK-30479: -- Description: The file system SQL connector itself is included in Flink and does not require a

[GitHub] [flink] liuml07 commented on a diff in pull request #21549: [FLINK-30479][doc] Document flink-connector-files for local execution

2022-12-21 Thread GitBox
liuml07 commented on code in PR #21549: URL: https://github.com/apache/flink/pull/21549#discussion_r1054985251 ## docs/content/docs/connectors/table/filesystem.md: ## @@ -33,6 +33,18 @@ The file system connector itself is included in Flink and does not require an ad The corres

[GitHub] [flink] lincoln-lil commented on pull request #21546: [FLINK-30477][datastream] Fix AsyncWaitOperator that not properly blocking retries when timeout occurs

2022-12-21 Thread GitBox
lincoln-lil commented on PR #21546: URL: https://github.com/apache/flink/pull/21546#issuecomment-1362266272 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [flink] flinkbot commented on pull request #21549: [FLINK-30479][doc] Document flink-connector-files for local execution

2022-12-21 Thread GitBox
flinkbot commented on PR #21549: URL: https://github.com/apache/flink/pull/21549#issuecomment-1362266024 ## CI report: * 3d0a250bc8391007493b1031b98a5acd4b87eae4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30479) Document flink-connector-files for local execution

2022-12-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30479: --- Labels: pull-request-available (was: ) > Document flink-connector-files for local execution

[GitHub] [flink] liuml07 commented on pull request #21549: [FLINK-30479][doc] Document flink-connector-files for local execution

2022-12-21 Thread GitBox
liuml07 commented on PR #21549: URL: https://github.com/apache/flink/pull/21549#issuecomment-1362264819 ![Uploading Screenshot 2022-12-21 at 4.52.34 PM.png…]() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [flink] liuml07 opened a new pull request, #21549: [FLINK-30479][doc] Document flink-connector-files for local execution

2022-12-21 Thread GitBox
liuml07 opened a new pull request, #21549: URL: https://github.com/apache/flink/pull/21549 ## What is the purpose of the change The file system SQL connector itself is included in Flink and does not require an additional dependency. However, if a user uses the filesystem connector fo

[jira] [Created] (FLINK-30479) Document flink-connector-files for local execution

2022-12-21 Thread Mingliang Liu (Jira)
Mingliang Liu created FLINK-30479: - Summary: Document flink-connector-files for local execution Key: FLINK-30479 URL: https://issues.apache.org/jira/browse/FLINK-30479 Project: Flink Issue Ty

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

2022-12-21 Thread GitBox
rkhachatryan commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1054964645 ## flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatManagerSenderImpl.java: ## @@ -37,7 +37,7 @@ private final long heartbeatPeriod;

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

2022-12-21 Thread GitBox
rkhachatryan commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1054957881 ## flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/NoOpHeartbeatServices.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

2022-12-21 Thread GitBox
rkhachatryan commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1054946222 ## flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatServices.java: ## @@ -100,37 +62,31 @@ public HeartbeatManager createHeartbeatManager(

[GitHub] [flink-connector-jdbc] snuyanzin opened a new pull request, #14: [FLINK-28768][tests] Update junit to 5.9.1

2022-12-21 Thread GitBox
snuyanzin opened a new pull request, #14: URL: https://github.com/apache/flink-connector-jdbc/pull/14 This is a cherry pick from flink master to update junit5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [flink-connector-jdbc] boring-cyborg[bot] commented on pull request #13: [FLINK-28466][tests] Update assertj to 3.23.1

2022-12-21 Thread GitBox
boring-cyborg[bot] commented on PR #13: URL: https://github.com/apache/flink-connector-jdbc/pull/13#issuecomment-1362209144 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is an

[GitHub] [flink-connector-jdbc] snuyanzin opened a new pull request, #13: [FLINK-28466][tests] Update assertj to 3.23.1

2022-12-21 Thread GitBox
snuyanzin opened a new pull request, #13: URL: https://github.com/apache/flink-connector-jdbc/pull/13 This is almost a cherry pick from flink master + exclusion of `byte-buddy` to avoid dependency convergence -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [flink-connector-aws] darenwkt commented on a diff in pull request #39: [FLINK-30418] Implement synchronous KinesisClient in EFO

2022-12-21 Thread GitBox
darenwkt commented on code in PR #39: URL: https://github.com/apache/flink-connector-aws/pull/39#discussion_r1054892467 ## flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyAsyncV2Test.java: ## @@ -0,0 +1,171 @@ +/* + * Licens

[GitHub] [flink-connector-aws] darenwkt commented on a diff in pull request #39: [FLINK-30418] Implement synchronous KinesisClient in EFO

2022-12-21 Thread GitBox
darenwkt commented on code in PR #39: URL: https://github.com/apache/flink-connector-aws/pull/39#discussion_r1054892121 ## flink-connector-kinesis/pom.xml: ## @@ -256,6 +256,11 @@ under the License. netty-nio-client + +software.amazo

[jira] [Assigned] (FLINK-30113) Compression for operator state

2022-12-21 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-30113: -- Assignee: Etienne Chauchot > Compression for operator state > ---

[GitHub] [flink] MartijnVisser commented on pull request #21548: [FLINK-30478] [core] Avoiding dependence on JDK-internal code

2022-12-21 Thread GitBox
MartijnVisser commented on PR #21548: URL: https://github.com/apache/flink/pull/21548#issuecomment-1361943096 @gunnarmorling Since this library would be bundled, it's required to update the NOTICE file in `flink-dist/src/main/resources/META-INF/NOTICE` -- This is an automated message fro

[GitHub] [flink-web] MartijnVisser merged pull request #594: Add RabbitMQ connector 3.0.0

2022-12-21 Thread GitBox
MartijnVisser merged PR #594: URL: https://github.com/apache/flink-web/pull/594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[GitHub] [flink-kubernetes-operator] mxm merged pull request #492: [FLINK-30463] Start stabilization period only after job goes into RUNNING

2022-12-21 Thread GitBox
mxm merged PR #492: URL: https://github.com/apache/flink-kubernetes-operator/pull/492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [flink-kubernetes-operator] mxm commented on pull request #492: [FLINK-30463] Start stabilization period only after job goes into RUNNING

2022-12-21 Thread GitBox
mxm commented on PR #492: URL: https://github.com/apache/flink-kubernetes-operator/pull/492#issuecomment-1361921179 Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [flink-web] MartijnVisser merged pull request #590: Add JDBC connector 3.0.0

2022-12-21 Thread GitBox
MartijnVisser merged PR #590: URL: https://github.com/apache/flink-web/pull/590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[GitHub] [flink-web] MartijnVisser merged pull request #589: Add Pulsar connector 3.0.0

2022-12-21 Thread GitBox
MartijnVisser merged PR #589: URL: https://github.com/apache/flink-web/pull/589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[GitHub] [flink] reta commented on pull request #21518: [FLINK-30436][Connectors/Opensearch][docs] Integrate Opensearch docs …

2022-12-21 Thread GitBox
reta commented on PR #21518: URL: https://github.com/apache/flink/pull/21518#issuecomment-1361905787 Thank you very much, @dannycranmer and @MartijnVisser -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (FLINK-27731) Remove Hugo Modules integration

2022-12-21 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650977#comment-17650977 ] Martijn Visser commented on FLINK-27731: [~xtsong] See https://github.com/apache

[jira] [Comment Edited] (FLINK-27731) Remove Hugo Modules integration

2022-12-21 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650977#comment-17650977 ] Martijn Visser edited comment on FLINK-27731 at 12/21/22 6:56 PM:

[GitHub] [flink-connector-opensearch] MartijnVisser commented on pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-12-21 Thread GitBox
MartijnVisser commented on PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#issuecomment-1361896306 > The Opensearch documentations available here [2] but I am not sure how it is going to be integrated into Flink documentation, @zentol may be you could spot some ligh

[GitHub] [flink-connector-opensearch] reta commented on pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-12-21 Thread GitBox
reta commented on PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#issuecomment-1361784372 > The artifacts you mentioned that will be available in the coming days is referring to registering this library to maven repo? @ypark2103 Correct -- This is an autom

[GitHub] [flink-connector-cassandra] RyanSkraba commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2022-12-21 Thread GitBox
RyanSkraba commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1054648476 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/SplitsGenerator.java: ## @@ -0,0 +1,211 @@ +/* + * Licensed

[GitHub] [flink-connector-opensearch] ypark2103 commented on pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-12-21 Thread GitBox
ypark2103 commented on PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#issuecomment-1361761149 @reta Is there a way we can install this library with pom.xml? I don't see opensearch in maven depository yet like elasticsearch connector. https://mvnrepository.com/

[GitHub] [flink-connector-opensearch] reta commented on pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-12-21 Thread GitBox
reta commented on PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#issuecomment-1361745642 > hi @zentol @reta I see that [flink-opensearch-connector](https://issues.apache.org/jira/browse/FLINK-opensearch-connector) was merged to master recently but I don't see it wa

[GitHub] [flink-connector-opensearch] ypark2103 commented on pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-12-21 Thread GitBox
ypark2103 commented on PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#issuecomment-1361723729 hi @zentol @reta I see that flink-opensearch-connector was merged to master recently but I don't see it was registered in maven repository. When will this be added t

[GitHub] [flink] ramkrish86 commented on pull request #21508: [FLINK-30128] Introduce Azure Data Lake Gen2 APIs in the Hadoop Recoverable path

2022-12-21 Thread GitBox
ramkrish86 commented on PR #21508: URL: https://github.com/apache/flink/pull/21508#issuecomment-1361723105 The current failure seems to be unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] gunnarmorling commented on pull request #21532: FLINK-30455 [core] Excluding java.lang.String and primitive types from closure cleaning

2022-12-21 Thread GitBox
gunnarmorling commented on PR #21532: URL: https://github.com/apache/flink/pull/21532#issuecomment-1361706613 Thanks a lot for reviewing @rmetzger; I have * Reworked the commit message * Added a test which would fail on JDK 17 without the fix; with the fix, it passes on 11 and 17

[GitHub] [flink] flinkbot commented on pull request #21548: [FLINK-30478] [core] Avoiding dependence on JDK-internal code

2022-12-21 Thread GitBox
flinkbot commented on PR #21548: URL: https://github.com/apache/flink/pull/21548#issuecomment-1361676706 ## CI report: * 611c92cf2be5bf99de666458482644df08732cb9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30478) Don't depend on IPAddressUtil

2022-12-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30478: --- Labels: pull-request-available (was: ) > Don't depend on IPAddressUtil > --

[GitHub] [flink] gunnarmorling commented on pull request #21548: [FLINK-30478] [core] Avoiding dependence on JDK-internal code

2022-12-21 Thread GitBox
gunnarmorling commented on PR #21548: URL: https://github.com/apache/flink/pull/21548#issuecomment-1361672500 // CC @rmetzger -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink] gunnarmorling opened a new pull request, #21548: [FLINK-30478] [core] Avoiding dependence on JDK-internal code

2022-12-21 Thread GitBox
gunnarmorling opened a new pull request, #21548: URL: https://github.com/apache/flink/pull/21548 ## What is the purpose of the change Increasing the usability of Flink with JDK 17: `sun.net.util.IPAddressUtil` is not exported by the JDK, i.e. `--add-opens` configuration is needed for

[jira] [Assigned] (FLINK-30478) Don't depend on IPAddressUtil

2022-12-21 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reassigned FLINK-30478: -- Assignee: Gunnar Morling > Don't depend on IPAddressUtil > --

[jira] [Created] (FLINK-30478) Don't depend on IPAddressUtil

2022-12-21 Thread Gunnar Morling (Jira)
Gunnar Morling created FLINK-30478: -- Summary: Don't depend on IPAddressUtil Key: FLINK-30478 URL: https://issues.apache.org/jira/browse/FLINK-30478 Project: Flink Issue Type: Sub-task

[GitHub] [flink] XComp commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

2022-12-21 Thread GitBox
XComp commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1054558267 ## flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatServices.java: ## @@ -100,37 +62,31 @@ public HeartbeatManager createHeartbeatManager(

[GitHub] [flink] XComp commented on a diff in pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

2022-12-21 Thread GitBox
XComp commented on code in PR #21467: URL: https://github.com/apache/flink/pull/21467#discussion_r1054523544 ## flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatManagerSenderImpl.java: ## @@ -56,7 +56,7 @@ new HeartbeatMonitorImpl.Factory<

[jira] [Commented] (FLINK-27731) Remove Hugo Modules integration

2022-12-21 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650930#comment-17650930 ] Xintong Song commented on FLINK-27731: -- bq. We've recently decided to integrate doc

[GitHub] [flink] rmetzger commented on a diff in pull request #21531: FLINK-30454 [runtime] Fixing visibility issue for SizeGauge.SizeSupplier

2022-12-21 Thread GitBox
rmetzger commented on code in PR #21531: URL: https://github.com/apache/flink/pull/21531#discussion_r1054551815 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStore.java: ## @@ -207,7 +207,7 @@ public Set getDirtyResultsInternal() thr

[jira] [Assigned] (FLINK-22922) Migrate flink project website to Hugo

2022-12-21 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-22922: -- Assignee: Martijn Visser (was: Daisy Tsang) > Migrate flink project website to Hugo

[GitHub] [flink] ljz2051 commented on pull request #21516: [FLINK-28863][state]Add comments about why snapshot result of RocksDB native savepoint doesn't have empty shared-state

2022-12-21 Thread GitBox
ljz2051 commented on PR #21516: URL: https://github.com/apache/flink/pull/21516#issuecomment-1361446598 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink-connector-aws] darenwkt commented on a diff in pull request #39: [FLINK-30418] Implement synchronous KinesisClient in EFO

2022-12-21 Thread GitBox
darenwkt commented on code in PR #39: URL: https://github.com/apache/flink-connector-aws/pull/39#discussion_r1054485689 ## flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/util/AWSAsyncSinkUtil.java: ## @@ -161,4 +163,47 @@ S createAwsAsyncClient(

[GitHub] [flink] ljz2051 commented on pull request #21516: [FLINK-28863][state]Add comments about why snapshot result of RocksDB native savepoint doesn't have empty shared-state

2022-12-21 Thread GitBox
ljz2051 commented on PR #21516: URL: https://github.com/apache/flink/pull/21516#issuecomment-1361437935 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink-connector-aws] darenwkt commented on a diff in pull request #39: [FLINK-30418] Implement synchronous KinesisClient in EFO

2022-12-21 Thread GitBox
darenwkt commented on code in PR #39: URL: https://github.com/apache/flink-connector-aws/pull/39#discussion_r1054467238 ## flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/util/AWSAsyncSinkUtil.java: ## @@ -161,4 +163,47 @@ S createAwsAsyncClient(

[GitHub] [flink] ljz2051 commented on pull request #21516: [FLINK-28863][state]Add comments about why snapshot result of RocksDB native savepoint doesn't have empty shared-state

2022-12-21 Thread GitBox
ljz2051 commented on PR #21516: URL: https://github.com/apache/flink/pull/21516#issuecomment-1361409276 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink-connector-aws] darenwkt commented on a diff in pull request #39: [FLINK-30418] Implement synchronous KinesisClient in EFO

2022-12-21 Thread GitBox
darenwkt commented on code in PR #39: URL: https://github.com/apache/flink-connector-aws/pull/39#discussion_r1054459944 ## flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/publisher/fanout/StreamConsumerRegistrar.java: ## @@ -77,8 +7

[GitHub] [flink-connector-aws] darenwkt commented on a diff in pull request #39: [FLINK-30418] Implement synchronous KinesisClient in EFO

2022-12-21 Thread GitBox
darenwkt commented on code in PR #39: URL: https://github.com/apache/flink-connector-aws/pull/39#discussion_r1054458256 ## flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/publisher/fanout/StreamConsumerRegistrar.java: ## @@ -243,28

[jira] [Assigned] (FLINK-30342) Migrate ZooKeeperLeaderElectionTest

2022-12-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-30342: - Assignee: Matthias Pohl > Migrate ZooKeeperLeaderElectionTest > ---

[GitHub] [flink] lincoln-lil commented on pull request #21177: [FLINK-29781][table-planner] Fix ChangelogNormalize uses wrong keys after transformation by WatermarkAssignerChangelogNormalizeTransposeR

2022-12-21 Thread GitBox
lincoln-lil commented on PR #21177: URL: https://github.com/apache/flink/pull/21177#issuecomment-1361378180 close the temporary backporting patch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [flink] lincoln-lil commented on pull request #21222: [BP-1.15][FLINK-29849 & FLINK-29781][table-planner] Fix event time temporal join on an upsert source may produce incorrect execution plan

2022-12-21 Thread GitBox
lincoln-lil commented on PR #21222: URL: https://github.com/apache/flink/pull/21222#issuecomment-1361378770 close the temporary backporting patch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [flink] lincoln-lil closed pull request #21222: [BP-1.15][FLINK-29849 & FLINK-29781][table-planner] Fix event time temporal join on an upsert source may produce incorrect execution plan

2022-12-21 Thread GitBox
lincoln-lil closed pull request #21222: [BP-1.15][FLINK-29849 & FLINK-29781][table-planner] Fix event time temporal join on an upsert source may produce incorrect execution plan URL: https://github.com/apache/flink/pull/21222 -- This is an automated message from the Apache Git Service. To re

[GitHub] [flink] lincoln-lil closed pull request #21177: [FLINK-29781][table-planner] Fix ChangelogNormalize uses wrong keys after transformation by WatermarkAssignerChangelogNormalizeTransposeRule

2022-12-21 Thread GitBox
lincoln-lil closed pull request #21177: [FLINK-29781][table-planner] Fix ChangelogNormalize uses wrong keys after transformation by WatermarkAssignerChangelogNormalizeTransposeRule URL: https://github.com/apache/flink/pull/21177 -- This is an automated message from the Apache Git Service. To

[GitHub] [flink-connector-aws] darenwkt commented on a diff in pull request #39: [FLINK-30418] Implement synchronous KinesisClient in EFO

2022-12-21 Thread GitBox
darenwkt commented on code in PR #39: URL: https://github.com/apache/flink-connector-aws/pull/39#discussion_r1054443739 ## flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxySyncV2.java: ## @@ -114,6 +104,7 @@ public DescribeSt

[GitHub] [flink-connector-aws] darenwkt commented on a diff in pull request #39: [FLINK-30418] Implement synchronous KinesisClient in EFO

2022-12-21 Thread GitBox
darenwkt commented on code in PR #39: URL: https://github.com/apache/flink-connector-aws/pull/39#discussion_r1054442840 ## flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxySyncV2.java: ## @@ -148,11 +139,10 @@ public Register

[GitHub] [flink-connector-aws] darenwkt commented on a diff in pull request #39: [FLINK-30418] Implement synchronous KinesisClient in EFO

2022-12-21 Thread GitBox
darenwkt commented on code in PR #39: URL: https://github.com/apache/flink-connector-aws/pull/39#discussion_r1054441165 ## flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/publisher/fanout/StreamConsumerRegistrar.java: ## @@ -77,8 +7

[GitHub] [flink] flinkbot commented on pull request #21547: [FLINK-30461][checkpoint] Fix the bug that the shared files will remain forever after the rocksdb incremental checkpoint exception

2022-12-21 Thread GitBox
flinkbot commented on PR #21547: URL: https://github.com/apache/flink/pull/21547#issuecomment-1361366338 ## CI report: * 36cbe3cc7b8acbbce02401f20ee0fa3b39251d4d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30461) Some rocksdb sst files will remain forever

2022-12-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30461: --- Labels: pull-request-available (was: ) > Some rocksdb sst files will remain forever > -

[GitHub] [flink] 1996fanrui opened a new pull request, #21547: [FLINK-30461][checkpoint] Fix the bug that the shared files will remain forever after the rocksdb incremental checkpoint exception

2022-12-21 Thread GitBox
1996fanrui opened a new pull request, #21547: URL: https://github.com/apache/flink/pull/21547 ## What is the purpose of the change In rocksdb incremental checkpoint mode, during file upload, if some files have been uploaded and some files have not been uploaded, the checkpoint is can

  1   2   3   >