[GitHub] [flink-connector-aws] darenwkt commented on a diff in pull request #39: [FLINK-30418] Implement synchronous KinesisClient in EFO

[GitBox]

darenwkt commented on code in PR #39:
URL: 
https://github.com/apache/flink-connector-aws/pull/39#discussion_r1054458256


##########
flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/publisher/fanout/StreamConsumerRegistrar.java:
##########
@@ -243,28 +244,28 @@ private void waitForConsumerToDeregister(
     }
 
     private Optional<DescribeStreamConsumerResponse> describeStreamConsumer(
-            final String streamArn, final String streamConsumerName)
-            throws InterruptedException, ExecutionException {
+            final String streamArn, final String streamConsumerName) throws 
Exception {
         return describeStreamConsumer(
                 () ->
                         kinesisProxyV2Interface.describeStreamConsumer(
                                 streamArn, streamConsumerName));
     }
 
     private Optional<DescribeStreamConsumerResponse> describeStreamConsumer(
-            final String streamConsumerArn) throws InterruptedException, 
ExecutionException {
+            final String streamConsumerArn) throws Exception {
         return describeStreamConsumer(
                 () -> 
kinesisProxyV2Interface.describeStreamConsumer(streamConsumerArn));
     }
 
     private Optional<DescribeStreamConsumerResponse> describeStreamConsumer(
-            final ResponseSupplier<DescribeStreamConsumerResponse> 
responseSupplier)
-            throws InterruptedException, ExecutionException {
+            final Callable<DescribeStreamConsumerResponse> responseSupplier) 
throws Exception {
         DescribeStreamConsumerResponse response;
 
         try {
-            response = responseSupplier.get();
-        } catch (ExecutionException ex) {
+            response = responseSupplier.call();
+        } catch (Exception ex) {
+            LOG.warn("describeStreamConsumer caught ExecutionException: {}", 
ex);

Review Comment:
   Thanks for highlighting this, I will add the InterruptedException back in as 
it might be thrown by registrationBackoff



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org