rkhachatryan commented on code in PR #21467:
URL: https://github.com/apache/flink/pull/21467#discussion_r1054946222
##########
flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatServices.java:
##########
@@ -100,37 +62,31 @@ public <I, O> HeartbeatManager<I, O>
createHeartbeatManager(
* @param <O> Type of the outgoing payload
* @return A new HeartbeatManager instance which actively sends heartbeats
*/
- public <I, O> HeartbeatManager<I, O> createHeartbeatManagerSender(
+ <I, O> HeartbeatManager<I, O> createHeartbeatManagerSender(
ResourceID resourceId,
HeartbeatListener<I, O> heartbeatListener,
ScheduledExecutor mainThreadExecutor,
- Logger log) {
-
- return new HeartbeatManagerSenderImpl<>(
- heartbeatInterval,
- heartbeatTimeout,
- failedRpcRequestsUntilUnreachable,
- resourceId,
- heartbeatListener,
- mainThreadExecutor,
- log);
- }
+ Logger log);
/**
* Creates an HeartbeatServices instance from a {@link Configuration}.
*
* @param configuration Configuration to be used for the HeartbeatServices
creation
* @return An HeartbeatServices instance created from the given
configuration
*/
- public static HeartbeatServices fromConfiguration(Configuration
configuration) {
+ static HeartbeatServices fromConfiguration(Configuration configuration) {
Review Comment:
I'd rather prefer the opposite so that the user is only aware of the
interface but not the specific implementation(s).
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
